Jump to content
  • Checkout
  • Login
  • Get in touch

osCommerce

The e-commerce.

Links not working correctly


Jack_mcs

Recommended Posts

If you take a look at My Webpage, you will see I have some links in the right hand column. If I click on the first link (Free Shipping) and then click on continue, it takes me back to the home page. But if I click on one of the other links, say Tell A Friend, and click continue, it reloads that page. This was working at one point and I cannot figure out what I did to change it. I renamed the shipping.php file to surprise.php (which is used by tell a friend) and tried clicking continue. The same thing happens so the problem is not in that file. Does anyone know what might be the problem here or how to troubleshoot it?

 

Jack

Support Links:

For Hire: Contact me for anything you need help with for your shop: upgrading, hosting, repairs, code written, etc.

Get the latest versions of my addons

Recommended SEO Addons

Link to comment
Share on other sites

Hi Jack,

 

I notice that on mouse over continue in the surprise.php shows the link being to surprise.php instead of say default so the initial thought would be that it is the link code in surprise.php

No longer giving free advice. Please place deposit in meter slot provided.  Individual: [=] SME: [==] Corporation: [===]
If deposit does not fit one of the slots provided then you are asking too much! :P

Is your Osc dated try Phoenix  raising oscommerce from the ashes.

Link to comment
Share on other sites

Hi Jack, Part two

 

in shipping.php you will have this for the continue button

 

<td align="right"><?php echo '<a href="' . tep_href_link(FILENAME_DEFAULT) . '">' . tep_image_button('button_continue.gif', IMAGE_BUTTON_CONTINUE) . '</a>'; ?></td>

and you would have something like this for surprise.php

<td><?php echo '<a href="' . tep_href_link(FILENAME_PRODUCT_INFO, 'products_id=' . $HTTP_GET_VARS['products_id']) . '">' . tep_image_button('button_back.gif', IMAGE_BUTTON_BACK) . '</a>'; ?></td>
               <td align="right"><?php echo tep_image_submit('button_continue.gif', IMAGE_BUTTON_CONTINUE); ?></td>

 

yours

the missing link

No longer giving free advice. Please place deposit in meter slot provided.  Individual: [=] SME: [==] Corporation: [===]
If deposit does not fit one of the slots provided then you are asking too much! :P

Is your Osc dated try Phoenix  raising oscommerce from the ashes.

Link to comment
Share on other sites

Steve, the code for the continue button is the same in all of the files for the right side:

 

/* WebMakers.com Added: Change Redirect */ ?>

<td align="right"><?php echo '<a href="' . $link . '">' . tep_image_button('button_continue.gif', IMAGE_BUTTON_CONTINUE) . '</a>'; ?></td>

<?php /* WebMakers.com Added: Change Redirect */ ?>

 

The $link was added by the SEC mod I guess. But the code itself isn't the problem since I replaced the entire file by renaming shipping.php (the one that works) to one of the non-working files and got the same result. You are correct about the link being wrong. If you look at the source for a non-working file, it shows a link back to that file. And that comes from $link. Why certain files are getting the wrong link seems to be the question.

 

Jack

Support Links:

For Hire: Contact me for anything you need help with for your shop: upgrading, hosting, repairs, code written, etc.

Get the latest versions of my addons

Recommended SEO Addons

Link to comment
Share on other sites

Yeah Jack I forgot that this was your SEC I was working on the basis of an ordinary osc, I will take a look at my SEC and see what differs

No longer giving free advice. Please place deposit in meter slot provided.  Individual: [=] SME: [==] Corporation: [===]
If deposit does not fit one of the slots provided then you are asking too much! :P

Is your Osc dated try Phoenix  raising oscommerce from the ashes.

Link to comment
Share on other sites

I have looked at my SEC and my tell_a_friend which is your surprise has this for the continue

 

 <td align="right"><?php echo tep_image_submit('button_continue.gif', IMAGE_BUTTON_CONTINUE); ?></td>

which is the standard code for the submit

 

When clicked this returns me to the product that was being recommended

No longer giving free advice. Please place deposit in meter slot provided.  Individual: [=] SME: [==] Corporation: [===]
If deposit does not fit one of the slots provided then you are asking too much! :P

Is your Osc dated try Phoenix  raising oscommerce from the ashes.

Link to comment
Share on other sites

I have looked at my SEC and my tell_a_friend which is your surprise has this for the continue

 

 <td align="right"><?php echo tep_image_submit('button_continue.gif', IMAGE_BUTTON_CONTINUE); ?></td>

which is the standard code for the submit

Hmm, I just looked at the code for shipping.php from the SEC zip file and it has the code I showed, not yours. I wonder how can that be? In any event, since the code is not that critical, I think I will just change it to the original non-SEC code. I'm sure that will fix the problem. It does bother me that the code stopped working though. If I have done something to cause it to break, it would be nice to find it before I strike again. Thanks for the help Steve.

 

Jack

Support Links:

For Hire: Contact me for anything you need help with for your shop: upgrading, hosting, repairs, code written, etc.

Get the latest versions of my addons

Recommended SEO Addons

Link to comment
Share on other sites

I fear we are at cross purposes again Jack the shipping.php for SEC is as the code you posted, however I was referencing the code for the tell_a_friend.php which I beleive you are using as surprise.php

No longer giving free advice. Please place deposit in meter slot provided.  Individual: [=] SME: [==] Corporation: [===]
If deposit does not fit one of the slots provided then you are asking too much! :P

Is your Osc dated try Phoenix  raising oscommerce from the ashes.

Link to comment
Share on other sites

Sorry for the confusion. I see what you mean. I think what happened is that the shipping mod was changed by SEC while the others were not meant to be. The others were all created by me and I probably made them using shipping.php as a model. I thought for sure I tested the continue button before but I must not have. So, I went through all of the other files and changed them to non-SEC type links and they all work now. Thanks for the assistance Steve. :)

 

Jack

Support Links:

For Hire: Contact me for anything you need help with for your shop: upgrading, hosting, repairs, code written, etc.

Get the latest versions of my addons

Recommended SEO Addons

Link to comment
Share on other sites

Archived

This topic is now archived and is closed to further replies.

×
×
  • Create New...