[Contribution] Links Manager for osC v1.00

[zaxxon]

when i try to add a link from the link_submit file.php

i get this error = This link is already on file.

but i definetly do not have this link on file. i tryed many difernet links addition and it never takes. any ideas on what is wrong ?

[zaxxon]

I dont know if this has anything to do with the error i was getting but when i try to add the link from the admin section i get these warnings when i hit the NEW LINK button :

Warning: array_merge() [function.array-merge]: Argument #1 is not an array in *******\catalog\admin\links.php on line 235

 

Warning: array_merge() [function.array-merge]: Argument #2 is not an array in *******\www\catalog\admin\links.php on line 235

 

Warning: reset() [function.reset]: Passed variable is not an array or object in *******\www\catalog\admin\includes\classes\object_info.php on line 17

 

Warning: Variable passed to each() is not an array or object in *******\www\catalog\admin\includes\classes\object_info.php on line 18

 

despite the errors the link is being added though

[Jack_mcs]

I have this kind of problem. The headers of the links are from wrong part of stylesheet.css.

 

Those headers style is from .productListing-heading instead of .linkListing-heading.

 

How can I customize those headers to fit that table? I dont want to change the .productListing-heading style becouse thats in use in my shopping cart.

 

How could I eg. change that table height in the first line so that those text would fit it?

This is a problem in the code. Here's the fix. Add the following to stylesheet.css (it doesn't matter where but it should go with the rest of the links manager code)

A.linkListing-heading {
 color: #FFFFFF;
}
A.linkListing-heading:hover {
 color: #FF0000;
}

At the top of the includes/modules/link_listing.php file, after the */, add this

  function tep_create_sort_link_heading($sortby, $colnum, $heading) {
global $PHP_SELF;

$sort_prefix = '';
$sort_suffix = '';

if ($sortby) {
  $sort_prefix = '<a href="' . tep_href_link(basename($PHP_SELF), tep_get_all_get_params(array('page', 'info', 'sort')) . 'page=1&sort=' . $colnum . ($sortby == $colnum . 'a' ? 'd' : 'a')) . '" title="' . tep_output_string(TEXT_SORT_PRODUCTS . ($sortby == $colnum . 'd' || substr($sortby, 0, 1) != $colnum ? TEXT_ASCENDINGLY : TEXT_DESCENDINGLY) . TEXT_BY . $heading) . '" class="linkListing-heading">';
  $sort_suffix = (substr($sortby, 0, 1) == $colnum ? (substr($sortby, 1, 1) == 'a' ? '+' : '-') : '') . '</a>';
}

return $sort_prefix . $heading . $sort_suffix;
 }

Around line 74, find this line

$lc_text = tep_create_sort_heading($HTTP_GET_VARS['sort'], $col+1, $lc_text);

and replace it with

$lc_text = tep_create_sort_link_heading($HTTP_GET_VARS['sort'], $col+1, $lc_text);

That should fix it.

 

Jack

[Jack_mcs]

when i try to add a link from the link_submit file.php

i get this error = This link is already on file.

but i definetly do not have this link on file. i tryed many difernet links addition and it never takes. any ideas on what is wrong ?

Do you require reciprocal links?

 

Jack

[matrix2223]

HI Jack,

 

Thanks for your help All is Good now.

 

Thanks,

 

Eric

[Logcbnfvr]

QUOTE

Warning: array_merge() [function.array-merge]: Argument #1 is not an array in *****\www\catalog\admin\link_categories.php on line 111

 

Warning: reset() [function.reset]: Passed variable is not an array or object in *******\www\catalog\admin\includes\classes\object_info.php on line 17

 

Warning: Variable passed to each() is not an array or object in *******\www\catalog\admin\includes\classes\object_info.php on line 18

 

I too am getting this error in admin. I looked back in this forum and I have not found a response to this original request.

 

Does anyone have a suggestion?

Thanks for any help!!!

[zaxxon]

Do you require reciprocal links?

 

Jack

no jack, i dont. but i checked with this require on or off, with no differance.

[Jack_mcs]

no jack, i dont. but i checked with this require on or off, with no differance.

There is a problem in the code that will return false results if that option is not used. You shouldn't see it with it on though. In any event, try doing the following and see if it fixes your problem. In links_submit,php, find this code

	  $duplink_query = tep_db_query("select l.links_id, l.links_url, l.links_reciprocal_url,  ld.links_id, ld.links_title from " . TABLE_LINKS . " l, " . TABLE_LINKS_DESCRIPTION . " ld where l.links_id = ld.links_id AND (ld.links_title = '" . $links_title . "' OR l.links_url = '" . $links_url . "' OR l.links_reciprocal_url = '" . $links_reciprocal_url . "' ) AND language_id = '" . (int)$languages_id . "'");

and replace it with

	  if (LINKS_RECIPROCAL_REQUIRED == 'True')
   $condition = "ld.links_title = '" . $links_title . "' OR l.links_url = '" . $links_url . "' OR l.links_reciprocal_url = '" . $links_reciprocal_url . "'";
  else
   $condition = "ld.links_title = '" . $links_title . "' OR l.links_url = '" . $links_url . "'";

  $duplink_query = tep_db_query("select l.links_id, l.links_url, l.links_reciprocal_url,  ld.links_id, ld.links_title from " . TABLE_LINKS . " l, " . TABLE_LINKS_DESCRIPTION . " ld where l.links_id = ld.links_id AND ($condition) AND language_id = '" . (int)$languages_id . "'");

 

Jack

[zaxxon]

thanks for the quick response Jack,

i have changed the code as you suggested and i still get that the link is alredy on file.. i definetly added a new link which is not on file. any other suggestions ?

BTW, i am running this site off my own computer for now so i am using a WAMP server. i am using

Apache 2.0.58

PHP 5.1.4 + PECL

MySQL 5.0.22

would that have any thing to do with it ?

[zaxxon]

OOPs :blush: ,

embarassing really, but i have made the changes and havent saved the file...... i just noticed it and saved it and its now working well :)

for my own records though... what did i change there ?

and also what about the errors from the admin panel

Warning: array_merge() [function.array-merge]: Argument #1 is not an array in *****\www\catalog\admin\link_categories.php on line 111

 

Warning: reset() [function.reset]: Passed variable is not an array or object in *******\www\catalog\admin\includes\classes\object_info.php on line 17

 

Warning: Variable passed to each() is not an array or object in *******\www\catalog\admin\includes\classes\object_info.php on line 18

any idea what is causing that ?

[zaxxon]

i just tryed turning on 'require reciprocal link' and noticed tht when i go to submit a link it does not require any reciprocity... would that be because of that code addition you gave me, jack ?

[Jack_mcs]

No, the code just disables checking for a reciprocal link in the database if the option is not on.

 

Jack

[kumst2000]

Hello Jack,

 

I inserted your Contrib and have with the following ranges in each case an error:

 

admin/links_status.php

 

1146 - Table 'db91255707.links_check' doesn't exist

 

select count(*) as total from links l LEFT JOIN links_description ld on l.links_id = ld.links_id LEFT JOIN links_check lc on l.links_id = lc.links_id LEFT JOIN links_status ls on l.links_status = ls.links_status_id and ls.language_id = '2'

 

 

admin/links_featured.php

 

1146 - Table 'db91255707.links_featured' doesn't exist

 

SELECT lf.links_id, lf.expires_date, ld.links_id, ld.links_title FROM links_featured lf, links_description ld where lf.links_id = ld.links_id

 

Already mark thanks in advance for your assistance.

 

Many greetings from Germany.

 

Andreas

[Jack_mcs]

The errors are saying the changes haven't been made to the database.

 

Jack

[Guest]

There is a problem in the code that will return false results if that option is not used. You shouldn't see it with it on though. In any event, try doing the following and see if it fixes your problem. In links_submit,php, find this code

	  $duplink_query = tep_db_query("select l.links_id, l.links_url, l.links_reciprocal_url,  ld.links_id, ld.links_title from " . TABLE_LINKS . " l, " . TABLE_LINKS_DESCRIPTION . " ld where l.links_id = ld.links_id AND (ld.links_title = '" . $links_title . "' OR l.links_url = '" . $links_url . "' OR l.links_reciprocal_url = '" . $links_reciprocal_url . "' ) AND language_id = '" . (int)$languages_id . "'");

and replace it with

	  if (LINKS_RECIPROCAL_REQUIRED == 'True')
   $condition = "ld.links_title = '" . $links_title . "' OR l.links_url = '" . $links_url . "' OR l.links_reciprocal_url = '" . $links_reciprocal_url . "'";
  else
   $condition = "ld.links_title = '" . $links_title . "' OR l.links_url = '" . $links_url . "'";

  $duplink_query = tep_db_query("select l.links_id, l.links_url, l.links_reciprocal_url,  ld.links_id, ld.links_title from " . TABLE_LINKS . " l, " . TABLE_LINKS_DESCRIPTION . " ld where l.links_id = ld.links_id AND ($condition) AND language_id = '" . (int)$languages_id . "'");

 

Jack

 

Hello Jack... I was getting a similar error in the links admin, and I implemented this change but I did notice that my error was slightly different and this code change had no effect.

 

I am getting the following:

Warning: array_merge() [function.array-merge]: Argument #2 is not an array in /home/bdsmmaz6/public_html/catalog/admin/links.php on line 733

 

Warning: reset() [function.reset]: Passed variable is not an array or object in /home/bdsmmaz6/public_html/catalog/admin/includes/classes/object_info.php on line 17

 

Warning: Variable passed to each() is not an array or object in /home/bdsmmaz6/public_html/catalog/admin/includes/classes/object_info.php on line 18

 

This error is occuring when I go to the "links manager" in the admin. it doesn't seem to be effecting the functionality because below the error messages I see the links.

 

any clues?

[Guest]

also my "links categories" doesn't seem to work at all, but I think that's probably because there's no category entries in the database. But since I can't use the links categories tool, how do I populate the database with some categories?

[Guest]

okay never mind. all the errors seemed to be hinged on the fact that the categories database was empty. I used myphpadmin to add a row to the links categories and categories description tables and everything appears to be working now.

[only2empires]

I hope someone out there can help me. I have this contribution installed, and for a very long time now. All of a sudden the "pharmacy" type spammers have found their way to the Submit A Link page, which is SSL, and every day I have over 30 pending links. They are in the form of the email type spam, which my email filters block them from direct emailing...how do I now stop them from submitting an email through the submit a link page?

 

I have installed all the lastest Oscommerce patches so everything is up to date. Is there a block coding I could use or something???

[Jack_mcs]

Not much you can do against spam. If it were some common IP, then they could be blocked but that is usually not the case. If you have the latest Links Manager installed, there is an option to verify the link to your site exists on their page before allowing them to submit. That might cut down on some if they are not real exchanges. You could also find this code in kinks_submit.php

if (strlen($links_title) < ENTRY_LINKS_TITLE_MIN_LENGTH) {

and change it to

	if (strlen($links_title) < ENTRY_LINKS_TITLE_MIN_LENGTH || strpos($links_title, "pharmacy") !== FALSE ) {

If the word pharmacy is in the title, the link won't be submitted. You can add more lines to test for other words or add it so it tests the url string. Let me know if it helps any and I will add to the next update.

 

Jack

[only2empires]

Tried changing that code and when I did a test, it came through on the word "Viagra"

 

To tell you the truth, I have no idea what version I have installed as it has been a long time. Went back to the contribution and WOW! If you can let me know which version to now use, I will update mine and see if that solves my problem. I'm guessing V 1.14 ? I will need the complete package version to compare to what I already have.

 

Thanks for your help and I'll keep trying!

[Jack_mcs]

Yes, the code I gave would only prevent pharmacy from submitting. That why I mentioned a new line would be needed for others. But with the way spam is, you would end up with quite a long list. The last full version is 1.14. There is a problem in it where one part of the code doesn't work due to mysql version differences. If you have that problem, you would need the code change that is mentioned here in this thread a few pages back. The version 1.14b is meant to fix that but I haven't looked at that code so I've no idea if it is done properly or not.

 

Jack

[zaxxon]

adding a simple CAPTCHA to the submit form will be a great idea - you will bock most like that.

i am no coder so i cant tell you how to do it, but if you look through contribution section you will find this little contrib

http://www.oscommerce.com/community/contri...arch,validation

i havent installed it yet so cant tell you if its easy enough to do, but certinly worth a try

[only2empires]

Thanks! Will look into that before I decide to do a complete overhaul on the version I am using for Links Manager. So far, that is the only thing that broke :'( although I see there is more fancier stuff going on now with the newest version :D

 

I did try to update to the newest version, and I did get that Division by Zero error. So, currently I backed it out and put my old files back in and just removed the post submit link info and the button so that no one can submit at this time. So far that's working, just no new link requests.

[only2empires]

Well, I ended up not using that contribution for the links submit page. The person says he added it to his reviews, but the instructions are for the contact us, and the codes are diff, so not sure just how to do that.

 

Since I don't have time to implement the new version of the Links Manager and figure out the Division by Zero error, that will have to wait. I did get that to go away, but none of my existing links would show up, which I'll have to figure out why on that later.

 

What I ended up doing in the meantime was just changing the name of the links submit page to something else. I'm sure I'll be back reading more so that I can figure out my error!

[only2empires]

Renaming the file has worked so far. Until they figure it out again. Thanks for you advices...and I will surely update my Links Manager when I have the time!