UK credit card validation not working properley for VISA

[garyidweb]

Hi

 

After putting our Osc 2 live on Thursday, we had 3 answer machine messages over the weekend letting us know they couldnt use their visa card, as the validation would not accept it.

 

In my /catalog/includes/classes/cc_validation.php I have the following for visa:-

 

// Visa

} elseif ( (($NumberLeft6 >= 400000) && ($NumberLeft6 <= 499999))

// ensure we exclude AMT only cards

&& !( (($NumberLeft6 >= 490300) && ($NumberLeft6 <= 490301))

 

|| (($NumberLeft6 >= 490310) && ($NumberLeft6 <= 490334))

|| (($NumberLeft6 >= 410000) && ($NumberLeft6 <= 458998))

|| (($NumberLeft6 >= 490340) && ($NumberLeft6 <= 490399))

|| (($NumberLeft6 >= 490400) && ($NumberLeft6 <= 490409))

|| ($NumberLeft6 == 490419)

|| ($NumberLeft6 == 490451)

|| ($NumberLeft6 == 490459)

|| ($NumberLeft6 == 490467)

|| (($NumberLeft6 >= 490475) && ($NumberLeft6 <= 490478))

|| (($NumberLeft6 >= 490500) && ($NumberLeft6 <= 490599))

|| (($NumberLeft6 >= 491103) && ($NumberLeft6 <= 491173))

|| (($NumberLeft6 >= 491183) && ($NumberLeft6 <= 491199))

|| (($NumberLeft6 >= 492800) && ($NumberLeft6 <= 492899))

|| (($NumberLeft6 >= 498700) && ($NumberLeft6 <= 498799)) ) ) {

$this->cc_type = 'Visa';

$ShouldLength = 16;

$ShouldLength2 = 13;

if ( strtolower(MODULE_PAYMENT_CC_ACCEPT_VISA) != 'true' ) {

return -5;

}

} else {

return -1;

}

 

 

 

Can any one spot a number range that is missing.

 

Thanks in advance

Gary

[Guest]

there is a tip in the tips and tricks section about this subject.

 

It is based on the code for MS2.

 

for your code, at the end of all the elseifs, change the else to read something like

 

} else {

$this->cc_type = 'Credit Card';

}

 

 

and it will allow the numbers through but not identify the card. You can put the number ranges in when you see an order with this card type.

[garyidweb]

Thanks

Ill give it a go

[garyidweb]

|| (($NumberLeft6 >= 430000) && ($NumberLeft6 <= 439999))