Canada Post Shipping Module Contrib ERROR

[horsedog]

CanadaPost Shipping Module version. 3.1 - with Length, Width and Height

 

From my admin pannel when loggin in the shipping module before installing this mod. I get the following warning.

 

Warning: Call-time pass-by-reference has been deprecated - argument passed by value; If you would like to pass it by reference, modify the declaration of fsockopen(). If you would like to enable call-time pass-by-reference, you can set allow_call_time_pass_reference to true in your INI file. However, future versions may not support this any longer. in /home/sites/site1/web/includes/modules/shipping/canadapost.php on line 198

 

On osc 2.2 ms2

Host is Cobalt Raq4

 

I had the same problem with ms1 and uninstalled the contrib.

I don't know if it is a good idea to set that in my ini file...

 

any suggestions?

[Guest]

What they are telling you is that you should not do new development with that setting and that you should try to move existing development away from it when you can. Since you aren't interested in development (I'm guessing), it shouldn't be a big deal to use the INI hack. In fact, you might even want to try it as is and see if the module will work. It's possible that it is one of those meaningless warnings.

 

You also might be able to get rid of it by changing line 198 from

	$fp = @fsockopen($host, $port, &$errno, &$errstr, 2);

to

	$fp = @fsockopen($host, $port, $errno, $errstr, 2);

This will make it not return an errno and errstr, but it doesn't seem to check them anyway. Therefore, it shouldn't matter.

 

The best way to fix it would be to change the declaration of fsockopen, as it suggests. Unfortunately, I would expect fsockopen to be a PHP function, so changing it would require modifying PHP itself. However, if you find out that I am wrong, it would not be hard to modify an OSC function to include explicit pass by reference.

 

Good luck,

Matt