Ken_Shea Posted April 21, 2023 Posted April 21, 2023 This is among the first lines Hello ##CUSTOMER_FIRSTNAME##, How can a new variable ##CUSTOMER_LASTNAME## be created, is that possible? I find customers_lastname but that does not work in the template. Thank you Ken Quote
Ken_Shea Posted April 23, 2023 Author Posted April 23, 2023 Hi Andy, yes checked that exact variable several time but none worked, just ignored it. I'll go over your message later to day and try that. Thank you Ken Quote
Ken_Shea Posted April 23, 2023 Author Posted April 23, 2023 The update did work with both variables. Though I tried many times on the order update going to try again. Quote
Ken_Shea Posted April 23, 2023 Author Posted April 23, 2023 Neither key worked on the "Send Coupon" Me thinks we have a code issue. Thank again Andy you've been a great help Quote
Ken_Shea Posted April 23, 2023 Author Posted April 23, 2023 Added ##CUSTOMER_LASTNAME## to EmailController.php , it does now list ##CUSTOMER_LASTNAME## in the "Key List" it still does not add last name to order confirmations. The "and ideally to the translations in the database too" is not something I could do is it? pandrei 1 Quote
Ken_Shea Posted April 24, 2023 Author Posted April 24, 2023 Hi Andy, Tried the add to keys and it still fails in "order confirmation", didn't try others, but did learn some new things in the process so not a loss. Maybe the fix in gethub will take care of the problem. Ken Quote
pandrei Posted April 24, 2023 Posted April 24, 2023 On 4/21/2023 at 6:48 PM, Ken_Shea said: How can a new variable ##CUSTOMER_LASTNAME## be created, is that possible? Andy is right - the template key is working fine in the latest 4.11 version. 20 hours ago, Ken_Shea said: Added ##CUSTOMER_LASTNAME## to EmailController.php , it does now list ##CUSTOMER_LASTNAME## in the "Key List" it still does not add last name to order confirmations. It is right fix, we will include it in the next update. 18 hours ago, CHD-UK said: I've submitted a potential fix to the Github repository so just awaiting feedback on that. As we concluded, it does indeed appear that the fields for CUSTOMER_FIRSTNAME and CUSTOMER_LASTNAME are not initialised in the $email_params array before calling the function to parse the email template for the Send Voucher email template. Thanks Andy, you are right again. Your fix will be included in the next update. 3 hours ago, Ken_Shea said: Tried the add to keys and it still fails in "order confirmation", didn't try others, but did learn some new things in the process so not a loss. It will be fixed in the update, which we are going to release this week. CHD-UK and Ken_Shea 2 Quote
Ken_Shea Posted April 24, 2023 Author Posted April 24, 2023 (edited) That would be a big help. Order confirmations need to be sent in a very specific format (Last name is just one piece of the puzzle) so a program I wrote years ago can read it, pull all the necessary data to keep sales, orders, inventory, tax etc current and accurate. I see V4 does some of this but not had the time to look into it. Edited April 24, 2023 by Ken_Shea Quote
Ken_Shea Posted April 24, 2023 Author Posted April 24, 2023 2 hours ago, CHD-UK said: Hi Ken, Just a thought, could you check to see if ##CUSTOMER_NAME## works on your order confirmation template?You'll need to type it in manually as I don't think it is in the "Add Key" popup Ill report on this in a couple Quote
Recommended Posts
Join the conversation
You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.