PHP 8.0 Upgrade to boxes.php class

[Teaman55]

PHP 8.0 requires that any classes that use the class name as a function name for the constructor function be changed to use  __construct() instead. This is an issue for the class boxes.php where the constructors may also be called directly from other classes. Has anyone worked out a solution for this class?

[♥raiwa]

This was already required for PHP 7.0

Or am I wrong?

[Teaman55]

Thanks for the response.

7.x announced that using matching function names as constructors would be removed as of 8.0.  They still work in 7.x versions as is.

 class tableBox {
    var $table_border = '2px solid #ccc;';
    var $table_width = '100%';
    var $table_cellspacing = '0';
    var $table_cellpadding = '0';
    var $table_parameters = '';
    var $table_row_parameters = 'style="vertical-align: middle;"';
    var $table_data_parameters = '';
    var $table_top_space = ''; // added AF 22APR05

// class constructor
    function tableBox($contents, $direct_output = false) {
      $tableBox_string = '<table style="border: ' . tep_output_string($this->table_border) . ' width: ' . tep_output_string($this->table_width) . '; border-spacing: ' . tep_output_string($this->table_cellspacing) . '; padding: ' . tep_output_string($this->table_cellpadding) . ';"';
      if (tep_not_null($this->table_parameters)) $tableBox_string .= ' ' . $this->table_parameters;
      $tableBox_string .= '>' . "\n";  etc.

Every extension of tableBox in boxes.php calls $this->tableBox().  So if it is really the constructor also, as marked in the code above, seems like every version  2.x.x, and probably some later versions, are headed for a breakdown when PHP is upgraded to 8.0.

I haven't figured out why boxes.php is built like this, unless it is just to create all the extensions on startup.. In every other class, the matching function name could be changed to __construct without a problem.  Can't believe I'm the first person to notice this problem.

[♥Smoky Barnable]

I ran into this issue today while updating to PHP 8. Did you ever find a solution?

[Hotclutch]

  class tableBox {
    var $table_border = '0';
    var $table_width = '100%';
    var $table_cellspacing = '0';
    var $table_cellpadding = '2';
    var $table_parameters = '';
    var $table_row_parameters = '';
    var $table_data_parameters = '';

// class constructor
    function __construct($contents, $direct_output = false) {

 

[Demitry]

My osC version does not have this boxes.php class file. However, I believe you have to make that function __construct change to each of the class XXXXX extends tableBox, function XXXXX in that file.

 

 

[ruden]

@Smoky Barnable take a look at this commit

https://github.com/ruden/vanilla-oscommerce/commit/d4cdd7ca167492f5b1bbcaa08c3de858dc89fd20

[♥Smoky Barnable]

13 hours ago, ruden said:

@Smoky Barnable take a look at this commit

https://github.com/ruden/vanilla-oscommerce/commit/d4cdd7ca167492f5b1bbcaa08c3de858dc89fd20

I have been using your vanilla code as a guide to update my shop to PHP 8. It has been very helpful but I see you have removed the boxes. I would like to keep them. Might you have a includes/classes/boxes.php file that is PHP 8 compatible so I can compare with my file?

[ruden]

add empty constructor for classes

  function __construct() {
    // empty
  }