What's the sence?

[mcmannehan]

In the last version osC BS 3 and BS 4 i find in /catalog/admin/includes/classes/upload.php

if (isset($_FILES[$this->file])) {
        $file = array('name' => $_FILES[$this->file]['name'],
                      'type' => $_FILES[$this->file]['type'],
                      'size' => $_FILES[$this->file]['size'],
                      'tmp_name' => $_FILES[$this->file]['tmp_name']);
      } elseif (isset($_FILES[$this->file])) {
        $file = array('name' => $_FILES[$this->file]['name'],
                      'type' => $_FILES[$this->file]['type'],
                      'size' => $_FILES[$this->file]['size'],
                      'tmp_name' => $_FILES[$this->file]['tmp_name']);
      }

i really ask by myself, what is that? Makes no sence!!!
An if and an else with the same!!!!
So i changed to:

if (isset($_FILES[$this->file])) {
        $file = array('name' => $_FILES[$this->file]['name'],
                      'type' => $_FILES[$this->file]['type'],
                      'size' => $_FILES[$this->file]['size'],
                      'tmp_name' => $_FILES[$this->file]['tmp_name']);
      }

every works fine.

Any suggestion why this is since the beginning of osC in the upload file?

[MrPhil]

Your observation is correct that it's redundant code. Presumably the author meant to get the fields name, type, size, and tmp_name from somewhere else, if $_FILES[$this->file] wasn't available. Does anyone have any idea where these fields might come from?