Jump to content
  • Checkout
  • Login
  • Get in touch

osCommerce

The e-commerce.

[contr] Fixed payment type charge: separate tax group?


Method

Recommended Posts

I installed the contribution Fixed Payment Type Charge (order total module).

It works, and i switched on the tax class, so taxes are calculated too for this module.

 

But the tax costs for this module show seperate from the normal tax line.

How to fix this?

 

See this screenshot for a clear view on the problem:

fixed_payment_charge.png

The problem line is the line with the description '19' (very strange).

 

Thanks in advance. :)

Link to comment
Share on other sites

I'm using CVS 18-May-2003.

 

In an earlier version I have installed, there is a switch in the module which switches between groups show yes or no.

 

function process() {

     global $order, $currencies;



     if (MODULE_ORDER_TOTAL_TAX_SHOW_GROUPS == 'true') {

       reset($order->info['tax_groups']);

[...]

But this is removed in this version of the module (ot_tax.php,v 1.14 2003/02/14)

 

Maybe it's a simple switch anywhere else in the OSC codebase. Please tell me. :)

Link to comment
Share on other sites

Got a workaround!!!

 

In file ot_fixed_payment_chg.php, i modified the tax group hard coded to "BTW 19%".

 

$order->info['tax_groups']["BTW 19%"] += tep_calculate_tax($table[$i+1], $tod_rate);

 

:)

Link to comment
Share on other sites

thanx for your help , i was also working on this subject :D

 

Maybe this is also an option:

 

["BTW {$tod_rate}%"]

 

now the tax percentage will change automaticly

 

it would be nice to do this also with the BTW ?!

 

But how to do this....

 

8)

Link to comment
Share on other sites

Maybe this is also an option:

 

["BTW {$tod_rate}%"]

 

now the tax percentage will change automaticly

 

it would be nice to do this also with the BTW ?!

 

But how to do this....

 

8)

This is I think how the module should function normally. :)

I think some minor changes to the codebase are causing this problem. In my shop, my workaround works perfect. I'm not into php that much to fix the code for universal use.

Link to comment
Share on other sites

  • 3 years later...

Hi Everybody,

 

This post might be outdated, but I had the same problem as Method did. I wrote a contribution the fix this problem:

Fixed Payment taxgroup bugfix

 

### APPLIES TO ###

 

/includes/modules/order_total/ot_fixed_payment_chg.php

 

If the payment module Fixed Payment Charge is enabled and VAT applies to this module.

 

 

### PROBLEM ###

 

1.

When VAT is added, according to the variable DISPLAY_PRICE_WITH_TAX, the value of this variable is reversed for this module.

2.

If you choose the same tax class for your product and for the fixed payment module, 2 different taxgroups will be created in the order total.

The sum of all tax amounts (from products with the same tax rate) will be combined to a taxgroup key, named after your given tax description for this tax rate.

The tax amount calculated from the fixed payment charge, will create a new taxgroup, named after the tax rate. While this should also be added to the taxgroup named after your description.

 

This will programmaticly fis this problem.

 

B) I wish you all the best!

 

Greetings!

Link to comment
Share on other sites

Archived

This topic is now archived and is closed to further replies.

×
×
  • Create New...