Down.Controller, creditclass: no taxrate for down. products

[helios]

Hello,

 

I am not really sure whether its related to Downloads Controller 5.3, Credit Class GV 5.03 or the download facility in the osCommerce shop itself, but for downloadable goods no tax rate get displayed in checkout_confirmation.php.

 

I use osCommerce 2.2MS1, together with Credit Class GV 5.03 and Downloads Controller 5.3. I have setup one product which costs 50 EUR with product attribute "as download". This can be set to yes to get a download version (this costs 10 EUR less). Or it can be set to no to receive it as snail mail package.

 

Now when I order the product as boxed version, everything works as expected. I get shipping options, I get all payment choices and the tax is displayed correctly!

 

But when I order this as a download version the tax does not get displayed in "checkout_confirmation.php". Instead of 40 EUR for the product (50EUR - 10 EUR off for the download version), I get 34,48 EUR. No tax is displayed. In the table "order_products" the product is included with a tax rate of "0".

 

What can I do to have it display the tax rate for download products also? When I add one physical product the tax rate is displayed, so I conclude it is not displayed for a order which contains only virtual products. This is not what we like: We are quite sure that downloadable products still have to contain taxes in Germany.

 

Other differences where that no shipping options get displayed. This is okay with me. But also some payment methods where not selectable. Only credit card and payment in advance where usable. I already found out that this is due to the order consisting of virtual products only. This is checked in each payment module in the "update_status" function. I like to enable further payment methods for virtual products. All downloads are set to ok manually here for now, so we can accept other payment methods. Should not be hardcoded into the modules IMHO.

 

BTW I think that the maximum string length of the message title field is rather low to issue meaningful subjects!

 

Regards,

[Ian]

I think it's the Credit Class code, actually I know it's the cresit class code.

 

in checkout_shipping.php find this code

if (($order->content_type == 'virtual') || ($order->content_type == 'virtual_weight') ) {

if (!tep_session_is_registered('shipping')) tep_session_register('shipping');

$shipping = false;

$sendto = false;

 

and change

$sendto = false;

to

 if ($order->content_type != 'virtual_weight') $sendto = false;

[helios]

Hello,

 

I applied the change you suggested, but the price in checkout_confirmation.php is still displayed without tax. The price when the download product is in the basket is displayed with tax.

 

The relevant code of checkout_shipping.php now looks as follows:

 

// if the order contains only virtual products, forward the customer to the billing page as

// a shipping address is not needed

// ICW CREDIT CLASS GV AMENDE LINE BELOW

//  if ($order->content_type == 'virtual') {

 if (($order->content_type == 'virtual') || ($order->content_type == 'virtual_weight') ) {

   if (!tep_session_is_registered('shipping')) tep_session_register('shipping');

   $shipping = false;

   //$sendto = false;

 if ($order->content_type != 'virtual_weight') $sendto = false;

   tep_redirect(tep_href_link(FILENAME_CHECKOUT_PAYMENT, '', 'SSL'));

 }

 

Regards,

[Ian]

Martin,

 

The code i suggested fixed a problem for me where no tax was being charged on Gift Vouchers.

 

The problem is that $sendto is being set to false, becuase of this there is no way that osCommerce can know which country the buyers is from and so can't calculate the tax.

 

Try removing the line altogether, and see if that helps.

[helios]

Hello,

 

ok, that one works! Thanks a lot for your hint. Now downloads are working with tax!

 

Regards,