Please give me your worst

zlack · May 15, 2003

Hello all,

I'm nearly done with my site, except add one more payment module, and add more products and adjusting the prices.

Tell me what you think about the colors/design and what i should improve.

The url is http://www.partshop.nl/default.php (only dutch)

Thanks, zlack

zlack · May 15, 2003

Arent you guys saying anything because you think i don't have the "powered by oscommerce" at my site?

it is there: left bottom, covered in the footer :)

emiliano · May 16, 2003

table with borders? come on!!! my pc is telling me we are in 2003!!!

i don't like the site with the borders.. get rid of them and you'll have a GREAT site..

cheers

emiliano

zlack · May 16, 2003

haha :D

thanks emiliano!

but the borders where nearly for doing some more testing :) forgot to get rid off them and went to bed :o

there gone now anyway. what do you think about the logo and such?

zlack · May 16, 2003

Not more comments for me?

HyperJack · May 17, 2003

Very professional looking. I really like your graphics.

I also like how you display the privacy info on the login page. However, and I don't know if this is intentional, you still have this in english: NOTE: Your "Visitors Cart" contents will be merged with your "Members Cart" contents once you have logged on.

-You have a few categories with no products available.

- why not have pictures next to the items on your P"rodukten in de categorie" pages?

-I would valign= "middle" your GO buttons. (That really annoys me for some reason)

I can't really say much else.

nice job!!!

zlack · May 17, 2003

However, and I don't know if this is intentional, you still have this in english: NOTE: Your "Visitors Cart" contents will be merged with your "Members Cart" contents once you have logged on.

-You have a few categories with no products available.

- why not have pictures next to the items on your P"rodukten in de categorie" pages?

-I would valign= "middle" your GO buttons. (That really annoys me for some reason)

I knew i forgot something to translate :) After you get busy some things you just don't see anymore :) thanks for pointing that out!

As of the categories with no pictures: The site aint live yet, and i'm very busy adding product/pictures.

And i know about the GO buttons. Can manage to get them in the middle. I use the TEP_IMAGE_SUBMIT function, and i dunno where to change that :(

Thanks for your comments!

zlack

phelan · May 17, 2003

I think your site just really looks good, keep it up!! I like the neatness of your graphics, I wish I could design some graphics but unfortunately I don't have a good graphics program, the only thing I have is MS Draw, go to my site and you'll see.

http://www.malewitch.com

zlack · May 18, 2003

I think your site just really looks good, keep it up!! I like the neatness of your graphics, I wish I could design some graphics but unfortunately I don't have a good graphics program, the only thing I have is MS Draw, go to my site and you'll see.
http://www.malewitch.com

thanks! your site ain't bad either.

if you need a good graphics program you could download the trial of adobe, or maybe switch to linux/bsd and use the gimp (free)

good luck with your site!

zlack

surfking · May 18, 2003

I really like the clean layout. Everything runs together good. Good Job!

zlack · May 18, 2003

Thanks Surfking!

I just removed the column left and right from my shopping cart and checkout process.

I think its easier for people to checkout this way, not getting distracted with all the "stuff" around it.

Anyone had any experience with that? (If you store ran better with/without column left/right on shoppingcart/checkout)

cheers, zlack

zlack · May 18, 2003

anyone a sollution to fix tep_image_submit to align the images in the middle?

thanks, zlack

May 19, 2003

Anyone had any experience with that? (If you store ran better with/without column left/right on shoppingcart/checkout)

Its running much better, I have removed the column_right and its not that crowded.

Customers can concentrate on the buying, not being disturbed by all the other things;-)

Cheers

dabri · May 19, 2003

I like your colors, you mixed it perfect.

There is only one thing, that I dont like. On the star page under special voor u ingekocht, the pictures have different sizes und so look the box a little bit chaotic.

And I also like your catagory menu with the popup.

For what contribution must I looking for, to manage this menu for my site?

Or is this your own solution? If its so, may be you can send me the code.

Greets Daniel

drakonan · May 19, 2003

I love your site, its very nice, and i see you've got the shopping cart header image to display without an added space like mine does when I convert the image into a link.

Can you tell me how to do that?

What i mean:

Picture a site with header graphics on the boxes,

all the box headers have no space in between them, then I convert the img tag on the shopping cart to a hyperlink so it can be clicked to show the cart,

It works and everything, but it puts a space in there! A lady asked me if I ever fixed it, and I totally forgot about it (I had removed the link)

zlack · May 19, 2003

I like your colors, you mixed it perfect.

There is only one thing, that I dont like. On the star page under special voor u ingekocht, the pictures have different sizes und so look the box a little bit chaotic.

And I also like your catagory menu with the popup.

For what contribution must I looking for, to manage this menu for my site?

Or is this your own solution? If its so, may be you can send me the code.

Greets Daniel

thanks for your comments! If still not satisfied about the logo, i had like 20 now and i dunno if i like this one.

the code for the menu was a contribution, you can find it here:

http://www.oscommerce.com/community/contributions,1238

you can adjust it to display it like i did, or you could display it in the header.

good luck, zlack

zlack · May 19, 2003

I love your site, its very nice, and i see you've got the shopping cart header image to display without an added space like mine does when I convert the image into a link.

Can you tell me how to do that?

What i mean:

Picture a site with header graphics on the boxes,

all the box headers have no space in between them, then I convert the img tag on the shopping cart to a hyperlink so it can be clicked to show the cart,

It works and everything, but it puts a space in there! A lady asked me if I ever fixed it, and I totally forgot about it (I had removed the link)

pm me and i'll send you mine. i believe i did nothing special with it but... :)

zlack · May 19, 2003

Anyone had any experience with that? (If you store ran better with/without column left/right on shoppingcart/checkout)

Its running much better, I have removed the column_right and its not that crowded.

Customers can concentrate on the buying, not being disturbed by all the other things;-)

Cheers

thanks :) thats what i wanted to hear

HyperJack · May 20, 2003

The menu crashes NN4*.

jaysin · May 20, 2003

Hi zlac like your site very much. I love the layout of your products_info.php and the pop up window with more information. Can you tell me which contributions you used.

zlack · May 20, 2003

The menu crashes NN4*.

netscape 4 is quite old isn't it? should i make it compatible with it?

thanks for testing, zlack

zlack · May 20, 2003

Hi zlac like your site very much. I love the layout of your products_info.php and the pop up window with more information. Can you tell me which contributions you used.

i only used dynamic mo_pics

and my products_info page is here:

(do not mind my bad++ coding, and post any improvements please)

<?php

/*

 $Id: product_info.php,v 1.92 2003/02/14 05:51:21 hpdl Exp $



 osCommerce, Open Source E-Commerce Solutions

 http://www.oscommerce.com



 Copyright (c) 2003 osCommerce



 Released under the GNU General Public License

*/



 require('includes/application_top.php');



 require(DIR_WS_LANGUAGES . $language . '/' . FILENAME_PRODUCT_INFO);

?>

<!doctype html public "-//W3C//DTD HTML 4.01 Transitional//EN">

<html <?php echo HTML_PARAMS; ?>>

<head>

<script language="javascript"><!--

function popupWindow(url) {

 window.open(url,'popupWindow','toolbar=no,location=no,directories=no,status=no,menubar=no,scrollbars=no,resizab
le=yes,copyhistory=no,width=100,height=100,screenX=150,screenY=150,top=150,left=1
50')

}

//--></script>

<meta http-equiv="Content-Type" content="text/html; charset=<?php echo CHARSET; ?>">

<title><?php echo TITLE; ?></title>

<base href="<?php echo (($request_type == 'SSL') ? HTTPS_SERVER : HTTP_SERVER) . DIR_WS_CATALOG; ?>">

<link rel="stylesheet" type="text/css" href="stylesheet.css">

</head>

<body marginwidth="0" marginheight="0" topmargin="0" bottommargin="0" leftmargin="0" rightmargin="0">

<!-- header //-->



<div id="overDiv" style="position:absolute; visibility:hidden; z-index:1000;"></div>

<script language="JavaScript" src="overlib_mini.js"><!-- overLIB (c) Erik Bosrup --></script>



<?php require(DIR_WS_INCLUDES . 'header.php'); ?>

<!-- header_eof //-->



<!-- body //-->

<table border="0" width="100%" cellspacing="0" cellpadding="3">

 <tr>

   <td bgcolor="#ffffff" width="<?php echo BOX_WIDTH; ?>" valign="top"><table border="0" width="<?php echo BOX_WIDTH; ?>" cellspacing="0" cellpadding="2">

<!-- left_navigation //-->

<?php require(DIR_WS_INCLUDES . 'column_left.php'); ?>

<!-- left_navigation_eof //-->

   </table></td>

<!-- body_text //-->

   <td width="100%" valign="top"><?php echo tep_draw_form('cart_quantity', tep_href_link(FILENAME_PRODUCT_INFO, tep_get_all_get_params(array('action')) . 'action=add_product')); ?><table border="0" width="100%" cellspacing="0" cellpadding="0">

<?php

// old one  $product_info_query = tep_db_query("select p.products_id, pd.products_name, pd.products_description, p.products_model, p.products_quantity, p.products_image, pd.products_url, p.products_price, p.products_tax_class_id, p.products_date_added, p.products_date_available, p.manufacturers_id, m.manufacturers_name from " . TABLE_PRODUCTS . " p, " . TABLE_MANUFACTURERS . " m, " . TABLE_PRODUCTS_DESCRIPTION . " pd where p.products_status = '1' and p.products_id = '" . (int)$HTTP_GET_VARS['products_id'] . "' and pd.products_id = p.products_id and pd.language_id = '" . $languages_id . "'");

$product_info_query = tep_db_query("select p.products_id, pd.products_name, pd.products_description, p.products_model, p.products_quantity, p.products_image, pd.products_url, p.products_price, p.products_tax_class_id, p.products_date_added, p.products_date_available, p.manufacturers_id, p.manufacturers_id from " . TABLE_PRODUCTS . " p, " . TABLE_PRODUCTS_DESCRIPTION . " pd where p.products_status = '1' and p.products_id = '" . (int)$HTTP_GET_VARS['products_id'] . "' and pd.products_id = p.products_id and pd.language_id = '" . $languages_id . "'");

//$product_info_query = tep_db_query("select p.products_id, pd.products_name, pd.products_description, p.products_model, p.products_quantity, p.products_image, pd.products_url, p.products_price, p.products_tax_class_id, p.products_date_added, p.products_date_available, p.manufacturers_id, m.manufacturers_name from " . TABLE_PRODUCTS . " p, " . TABLE_PRODUCTS_DESCRIPTION . " pd, " . TABLE_MANUFACTURERS . " m where p.products_id = '" . $HTTP_GET_VARS['products_id'] . "' and pd.products_id = '" . $HTTP_GET_VARS['products_id'] . "' and pd.language_id = '" . $languages_id . "' and m.manufacturers_id = p.manufacturers_id");

 if (!tep_db_num_rows($product_info_query)) { // product not found in database

?>

     <tr>

       <td class="main"><br><?php echo TEXT_PRODUCT_NOT_FOUND; ?></td>

     </tr>

     <tr>

       <td align="right"><br><a href="<?php echo tep_href_link(FILENAME_DEFAULT); ?>"><?php echo tep_image_button('button_continue.gif', IMAGE_BUTTON_CONTINUE); ?></a></td>

     </tr>

<?php

 } else {



   tep_db_query("update " . TABLE_PRODUCTS_DESCRIPTION . " set products_viewed = products_viewed+1 where products_id = '" . (int)$HTTP_GET_VARS['products_id'] . "' and language_id = '" . $languages_id . "'");

   $product_info = tep_db_fetch_array($product_info_query);

// Comfortcard Addon

       $blah = $product_info['products_price'];

       $fabrikant = $product_info['manufacturer'];

       echo $fabrikant;

               switch ($blah):

                   case ($blah > 3000):

                       $cc_factor = 0.0209;

                       break;

                   case ($blah > 1500):

                       $cc_factor = 0.0224;

                       break;

                   case ($blah > 500):

                       $cc_factor = 0.0259;

                       break;

                   case ($blah > 200):

                       $cc_factor = 0.0517;

                       break;

                   default:

                       // Comfort Card niet mogelijk bij dit produkt alleen. Misschien als het totaalbedrag hoger > 200

                       $cc_factor = 1;

               endswitch;

             $blah2 = $blah * $cc_factor;

             

       $comfortcard_price= number_format($blah2,2);



// End comfortcard Addon

   if ($new_price = tep_get_products_special_price($product_info['products_id'])) {

     $products_price = '<s>' . $currencies->display_price($product_info['products_price'], tep_get_tax_rate($product_info['products_tax_class_id'])) . '</s> <span class="productSpecialPrice">' . $currencies->display_price($new_price, tep_get_tax_rate($product_info['products_tax_class_id'])) . '</span>';

   } else {

     $products_price = $currencies->display_price($product_info['products_price'], tep_get_tax_rate($product_info['products_tax_class_id']));

   }

?>







     <tr>

       <td><table border="0" width="100%" cellspacing="0" cellpadding="0">

         <tr height="30">

           <td valign="bottom" background="pageheader.gif2" background="" class="pageHeading"><?php echo $product_info['products_name']; ?></td>

         </tr>

         <tr >

           <td height="28" align="right" valign="bottom" ><img src="product_info_top.gif"></td>

         </tr></table><table border="0" width="100%" cellspacing="0" cellpadding="2">

                   <tr height="15">

           <td width="50%" align="right" valign="bottom" background="">

           <center>

         <script language="javascript"><!--

document.write('<?php echo '<a href="javascript:popupWindow('' . tep_href_link(FILENAME_POPUP_IMAGE, 'pID=' . $product_info['products_id']) . '')">' . tep_image(DIR_WS_IMAGES . $product_info['products_image'], addslashes($product_info['products_name']), SMALL_IMAGE_WIDTH, SMALL_IMAGE_HEIGHT, 'hspace="5" vspace="5"') . '<br>' . TEXT_CLICK_TO_ENLARGE . '</a>'; ?>');

//--></script>

<noscript>

<?php echo '<a href="' . tep_href_link(DIR_WS_IMAGES . $product_info['products_image']) . '">' . tep_image(DIR_WS_IMAGES . $product_info['products_image'], $product_info['products_name'], SMALL_IMAGE_WIDTH, SMALL_IMAGE_HEIGHT, 'hspace="5" vspace="5"') . '<br>' . TEXT_CLICK_TO_ENLARGE . '</a>'; ?>

</noscript>

       </center>

           </td>

           <td class="product_witgrijs" align="left" valign="bottom" >



          <table width="100%" border="0" cellpadding="0" cellspacing="0">

         <tr>

         <td class="maininfo"><b>

         <a href="javascript:void(0);" onmouseover="return overlib('We zullen zo spoedig mogelijk verzenden. Als het artikel op voorraad is gewoonlijk binnen 0 tot 4 dagen.');" onmouseout="return nd();">Verzending:</a>

         </b></td>

         <td class="maininfo" align="right" bgcolor="#ffffff"><font size="1">0-4 dagen</font> </td>

         </tr>

         <tr>

         <td class="maininfo"><b>Categorie:</b></td>

         <td class="maininfo" align="right" bgcolor="#ffffff"><font size="1">

         <?php echo tep_get_categories_name($cPath); ?>

         </font> </td>

        </tr>

         <tr>

         <td class="maininfo"><b>Fabrikant:</b></td>

         <td class="maininfo" align="right" bgcolor="#ffffff"><font size="1">

       <?

       echo $product_info_values['manufacturers_name'];

         ?>

         </font></td>

        </tr>

         <tr>

         <td class="maininfo"><b>Art. Nr.:</b><br><br><br><br></td>

         <td class="maininfo" align="right" bgcolor="#ffffff"><font size="1"><? echo $HTTP_GET_VARS['products_id'];?></font><br><br><br><br></td>

         </tr>





         </table>



           </td>

         </tr>

        <tr>

         <td></td>

         <td class="product_grijsgrijs1">



         <table width="100%" border="0" cellpadding="0" cellspacing="0">

         <tr>

         <td bgcolor="#EFEFEF"><font size="2">Prijs:</font></td>

         <td align="right" bgcolor="#EFEFEF"><font face="arial" size="4"><b><?php echo $products_price; ?></b></font> </td>

         </tr></table>





         </td>

        </tr>

        <tr>

         <td></td>

         <td class="product_grijsgrijs2"><center><?php echo tep_draw_hidden_field('products_id', $product_info['products_id']) . tep_image_submit('bestel.gif', IMAGE_BUTTON_IN_CART); ?></center><br></td>

        </tr>

<?php

              if ($cc_factor < 1) {

               include ("comfortgeel.php");

              }

?>

          <?php

   if (PRODUCT_LIST_MANUFACTURER > 0) {

     echo '          <tr>' . "n" .

         '            <td></td><td colspan="2" class="pageHeading">' . $product_info['manufacturers_name'] . '</td>' . "n" .

          '          </tr>' . "n";

   }

?>

<?php

   if (PRODUCT_LIST_MODEL > 0) {

     echo '          <tr>' . "n" .

          '            <td colspan="2" class="pageHeading">' . $product_info['products_model'] . '</td>' . "n" .

          '          </tr>' . "n";

   }

?>

       </table></td>

     </tr>

     <tr>

       <td height=1 background="dots.gif2"></td>

     </tr>

     <tr>

       <td class="marco"><table border="0" cellspacing="0" cellpadding="0" align="right">

<?php

   if (tep_not_null($product_info['products_image'])) {

?>

         <tr>

           <td height="28" align="left" valign="bottom">

           </td>

         </tr>

<?php

   }

?>

       </table><table width="100%" cellpadding="0" cellspacing="0" border="0">

       <tr><td><img src="meerfotos.jpg"></td></tr>

       <tr><td><?php include(DIR_WS_MODULES . FILENAME_DYNAMIC_MOPICS); ?></td></tr>

       <tr><td><img src="opties.gif"></td></tr>

       <tr><td class="smallText">

       <?php

   $products_attributes_query = tep_db_query("select count(*) as total from " . TABLE_PRODUCTS_OPTIONS . " popt, " . TABLE_PRODUCTS_ATTRIBUTES . " patrib where patrib.products_id='" . (int)$HTTP_GET_VARS['products_id'] . "' and patrib.options_id = popt.products_options_id and popt.language_id = '" . $languages_id . "'");

   $products_attributes = tep_db_fetch_array($products_attributes_query);

   if ($products_attributes['total'] > 0) {

     echo '<table border="0" cellpadding="0" cellspacing"0">';

     $products_options_name_query = tep_db_query("select distinct popt.products_options_id, popt.products_options_name from " . TABLE_PRODUCTS_OPTIONS . " popt, " . TABLE_PRODUCTS_ATTRIBUTES . " patrib where patrib.products_id='" . (int)$HTTP_GET_VARS['products_id'] . "' and patrib.options_id = popt.products_options_id and popt.language_id = '" . $languages_id . "'");

     while ($products_options_name = tep_db_fetch_array($products_options_name_query)) {

       $selected = 0;

       $products_options_array = array();

       echo '<tr><td class="main">' . $products_options_name['products_options_name'] . ':</td><td>' . "n";

       $products_options_query = tep_db_query("select pov.products_options_values_id, pov.products_options_values_name, pa.options_values_price, pa.price_prefix from " . TABLE_PRODUCTS_ATTRIBUTES . " pa, " . TABLE_PRODUCTS_OPTIONS_VALUES . " pov where pa.products_id = '" . (int)$HTTP_GET_VARS['products_id'] . "' and pa.options_id = '" . $products_options_name['products_options_id'] . "' and pa.options_values_id = pov.products_options_values_id and pov.language_id = '" . $languages_id . "'");

       while ($products_options = tep_db_fetch_array($products_options_query)) {

         $products_options_array[] = array('id' => $products_options['products_options_values_id'], 'text' => $products_options['products_options_values_name']);

         if ($products_options['options_values_price'] != '0') {

           $products_options_array[sizeof($products_options_array)-1]['text'] .= ' (' . $products_options['price_prefix'] . $currencies->display_price($products_options['options_values_price'], tep_get_tax_rate($product_info['products_tax_class_id'])) .') ';

         }

       }

       echo tep_draw_pull_down_menu('id[' . $products_options_name['products_options_id'] . ']', $products_options_array, $cart->contents[$HTTP_GET_VARS['products_id']]['attributes'][$products_options_name['products_options_id']]);

       echo '</td></tr>';

     }

     echo '</table><br>';

   } else {

   echo "Geen.";

           }

?>

               </tr></td>



       <tr><td><img src="product_info_midden.gif"></td></tr>

       <tr><td class="maininfo" height="28" align="left" valign="bottom">



<p><?php echo stripslashes($product_info['products_description']); ?></p>

           </td>

         </tr>

       </table>

       </td>

     </tr>



<?php

   $reviews = tep_db_query("select count(*) as count from " . TABLE_REVIEWS . " where products_id = '" . $HTTP_GET_VARS['products_id'] . "'");

   $reviews_values = tep_db_fetch_array($reviews);

   if ($reviews_values['count'] > 0) {

?>

     <tr>

       <td class="main"><br><?php echo TEXT_CURRENT_REVIEWS . ' ' . $reviews_values['count']; ?></td>

     </tr>

<?php

   }



   if (tep_not_null($product_info['products_url'])) {

?>

     <tr>

       <td class="main"></td>

     </tr>

<?php

   }



   if ($product_info['products_date_available'] > date('Y-m-d H:i:s')) {

?>

     <tr>

       <td align="center" class="smallText"><br><?php echo sprintf(TEXT_DATE_AVAILABLE, tep_date_long($product_info['products_date_available'])); ?></td>

     </tr>

<?php

   } else {

?>

     <tr>

     </tr>

<?php

   }

?>

     <tr>

       <td><table border="0" width="100%" cellspacing="0" cellpadding="0">

         <tr>

           <td align="right" class="main"></td>

         </tr>

       </table></td>

     </tr>

     <tr>

       <td><br>

<?php

   if ( (USE_CACHE == 'true') && !defined('SID')) {

     echo tep_cache_also_purchased(3600);

   } else {

     include(DIR_WS_MODULES . FILENAME_ALSO_PURCHASED_PRODUCTS);

   }

 }

?>

       </td>

     </tr>

   </table></form></td>

<!-- body_text_eof //-->

   <td width="<?php echo BOX_WIDTH; ?>" valign="top"><table border="0" width="<?php echo BOX_WIDTH; ?>" cellspacing="0" cellpadding="2">

<!-- right_navigation //-->

<?php require(DIR_WS_INCLUDES . 'column_right.php'); ?>

<!-- right_navigation_eof //-->

   </table></td>

 </tr>

</table>

<!-- body_eof //-->



<!-- footer //-->

<?php require(DIR_WS_INCLUDES . 'footer.php'); ?>

<!-- footer_eof //-->

<br>

</body>

</html>

<?php require(DIR_WS_INCLUDES . 'application_bottom.php'); ?>

i also added a check for a specific lease supplier here in holland called Comfort Card. You can delete those parts.

Good luck

jaysin · May 20, 2003

Thanks for quick responce :P

dabri · May 20, 2003

Hi Zlack,

can you tell me, how managed, that the menu displayed vertical?

I just get it horizontal.

Or can you post / send me the menu_tpl.js file?

Thank you very much

Daniel

zlack · May 20, 2003

Hi Zlack,

can you tell me, how managed, that the menu displayed vertical?

I just get it horizontal.

Or can you post / send me the menu_tpl.js file?

Thank you very much

Daniel

Oops :oops:

I pasted the wrong link :( Well after trying so much contributions i just loose sight :D

Here's the correct one:

http://www.oscommerce.com/community/contributions,956

Should work with this one

Best regards, zlack

Please give me your worst

Recommended Posts

zlack

zlack

emiliano

zlack

zlack

HyperJack

zlack

phelan

zlack

surfking

zlack

zlack

Guest

dabri

drakonan

zlack

zlack

zlack

HyperJack

jaysin

zlack

zlack

jaysin

dabri

zlack

Archived

Browse

Activity