Modules Control

[LeeFoster 219]

Got another good one;

Just created a new box (copy of the information box) and a new page (copy of privacy page). If I hide all boxes for a page except my new one, as I may be doing for the new page, no boxes show on the site at all.

This is my boxes config

Uninstalled my box to see if that was the problem

Also tested a combination of different boxes being on and off 

It appears that if all boxes are off over a combination of pages then they are off for the entire site.

[♥raiwa 1,472]

Yep, I could reproduce some glitch like this. I'll have a deeper look when I find some time.

[LeeFoster 219]

8 minutes ago, raiwa said:

Yep, I could reproduce some glitch like this. I'll have a deeper look when I find some time.

I thought it was my changes at first but as I was testing to write the message I realised it wasn't. Happy to test when you find a fix.

[LeeFoster 219]

To add more confusion to this if you have 2 pages that between them hide all boxes but a 3rd page that hides non they show on the 3rd page.

[LeeFoster 219]

Removing this bit of code from osc_template.php fixes the issue but wanted to check it wasn't doing anything vital before making it a permanent fix.

// check if side columns are empty
      if (in_array(basename($PHP_SELF), $modules_exclude_array[$class])) {
        $this->_hide_column = count(array_intersect(array_keys($modules_exclude_array), str_replace('.php', '', explode(';', MODULE_BOXES_INSTALLED)))) == count(explode(';', MODULE_BOXES_INSTALLED));
      }

 

[♥raiwa 1,472]

On 10/17/2019 at 12:59 PM, LeeFoster said:

Removing this bit of code from osc_template.php fixes the issue but wanted to check it wasn't doing anything vital before making it a permanent fix.

// check if side columns are empty
      if (in_array(basename($PHP_SELF), $modules_exclude_array[$class])) {
        $this->_hide_column = count(array_intersect(array_keys($modules_exclude_array), str_replace('.php', '', explode(';', MODULE_BOXES_INSTALLED)))) == count(explode(';', MODULE_BOXES_INSTALLED));
      }

 

Hello Lee @LeeFoster,

I had a look and yes, all the side column control is not needed any more. Seems this is due to the BS4 column/layout dynamic behaviour.

I cleaned up the whole osc_template-php class file and it seems to work fine.

Please try and let me know. I'll then update also the admin page and upload the update with the fixes.

osc_template.php

[LeeFoster 219]

4 minutes ago, raiwa said:

Hello Lee @LeeFoster,

I had a look and yes, all the side column control is not needed any more. Seems this is due to the BS4 column/layout dynamic behaviour.

I cleaned up the whole osc_template-php class file and it seems to work fine.

Please try and let me know. I'll then update also the admin page and upload the update with the fixes.

osc_template.php

Just tested and seems to work.

[♥raiwa 1,472]

Uploade version 1.3.0 Phoenix with the above fix:

Modules Control Version 1.3.0.

[LeeFoster 219]

On 10/20/2019 at 3:50 PM, raiwa said:

Uploade version 1.3.0 Phoenix with the above fix:

Modules Control Version 1.3.0.

Doesn't appear to work on Phoenix 1.0.6.0

[♥raiwa 1,472]

26 minutes ago, LeeFoster said:

Doesn't appear to work on Phoenix 1.0.6.0

Not updated yet. It's on my list, but not on the top.

[LeeFoster 219]

6 minutes ago, raiwa said:

Not updated yet. It's on my list, but not on the top.

Any thing I can do to help?

[LeeFoster 219]

@raiwa I just realised, the osc_template.php class file was removed. I suspect that's the cause of the issue.

[♥raiwa 1,472]

28 minutes ago, LeeFoster said:

Any thing I can do to help?

Thanks. You could do the beta testing.

[LeeFoster 219]

Just now, raiwa said:

Thanks. You could do the beta testing.

Happy to.

[LeeFoster 219]

@raiwa I found that some things still use the osc_template.php file however it is now located in includes/system/versioned/1.0.4.0/

I made your original changes in this file and it now works. Not the long term solution I'm sure but it will do me for now.

[LeeFoster 219]

@raiwa One issue that might be there is that I have to tick the ones I want to hide not the ones I want to show on a page. I can't remember if this has always been this way, can you confirm?

[♥raiwa 1,472]

It was always like this.

[LeeFoster 219]

2 minutes ago, raiwa said:

It was always like this.

Thanks, I thought that might be the case.