burt Posted October 6, 2017 Share Posted October 6, 2017 51 minutes ago, raiwa said: @burt, 2 things I found could be improved: 1. modularization as always. In that project we missed it for product_info.php, product_reviews.php, product_reviews_write.php and reviews.php 2. hooks support could be improved and included a sistematic pattern The hooks system definitely needs to be looked at, without a doubt. It's on the list. The list is short as the old list was nuked. I'd like for the hook system to be radically overhauled; sort, pass parameters [eg for use passing the products_id at the product_listing module], have 1 hook call invoke multiple hooks (and so on) For the modularisation...that's something that needs to be introduced to other pages. product_info has modular (for the extras). It also has historical code as I did not have the time to rebuild all that into modules. the other pages don't (so far as I recall). We probably just need a getContent call on each page (like was done for product_info) and then hope over time that modules get made to replace the historical code. Quote Link to comment Share on other sites More sharing options...
Join the conversation
You can post now and register later. If you have an account, sign in now to post with your account.