2.3.4 BS GOLD form in product_info.php

[azpro]

@@burt and other!

 

We still have this issue on Github : https://github.com/gburton/Responsive-osCommerce/issues/89

 

I have a modularized product_info.php and are now seeing the issue for an extra form I need. Off course it is simple to move the main form into my cart button module :

 

tep_draw_form('cart_quantity', tep_href_link(FILENAME_PRODUCT_INFO, tep_get_all_get_params(array('action')). 'action=add_product', $request_type), 'post', 'class="form-horizontal" role="form"');

 

The question I have - reading the comments / discussion - is there dependency between the form and the micro-data? In other words - could there be a problem if I shorten the form wher it only contains the main add-to-cart Button?

 

Thanks!

 

Arjan

[burt]

The question I have - reading the comments / discussion - is there dependency between the form and the micro-data? In other words - could there be a problem if I shorten the form wher it only contains the main add-to-cart Button?

 

No link between form and microdata...

The form only needs to around the attributes and the button.

[burt]

This:

https://github.com/gburton/Responsive-osCommerce/blob/master/product_info.php#L69

 

Move To:

https://github.com/gburton/Responsive-osCommerce/blob/master/product_info.php#L140

 

This:

https://github.com/gburton/Responsive-osCommerce/blob/master/product_info.php#L230

 

Move To:

https://github.com/gburton/Responsive-osCommerce/blob/master/product_info.php#L205

 

That would reduce the form size to encompass the needed items (attribs and buy button).

Addon makers would then have a bit more flexibility.

 

The problem comes (in the future) when we modularise the page...

Somehow we need to work out a foolproof way of modularisation that allows the form to be moved around appropriately.

[azpro]

Thanks!

 

I Think if each module would use it's own form with proper closing tag </form> that would be sufficient. I see more problems with the shopping cart additional actions in application_top.php.

 

Maybe move these actions to the new hook system.

 

Regards!