Jump to content
  • Checkout
  • Login
  • Get in touch

osCommerce

The e-commerce.

javascript issues after upgrade


rmanbike

Recommended Posts

Posted

After upgrading 2.2 to 2.3 I have noticed some issues with our site (www.icustomsofa.com) that uses javascript to select items to add to shopping cart.

 

I am seeing this issue only on iPad after enabling javascript. Not tested on Android,  In 2.2 javascript was very stable, but after upgrading to 2.3 javascript had been unstable, meaning that once a item is selected it only holds a second and then released back to default. Thus your unable to add the product to the shopping cart. 

 

I thought that 2.3 would have been more mobile friendly! 

 

This is some of how javascript is incorporated into the shopping cart, if this will help any:

 

 loadPopup(url+'&status='+status+'&id='+id+'&size='+size+'&location='+location+'&where='+where+'&this_page='+this_page)}

function swapFabric_Special(ajax_path,location_id,fabric_path,fabric_alt,fabric_id,size,location,where,this_page){
var content='<a href="javascript:select_fabrics('+"'"+ajax_path+'?ajax_path='+ajax_path+'&location_id='+location_id+"'"+",'"+size+"','"+location+"','"+where+"','"+this_page+"'"+')">'+'<img border="0" src="'+fabric_path+'" width="146" height="33" alt="'+fabric_alt+'" />'+"</a>"
$("#"+location_id).html(content)
$("#"+location_id+"_").val(fabric_id)
nd()
disablePopup()}
Posted

First, I like the idea of your site.  Popups are not too popular these days.  This may be from an Apple update as I saw some javascript problems a year or two ago after an update.  The other thing is the jquery version change may afftect this.  Google loadPopup and you'll see a bunch of posts on the jquery site about loadPopup as well as some other sites.  You have what looks like custom code there that may need updating.  Are you still in contact with the person that did it? 

 

Aslo, your pages use different versions of jquery depending on the page your on and it's not all 2.3.  If you want more mobile friendly think 2.3.4 BS version.

I'm not really a dog.

Posted

Thanks John, I have a developer working on the site now and he says he is almost completed the upgrade to 2.3.4 BS version. With what you have just told me, sounds like this guy may not know what he is doing. I can see that admin is 2.3 but I haven't looked at the coding on each and every page. Not sure how I would know if its 2.3 or the 2.3.4 BS?? 

Posted

This is what I can find for version:

 

// Define the project version

//  define('PROJECT_VERSION', 'osCommerce Online Merchant v2.2 RC2a');
 
// Define the project version --- obsolete, now retrieved with tep_get_version()
  define('PROJECT_VERSION', 'osCommerce Online Merchant v2.3');
Posted

It's not quite just that simple.  I was view source on your pages which shows the htlml, javascript, css and they are not consistent.  I'm not a developer and I'm not looking to make money off of you, but you might think about working with one of the active developers here that will be very familiar with 2.3.4 BS.  Maybe just get a consult like a second opinion. 

 

One thing to be aware of though is that your Ipad problem could easily be an Ipad update that would have happened with your old code.

 

However, one day I might order a sofa from you.

I'm not really a dog.

Posted

John, I very much appreciate this input, as I was leaving this up to the developer, but now that you saw this I spent some time looking at the source code and could see what your talking about. Now I'm thinking to ask one of the sponsored developers here for some consulting advice.

 

And many thanks for the interest too! Just about 75% of our customers is repeat business.  

Archived

This topic is now archived and is closed to further replies.

×
×
  • Create New...