PayPal App v4.039 - PayPal Standard bug

[lee the bean]

ocCommerce v2.3.4 - PayPal App v4.039

 

Only one Payment module enabled - PayPal Payments Standard

 

catalog/checkout_process.php & catalog/includes/modules/payment/paypal_standard.php modified to include store logo in email:

// lets start with the email confirmation
      $email_order = tep_image(HTTPS_SERVER . DIR_WS_HTTP_CATALOG . DIR_WS_IMAGES . 'store_logo.png', STORE_NAME, 441, 44) . "\n\n" .
                     STORE_NAME . "\n" .
                     EMAIL_SEPARATOR . "\n" .                   etc. This simple modification has been installed many years.

PayPal App v4.039 has been installed, tested and live for a few months now without errors - it works a treat.

 

However with two recent orders the extra order emails were missing the store logo image. No other indication that a problem may exist and no recent changes to coding.

 

Decided to investigate and found the following in the server log on the last affected order:

 

mysite.com 69.xxx.xxx.74 - - [31/Oct/2015:21:24:15 +0000] "GET /shop/shopping_cart.php?osCsid=58q8tesu4d33srpelbefbmpj22 HTTP/1.1" 200 44211 "https://www.mysite.com/shop/product_info.php?products_id=1164&osCsid=58q8tesu4d33srpelbefbmpj22" "Mozilla/5.0 (Windows NT 10.0; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/46.0.2490.80 Safari/537.36"

mysite.com 69.xxx.xxx.74 - - [31/Oct/2015:21:26:22 +0000] "POST /shop/checkout_shipping.php?osCsid=58q8tesu4d33srpelbefbmpj22 HTTP/1.1" 302 - "https://www.mysite.com/shop/checkout_shipping.php?osCsid=58q8tesu4d33srpelbefbmpj22" "Mozilla/5.0 (Windows NT 10.0; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/46.0.2490.80 Safari/537.36"

mysite.com 69.xxx.xxx.74 - - [31/Oct/2015:21:26:23 +0000] "GET /shop/checkout_payment.php?osCsid=58q8tesu4d33srpelbefbmpj22 HTTP/1.1" 200 31545 "https://www.mysite.com/shop/checkout_shipping.php?osCsid=58q8tesu4d33srpelbefbmpj22" "Mozilla/5.0 (Windows NT 10.0; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/46.0.2490.80 Safari/537.36"

mysite.com 69.xxx.xxx.74 - - [31/Oct/2015:21:35:15 +0000] "GET /shop/checkout_confirmation.php?osCsid=58q8tesu4d33srpelbefbmpj22 HTTP/1.1" 302 - "-" "Mozilla/5.0 (Windows NT 10.0; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/46.0.2490.80 Safari/537.36"

 

mysite.com 69.xxx.xxx.74 - - [31/Oct/2015:21:35:21 +0000] "GET /shop/checkout_payment.php?error_message=Please+select+a+payment+method+for+your+order.&osCsid=58q8tesu4d33srpelbefbmpj22 HTTP/1.1" 200 31748 "-" "Mozilla/5.0 (Windows NT 10.0; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/46.0.2490.80 Safari/537.36"

mysite.com 69.xxx.xxx.74 - - [31/Oct/2015:21:36:10 +0000] "POST /shop/checkout_confirmation.php?osCsid=58q8tesu4d33srpelbefbmpj22 HTTP/1.1" 200 36588 "https://www.mysite.com/shop/checkout_payment.php?error_message=Please+select+a+payment+method+for+your+order.&osCsid=58q8tesu4d33srpelbefbmpj22" "Mozilla/5.0 (Windows NT 10.0; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/46.0.2490.80 Safari/537.36"

 

mysite.com 69.xxx.xxx.74 - - [31/Oct/2015:21:55:36 +0000] "GET /shop/checkout_process.php?osCsid=58q8tesu4d33srpelbefbmpj22&tx=08312084CR8405507&st=Completed&amt=91%2e55&cc=GBP&cm=1532&item_number= HTTP/1.1" 302 - "https://www.paypal.com/ca/cgi-bin/webscr?cmd=_flow&SESSION=TPPMEy2coLjMqGNnXfR4v46q3KVibDFC_k85uCXZmLkfzr3woX6SlZchQYm&dispatch=50a222a57771920b6a3d7b606239e4d529b525e0b7e69bf0224adecfb0124e9b61f737ba21b081984719xxxxxxxxxxxxxxxxx" "Mozilla/5.0 (Windows NT 10.0; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/46.0.2490.80 Safari/537.36"

mysite.com 69.xxx.xxx.74 - - [31/Oct/2015:21:55:38 +0000] "GET /shop/checkout_success.php?osCsid=58q8tesu4d33srpelbefbmpj22 HTTP/1.1" 200 36584 "https://www.paypal.com/ca/cgi-bin/webscr?cmd=_flow&SESSION=TPPMEy2coLjMqGNnXfR4v46q3KVibDFC_k85uCXZmLkfzr3woX6SlZchQYm&dispatch=50a222a57771920b6a3d7b606239e4d529b525e0b7e69bf0224adecfb0124e9b61f737ba21b08198471xxxxxxxxxxxxxxxxx" "Mozilla/5.0 (Windows NT 10.0; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/46.0.2490.80 Safari/537.36"

 

As there is only one payment option - it is not selectable but the selected default, so it is not possible to not have the payment method not selected as per the error message appended to the checkout_payment.php url.

Also - it is not possible to create the email without the image. So in this case the email is not being created from the two possible scripts paypal_standard.php (it should be this) or checkout_process.php (it would only be this if cash option was enabled). Hmmm. What the heck is going on.

 

I cant reproduce the error message having extensively tested again.

 

Thought I should report this to see if anyone else has seen this problem.

 

[lee the bean]

I found the answer to the missing order email image - the order email is now also created in the file

 

catalog/ext/modules/payment/paypal/standard_ipn.php - added code as above and the next order included the image as expected.

 

However some emails are also created via catalog/includes/modules/payment/paypal_standard.php, so it would be nice to know in what circumstances the emails are generated from which of the two files, as both have for my site - which is setup only to use PayPal Standard checkout. The only possible explanation I can deduce is that a payment via a tablet/mobile device via a PayPal installed app uses different code to a PC device.

 

Also could it explain why a trace of a payment had this during a checkout

/shop/checkout_payment.php?error_message=Please+select+a+payment+method+for+your+order.&osCsid=58q8tesu4d33srpelbefbmpj22