Why are my redirect fields showing as blank in OSC 2.3.4?

[fleeced]

I run a modified OSC store where the category links redirect to the products URL. It has worked well in OSC 2.2 but struggling to get it working in OSC 2.3.4.

 

Any ideas why the url links when hovered over show as blank as opposed to the external product id? The file we edited is modules/product_listing.php

 

$prod_list_contents .= '    <a href="' . tep_href_link(FILENAME_PRODUCT_INFO, 'manufacturers_id=' . $HTTP_GET_VARS['manufacturers_id'] . '&products_id=' . $listing['products_id']) . '">' . tep_image(DIR_WS_IMAGES . $listing['products_image'], $listing['products_name'], SMALL_IMAGE_WIDTH, SMALL_IMAGE_HEIGHT, NULL, NULL, 'img-responsive thumbnail group list-group-image') . '</a>';

    } else {

      $prod_list_contents .= '    <a href="' . tep_href_link(FILENAME_REDIRECT,

'action=url&goto=' . urlencode($listing['products_url'])) . '">' . tep_image(DIR_WS_IMAGES . $listing['products_image'], $listing['products_name'], SMALL_IMAGE_WIDTH, SMALL_IMAGE_HEIGHT, NULL, NULL, 'img-responsive thumbnail group list-group-image') . '</a>';

    }

    $prod_list_contents .= '    <div class="caption">';

    $prod_list_contents .= '      <h2 class="group inner list-group-item-heading">';

    if (isset($HTTP_GET_VARS['manufacturers_id']) && tep_not_null($HTTP_GET_VARS['manufacturers_id'])) {

      $prod_list_contents .= '    <a href="' . tep_href_link(FILENAME_PRODUCT_INFO, 'manufacturers_id=' . $HTTP_GET_VARS['manufacturers_id'] . '&products_id=' . $listing['products_id']) . '">' . $listing['products_name'] . '</a>';

    } else {

      $prod_list_contents .= '    <a href="' . tep_href_link(FILENAME_REDIRECT,

'action=url&goto=' . urlencode($listing['products_url'])) . '">' . $listing['products_name'] . '</a>';

    }

    $prod_list_contents .= '      </h2>';

 

 

 

 

[fleeced]

Bumpety Bump Bump Bump...

 

This is a very old listing I found, tried the code but still doesn't work

http://www.oscommerce.com/forums/topic/62990-display-a-link-with-products-url-in-products-list/#entry246075

[fleeced]

Fixed, done in the RCMDesign section of the following index.php file along with product_listing as above

http://www.oscommerce.com/forums/topic/104707-change-buy-now-to-url-link/page-2