Free Shipping applied wrongly

[vritzka]

Hello,

 

firstly, thank you so much for this bootstrap version.

 

I have just completed re-building a store with it (PM for url) and it worked fantastic.

 

Glad I have it responsive now.

 

I found a bug and I'd like to post it here

 

 

Currently, customers can get free shipping for carts smaller than allowed. 

 

 

Lets say you allow free shipping from 50 EUR.  (in Admin -> Moduls -> order total -> shipping -> allow free shipping)

 

 

Your shipping cost for carts less than 50 EUR is 6 EUR

 

Now a customer has a cart worth 45 EUR.

 

 

The first time he goes to checkout_confirmation.php, he is shown shipping costs of 6 EUR, correct.

 

But now he/she decides to go back to the shopping cart and then starts checkout again.

 

 

Now he is show free shipping.

 

 

Here is why:

 

checkout_shipping.php around LINE 96

 

    if ( ($pass == true) && ($order->info['total'] >= MODULE_ORDER_TOTAL_SHIPPING_FREE_SHIPPING_OVER) ) {

      $free_shipping = true;

 

 

should be changed to 

 

   if ( ($pass == true) && (($order->info['total'] - $order->info['shipping_cost']) >= MODULE_ORDER_TOTAL_SHIPPING_FREE_SHIPPING_OVER) ) {

      $free_shipping = true;

 

 

 

Because after choosing a shipping method during first time checkout, $order->info['total'] is being updated. The shipping cost is added.

 

Now $order->info['total'] equals 51 EUR. And with the current code, that will cause free shipping and the customer pays only 45 EUR.

 

 

 

This fix has additionally been done already in the shipping module, as we can see here: https://github.com/gburton/Responsive-osCommerce/blob/master/includes/modules/order_total/ot_shipping.php#L41

 

 

But it also needs to be done here:  https://github.com/gburton/Responsive-osCommerce/blob/master/checkout_shipping.php#L94

 

 

Thanks

[vritzka]

also for checkout with paypal, here: https://github.com/gburton/Responsive-osCommerce/blob/master/ext/modules/payment/paypal/express.php#L177

[Mikepo]

@@vritzka, thanks for the free shipping update.  I checked my 2.3.4BS live shop and yes free shipping occured incorrectly if customers go back to their shopping basket. Fixed worked.  Thanks again

Mike

[burt]

@@vritzka thanks.

 

Bugs in oscommerce : http://www.oscommerce.com/forums/tracker/project-1-oscommerce-online-merchant-v2x/