Jump to content
  • Checkout
  • Login
  • Get in touch

osCommerce

The e-commerce.

Bestsellers Module - tap targets too close


Recommended Posts

The stock version of bootstrap gives a 100/100 score in webmaster tools (pagespeed insights). When the Bestsellers module is activated or populated the score reduces to 97/100, reason given is tap targets are too close. By inserting a <br /> in  /includes/modules/boxes/bm_best_sellers.php the score returns to 100/100.

Link to comment
Share on other sites

@@Hotclutch

 

The stock version of bootstrap gives a 100/100 score in webmaster tools (pagespeed insights). When the Bestsellers module is activated or populated the score reduces to 97/100, reason given is tap targets are too close. By inserting a <br /> in  /includes/modules/boxes/bm_best_sellers.php the score returns to 100/100.

 

While I can guess, can you tell us -where- you inserted the <br /> ?

 

Malcolm

Link to comment
Share on other sites

Find

 

$bestsellers_list .= '<li><a href="' . tep_href_link(FILENAME_PRODUCT_INFO, 'products_id=' . $best_sellers['products_id']) . '">' . $best_sellers['products_name'] . '</a></li>';

 

replace with

 

$bestsellers_list .= '<li><a href="' . tep_href_link(FILENAME_PRODUCT_INFO, 'products_id=' . $best_sellers['products_id']) . '">' . $best_sellers['products_name'] . '</a></li><br />';

Link to comment
Share on other sites

@@Hotclutch @@ArtcoInc

 

Change the bestsellers list to a nav list (eg: http://getbootstrap.com/components/#nav-pills) or a list group (eg: http://getbootstrap.com/components/#list-group

 

Or use .css to space the <li> apart (maybe line-height - not tried it, but sounds about right). 

 

We want to try to keep code as clean and semantically correct as possible, adding br in between each li, makes me feel dirty.

Link to comment
Share on other sites

Archived

This topic is now archived and is closed to further replies.

×
×
  • Create New...