modding up a 2.3.4BS Gold

[greasemonkey]

Hi All, I thought I would start up a new thread a la @@Mort-lemur.

 

I've recently started modding up a new 2.3.4BS Gold install to replace my current 2.3.4 - with iOSC installed. I have a TON of addons in this store... and it has a "few quirks".

 

I have no particular timeline on this project (I was hoping for mid 2015) and will be working on this only in my spare time. I do have some goals... some of which will be hard to achieve.

 

My plan is to post here as I go along (as was done with the previous modding up 2.3.3.4 thread).

 

Some of my goals;

 

1) leave core code as un-touched as possible... completely un-touched will be impossible for me as SPPC is an important part of our business

2) design myself - previously use a purchased template (yes.... OMG a template) - and yes, I've learned my lesson...

 

Here is where I'm at in the past week working on the store. I purchased the 28daysofcoding bundle from @@burt.... this is going to be a great help.

 

 I've so far installed;

SEO Header Tags - Reloaded (I installed this first.... drop on top). I've previously used Header Tags SEO... so need to be careful when I get to the database update/merge.

Bootstrap Carousel - no core changes

Bootstrap Featured Products - 1 line to index

Bootstrap Buttons Content mod - no core changes

Created a new catalog/manufacturers.php page - no core changes

Added Categories dropdown to the navbar from this thread - 1 addition to output_html & 1 line to application_top

 

I'm LOVING the user.css.... I'm using firebug to inspect each element and change colors etc... then adding the changes to user.css...

 

Issues;

 

1) I'm going to install a URL re-writer - sorry for the core code changes @@burt.... but I believe human readable URL's are critical

2) I need to figure out when I'm going to install SPPC - right now I'm thinking to leave this to last. There are too many core changes - but it has to be done. Love to here others thoughts on this.

 

 

 

 

 

 

[burt]

SEO Header Tags - Reloaded (I installed this first.... drop on top). I've previously used Header Tags SEO... so need to be careful when I get to the database update/merge.

 

 

I have a conversion script almost ready ..

 

I'm going to try to find time this week to get reloaded directly into the core.

 

 

1) I'm going to install a URL re-writer - sorry for the core code changes @burt.... but I believe human readable URL's are critical

 

There's nothing wrong with core code changes.  Problems only arise when shopowners (and those who have shopowning clients) find an addon and install it, with no real understanding of the changes they just made.  For any shopowner with a bit of a technical knowledge I have no problem in saying "have at it" and change the core.

[greasemonkey]

here is summary of some of my work yesterday (while watching the Oscars). It was almost all in the configuration and user.css... The site is starting to look really nice.

 

- moved all box modules to the left column

- changed the column width by adjusting the bootstrap setup - content to "6".

 

Total time - 10 mins (actually only 3 seconds... if you knew what you were doing...lol). But these 2 super quick easy change and now it doesn't look like an OsC install....

 

Then went on to;

 

Added padding around the logo with

/*BOF padding for logo*/
.col-sm-6{
  padding-top: 10px;
  padding-bottom: 10px
  }
/*EOF padding for logo*/

Changed all button colors to match the look and feel I'm going for

/*BOF button colors*/
  .btn-success{
  background-color: #844224;
  border-color: #70381f;
  }
  .btn-success.active, .btn-success.focus, .btn-success:active, .btn-success:focus, .btn-success:hover, .open > .dropdown-toggle.btn-success {
  background-color: #844224;
  border-color: #70381f;
  }
  .btn-info {
    background-color: #844224;
    border-color: #70381f;
	}
/*EOF button color*/

Changed the breadcrumb and box module heading background and font colors with

/*BOF panel colors*/
.panel-default>.panel-heading {
  color: #844224;
  background-color: #F3CBD9;
  font-size: 18px;
  font-weight: 600;
  }
/*EOF panel colors*/
/*BOF Breadcrumb panel color*/
  .breadcrumb {
  background-color: #F3CBD9;
  }
/*EOF Breadcrumb panel color*/

Changed footer background and font colors with

/*BOF footer colors*/
  .footer h2 {
  color: #fff}
  .contact {
  color: #fff}
  .generic-text {
  color: #fff}
  .information  a{
  color: #fff}
  .account  {
  color: #fff}
  .footer {
	background-color: #844224 }
  .btn-default {
  color #333}
/*EOF footer colors*/

Created "create account" button in footer to match "Existing Customer? Log In" button by editing includes/modules/content/footer/cm_footer_account.php
 from

       $account_content = '<li><a href="' . tep_href_link('create_account.php', '', 'SSL') . '">' . MODULE_CONTENT_FOOTER_ACCOUNT_BOX_CREATE_ACCOUNT . '</a></li>' .

To

        $account_content = '<li><br><a class="btn btn-default btn-sm btn-block" role="button" href="' . tep_href_link('create_account.php', '', 'SSL') . '"><i class="glyphicon glyphicon-pencil"></i>' . MODULE_CONTENT_FOOTER_ACCOUNT_BOX_CREATE_ACCOUNT . '</a></li>' .

Again... if I new what I was doing and what I was looking for this would go much more quickly... Total time... Maybe 3 hours so far.

 

Next.... Make a list of all addon's and code changes that will be required (I have a list of all modifications to my 2.3.4 store... however, I have a feeling its gonna fall short).

[greasemonkey]

Another 30 mins to an hour just on cleaning up the look and feel...

 

After doing some research (here and here) on hamburger responsive menu’s I decided to change to the word “Menu” with a strong white border

 

In includes/modules/content/header/templates/navbar.php

 

Changed

        <span class="icon-bar"></span>
        <span class="icon-bar"></span>
        <span class="icon-bar"></span>

To

     <i class="fa"></i>Menu

Also restyled making the border & font white

/*BOF menu button*/
.navbar-inverse .navbar-toggle {
    border-color: #fff;
    color: #fff}
/*EOF menu button*/

Installed manufactures logo content modules from 28daysofcoding in index (originally footer)

 

And styled, hiding the module on mobile with @@media in css and creating a padding between the carousel.

/*BOF manufacturers logos*/
   @[member=media] only screen and (max-width: 667px) {
  #manufacturers-hide { display: none; }   /* hide it elsewhere */
}
  .manufacturers_images ul { 
  padding-top: 10px;
  padding-bottom:10px;
  background-color: #F3CBD9;
  border-radius: 3px;
  margin-bottom: 0px;
  }
  .carousel {
  margin-bottom: 20px
  }
/*EOF manufacturers logo*/

Made the h1 slightly small on mobile with @@media in css

  /*BOF make h1 smaller on mobile*/
  h1,.h1{font-size:30px}
@[member=media] only screen and (max-width: 667px) {
   h1,.h1 { font-size: 24px; }
}
/*EOF make h1 smaller on mobile*/

[greasemonkey]

Started to add some gradient to the color - to give the site a little more depth.... this needs a little more work...

  background-image: -moz-linear-gradient(center top , #F3CBD9, #F4C5D5);

And added a qty box to product listing from this post .

 

Having issues adding the qty box to product listing... from the same thread (had this working just fine in pre-gold version and non BS-2.3.4).

[ArtcoInc]

@@greasemonkey Scott,

 

Do you have a public (even if not active) site up so that we can see your changes?

 

Malcolm

[greasemonkey]

@@ArtcoInc I'll PM you a link... I lock it down at night when I'm not working on it - so if you can't access go ahead and try again later.

[greasemonkey]

So today's work was adding a quantity box to product_info and fixing the issues mentioned yesterday when adding the qty box to product_listing.

 

I've used the input type 'tel' on both these boxes... 'tel' provides a 12 digit number keypad on most mobile that is much easier to use when compared to the full qwerty style number keypad provided with the 'number' input type.

 

I've also moved my add to cart button in product_info from under the description to above by separating out the $products_name and $products_price h1.... like so... This may require a "re-think" when it comes time to do SPPC....

<div class="page-header">
  <h1 itemprop="name"><?php echo $products_name; ?></h1>
</div>
<div class="page-header">
       <span class="buttonAction"><?php echo tep_draw_input_field('quantity[]', '1', 'size="3" style="vertical-align:middle', 'tel').' '. tep_draw_hidden_field('products_id', $product_info['products_id']) . tep_draw_button(IMAGE_BUTTON_IN_CART, 'glyphicon glyphicon-shopping-cart', null, 'primary', null, 'btn-success'); ?></br></span>
	   <h1 class="pull-right"><h1><div itemprop="offers" itemscope itemtype="http://schema.org/Offer"><?php echo $products_price; ?></h1>
</div>

Sorry for the "core" changes....

[greasemonkey]

Small changes today...

 

Removed the model/part number from the breadcrumb with a small edit (commented out the line) to application top

 //remove part number
     // $breadcrumb->add($model['products_model'], tep_href_link(FILENAME_PRODUCT_INFO, 'cPath=' . $cPath . '&products_id=' . $HTTP_GET_VARS['products_id']));

And also the model/part number from product_info h1 tag.... There should be a config for this (like product_listing) in my opinion.

      $products_name;//remove part number .= '<br /><small>[<span itemprop="model">' . $product_info['products_model'] . '</span>]</small>';

Added auto complete search box from 28daysofcoding complements of @@burt. and edit user.css to add some margin;

/*BOF search box margin*/
.autocompletebox-margin {
    margin-top: 20px;
    margin-bottom: 5px;
}
/*EOF search box margin*/

And from yesterday - I forgot... added an @@media query to hide the header buttons module in smaller views to prevent it from wrapping.

/*BOF button group padding and hide*/
.btn-group, .btn-group-vertical {
padding-bottom: 10px}
   @[member=media] only screen and (max-width: 525px) {
  #headerShortcuts { display: none; }   /* hide it elsewhere */
}
/*EOF button group padding and hide*/

Total time today - 5 mins.

[greasemonkey]

Couple changes over the past day... installed SEO urls 5 from here - simple 5 min install.... but as everyone know it required a few core changes (4 changes in catalog and 2 in admin) All set up in .htaccess to use rewrite feature and match my current urls. Also installed the matching site map - zero core changes.

 

Also installed/modified an old "all product" sort feature from an old addon here -  again simple 5 min install with a couple small mods to product_listing. Previously (in current my 2.3.4 store) had used "select product listing size" addon which modified the split_page_result class.... it sucked. Never worked right from the get go.

 

Next on my list will be the mailchimp box module from 28 days of coding.

[♥Tsimi]

@@greasemonkey

 

Also installed the matching site map - zero core changes.

Hi Scott

 

Do you have a link to that addon?

[♥Tsimi]

Oh and forgot...

Which USU did you use? FWR or Chemo ?

Did you test the USU with php 5.5 or even 5.6?

[greasemonkey]

Oh and forgot...

Which USU did you use? FWR or Chemo ?

Did you test the USU with php 5.5 or even 5.6?

@@Tsimi it is the FWR package. The site map is in the extra for. No, I'm on 5.4... Should I expect issues?

[♥Tsimi]

Currently I am running a osC 2.3.3.4 non-BS shop and i have USU (Chemo version, support by Jack) installed.

Server currently running on 5.4.35 and no problems BUT in my server i can switch between 6 different php versions and the latest i can currently switch to was 5.5.19 and then problems started. Same on my localhost with php 5.6

@@De Dokta posted somewhere a fix for it (....i think...), just don't recall where. This is the reason I haven't installed any USU in my BS shop that I am currently building up.

According to kymation, php 5.4.x will be supported till summer this year and then comes 5.5 or 5.6, so I was hesitant installing something that probably won't work with any newer php version.

 

I must admit I haven't looked at the FWR version since it has no support anymore. Further testing is in order i guess....

[greasemonkey]

@@Tsimi I have to say I'm a little concerned... but haven't had any issues.

 

My original 2.2 site used the chemo version - when I built up my 2.3.3 site I switched to FWR maintaining the same url structure (so I didn't have to worry about re-indexing). So, I think it should be easy enough to switch back to Jacks version if I do run into issues.

 

There is lots of activity on the support thread and a relatively simple update for  php 5.4/5.5 cache issues here . I presume I don't have any issues because I've always used the "file" cache setting and not sqlite.

[♥Tsimi]

@@greasemonkey

 

Hi Scott

Thanks for the Info.

Hmm...kinda confused and unsure at the moment...Chemo works fine for me at the moment but I don't know what the future brings...I will do some testing with newer php versions and see how that goes...I'll keep you posted...

[greasemonkey]

@@Tsimi please keep me posted on your tests... I'm not in a huge rush with this bootstrap build up so if we foresee issues with FWR and php 5.6 I'd be better to switch now I think.

[greasemonkey]

Today's changes....

 

Mailchimp signup module from 28 days of coding... install time... less than 5 mins with a couple small changes to core files create_account and account_newsletters.

 

Next was Superfish category menu for bootstrap from here. Install about 15 mins (couple small issues). Then styled it by making changes to /ext/jquery/superfish/css/superfish.css. The issues are mentioned in the support thread here . Well supported by @kymation.

 

Currently, I've added the id superfish-panel and I'm hiding this box module it with the below code in css... I'm not sure this is wise... and would love to here others thoughts on responsive navigation...

/*BOF hide cat menu box on medium sizes */
   @[member='media'] only screen and (max-width: 991px) {
  #superfish-panel { display: none; }   /* hide it elsewhere */
}
/* EOD hide cat menu box */

Here are my thoughts; hide the category box completely when it gets to 991px because it gets kicked down to the bottom - and let the expanded category class tree I built for the navbar take over for navigation.

 

Thoughts?????

[greasemonkey]

Today's work was easier than I thought... I had previously installed a couple index content modules from 28 days of coding (carousel and featured products) and could not use the sort order to get the new products module where I required (in between the carousel and featured products modules)

 

So, I made a new products content module for the index... worked well.

 

However, I don't know how to (and I'm not sure I should) move the configuration for "Maximum number of new products to display in a category" from maximum value to the new content mod. Any advice here? I've left it in max values for now... however I would think it should go in content mod.

 

@@burt I presume you've done this already.... If not would you like to check it and add to core or just have it as an addon?

[burt]

@@greasemonkey - email it over to me please.  I can compare your ideas to mine and can start getting it into the core...

 

Basis would be to move all the possible variables out of the "core" database and into the module (if that makes sense)...

[greasemonkey]

today's changes... maybe an hour or so.

 

I created a catalog/featured_products.php page using catalog/products_new.php as a template and borrowing the query from the featured products content module.

 

Then styled the h2 lines of the featured products and new products content modules to match the box module headings like this (in the language file);

  define('MODULE_CONTENT_NEW_PRODUCTS_HEADING', '<div class="panel panel-default"><div class="panel-heading">New Products</div></div>');

Then added a tep_href_link in the heading - in the module files like this (notice I removed the "month" reference in each);

if (tep_not_null(MODULE_CONTENT_NEW_PRODUCTS_HEADING)) echo '<a href="' . tep_href_link(FILENAME_PRODUCTS_NEW) . '">' . (MODULE_CONTENT_NEW_PRODUCTS_HEADING). '</a>';

[♥Tsimi]

Hi Scott

 

Sorry to jump into your Topic but I installed XAMPP with php 5.5.19 and I have SEO URLs from Chemo (supported by Jack_mcs) installed in a non-BS 2.3.3.4 shop and this is the error message I get.

 

Deprecated: mysql_connect(): The mysql extension is deprecated and will be removed in the future: use mysqli or PDO instead in C:\xampp\htdocs\xxxx\includes\classes\seo.class.php on line 78

Deprecated: mysql_connect(): The mysql extension is deprecated and will be removed in the future: use mysqli or PDO instead in C:\xampp\htdocs\xxxx\includes\classes\seo.class.php on line 78

 

As you can see there is some deprecated code inside it that needs attention, this is where De Doktas fix comes in. He posted some updates for the mysql stuff somewhere in the SEO URL topic a while back.

I don't know about FWRs version but it would be interesting to see if that version can run on a php 5.5.x or even on 5.6.x version server.

[De Dokta]

@@Tsimi

Hi Scott

 

Sorry to jump into your Topic but I installed XAMPP with php 5.5.19 and I have SEO URLs from Chemo (supported by Jack_mcs) installed in a non-BS 2.3.3.4 shop and this is the error message I get.

 

Deprecated: mysql_connect(): The mysql extension is deprecated and will be removed in the future: use mysqli or PDO instead in C:\xampp\htdocs\xxxx\includes\classes\seo.class.php on line 78

Deprecated: mysql_connect(): The mysql extension is deprecated and will be removed in the future: use mysqli or PDO instead in C:\xampp\htdocs\xxxx\includes\classes\seo.class.php on line 78

 

As you can see there is some deprecated code inside it that needs attention, this is where De Doktas fix comes in. He posted some updates for the mysql stuff somewhere in the SEO URL topic a while back.

I don't know about FWRs version but it would be interesting to see if that version can run on a php 5.5.x or even on 5.6.x version server.

 

Hi Lambros

 

There's a reason why two newer versions of Chemos USU (by vritzka and Roaddoctor) exist.  :-  In both the mysql/mysqli issue is fixed!

 

J.J.

[♥Tsimi]

I now that the woman with something...hexe posted a fix a while back and you corrected that fix. No offense but I don't trust unknown peoples fixes.

If you or Jack_mcs or Dave can confirm it THEN it is OK for me. Just wanted to make sure.

So php5.5 and 5.6 should be no problem then?

[De Dokta]

Weinhexe! She posted a fix here that I posted before in the German forum. That means, it was my, not her fix (she has also mentioned this and previously asked me for permission.... ;) ) I run it on php 5.5 without problems....

 

J.J.