Jump to content
dev osCommerce
Forum
  • Checkout
  • Login
  • Contact Us
  • Get in touch

osCommerce

The e-commerce.

New Demo
Our Partners

Strange Headers Being Sent From URL's

toyzonline

By toyzonline
in General Support

Recommended Posts

toyzonline

toyzonline

Posted
Posted

I have noticed that when I submit a url strange headers seem to be getting submitted. An example would be putting a link on FB (which captures a little info for the link)

 

http://www.raunchyrags.co.uk/shop/floral-suspender-belt-with-stockings-p-1940.html (not suitable for work)

 

the correct image is pulled but along with the following

 

 

Sexy Suspender Set with stockings and belt. One Size #sizes { font-size: 10px; FONT-FAMILY: verdana; border-spacing: 20px 10px; } .sizes td { border-bottom:1px solid #EEEEEE; padding:1px... 

 

Note the style sheet info

 

I am worried this has been effecting my SEO attempts

 

Ricardo

Complete Newbie On The Learn - Not A Programmer

But Learning As I Go

burt

burt

Posted
Posted

You should be worried, the code behind your site is an absolute mess :(

 

Have you put .css directly into the products description ???

toyzonline

toyzonline

Posted
  • Author
Posted

You should be worried, the code behind your site is an absolute mess :(

 

Have you put .css directly into the products description ???

 

Not as far as I know, as far as I can work back I believe this has only been happening since I installed Header Tags SEO (but cannot be certain hence not posting to the add on support thread).

Having checked I can confirm that this only happens when I use a URL linked to a product (none product pages do not show similar results).

 

I have posted below my product_info.php below (hope its the right page...lol)

<?php
/*
  $Id$

  osCommerce, Open Source E-Commerce Solutions
  http://www.oscommerce.com

  Copyright (c) 2014 osCommerce

  Released under the GNU General Public License
*/

  require('includes/application_top.php');

  if (!isset($HTTP_GET_VARS['products_id'])) {
    tep_redirect(tep_href_link(FILENAME_DEFAULT));
  }

  require(DIR_WS_LANGUAGES . $language . '/' . FILENAME_PRODUCT_INFO);

  $product_check_query = tep_db_query("select count(*) as total from " . TABLE_PRODUCTS . " p, " . TABLE_PRODUCTS_DESCRIPTION . " pd where p.products_status = '1' and p.products_id = '" . (int)$HTTP_GET_VARS['products_id'] . "' and pd.products_id = p.products_id and pd.language_id = '" . (int)$languages_id . "'");
  $product_check = tep_db_fetch_array($product_check_query);

  require(DIR_WS_INCLUDES . 'template_top.php');
/*** Begin Header Tags SEO ***/
  echo "<a name=\"\$header_tags_array['title']\"></a>";
  /*** End Header Tags SEO ***/

  if ($product_check['total'] < 1) {
?>

<div class="contentContainer">
  <div class="contentText">
    <?php echo TEXT_PRODUCT_NOT_FOUND; ?>
  </div>

  <div style="float: right;">
    <?php echo tep_draw_button(IMAGE_BUTTON_CONTINUE, 'triangle-1-e', tep_href_link(FILENAME_DEFAULT)); ?>
  </div>
</div>

<?php
  } else {
    /*** Begin Header Tags SEO ***/
    $product_info_query = tep_db_query("select p.products_id, pd.products_name, pd.products_description, p.products_model, p.products_quantity, p.products_image, pd.products_url, p.products_price, p.products_tax_class_id, p.products_date_added, p.products_date_available, p.manufacturers_id, pd.products_head_sub_text from " . TABLE_PRODUCTS . " p, " . TABLE_PRODUCTS_DESCRIPTION . " pd where p.products_status = '1' and p.products_id = '" . (int)$HTTP_GET_VARS['products_id'] . "' and pd.products_id = p.products_id and pd.language_id = '" . (int)$languages_id . "'");
    $product_info = tep_db_fetch_array($product_info_query);
    
    $product_info['products_name'] = $header_tags_array['title_alt'];
    /*** End Header Tags SEO ***/

    tep_db_query("update " . TABLE_PRODUCTS_DESCRIPTION . " set products_viewed = products_viewed+1 where products_id = '" . (int)$HTTP_GET_VARS['products_id'] . "' and language_id = '" . (int)$languages_id . "'");

    if ($new_price = tep_get_products_special_price($product_info['products_id'])) {
      $products_price = '<del>' . $currencies->display_price($product_info['products_price'], tep_get_tax_rate($product_info['products_tax_class_id'])) . '</del> <span class="productSpecialPrice">' . $currencies->display_price($new_price, tep_get_tax_rate($product_info['products_tax_class_id'])) . '</span>';
    } else {
      $products_price = $currencies->display_price($product_info['products_price'], tep_get_tax_rate($product_info['products_tax_class_id']));
    }

    if (tep_not_null($product_info['products_model'])) {
      $products_name = $product_info['products_name'] . '<br /><span class="smallText">[' . $product_info['products_model'] . ']</span>';
    } else {
      $products_name = $product_info['products_name'];
    }
?>
<?php echo tep_draw_form('cart_quantity', tep_href_link(FILENAME_PRODUCT_INFO, tep_get_all_get_params(array('action')) . 'action=add_product')); ?>

<div>
  <h1 style="float: right;"><?php echo $products_price; ?></h1>
  <h1><?php echo $products_name; ?></h1>
</div>

<div class="contentContainer">
  <div class="contentText">

<?php
    if (tep_not_null($product_info['products_image'])) {
      $photoset_layout = '1';

      $pi_query = tep_db_query("select image, htmlcontent from " . TABLE_PRODUCTS_IMAGES . " where products_id = '" . (int)$product_info['products_id'] . "' order by sort_order");
      $pi_total = tep_db_num_rows($pi_query);

      if ($pi_total > 0) {
        $pi_sub = $pi_total-1;

        while ($pi_sub > 5) {
          $photoset_layout .= 5;
          $pi_sub = $pi_sub-5;
        }

        if ($pi_sub > 0) {
          $photoset_layout .= ($pi_total > 5) ? 5 : $pi_sub;
        }
?>

    <div id="piGal">

<?php
        $pi_counter = 0;
        $pi_html = array();

        while ($pi = tep_db_fetch_array($pi_query)) {
          $pi_counter++;

          if (tep_not_null($pi['htmlcontent'])) {
            $pi_html[] = '<div id="piGalDiv_' . $pi_counter . '">' . $pi['htmlcontent'] . '</div>';
          }

          echo tep_image(DIR_WS_IMAGES . $pi['image'], '', '', '', 'id="piGalImg_' . $pi_counter . '"');
        }
?>

    </div>
<?php
		  // START: Extra Fields Contribution v2.0b - mintpeel display fix
		  
                      $extra_fields_query = tep_db_query("
SELECT pef.products_extra_fields_order, pef.products_extra_fields_status as status, pef.products_extra_fields_name as name, ptf.products_extra_fields_value as value
FROM ". TABLE_PRODUCTS_EXTRA_FIELDS ." pef
LEFT JOIN ". TABLE_PRODUCTS_TO_PRODUCTS_EXTRA_FIELDS ." ptf
ON ptf.products_extra_fields_id=pef.products_extra_fields_id
WHERE ptf.products_id=". (int)$HTTP_GET_VARS['products_id'] ." and ptf.products_extra_fields_value<>'' and (pef.languages_id='0' or pef.languages_id='".(int)$languages_id."')
ORDER BY pef.products_extra_fields_order");


        echo '<tr>
	  <td>
	  <table border="0" width="50%" cellspacing="0" cellpadding="2px">';
  while ($extra_fields = tep_db_fetch_array($extra_fields_query)) {
        if (! $extra_fields['status'])  // show only enabled extra field
           continue;
     echo'<tr><td class="main" align="left" valign="middle"><font size="1" color="#666666"><b>'.$extra_fields['name'].': </b>' . stripslashes($extra_fields['value']).'</font></td></tr>';
  }
     echo' </table>
	  </td>
      </tr>'; 
       // END: Extra Fields Contribution - mintpeel display fix
?>

<?php
        if ( !empty($pi_html) ) {
          echo '    <div style="display: none;">' . implode('', $pi_html) . '</div>';
        }
      } else {
?>

    <div id="piGal">
      <?php echo tep_image(DIR_WS_IMAGES . $product_info['products_image'], addslashes($product_info['products_name'])); ?>
    </div>

<?php
      }
    }
?>

<script type="text/javascript">
$(function() {
  $('#piGal').css({
    'visibility': 'hidden'
  });

  $('#piGal').photosetGrid({
    layout: '<?php echo $photoset_layout; ?>',
    width: '250px',
    highresLinks: true,
    rel: 'pigallery',
    onComplete: function() {
      $('#piGal').css({ 'visibility': 'visible'});

      $('#piGal a').colorbox({
        maxHeight: '90%',
        maxWidth: '90%',
        rel: 'pigallery'
      });

      $('#piGal img').each(function() {
        var imgid = $(this).attr('id').substring(9);

        if ( $('#piGalDiv_' + imgid).length ) {
          $(this).parent().colorbox({ inline: true, href: "#piGalDiv_" + imgid });
        }
      });
    }
  });
});
</script>

<?php /*** Begin Header Tags SEO ***/ ?>
<?php echo HTS_Highlight(stripslashes($product_info['products_description']), $header_tags_array['keywords']); ?>
<?php /*** End Header Tags SEO ***/ ?>

<?php
    $products_attributes_query = tep_db_query("select count(*) as total from " . TABLE_PRODUCTS_OPTIONS . " popt, " . TABLE_PRODUCTS_ATTRIBUTES . " patrib where patrib.products_id='" . (int)$HTTP_GET_VARS['products_id'] . "' and patrib.options_id = popt.products_options_id and popt.language_id = '" . (int)$languages_id . "'");
    $products_attributes = tep_db_fetch_array($products_attributes_query);
    if ($products_attributes['total'] > 0) {
?>

    <p><?php echo TEXT_PRODUCT_OPTIONS; ?></p>

    <p>
<?php
      $products_options_name_query = tep_db_query("select distinct popt.products_options_id, popt.products_options_name from " . TABLE_PRODUCTS_OPTIONS . " popt, " . TABLE_PRODUCTS_ATTRIBUTES . " patrib where patrib.products_id='" . (int)$HTTP_GET_VARS['products_id'] . "' and patrib.options_id = popt.products_options_id and popt.language_id = '" . (int)$languages_id . "' order by popt.products_options_name");
      while ($products_options_name = tep_db_fetch_array($products_options_name_query)) {
        $products_options_array = array();
        $products_options_query = tep_db_query("select pov.products_options_values_id, pov.products_options_values_name, pa.options_values_price, pa.price_prefix from " . TABLE_PRODUCTS_ATTRIBUTES . " pa, " . TABLE_PRODUCTS_OPTIONS_VALUES . " pov where pa.products_id = '" . (int)$HTTP_GET_VARS['products_id'] . "' and pa.options_id = '" . (int)$products_options_name['products_options_id'] . "' and pa.options_values_id = pov.products_options_values_id and pov.language_id = '" . (int)$languages_id . "'");
        while ($products_options = tep_db_fetch_array($products_options_query)) {
          $products_options_array[] = array('id' => $products_options['products_options_values_id'], 'text' => $products_options['products_options_values_name']);
          if ($products_options['options_values_price'] != '0') {
            $products_options_array[sizeof($products_options_array)-1]['text'] .= ' (' . $products_options['price_prefix'] . $currencies->display_price($products_options['options_values_price'], tep_get_tax_rate($product_info['products_tax_class_id'])) .') ';
          }
        }

        if (is_string($HTTP_GET_VARS['products_id']) && isset($cart->contents[$HTTP_GET_VARS['products_id']]['attributes'][$products_options_name['products_options_id']])) {
          $selected_attribute = $cart->contents[$HTTP_GET_VARS['products_id']]['attributes'][$products_options_name['products_options_id']];
        } else {
          $selected_attribute = false;
        }
?>
      <strong><?php echo $products_options_name['products_options_name'] . ':'; ?></strong><br /><?php echo tep_draw_pull_down_menu('id[' . $products_options_name['products_options_id'] . ']', $products_options_array, $selected_attribute); ?><br />
<?php
      }
?>
    </p>

<?php
    }
?>

    <div style="clear: both;"></div>

<?php
    if ($product_info['products_date_available'] > date('Y-m-d H:i:s')) {
?>

    <p style="text-align: center;"><?php echo sprintf(TEXT_DATE_AVAILABLE, tep_date_long($product_info['products_date_available'])); ?></p>

<?php
    }
?>

  </div>

<?php
    $reviews_query = tep_db_query("select count(*) as count from " . TABLE_REVIEWS . " r, " . TABLE_REVIEWS_DESCRIPTION . " rd where r.products_id = '" . (int)$HTTP_GET_VARS['products_id'] . "' and r.reviews_id = rd.reviews_id and rd.languages_id = '" . (int)$languages_id . "' and reviews_status = 1");
    $reviews = tep_db_fetch_array($reviews_query);
?>
<?php if ($product_info['products_quantity'] == 0 ) echo '<font color="red"><b><i><u>This item is currently out of stock, but can be backordered.</i></u></b></font>'; ?>
  <div class="buttonSet">
    <span class="buttonAction"><?php echo tep_draw_hidden_field('products_id', $product_info['products_id']) . tep_draw_button(IMAGE_BUTTON_IN_CART, 'cart', null, 'primary'); ?></span>

    <?php echo tep_draw_button(IMAGE_BUTTON_REVIEWS . (($reviews['count'] > 0) ? ' (' . $reviews['count'] . ')' : ''), 'comment', tep_href_link(FILENAME_PRODUCT_REVIEWS, tep_get_all_get_params())); ?>
  </div>
<!--- BEGIN Header Tags SEO SUB TEXT -->
      <?php
      if (tep_not_null($product_info['products_head_sub_text'])) {
          echo '<div class="contentText" style="margin-top:5px;">' . $product_info['products_head_sub_text'] . '</div>';
      }
      ?>
      <!--- END Header Tags SUB TEXT -->

<?php
    if ((USE_CACHE == 'true') && empty($SID)) {
      echo tep_cache_also_purchased(3600);
    } else {
      include(DIR_WS_MODULES . FILENAME_ALSO_PURCHASED_PRODUCTS);
    }
?>
<?php /*** Begin Header Tags SEO ***/
      if (tep_not_null($product_info['products_head_sub_text'])) {
          echo '<div class="hts_sub_text" style="padding:10px 0;">' . $product_info['products_head_sub_text'] . '</div>';
      }

      if (HEADER_TAGS_DISPLAY_CURRENTLY_VIEWING == 'true') {
          echo '<div id="hts_viewing">' .TEXT_VIEWING;
          $header_tags_array['title'] = (tep_not_null($header_tags_array['title']) ? $header_tags_array['title'] : $product_info['products_name']);
          echo '<a title="' . $header_tags_array['title'] . '" href="' . tep_href_link(FILENAME_PRODUCT_INFO, 'products_id=' . $product_info['products_id'], 'NONSSL') . '"/# ' . $header_tags_array['title'] . '">' . $header_tags_array['title'] . '</a>';
          echo '</div>';
      }
      if (HEADER_TAGS_DISPLAY_SOCIAL_BOOKMARKS == 'true') {
        echo '<div style="float:right; margin-top:5px; margin-right:4px;">';
        include(DIR_WS_MODULES . 'header_tags_social_bookmarks.php');
        echo '</div>';
      }
      /*** End Header Tags SEO ***/
      ?>
</div>

</form>

<?php
  }

  require(DIR_WS_INCLUDES . 'template_bottom.php');
  require(DIR_WS_INCLUDES . 'application_bottom.php');
?>

Complete Newbie On The Learn - Not A Programmer

But Learning As I Go

toyzonline

toyzonline

Posted
  • Author
Posted

Go to the admin product adding/editing page for this product :

http://www.raunchyrags.co.uk/shop/floral-suspender-belt-with-stockings-p-1940.html  (NSFW)

 

and take a screenshot of the products description box.  Post that screenshot here.

 

Aha no need for that I just realised a piece of code I imported to show a table on the products is causing this.

<style type="text/css">

#sizes
{

	font-size: 10px;
FONT-FAMILY: verdana;
border-spacing: 20px 10px;
}

.sizes td {
border-bottom:1px solid #EEEEEE;
padding:1px 1em 1px 0;
}

.sizes th {
border-bottom:1px solid #9966ff;
padding:1px 1em 1px 0;
}

</style><br>
    <div align="center"><style type="text/css">
#sizes tbody tr th em strong {
}
#sizes tbody tr td {
  text-align: center;
}
</style>
  <table class="sizes" id="sizes">
    
        <thead>
        <tr>

            <th><em><strong>Lingerie Size</strong></em></th>
            <th><em><strong>UK Dress size</strong></em></th>
            <th><em><strong>Bust</strong></em></th>
            <th><em><strong>Cup Size</strong></em></th>
            <th><em><strong>Waist</strong></em></th>
            <th><em><strong>Hips</strong></em></th>
        </tr>
    </thead>
    <tbody>
        <tr>
            <th><div align="left"><em><strong>Small</strong></em></div></th>
            <td><div align="center">8 - 10</div></td>
            <td><div align="center">32" - 34"</div></td>

            <td><div align="center">A - B</div></td>
            <td><div align="center">24" - 26"</div></td>
            <td><div align="center">34" - 36"</div></td>
        </tr>
        <tr>

            <th><div align="left"><em><strong>Medium</strong></em></div></th>
            <td><div align="center">12 - 14</div></td>
            <td><div align="center">34" - 36"</div></td>
            <td><div align="center">B - C</div></td>
            <td><div align="center">26" - 28"</div></td>

            <td><div align="center">36" - 38"</div></td>
        </tr>
        <tr>
            <th><div align="left"><em><strong>Large</strong></em></div></th>
            <td><div align="center">14 - 16</div></td>
            <td><div align="center">36" - 38"</div></td>

            <td><div align="center">C - D</div></td>
            <td><div align="center">28" - 32"</div></td>
            <td><div align="center">38" - 40"</div></td>
        </tr>
        <tr>

            <th><div align="left"><em><strong>XL</strong></em></div></th>
            <td><div align="center">16 - 18</div></td>
            <td><div align="center">40" - 42"</div></td>
            <td><div align="center">D - DD</div></td>
            <td><div align="center">34" - 36"</div></td>

            <td><div align="center">42" - 44"</div></td>
        </tr>
        <tr>
            <th><div align="left"><em><strong>XXL</strong></em></div></th>
            <td><div align="center">20 - 22</div></td>
            <td><div align="center">44" - 46"</div></td>

            <td><div align="center">DD - E</div></td>
            <td><div align="center">38" - 40"</div></td>
            <td><div align="center">46" - 48"</div></td>
        </tr>
        <tr>

            <th><div align="left"><em><strong>XXXL</strong></em></div></th>
            <td><div align="center">22 - 24</div></td>
            <td><div align="center">46" - 48"</div></td>
            <td><div align="center">DD - E</div></td>
            <td><div align="center">40" - 42"</div></td>

            <td><div align="center">48" - 50"</div></td>
        </tr>
        <tr>
            <th><div align="left"><em><strong>One size</strong></em></div></th>
            <td><div align="center">8 - 12</div></td>
            <td><div align="center">32" - 38"</div></td>

            <td><div align="center">B - C</div></td>
            <td><div align="center">24" - 32"</div></td>
            <td><div align="center">34" - 40"</div></td>
        </tr>
        <tr>

            <th><div align="left"><em><strong>S / M</strong></em></div></th>
            <td><div align="center">8 - 10</div></td>
            <td> <div align="center"></div></td>
            <td> <div align="center"></div></td>
            <td><div align="center"></div></td>

          <td><div align="center"></div></td>
        </tr>
        <tr>
          <th><div align="left"><em><strong>M / L</strong></em></div></th>
          <td><div align="center">12-14</div></td>
          <td> <div align="center"></div></td>
          <td><div align="center"></div></td>
          <td><div align="center"></div></td>
          <td><div align="center"></div></td>
        </tr>
        <tr>
          <th><div align="left"><strong>L / XL</strong></div></th>
          <td>16-18</td>
          <td> </td>
          <td> </td>
          <td> </td>
          <td> </td>
        </tr>
        <tr>
          <th><div align="left">1XL - 2 XL</div></th>
          <td>16-18</td>
          <td> </td>
          <td> </td>
          <td> </td>
          <td> </td>
        </tr>
        <tr>
          <th><div align="left">3XL - 4 XL</div></th>
          <td>20-22
            <div align="center"></div></td>
          <td> <div align="center"></div></td>
          <td><div align="center"></div></td>
          <td><div align="center"></div></td>
          <td><div align="center"></div></td>
        </tr>
    </tbody>
   
</table>

              </div>

But this now leaves me with the problem that if I remove the style references the page goes all funny and unaligned?

Complete Newbie On The Learn - Not A Programmer

But Learning As I Go

burt

burt

Posted
Posted

put the css into the stylesheet - which is where it should be.

Do the same for any other product that has such code in its description.

toyzonline

toyzonline

Posted
  • Author
Posted

put the css into the stylesheet - which is where it should be.

Do the same for any other product that has such code in its description.

 

Sorry to be total idiot, but would I just paste the below into the stylesheet

#sizes
{

	font-size: 10px;
FONT-FAMILY: verdana;
border-spacing: 20px 10px;
}

.sizes td {
border-bottom:1px solid #EEEEEE;
padding:1px 1em 1px 0;
}

.sizes th {
border-bottom:1px solid #9966ff;
padding:1px 1em 1px 0;
}

And then remove the following from each instance of that table?

<style type="text/css">

#sizes
{

	font-size: 10px;
FONT-FAMILY: verdana;
border-spacing: 20px 10px;
}

.sizes td {
border-bottom:1px solid #EEEEEE;
padding:1px 1em 1px 0;
}

.sizes th {
border-bottom:1px solid #9966ff;
padding:1px 1em 1px 0;
}

</style><br>

Complete Newbie On The Learn - Not A Programmer

But Learning As I Go

Archived

This topic is now archived and is closed to further replies.

Go to topic listing
×
×
  • Create New...