Elmo Posted April 2, 2003 Share Posted April 2, 2003 Hi, I have a quick question regarding All Products Page, v2.1. When I installed HeaderTagsControllerv2 and Header Tag Controller Admin today, I noticed that the title tag in All Products Page, v2.1. is <title><?php echo TITLE ?></title> but in the rest of php files in /catalog, the title tag is <title><?php echo TITLE; ?></title> May I if the extra ";" make any difference? Quote Best regards, Elmo Link to comment Share on other sites More sharing options...
Guest Posted April 2, 2003 Share Posted April 2, 2003 yes, in PHP a statement must close with a ";" Quote Link to comment Share on other sites More sharing options...
gdfwilliams Posted April 2, 2003 Share Posted April 2, 2003 Good find. This and other imporovements have just been added to the most recent contribution. http://www.oscommerce.com/forums/viewtopic.php?t=39737 - Greg Quote Link to comment Share on other sites More sharing options...
Elmo Posted April 3, 2003 Author Share Posted April 3, 2003 Thanks for the replies. I just found that according to the readme file for Header Tags Controller v2.0: It says to replace Old Line: <title><?php echo TITLE ?></title> with New Lines: <?php // BOF: WebMakers.com Changed: Header Tag Controller v1.0 // Replaced by header_tags.php if ( file_exists(DIR_WS_INCLUDES . 'header_tags.php') ) { require(DIR_WS_INCLUDES . 'header_tags.php'); } else { ?> <title><?php echo TITLE ?></title> <?php } // EOF: WebMakers.com Changed: Header Tag Controller v1.0 ?> But my php files under the /catalog have <title><?php echo TITLE; ?></title> instead of <title><?php echo TITLE ?></title> Is it because when Header Tags Controller v2.0 was released, the oscommerce version at that time was using <title><?php echo TITLE ?></title> ? And do we need to add the ";" in the code of Header Tags Controller v2.0: <?php // BOF: WebMakers.com Changed: Header Tag Controller v1.0 // Replaced by header_tags.php if ( file_exists(DIR_WS_INCLUDES . 'header_tags.php') ) { require(DIR_WS_INCLUDES . 'header_tags.php'); } else { ?> <title><?php echo TITLE ?></title> <?php } Please help, I am very very confused. Quote Best regards, Elmo Link to comment Share on other sites More sharing options...
gdfwilliams Posted April 3, 2003 Share Posted April 3, 2003 It must read <title><?php echo TITLE; ?></title> The omission of ';' was an error in the code. Quote Link to comment Share on other sites More sharing options...
Elmo Posted April 3, 2003 Author Share Posted April 3, 2003 HI Greg, thanks very much for your great! The All Products Page, v2.1. module works great on my site! Many thanks! :D Quote Best regards, Elmo Link to comment Share on other sites More sharing options...
Elmo Posted April 3, 2003 Author Share Posted April 3, 2003 Hi Greg, I visited your estore and I noticed that in the source code, your <title> tag is also being placed after the other two meta tags (site description and keyword). I want to know how we can modify the code so that the <title> tag would be placed before these two tags because I am not sure if the order of these tags would affect the ranking position in search engines. May I ask if you have any ideas? Quote Best regards, Elmo Link to comment Share on other sites More sharing options...
Recommended Posts
Join the conversation
You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.