tinker74 Posted January 14, 2014 Share Posted January 14, 2014 I had a "?>" at the bottom of general.php.....took it out and the problem went away Quote Link to comment Share on other sites More sharing options...
burt Posted January 14, 2014 Share Posted January 14, 2014 (edited) The latest version (which you state you have) addon does not have a ?> at the bottom of that file. Edited January 14, 2014 by burt Quote Link to comment Share on other sites More sharing options...
tinker74 Posted January 14, 2014 Share Posted January 14, 2014 when i did winmerge....my version must have had it so i moved it over to the new one burt 1 Quote Link to comment Share on other sites More sharing options...
burt Posted January 14, 2014 Share Posted January 14, 2014 (edited) Almost all .php files should have no ?> final end tag. The only ones that need them are those that output HTML (eg, index.php, product_info.php and so on). In the case of osCommerce almost all files inside /includes/ and subfolders do not need the final end ?> tag. Not having a final end ?> tag prevents the type of error you experienced. Edited January 14, 2014 by burt Quote Link to comment Share on other sites More sharing options...
HuffYk Posted January 25, 2014 Share Posted January 25, 2014 I used very long time header_tags_controller. Now I'm converting my site to 2.3.3.4 from old 2.2. I checked header tags addons and see this one is using new system introduced in 2.3 - header tags modules. It is very easy to install and not to many changes into existing files. Thats why I like it more than controller. However what I miss from controller is "fill tags" functionality. Thats why I started to think about creating default meta tags in case seo fields are empty. For products it is actually done - I just started to use osc_get_mini_description. Same approach I did for categories and manufacturers (just copy&paste existing osc_get_mini_description and osc_split_mini_description and change fields and tables). One think why I write is I had to change all coalesce sql calls. Currently it takes empty string as valid value. I changed it to this: (use nullif functions for all seo fields): this way empty values are converted to NULL here is one example from osc_get_mini_description fnc $product_query = tep_db_query("select coalesce(nullif(products_mini_description,''), nullif(products_seo_description,''), LEFT(products_description, 300)) as products_precis from " . TABLE_PRODUCTS_DESCRIPTION . " where products_id = '" . (int)$products_id . "' and language_id = '" . (int)$languages_id . "'"); Quote Link to comment Share on other sites More sharing options...
burt Posted January 26, 2014 Share Posted January 26, 2014 I have not yet come across a "null" problem, but when I do I'll make more investigations - thanks for sharing the code. On the other point about pre-filled items, it's best to not do this - the whole point of this addon is to allow/force the shopowner to create proper tags and descriptions manually. Good crafted words in these places are worth their weight in gold, a precis of the products description (for example) would certainly not be worth as much. Quote Link to comment Share on other sites More sharing options...
♥joli1811 Posted January 28, 2014 Share Posted January 28, 2014 Hi, Looks like I can confirm a similar problem when adding a new product where the Products Title for SEO: is not filled out using the latest version of reloaded (SEO Header Tags - Reloaded - 2014 01 10) The Products Name: does not appear on product_info.php where by default if the seo title is not filled the product name should appear this query seems to be the problem $product_info_query = tep_db_query("select p.products_id, COALESCE(pd.products_seo_title, pd.products_name) as products_name, pd.products_description, p.products_model, p.products_quantity, p.products_image, pd.products_url, p.products_price, p.products_tax_class_id, p.products_date_added, p.products_date_available, p.manufacturers_id from " . TABLE_PRODUCTS . " p, " . TABLE_PRODUCTS_DESCRIPTION . " pd where p.products_status = '1' and p.products_id = '" . (int)$HTTP_GET_VARS['products_id'] . "' and pd.products_id = p.products_id and pd.language_id = '" . (int)$languages_id . "'"); Regards John Quote To improve is to change; to be perfect is to change often. Link to comment Share on other sites More sharing options...
♥joli1811 Posted January 28, 2014 Share Posted January 28, 2014 Ok getting expected results with this but really not sure what I am doing what do you think ?? $product_info_query = tep_db_query("select p.products_id, COALESCE(NULLIF(pd.products_seo_title,''), pd.products_name) as products_name, pd.products_description, p.products_model, p.products_quantity, p.products_image, pd.products_url, p.products_price, p.products_tax_class_id, p.products_date_added, p.products_date_available, p.manufacturers_id from " . TABLE_PRODUCTS . " p, " . TABLE_PRODUCTS_DESCRIPTION . " pd where p.products_status = '1' and p.products_id = '" . (int)$HTTP_GET_VARS['products_id'] . "' and pd.products_id = p.products_id and pd.language_id = '" . (int)$languages_id . "'"); Regards John Quote To improve is to change; to be perfect is to change often. Link to comment Share on other sites More sharing options...
burt Posted January 28, 2014 Share Posted January 28, 2014 Yes, adding the nullif will cure that, but I still have not come across a situation where it's needed (and that's on a number of cient sites across a range of hosts) - how strange. Quote Link to comment Share on other sites More sharing options...
♥Tsimi Posted January 30, 2014 Author Share Posted January 30, 2014 (edited) i was just installing the latest version and realized that the ?> tag at the end is missing inside the languages/english/ index.php product_reviews_info.php specials.php testimonials.php is that on purpose? Edited January 30, 2014 by Tsimi Quote Link to comment Share on other sites More sharing options...
♥Tsimi Posted January 30, 2014 Author Share Posted January 30, 2014 please ignore my post above! http://www.oscommerce.com/forums/topic/394978-seo-header-tags-reloaded-support/page__st__20#entry1689653 Quote Link to comment Share on other sites More sharing options...
burt Posted February 10, 2014 Share Posted February 10, 2014 New fileset (added 2014 02 10): http://addons.oscommerce.com/info/8864 Introduction of HT modules for Information Pages Unlimited, courtesy of @@joli1811 Addition of NULLIF to all coalesce statements to solve a display problem, chapeau @@HuffYk Quote Link to comment Share on other sites More sharing options...
kido2 Posted February 13, 2014 Share Posted February 13, 2014 Hello my main issue is non availablity of SEO Plugin on your website. I need to install any SEO plugin in the website. Can you help me Quote Link to comment Share on other sites More sharing options...
burt Posted February 13, 2014 Share Posted February 13, 2014 Download and install: http://addons.oscommerce.com/info/8864 This is the support thread, if you need help after it is installed. Quote Link to comment Share on other sites More sharing options...
kido2 Posted February 24, 2014 Share Posted February 24, 2014 Hello Burt i have downloaded the SEO Header Tags Reloaded and now i need to add Alt Tag Optimization my where do i find a plugin Quote Link to comment Share on other sites More sharing options...
kido2 Posted February 24, 2014 Share Posted February 24, 2014 OS commerece do not supopor this functionality for alttags in images what do i do ? Quote Link to comment Share on other sites More sharing options...
kido2 Posted February 24, 2014 Share Posted February 24, 2014 Is there any 1 who can help me about the Alt Tag Optimization or a plugin for Tags Quote Link to comment Share on other sites More sharing options...
burt Posted February 24, 2014 Share Posted February 24, 2014 I have no desire to add the ability for shopowners to destroy their Alt tags in the name of SEO. In other words: alt tags for images should never be used as an SEO strategy, not even as a mini part of it, and I won't help anyone do it. Quote Link to comment Share on other sites More sharing options...
kido2 Posted February 24, 2014 Share Posted February 24, 2014 i have downloaded the SEO Header Tags Reloaded and now i need to add Alt Tag Optimization where do i find a plugin do you know any thing about the Alt tag OS commerece do not supopor this functionalityfor alttags in images do you know anything about this and where i can find a plugin or some to fix this problem i checked everywhere for samebut no way out to solve it Quote Link to comment Share on other sites More sharing options...
kido2 Posted February 24, 2014 Share Posted February 24, 2014 is there something else you could recommend using in it place for SEO Quote Link to comment Share on other sites More sharing options...
mirageco Posted March 11, 2014 Share Posted March 11, 2014 i have heavily modified OSC and a install instruction would b good to add i'm having trouble finding what t install. any one can help would be great cheers thanks Quote Link to comment Share on other sites More sharing options...
burt Posted March 11, 2014 Share Posted March 11, 2014 If you have a highly modified osCommerce, a set of installation instructions would be useless to you. Read the readme, download a program such as Winmerge and start making code edits in a better way. Quote Link to comment Share on other sites More sharing options...
StavrosZ Posted March 14, 2014 Share Posted March 14, 2014 Hello Burt, I just finished with a fresh install of your contribution. I'm not very experienced with OSc. What I need to know is: Is their a way to bulk update the meta data of the products? I used the Easy Populate contribution to massively update titles, descr, images etc. But now how could I be productive with the meta tags? If I start editing one by one it's gonna take me ages. THank you Quote Link to comment Share on other sites More sharing options...
burt Posted March 14, 2014 Share Posted March 14, 2014 You can do it in phpmyadmin, but that defeats the purpose of creating especially crafted titles and descriptions, no? StavrosZ 1 Quote Link to comment Share on other sites More sharing options...
StavrosZ Posted March 14, 2014 Share Posted March 14, 2014 hello Again. I noticed that my meta description on page source contains <p> tags. Does anyone know how to get rid of them? Quote Link to comment Share on other sites More sharing options...
New 
Recommended Posts
Join the conversation
You can post now and register later. If you have an account, sign in now to post with your account.