catalog/checkout_shipping... Is this really a bug?

[Juto]

It's about free shipping and goes:

 

//Bug fix Ref: http://www.oscommerce.com/forums/topic/365714-free-shipping/

// and http://www.oscommerce.com/forums/topic/270956-free-shipping-option-bug/

//The fix if ( ($pass == true) && ($cart->show_total() >= MODULE_ORDER_TOTAL_SHIPPING_FREE_SHIPPING_OVER) ) {

//Instead of:

if ( ($pass == true) && ($order->info['total'] >= MODULE_ORDER_TOTAL_SHIPPING_FREE_SHIPPING_OVER) ) {

 

Around line 88

 

When I look into the code for v2.3.1 there's no fix done.

 

So, is it a bug or not?

 

Sara

[♥kymation]

It appears to be a real bug. Fix it if you are offering free shipping using the built-in capability.

 

I don't like the way osC does free shipping. If the order qqualifies, the customer has no other shipping option. What if the customer needs the item shipped overnight, and is willing to pay for that? I prefer to have free shipping as just one of the options. You can do this with the Freeamount module along with your regular shipping module(s).

 

Regards

Jim

[Juto]

Hi Jim and thanks for your answer, it's really appreciated.

 

I have included the fix.

 

The issues I have otherwise only appears for free shipping.

 

I have tried all day to fix those, but no success. So the coding for free shipping is wrong.

Maby the fix is to have free shipping as a module?

 

I'll try your suggesed contribution.

If that works, I think that the checkout_shipping should be cleared from the code for fre shipping, or?

 

Also, I have moved this to line 15 after inclusion of application_top:

 

include(DIR_WS_LANGUAGES . $language . '/modules/order_total/ot_shipping.php');

 

I do beleive that it was missplaced at line 91 (v2.3.x)

 

Regards

 

Sara

[♥kymation]

You don't need to remove the free shipping code. It's better to just turn it off in the Admin and it will never run.

 

Regards

Jim