technophobe Posted May 31, 2011 Share Posted May 31, 2011 After my service provider upgraded me to php version 5 from version 4, i have had a few problems with the website that i seem to have overcome most of them, but on the contact_us.php page i am now getting this error. Parse error: syntax error, unexpected ';' in /homepages/21/d227036576/htdocs/contact_us.php on line 157 I have looked around to see if anyone has had a similar problem, but cant see anything. I have removed the ; but then the error goes to the next line. This is a snippet from the contact_us.php. }else{ foreach(explode("," ,CONTACT_US_LIST) as $k => $v) { $send_to_array[] = array('id' => $k, 'text' => preg_replace('/\<[^*]*/', '', $v)); } echo tep_draw_pull_down_menu('send_to', $send_to_array); } echo ; } ?> <?php echo ENTRY_REASON; ?><br> <select name="reason"> <?php echo '<option value="' . REASONS1 . '">' . REASONS1 . '</option>'; ?> <?php echo '<option value="' . REASONS2 . '">' . REASONS2 . '</option>'; ?> <?php echo '<option value="' . REASONS3 . '">' . REASONS3 . '</option>'; ?> <?php echo '<option value="' . REASONS4 . '">' . REASONS4 . '</option>'; ?> <?php echo '<option value="' . REASONS5 . '">' . REASONS5 . '</option>'; ?> <?php echo '<option value="' . REASONS6 . '">' . REASONS6 . '</option>'; ?> If anyone can help that would be much appreciated. zappautomation Link to comment Share on other sites More sharing options...
FIMBLE Posted May 31, 2011 Share Posted May 31, 2011 What is the code supposed to do, by the looks of it display a drop down. Better you post the whole file, so we can see the context too. echo ; looks wrong, unless you want a ; to show? can you wrap it in the code blocks too. Nic Sometimes you're the dog and sometimes the lamp post [/url] My Contributions Link to comment Share on other sites More sharing options...
technophobe Posted May 31, 2011 Author Share Posted May 31, 2011 It is just a contact us form. Not sure how different it is from stondard, but nothing has changed on it for at least 2 years. This is the file. <?php /* $Id: contact_us.php,v 1.42 2003/06/12 12:17:07 hpdl Exp $ osCommerce, Open Source E-Commerce Solutions http://www.oscommerce.com Copyright © 2003 osCommerce Released under the GNU General Public License */ require('includes/application_top.php'); require(DIR_WS_LANGUAGES . $language . '/' . FILENAME_CONTACT_US); $error = false; if (isset($HTTP_GET_VARS['action']) && ($HTTP_GET_VARS['action'] == 'send')) { $name = tep_db_prepare_input($HTTP_POST_VARS['name']); $email_address = tep_db_prepare_input($HTTP_POST_VARS['email']); // BOF Super Contact us enhancement 1.41 $order_id = tep_db_prepare_input($HTTP_POST_VARS['order_id']); if ($order_id <> NULL){ $enquiry = 'Order ID: ' . $order_id . "\n\n" . tep_db_prepare_input($HTTP_POST_VARS['enquiry']); }else{ $enquiry = tep_db_prepare_input($HTTP_POST_VARS['enquiry']); } $emailsubject = tep_db_prepare_input($HTTP_POST_VARS['reason']) . ' ' . EMAIL_SUBJECT; if (tep_validate_email($email_address)) { tep_mail(STORE_OWNER, STORE_OWNER_EMAIL_ADDRESS, $emailsubject, $enquiry, $name, $email_address); if (CONTACT_US_LIST !=''){ $send_to_array=explode("," ,CONTACT_US_LIST); preg_match('/\<[^>]+\>/', $send_to_array[$send_to], $send_email_array); $send_to_email= eregi_replace (">", "", $send_email_array[0]); $send_to_email= eregi_replace ("<", "", $send_to_email); tep_mail(preg_replace('/\<[^*]*/', '', $send_to_array[$send_to]), $send_to_email, $emailsubject, $enquiry, $name, $email_address); }else{ //tep_redirect(tep_href_link(FILENAME_CONTACT_US, 'action=success')); tep_redirect(tep_href_link(FILENAME_CONTACT_US, 'action=send')); } // EOF Super Contact us enhancement 1.41 } else { $error = true; $messageStack->add('contact', ENTRY_EMAIL_ADDRESS_CHECK_ERROR); } } $breadcrumb->add(NAVBAR_TITLE, tep_href_link(FILENAME_CONTACT_US)); ?> <!doctype html public "-//W3C//DTD HTML 4.01 Transitional//EN"> <html <?php echo HTML_PARAMS; ?>> <head> <meta http-equiv="Content-Type" content="text/html; charset=<?php echo CHARSET; ?>"> <title><?php echo TITLE; ?></title> <base href="<?php echo (($request_type == 'SSL') ? HTTPS_SERVER : HTTP_SERVER) . DIR_WS_CATALOG; ?>"> <link rel="stylesheet" type="text/css" href="stylesheet.css"> </head> <body marginwidth="0" marginheight="0" topmargin="0" bottommargin="0" leftmargin="0" rightmargin="0"> <!-- header //--> <?php require(DIR_WS_INCLUDES . 'header.php'); ?> <!-- header_eof //--> <!-- body //--> <table border="0" width="100%" cellspacing="0" cellpadding="0"> <tr> <!-- body_text //--> <td width="100%" valign="top"><?php echo tep_draw_form('contact_us', tep_href_link(FILENAME_CONTACT_US, 'action=send')); ?><table border="0" width="100%" cellspacing="0" cellpadding="0"> <tr> <td><table border="0" width="100%" cellspacing="0" cellpadding="0"> <tr> <td class="pageHeading"><?php echo HEADING_TITLE; ?></td> </tr> </table></td> </tr> <tr> <td><?php echo tep_draw_separator('pixel_trans.gif', '100%', '10'); ?></td> </tr> <?php if ($messageStack->size('contact') > 0) { ?> <tr> <td><?php echo $messageStack->output('contact'); ?></td> </tr> <tr> <td><?php echo tep_draw_separator('pixel_trans.gif', '100%', '10'); ?></td> </tr> <?php } if (isset($HTTP_GET_VARS['action']) && ($HTTP_GET_VARS['action'] == 'send')) { ?> <tr> <td class="main" align="center"><?php echo tep_image(DIR_WS_IMAGES . 'table_background_man_on_board.gif', HEADING_TITLE, '0', '0', 'align="left"') . TEXT_SUCCESS; ?></td> </tr> <tr> <td><?php echo tep_draw_separator('pixel_trans.gif', '100%', '10'); ?></td> </tr> <tr> <td><table border="0" width="100%" cellspacing="1" cellpadding="2" class="infoBox"> <tr class="infoBoxContents"> <td><table border="0" width="100%" cellspacing="0" cellpadding="2"> <tr> <td width="10"><?php echo tep_draw_separator('pixel_trans.gif', '10', '1'); ?></td> <td align="right"><?php echo '<a href="' . tep_href_link(FILENAME_DEFAULT) . '">' . tep_image_button('button_continue.gif', IMAGE_BUTTON_CONTINUE) . '</a>'; ?></td> <td width="10"><?php echo tep_draw_separator('pixel_trans.gif', '10', '1'); ?></td> </tr> </table></td> </tr> </table></td> </tr> <!-- BOF Super Contact us enhancement 1.41 //--> <?php } else { if (tep_session_is_registered('customer_id')) { $account_query = tep_db_query("select customers_firstname, customers_lastname, customers_email_address from " . TABLE_CUSTOMERS . " where customers_id = '" . (int)$customer_id . "'"); $account = tep_db_fetch_array($account_query); $name = $account['customers_firstname'] . ' ' . $account['customers_lastname']; $email = $account['customers_email_address']; } ?> <tr><td> <table border="0" width="100%" cellspacing="1" cellpadding="2" class="infoBox"> <tr class="infoBoxContents"><td><table><tr> <td class="main" valign="top" width=40%><b><?php echo nl2br(STORE_NAME_ADDRESS); ?></b><br><br> <?php echo (OPENING_HOURS); ?><br><br></td> <td class="main" valign="top" width="60%"><?php echo ENTRY_NAME; ?><br> <?php echo tep_draw_input_field('name'); ?><br /> <?php echo ENTRY_EMAIL; ?><br> <?php echo tep_draw_input_field('email'); ?><br /> <?php echo ENTRY_ORDER_ID; ?><br> <?php echo tep_draw_input_field('order_id'); ?><br /> <?php if (CONTACT_US_LIST !=''){ echo SEND_TO_TEXT . '<br>'; if(SEND_TO_TYPE=='radio'){ foreach(explode("," ,CONTACT_US_LIST) as $k => $v) { if($k==0){ $checked=true; }else{ $checked=false; } echo tep_draw_radio_field('send_to', "$k", $checked). " " .preg_replace('/\<[^*]*/', '', $v); } }else{ foreach(explode("," ,CONTACT_US_LIST) as $k => $v) { $send_to_array[] = array('id' => $k, 'text' => preg_replace('/\<[^*]*/', '', $v)); } echo tep_draw_pull_down_menu('send_to', $send_to_array); } echo ; } ?> <?php echo ENTRY_REASON; ?><br> <select name="reason"> <?php echo '<option value="' . REASONS1 . '">' . REASONS1 . '</option>'; ?> <?php echo '<option value="' . REASONS2 . '">' . REASONS2 . '</option>'; ?> <?php echo '<option value="' . REASONS3 . '">' . REASONS3 . '</option>'; ?> <?php echo '<option value="' . REASONS4 . '">' . REASONS4 . '</option>'; ?> <?php echo '<option value="' . REASONS5 . '">' . REASONS5 . '</option>'; ?> <?php echo '<option value="' . REASONS6 . '">' . REASONS6 . '</option>'; ?> </select><br /> <?php echo ENTRY_ENQUIRY; ?><BR> <?php echo tep_draw_textarea_field('enquiry', 'soft', 50, 15, tep_sanitize_string($_POST['enquiry']), '', false); ?> <br /> </td></tr></table></td> </tr> </table> <br /> <table border="0" width="100%" cellspacing="1" cellpadding="2" class="infoBox"> <tr class="infoBoxContents"> <td><table border="0" width="100%" cellspacing="0" cellpadding="2"> <tr> <td width="10"><?php echo tep_draw_separator('pixel_trans.gif', '10', '1'); ?></td> <td align="right"><?php echo tep_image_submit('button_send.gif', IMAGE_BUTTON_CONTINUE); ?></td> <td width="10"><?php echo tep_draw_separator('pixel_trans.gif', '10', '1'); ?></td> </tr> </table></td> </tr> </table></td></tr> <?php } ?> <!-- EOF Super Contact us enhancement 1.41 //--> </table></form></td> <!-- body_text_eof //--> </tr> </table> <!-- body_eof //--> <!-- footer //--> <?php require(DIR_WS_INCLUDES . 'footer.php'); ?> <!-- footer_eof //--> </body> </html> <?php require(DIR_WS_INCLUDES . 'application_bottom.php'); ?> What is the code supposed to do, by the looks of it display a drop down. Better you post the whole file, so we can see the context too. echo ; looks wrong, unless you want a ; to show? can you wrap it in the code blocks too. Nic zappautomation Link to comment Share on other sites More sharing options...
technophobe Posted May 31, 2011 Author Share Posted May 31, 2011 I think the drop down was selecting the reason for contacting us, like sales, support and so on. zappautomation Link to comment Share on other sites More sharing options...
MrPhil Posted June 1, 2011 Share Posted June 1, 2011 Well, echo ; is certainly invalid PHP. Maybe earlier versions of PHP tolerated it, but PHP 5 is stricter. You can either get rid of that line completely, or change it to echo ' '; and the PHP error should go away. That's atrocious coding, too, constantly popping in and out of PHP. Whoever wrote that should be drawn and quartered! Link to comment Share on other sites More sharing options...
technophobe Posted June 1, 2011 Author Share Posted June 1, 2011 Thanks, that has worked. zappautomation Link to comment Share on other sites More sharing options...
Recommended Posts
Archived
This topic is now archived and is closed to further replies.