Jump to content
  • Checkout
  • Login
  • Get in touch

osCommerce

The e-commerce.

Double-quotes not working in advanced search


redrum

Recommended Posts

Posted

I was abit amazed when I found out that double-quotes search dont work in advanced search. This is a major bug and the search help text in a osc-original store even say:

"For example, "notebook computer" would generate a result set which match the exact string."

 

I first thought there was an error with my advanced_search_result.php, but I tried several stores including the osc-original store at http://demo.opensourcecms.com/oscommerce/advanced_search.php

 

Try these two searches and you can see it:

Hot Keys

"Hot Keys"

 

Does anyone have any solution for this major bug?

 

 

//Fredrik

  • 2 weeks later...
Posted

I was abit amazed when I found out that double-quotes search dont work in advanced search. This is a major bug and the search help text in a osc-original store even say:

"For example, "notebook computer" would generate a result set which match the exact string."

 

I first thought there was an error with my advanced_search_result.php, but I tried several stores including the osc-original store at http://demo.opensourcecms.com/oscommerce/advanced_search.php

 

Try these two searches and you can see it:

Hot Keys

"Hot Keys"

 

Does anyone have any solution for this major bug?

 

 

//Fredrik

 

The solution is fortunately VERY simple. In advanced_search_result.php find around line 51 the line that reads like this:

 

 

$keywords = $HTTP_GET_VARS['keywords'];

 

 

and CHANGE it to read like this:

 

 

$keywords = tep_db_prepare_input($HTTP_GET_VARS['keywords']);

 

 

The development team apparently forgot that they perform addslashes on all $HTTP_GET_VARS and that quote characters therefore have slashes added to them. The code to parse the keywords was correct but the input sent to it is not until run through the tep_db_prepare_input function.

Archived

This topic is now archived and is closed to further replies.

×
×
  • Create New...