♥FWR Media Posted December 7, 2010 Author Share Posted December 7, 2010 (edited) Hi I have just found an issue with articles 1.57 article-submit.php and article-topics.php Fatal error: Call to a member function retrieveDependencies() on a non-object in /home/electri3/public_html/includes/modules/ultimate_seo_urls5/main/bootstrap.php on line 298 I am guessing that it is the filenames being article-submit instead of article_submit and article-topics instead of article_topics Yup .. osCommerce filenames can have an underscore but never a hyphen. Ahhhh just checked .. Mr jackmcs is trying to take over yet another contribution of someone else and has ruined the code with bad filenames. Edited December 7, 2010 by FWR Media Quote Ultimate SEO Urls 5 PRO - Multi Language Modern, Powerful SEO Urls KissMT Dynamic SEO Meta & Canonical Header Tags KissER Error Handling and Debugging KissIT Image Thumbnailer Security Pro - Querystring protection against hackers ( a KISS contribution ) If you found my post useful please click the "Like This" button to the right. Please only PM me for paid work. Link to comment Share on other sites More sharing options...
pdcelec Posted December 16, 2010 Share Posted December 16, 2010 Hi I have a possible issue. With performance reporting enabled, my site is showing queries for the information box on every page request. Should they not be cached?. Quote Link to comment Share on other sites More sharing options...
pdcelec Posted December 16, 2010 Share Posted December 16, 2010 (edited) I am having a possible issue with links.php with the breadcrumb When I am here http: //www.electricalcitydotco.uk/electronics-suppliers-links-2_4.html and hover over the breadcrumb, I get http: //www. electricalcitydotco.uk/links.php?parentID=4 When I am here http: //www.electricalcitydotco.uk/electronics-links-0_2.html and hover over the breadcrumb, I get http: //www.electricalcitydotco.uk/links.php?parentID= Here is the section of code taken from a view source </div> <div class="grid_24 ui-widget infoBoxContainer"> <div class="ui-widget-header infoBoxHeading"><ul id="breadcrumb"><li><a href="http://www.electricalcity.co.uk" class="headerNavigation">Top</a> » </li><li><a href="http://www.electricalcity.co.uk/" class="headerNavigation">Catalog</a> » </li><li><a href="http://www.electricalcity.co.uk/links.php" class="headerNavigation">Links</a> » </li><li><a href="links.php?parentID=" class="headerNavigation">Electronics<b</a> » </li><li><a href="links.php?parentID=4" class="headerNavigation">Electronics Suppliers</a></li></ul> </div> </div> <div id="bodyContent" class="grid_16 push_4"> </a><h1>Links </h1> <div class="contentContainer"> <div class="contentText"> <h2>Below is our list of links for the <strong>Electronics Suppliers</strong> category.</h2> Suppliers of electronic components</div> Edited December 16, 2010 by pdcelec Quote Link to comment Share on other sites More sharing options...
♥FWR Media Posted December 16, 2010 Author Share Posted December 16, 2010 @pdcelec One at a time. With performance reporting enabled, my site is showing queries for the information box on every page request. Should they not be cached?. Depends .. USU5 PRO does not cache like USU5. Are the links in the information box always the same or do they rotate/change? Also did you reset the cache after installing the information contribution? When I am here http: //www.electricalcitydotco.uk/electronics-links-0_2.html and hover over the breadcrumb, I get http: //www.electricalcitydotco.uk/links.php?parentID= Yes that won't create an seo url as parentID is not a part of the links contribution which uses lPath. So looks like a problem in your code. Quote Ultimate SEO Urls 5 PRO - Multi Language Modern, Powerful SEO Urls KissMT Dynamic SEO Meta & Canonical Header Tags KissER Error Handling and Debugging KissIT Image Thumbnailer Security Pro - Querystring protection against hackers ( a KISS contribution ) If you found my post useful please click the "Like This" button to the right. Please only PM me for paid work. Link to comment Share on other sites More sharing options...
pdcelec Posted December 16, 2010 Share Posted December 16, 2010 (edited) regarding the information box: My pages stay the same. I am considering removing the info pages contrib and just having static pages as I dont really see a benefit to them. All I see is additional server load. Yes the cache was reset. Edited December 16, 2010 by pdcelec Quote Link to comment Share on other sites More sharing options...
pdcelec Posted December 16, 2010 Share Posted December 16, 2010 (edited) This is the code as taken from Links Manager 1.28 links.php http://addons.oscommerce.com/info/5272 { $breadcrumb->add($pathStr[$i], FILENAME_LINKS . '?parentID=' . tep_get_category_id($pathStr[$i])); } } ?> On the download pages, Jack has wrote - Changed code so that the breadcrumb link has the session ID attached. Edited December 16, 2010 by pdcelec Quote Link to comment Share on other sites More sharing options...
pdcelec Posted December 16, 2010 Share Posted December 16, 2010 regarding the information box: My pages stay the same. I am considering removing the info pages contrib and just having static pages as I dont really see a benefit to them. All I see is additional server load. Yes the cache was reset. I have another question about the cache. Is it best to use the osC cache as well as the KISSMt cache and USU5 cache or leave the standard one off? Quote Link to comment Share on other sites More sharing options...
♥FWR Media Posted December 16, 2010 Author Share Posted December 16, 2010 This is the code as taken from Links Manager 1.28 links.php http://addons.oscommerce.com/info/5272 { $breadcrumb->add($pathStr[$i], FILENAME_LINKS . '?parentID=' . tep_get_category_id($pathStr[$i])); } } ?> On the download pages, Jack has wrote - Changed code so that the breadcrumb link has the session ID attached. I can't see any code in the 1.28 version of Links Manager that changes the breadcrumb .. also $parentID seems to be used as a variable where lPath is used in the querystring. Either way .. nothing to do with USU5 PRO it seems. Quote Ultimate SEO Urls 5 PRO - Multi Language Modern, Powerful SEO Urls KissMT Dynamic SEO Meta & Canonical Header Tags KissER Error Handling and Debugging KissIT Image Thumbnailer Security Pro - Querystring protection against hackers ( a KISS contribution ) If you found my post useful please click the "Like This" button to the right. Please only PM me for paid work. Link to comment Share on other sites More sharing options...
pdcelec Posted December 16, 2010 Share Posted December 16, 2010 Changing it top this seems to do the trick $breadcrumb->add($pathStr[$i], tep_href_link(FILENAME_LINKS, 'lPath=' . $_GET['lPath'] . tep_get_category_id($pathStr[$i]), 'NONSSL')); Quote Link to comment Share on other sites More sharing options...
♥FWR Media Posted December 16, 2010 Author Share Posted December 16, 2010 (edited) Changing it top this seems to do the trick $breadcrumb->add($pathStr[$i], tep_href_link(FILENAME_LINKS, 'lPath=' . $_GET['lPath'] . tep_get_category_id($pathStr[$i]), 'NONSSL')); Yes .. as I said .. the links contribution uses lPath in the querystring. Nothing to do with USU5 PRO. This is a beta testing forum, you seem to be using it as a support thread. Edited December 16, 2010 by FWR Media Quote Ultimate SEO Urls 5 PRO - Multi Language Modern, Powerful SEO Urls KissMT Dynamic SEO Meta & Canonical Header Tags KissER Error Handling and Debugging KissIT Image Thumbnailer Security Pro - Querystring protection against hackers ( a KISS contribution ) If you found my post useful please click the "Like This" button to the right. Please only PM me for paid work. Link to comment Share on other sites More sharing options...
pdcelec Posted December 17, 2010 Share Posted December 17, 2010 I was beta testing the contribution, and I thought that as support was added for other contributions, that I would report compatibility issues with other contributions. Links.php in version 1.28 uses $parentID and as such, USU5 is not compatible, without either a modification in links.php or USU5. Quote Link to comment Share on other sites More sharing options...
♥FWR Media Posted December 17, 2010 Author Share Posted December 17, 2010 (edited) I was beta testing the contribution, and I thought that as support was added for other contributions, that I would report compatibility issues with other contributions. Links.php in version 1.28 uses $parentID and as such, USU5 is not compatible, without either a modification in links.php or USU5. I appreciate you beta testing and I appreciate you bringing the issue to my notice. A contribution can try and be "compatible" with other contributions but if those contributions are developed badly and change key factors on a version by version basis then there's nothing to be done. This does not seem to be the case in this instance, I cannot see any instance of a querystring key parentID in the install instructions for the version you mention .. and I quote again .. I can't see any code in the 1.28 version of Links Manager that changes the breadcrumb .. also $parentID seems to be used as a variable where lPath is used in the querystring. Edited December 17, 2010 by FWR Media Quote Ultimate SEO Urls 5 PRO - Multi Language Modern, Powerful SEO Urls KissMT Dynamic SEO Meta & Canonical Header Tags KissER Error Handling and Debugging KissIT Image Thumbnailer Security Pro - Querystring protection against hackers ( a KISS contribution ) If you found my post useful please click the "Like This" button to the right. Please only PM me for paid work. Link to comment Share on other sites More sharing options...
pdcelec Posted December 18, 2010 Share Posted December 18, 2010 I appreciate you beta testing and I appreciate you bringing the issue to my notice. A contribution can try and be "compatible" with other contributions but if those contributions are developed badly and change key factors on a version by version basis then there's nothing to be done. This does not seem to be the case in this instance, I cannot see any instance of a querystring key parentID in the install instructions for the version you mention .. and I quote again .. I have just downloaded it again from http://addons.oscommerce.com/info/5272 and the breadcrumb in catalog/links.php does have $breadcrumb->add($pathStr[$i], FILENAME_LINKS . '?parentID=' . tep_get_category_id($pathStr[$i])); } } ?> <!doctype html public "-//W3C//DTD HTML 4.01 Transitional//EN"> <html <?php echo HTML_PARAMS; ?>> Is this the version to which you are referring? Quote Link to comment Share on other sites More sharing options...
♥FWR Media Posted December 18, 2010 Author Share Posted December 18, 2010 (edited) I have just downloaded it again from http://addons.oscommerce.com/info/5272 and the breadcrumb in catalog/links.php does have $breadcrumb->add($pathStr[$i], FILENAME_LINKS . '?parentID=' . tep_get_category_id($pathStr[$i])); } } ?> <!doctype html public "-//W3C//DTD HTML 4.01 Transitional//EN"> <html <?php echo HTML_PARAMS; ?>> Is this the version to which you are referring? Ok Paul . .then tell him he's written his script badly .. not much I can do about it. Nothing to do with USU5 PRO. If the script was written correctly using lPath then this contribution would output an seo url. I do appreciate you letting me know though .. if I hear this in the future I'll just send them back to the author of the links contribution. Edited December 18, 2010 by FWR Media Quote Ultimate SEO Urls 5 PRO - Multi Language Modern, Powerful SEO Urls KissMT Dynamic SEO Meta & Canonical Header Tags KissER Error Handling and Debugging KissIT Image Thumbnailer Security Pro - Querystring protection against hackers ( a KISS contribution ) If you found my post useful please click the "Like This" button to the right. Please only PM me for paid work. Link to comment Share on other sites More sharing options...
pdcelec Posted December 18, 2010 Share Posted December 18, 2010 Ok Paul . .then tell him he's written his script badly .. not much I can do about it. Nothing to do with USU5 PRO. I agree with you, your code is always much cleaner. I was just pointing out what I found. Quote Link to comment Share on other sites More sharing options...
pdcelec Posted December 18, 2010 Share Posted December 18, 2010 (edited) I have found another issue with Links 1.28. Going forward I get http://www dotelectricalcity.co.uk/links.php http://www dotelectricalcity.co.uk/electronics-links-0_2.html http://www dotelectricalcity.co.uk/electronics-suppliers-links-2_4.html but then going back, it becomes http://www dotelectricalcity.co.uk/electronics-links-2.html http://www dotelectricalcity.co.uk/links.php Can you recommend which version of Links manager to use and I will replace this version Edited December 18, 2010 by pdcelec Quote Link to comment Share on other sites More sharing options...
♥FWR Media Posted December 21, 2010 Author Share Posted December 21, 2010 The latest package has been added .. same address different filename .. Ultimate_Seo_Urls_5_PRO_packaged_r194.tar.gz The only change is a correction to the application_top code which returns the filename .. function usu5_base_filename(). I had copied across the standard 2.3 code but neglected to change the long arrays to _SERVER superglobals. Quote Ultimate SEO Urls 5 PRO - Multi Language Modern, Powerful SEO Urls KissMT Dynamic SEO Meta & Canonical Header Tags KissER Error Handling and Debugging KissIT Image Thumbnailer Security Pro - Querystring protection against hackers ( a KISS contribution ) If you found my post useful please click the "Like This" button to the right. Please only PM me for paid work. Link to comment Share on other sites More sharing options...
♥FWR Media Posted December 22, 2010 Author Share Posted December 22, 2010 This has now been released. http://www.oscommerce.com/forums/topic/336702-ultimate-seo-urls-5-by-fwr-media/page__view__findpost__p__1553716 Download: http://addons.oscommerce.com/info/6768 Thanks to all the beta testers who gave feedback: GLCustoms jwilkins tomh Burt mikeman Mister_dj motorcity Manniman Greecom pdcelec JFrancis acropolis Quote Ultimate SEO Urls 5 PRO - Multi Language Modern, Powerful SEO Urls KissMT Dynamic SEO Meta & Canonical Header Tags KissER Error Handling and Debugging KissIT Image Thumbnailer Security Pro - Querystring protection against hackers ( a KISS contribution ) If you found my post useful please click the "Like This" button to the right. Please only PM me for paid work. Link to comment Share on other sites More sharing options...
mikeman Posted December 25, 2010 Share Posted December 25, 2010 This has now been released. http://www.oscommerce.com/forums/topic/336702-ultimate-seo-urls-5-by-fwr-media/page__view__findpost__p__1553716 Download: http://addons.oscommerce.com/info/6768 Thanks to all the beta testers who gave feedback: GLCustoms jwilkins tomh Burt mikeman Mister_dj motorcity Manniman Greecom pdcelec JFrancis acropolis Great work! Merry Christmas! Quote Link to comment Share on other sites More sharing options...
Guest Posted December 31, 2010 Share Posted December 31, 2010 Happy Holidays Rob, Updated my 2.3.1 SEO 5 to your latest contribution, SEO PRO and install went very well. But the rewrite is no longer working? It was setup and working great in 5, do I have to make any mods to get it to work in the PRO version? Cheers Quote Link to comment Share on other sites More sharing options...
♥FWR Media Posted December 31, 2010 Author Share Posted December 31, 2010 Happy Holidays Rob, Updated my 2.3.1 SEO 5 to your latest contribution, SEO PRO and install went very well. But the rewrite is no longer working? It was setup and working great in 5, do I have to make any mods to get it to work in the PRO version? Cheers "No longer working" is not descriptive enough Peder. Quote Ultimate SEO Urls 5 PRO - Multi Language Modern, Powerful SEO Urls KissMT Dynamic SEO Meta & Canonical Header Tags KissER Error Handling and Debugging KissIT Image Thumbnailer Security Pro - Querystring protection against hackers ( a KISS contribution ) If you found my post useful please click the "Like This" button to the right. Please only PM me for paid work. Link to comment Share on other sites More sharing options...
Guest Posted December 31, 2010 Share Posted December 31, 2010 (edited) "No longer working" is not descriptive enough Peder. If I select under "Choose url format" rewrite like I had on SEO 5 I'm getting following message, The page isn't redirecting properly Firefox has detected that the server is redirecting the request for this address in a way that will never complete. I did clear the cache Edited December 31, 2010 by pederb Quote Link to comment Share on other sites More sharing options...
♥FWR Media Posted December 31, 2010 Author Share Posted December 31, 2010 (edited) If I select under "Choose url format" rewrite like I had on SEO 5 I'm getting following message, The page isn't redirecting properly Firefox has detected that the server is redirecting the request for this address in a way that will never complete. I did clear the cache Ok You need to go to the support thread and see the last post .. http://forums.oscomm...ost__p__1555445 Then after making those changes look two posts up for configuration help. Your configuration file is probably wrong. Edited December 31, 2010 by FWR Media Quote Ultimate SEO Urls 5 PRO - Multi Language Modern, Powerful SEO Urls KissMT Dynamic SEO Meta & Canonical Header Tags KissER Error Handling and Debugging KissIT Image Thumbnailer Security Pro - Querystring protection against hackers ( a KISS contribution ) If you found my post useful please click the "Like This" button to the right. Please only PM me for paid work. Link to comment Share on other sites More sharing options...
Guest Posted December 31, 2010 Share Posted December 31, 2010 Ok You need to go to the support thread and see the last post .. http://forums.oscomm...ost__p__1555445 Then after making those changes look two posts up for configuration help. Your configuration file is probably wrong. Cool Thxs Quote Link to comment Share on other sites More sharing options...
Guest Posted January 1, 2011 Share Posted January 1, 2011 Cool Thxs It's now working great, thxs Cheers Quote Link to comment Share on other sites More sharing options...
Recommended Posts
Join the conversation
You can post now and register later. If you have an account, sign in now to post with your account.