Freelance GD Posted June 8, 2009 Posted June 8, 2009 I installed a template version of OSCommerce. Probably V2.2 RC2 (I am a newbie, my Admin Panel shows the same) and everything seems to be working fine instead of a small issue. I discounted a product by 20% and everything is fine but when I go to special.php page it shows a line on discounted price instead of actual price. Please help me out. I am pasting the code here: <?php /* $Id: specials.php,v 1.49 2003/06/09 22:35:33 hpdl Exp $ osCommerce, Open Source E-Commerce Solutions http://www.oscommerce.com Copyright (c) 2003 osCommerce Released under the GNU General Public License */ require('includes/application_top.php'); require(DIR_WS_LANGUAGES . $language . '/' . FILENAME_SPECIALS); $breadcrumb->add(NAVBAR_TITLE, tep_href_link(FILENAME_SPECIALS)); ?> <!doctype html public "-//W3C//DTD HTML 4.01 Transitional//EN"> <html <?php echo HTML_PARAMS; ?>> <head> <meta http-equiv="Content-Type" content="text/html; charset=<?php echo CHARSET; ?>"> <title><?php echo TITLE; ?></title> <base href="<?php echo (($request_type == 'SSL') ? HTTPS_SERVER : HTTP_SERVER) . DIR_WS_CATALOG; ?>"> <link rel="stylesheet" type="text/css" href="stylesheet.css"> </head> <body marginwidth="0" marginheight="0" topmargin="0" bottommargin="0" leftmargin="0" rightmargin="0"> <!-- header //--> <?php require(DIR_WS_INCLUDES . 'header.php'); ?> <!-- header_eof //--> <!-- body //--> <table border="0" width="100%" cellspacing="0" cellpadding="0"> <tr> <td valign="top"> <!-- left_navigation //--> <?php require(DIR_WS_INCLUDES . 'column_left.php'); ?> <!-- left_navigation_eof //--> </td> <!-- body_text //--> <td width="100%" valign="top"><table border="0" width="100%" cellspacing="0" cellpadding="0"> <?php /* require(DIR_WS_BOXES . 'panel_top.php'); */ ?> <? tep_draw_heading_top();?> <? new contentBoxHeading_ProdNew($info_box_contents);?> <? tep_draw_heading_top_1();?> <?php $specials_query_raw = "select p.products_id, pd.products_name, p.products_price, p.products_tax_class_id, p.products_image, s.specials_new_products_price from " . TABLE_PRODUCTS . " p, " . TABLE_PRODUCTS_DESCRIPTION . " pd, " . TABLE_SPECIALS . " s where p.products_status = '1' and s.products_id = p.products_id and p.products_id = pd.products_id and pd.language_id = '" . (int)$languages_id . "' and s.status = '1' order by s.specials_date_added DESC"; $specials_split = new splitPageResults($specials_query_raw, MAX_DISPLAY_SPECIAL_PRODUCTS); if (($specials_split->number_of_rows > 0) && ((PREV_NEXT_BAR_LOCATION == '1') || (PREV_NEXT_BAR_LOCATION == '2'))) { ?> <table border="0" width="100%" cellspacing="0" cellpadding="0" class="result box_width_cont"> <tr> <td><?php echo $specials_split->display_count(TEXT_DISPLAY_NUMBER_OF_SPECIALS); ?></td> <td class="result_right"><?php echo TEXT_RESULT_PAGE . ' ' . $specials_split->display_links(MAX_DISPLAY_PAGE_LINKS, tep_get_all_get_params(array('page', 'info', 'x', 'y'))); ?></td> </tr> </table> <?php echo tep_draw_result_top(); ?> <?php } ?> <?php $row = 0; $specials_query = tep_db_query($specials_split->sql_query); $row = 0; $col = 0; $info_box_contents = array(); while ($specials = tep_db_fetch_array($specials_query)) { $specials['products_name'] = tep_get_products_name($specials['products_id']); // ---------- $product_query = tep_db_query("select products_description, products_id from " . TABLE_PRODUCTS_DESCRIPTION . " where products_id = '" . (int)$specials['products_id'] . "' and language_id = '" . (int)$languages_id . "'"); $product = tep_db_fetch_array($product_query); $p_desc = substr($product['products_description'], 0, MAX_DESCR_1); $p_id = $product['products_id']; $p_pic = '<a href="' . tep_href_link(FILENAME_PRODUCT_INFO, 'products_id=' . $specials['products_id']) . '">' . tep_image(DIR_WS_IMAGES . $specials['products_image'], $specials['products_name'], SMALL_IMAGE_WIDTH, SMALL_IMAGE_HEIGHT) . '</a>'; $p_name = '<a href="' . tep_href_link(FILENAME_PRODUCT_INFO, 'products_id=' . $specials['products_id']) . '">' . $specials['products_name'] . '</a>'; $p_price = $currencies->display_price($specials['products_price'], tep_get_tax_rate($specials['products_tax_class_id'])).'</strong> <s>'.$currencies->display_price($specials['specials_new_products_price'],'').'</s>'; // ---------- $info_box_contents[$row][$col] = array('align' => 'center', 'params' => ' valign="top"', 'text' => ''.tep_draw_prod_top().' <table cellspacing="0" cellpadding="0" border="0" > <tr> <td width="157" height="52" style=" vertical-align:middle;"> '.$p_name.'</td> </tr> <tr> <td width="157" height="156" class="pic" align="center">'.$p_pic.'</td> </tr> <tr> <td width="157" height="45">'.$p_desc.'...</td> </tr> <tr> <td width="157" height="44"> <table cellspacing="0" cellpadding="0" border="0" > <tr> <td width="87" height="29"><span>'.$p_price.'</span></td> </tr> <tr><td height="20"> <table cellpadding="0" cellspacing="0" border="0" style=" width:10px;"> <tr><td><a href="' . tep_href_link('product_info.php?products_id='.$p_id) . '">'.tep_image_button("button_details.gif").'</a></td> <td><img src="images/spacer.gif" width="5" height="1" alt=""></td> <td><a href="'.tep_href_link("products_new.php","action=buy_now&products_id=".$p_id).'">'.tep_image_button('button_add_to_cart1.gif').'</a><br></td></tr> </table> </td></tr> </table> </td> </tr> </table> '.tep_draw_prod_bottom()); $col ++; if ($col > 2) { $col = 0; $row ++; } } new contentBox($info_box_contents); ?> <?php if (($specials_split->number_of_rows > 0) && ((PREV_NEXT_BAR_LOCATION == '2') || (PREV_NEXT_BAR_LOCATION == '3'))) { ?> <?php echo tep_draw_result_bottom(); ?> <table border="0" width="100%" cellspacing="0" cellpadding="0" class="result box_width_cont"> <tr> <td><?php echo $specials_split->display_count(TEXT_DISPLAY_NUMBER_OF_SPECIALS); ?></td> <td class="result_right"><?php echo TEXT_RESULT_PAGE . ' ' . $specials_split->display_links(MAX_DISPLAY_PAGE_LINKS, tep_get_all_get_params(array('page', 'info', 'x', 'y'))); ?></td> </tr> </table> <?php } ?> <? tep_draw_heading_bottom_1();?> <? tep_draw_heading_bottom();?> </td> <td valign="top"> <!-- right_navigation //--> <?php require(DIR_WS_INCLUDES . 'column_right.php'); ?> <!-- right_navigation_eof //--> </td> </tr> </table> <!-- body_eof //--> <!-- footer //--> <?php require(DIR_WS_INCLUDES . 'footer.php'); ?> <!-- footer_eof //--> </body> </html> <?php require(DIR_WS_INCLUDES . 'application_bottom.php'); ?> Thanking you in anticipation.
sharma.atul85 Posted June 8, 2009 Posted June 8, 2009 $p_price = $currencies->display_price($specials['products_price'], tep_get_tax_rate($specials['products_tax_class_id'])).'</strong> <s>'.$currencies->display_price($specials['specials_new_products_price'],'').'</s>'; in above code replace code by this : $p_price = <s>.$currencies->display_price($specials['products_price'], tep_get_tax_rate($specials['products_tax_class_id'])).'</s></strong>'. $currencies->display_price($specials['specials_new_products_price'],'');
landylin Posted June 8, 2009 Posted June 8, 2009 well, you are a good expert.pls come to my blog www.watches-space.com. any suggestion could you give ?
sharma.atul85 Posted June 8, 2009 Posted June 8, 2009 well I have few sugestion to u first change that marquee to right to left as reading is difficult in current mode plus make products images in middle on right scrolling products and use better background in products images and dn't use black colored text ..doesn't make a sense thats it!!
Freelance GD Posted June 8, 2009 Author Posted June 8, 2009 $p_price = $currencies->display_price($specials['products_price'], tep_get_tax_rate($specials['products_tax_class_id'])).'</strong> <s>'.$currencies->display_price($specials['specials_new_products_price'],'').'</s>'; in above code replace code by this : $p_price = <s>.$currencies->display_price($specials['products_price'], tep_get_tax_rate($specials['products_tax_class_id'])).'</s></strong>'. $currencies->display_price($specials['specials_new_products_price'],''); Thank you Sharma but now I am getting this error: http://shop.earnerpoint.com/specials.php Parse error: syntax error, unexpected '<' in /home/earnerpo/public_html/shop/specials.php on line 90 Where line 90 is $p_price = <s>.$currencies->display_price($specials['products_price'], tep_get_tax_rate($specials['products_tax_class_id'])).'</s></strong>'. Edit: I fixed the error but strike line is gone. This is what I did: $p_price = $currencies->display_price($specials['specials_new_products_price'], tep_get_tax_rate($specials['products_tax_class_id'])).'</strong> <s>'.$currencies->display_price($specials['products_price'],'').'</s>'; Please help. Thank you
Nullachtfuffzehn Posted June 8, 2009 Posted June 8, 2009 Replace the code with this snippet: $p_price = '<s>'.$currencies->display_price($specials['products_price'], tep_get_tax_rate($specials['products_tax_class_id'])).'</s></strong>'.
Freelance GD Posted June 8, 2009 Author Posted June 8, 2009 Edit Edit: Fixed it. Text Decoration was set to none is style sheet. Removed that and it worked. Thank you guys for helping me out.
Freelance GD Posted June 8, 2009 Author Posted June 8, 2009 I believe I am not bumping. Post is on page 1 and 3rd position. I just dont see Edit Option. Problem: I want to reduce the gap between the Product Image and short description. Where can I find it? I tried it in my style sheet but couldn't find. http://www.shop.earnerpoint.com Thanking you in anticipation.
Nullachtfuffzehn Posted June 8, 2009 Posted June 8, 2009 I already answered to this question in another thread! Check the layout of the new products box. There is a hardcoded TD height of 156px somwhere.
Freelance GD Posted June 8, 2009 Author Posted June 8, 2009 Honka! I fixed the issue for new products but the issue is still there on the index. Please check that. I tried to find 156 in whats_new.php but couldnt find. Please help me out. Thank you whats_new.php code: <?php /* $Id: whats_new.php,v 1.31 2003/02/10 22:31:09 hpdl Exp $ osCommerce, Open Source E-Commerce Solutions http://www.oscommerce.com Copyright (c) 2003 osCommerce Released under the GNU General Public License */ if ($random_product = tep_random_select("select products_id, products_image, products_tax_class_id, products_price from " . TABLE_PRODUCTS . " where products_status = '1' order by products_date_added desc limit " . MAX_RANDOM_SELECT_NEW)) { ?> <!-- whats_new //--> <tr> <td class=""> <?php $random_product['products_name'] = tep_get_products_name($random_product['products_id']); $random_product['specials_new_products_price'] = tep_get_products_special_price($random_product['products_id']); $info_box_contents = array(); $info_box_contents[] = array('text' => BOX_HEADING_WHATS_NEW); new infoBoxHeading($info_box_contents, false, false, tep_href_link(FILENAME_PRODUCTS_NEW)); if (tep_not_null($random_product['specials_new_products_price'])) { $whats_new_price = '<s>' . $currencies->display_price($random_product['products_price'], tep_get_tax_rate($random_product['products_tax_class_id'])) . '</s> '; $whats_new_price .= '<span class="productSpecialPrice">' . $currencies->display_price($random_product['specials_new_products_price'], tep_get_tax_rate($random_product['products_tax_class_id'])) . '</span>'; } else { $whats_new_price = $currencies->display_price($random_product['products_price'], tep_get_tax_rate($random_product['products_tax_class_id'])); } $info_box_contents = array(); $info_box_contents[] = array('align' => 'center ', 'text' => ' <table cellspacing="14" cellpadding="0" border="0"> <tr><td height="111" align="center" class="pic"> <br style="line-height:20px"> <a href="' . tep_href_link(FILENAME_PRODUCT_INFO, 'products_id=' . $random_product['products_id']) . '">' . tep_image(DIR_WS_IMAGES . $random_product['products_image'], $random_product['products_name'], SMALL_IMAGE_WIDTH, SMALL_IMAGE_HEIGHT) . '</a> <br style="line-height:1px;"><br style="line-height:5px;"> </td></tr> <tr><td height="38" align="center"> <a href="' . tep_href_link(FILENAME_PRODUCT_INFO, 'products_id=' . $random_product['products_id']) . '">' . substr( $random_product['products_name'],0,MAX_DESCR_NAME) . '</a> <br><br style="line-height:13px"> <span height=40 class="productSpecialPrice">' . $whats_new_price.'</span> </td></tr> </table> '); new infoBox($info_box_contents); ?> </td> </tr> <!-- whats_new_eof //--> <?php } ?>
Nullachtfuffzehn Posted June 8, 2009 Posted June 8, 2009 Check the catalog/includes/modules/new_products.php please.
Freelance GD Posted June 8, 2009 Author Posted June 8, 2009 Thank you guys. You were of great help. Thanks again.
Recommended Posts
Archived
This topic is now archived and is closed to further replies.