Is that a bug?

[limor01]

Hello

 

I have been using the module for a month now.

I have never been able to see the order in "PayPal IPN - Start" status.

 

The order information is saved on the confirmation() function

 

but the status is taken from the order object instead of the member variable $order_status of this class.

So I fixed it by adding the variable to the class declaration like:

 

class paypal_ipn {

var $code, $title, $description, $enabled, $identifier, $order_status;

 

and

if ((int)MODULE_PAYMENT_PAYPAL_IPN_PREPARE_ORDER_STATUS_ID > 0) {

$this->order_status = (int)MODULE_PAYMENT_PAYPAL_IPN_PREPARE_ORDER_STATUS_ID;

}

 

 

and made the following change to the data array sent to the database:

 

$sql_data_array = array('customers_id' => $customer_id,

bla bla bla

bla bla bla

bla bla bla

bla bla bla

bla bla bla

'orders_status' => $this->order_status,

bla bla bla

bla bla bla

bla bla bla

bla bla bla

);

 

 

also in

 

 

//+1.4

$sql_data_array = array('orders_id' => $insert_id,

'orders_status_id' => $this->order_status,

'date_added' => 'now()',

'customer_notified' => '0',

'comments' => $order->info['comments']);

 

tep_db_perform(TABLE_ORDERS_STATUS_HISTORY, $sql_data_array);

//-1.4

 

 

 

 

All of this looks like something nobody can miss so I am thinking I did a mess :-) and this is not a bug as I think.

The code goes back so long that I am not sure If my fix is true.

 

 

Thanks

[web-project]

No this is not bug, simply php object oriented way to say $order_status

[limor01]

No this is not bug, simply php object oriented way to say $order_status

 

 

I know that...

You didnt read the original paypal IPN code.

I was refering the fact that the wrong variable was used. My bold text is the variable that I think should have been used.