Jump to content
  • Checkout
  • Login
  • Get in touch

osCommerce

The e-commerce.

CMS for OSCOMMERCE


lxfx

Recommended Posts

Looks really great, but some constructive critisism.

 

In the admin side you could put the text in a language file instead of hard coding it into the page.

 

Also on catalog side I get this:

 

Fatal error: Failed opening required 'includes/boxes/cms_box.php' (include_path='.:/usr/share/pear') in /home/voimaharjo/public_html/catalog/includes/column_left.php on line 32

 

Because in column_left.php it says:

 

require(DIR_WS_BOXES . 'cms_box.php');  

 

When it should be:

 

require(DIR_WS_BOXES . 'cms.php');  

 

And could the box use a list instead of pulldown menu ?

 

In the admin side you could onlly list changes to configure.php, not the whole thing. Also the code is pretty cryptic (you probably took it straigth from macig mushrooms)

 

Couldnt

// Zneak CMS

 define('DIR_WS_UPLOAD_PICS', HTTP_CATALOG_SERVER.'/shop_test/products/images/cms_upload/');   // image upload path required

 define('DIR_FS_UPLOAD_PICS', 'c:/inetpub/wwwroot/magicmushrooms/shop_test/products/images/cms_upload//');   // FS image upload path required

 

Just as well be:

 

  // Zneak CMS

 define('DIR_WS_UPLOAD_PICS', DIR_WS_IMAGES . 'cms_upload/');   // image upload path required

 define('DIR_FS_UPLOAD_PICS', DIR_FS_DOCUMENT_ROOT . DIR_WS_CATALOG . DIR_WS_IMAGES . 'cms_upload/');   // FS image upload path required

 

HTML:

 

$s.= "</SELECT><input type='submit' name='Submit' value='Go'></FORM>n";

 

why not:

 

$s.= "</select><input type="submit" name="Submit" value="Go"></select>n";

 

sample:

 

error_log("MySQL Abfrage fehlgeschlagen!nSQL Befehl : $sqln" . mysql_error($mysql_verbindung),0);

 

I do not like it when code is made in some other language than english as it makes it harder for the large majority to fix. When you use english there are alot of people who can help with fixing errors.

 

Also, could the code from catalog side (cms_ind.php) be moved to admin side as it would make more sense.

 

Just some little 0.1 release issues, I guess. Otherwise looks really nice. Hope you are planning to develop this contribution further. With a little fixing this would be a "must have" contribution. Much better way of handling content than the language files. If you need some help with cleaning the html and language files, let me know.

"Use no way as way, have no limitation as limitation." - Bruce Lee

Link to comment
Share on other sites

we will adapt the code and upload it asap

 

cheers!

 

next thing we?re planning is to kinda have the options of the forum to add links, make bold tags etc. also the image positioning is not very well done at the moment....

 

anybody who would like to support us... please get back to us

 

lx

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Paste as plain text instead

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

×
×
  • Create New...