Jump to content
  • Checkout
  • Login
  • Get in touch

osCommerce

The e-commerce.

Product Notifications mess up Search-Engine Safe URLS


wider

Recommended Posts

Dear Colleagues,

 

on completion of the checkout process, the customer may select the products to be notified about.

 

Now, this $notify_string in this line of checkout_success.php

 

 

    tep_redirect(tep_href_link(FILENAME_DEFAULT, $notify_string, 'SSL'));

 

seems to mess up the search-engine safe urls to something like:

/72?osCsid=061894272f24654a0d9ac3a246a8dcc7]http://looks.seligmanfox.de/72/osCsid/0618...d9ac3a246a8dcc7

 

That, obviously, is not so nice.

Does anyone have an idea how this could be fixed?

Thanks in advance!

 

Greetings!

german

Link to comment
Share on other sites

Thanks Linda.

 

Yes, I've tried that. Yes, it works but, to be frank, I really value the idea of having search-engine safe urls.

:?

Would there be a way to bypass the 'safe' features for this page/link only?

 

Thanks so far!

 

Cheerio,

German

 

(Christian, I'll do the bug report.)

Link to comment
Share on other sites

wider,

 

change the line that you listed. This will work for this link and any other links that use the tep_href_link()

 

as long as your version of html_output.php contains the last parameter ''$search_engine_safe = true"

 

tep_redirect(tep_href_link(FILENAME_DEFAULT, $notify_string, 'SSL', '', 'false'));

Link to comment
Share on other sites

Thanx Hobbzilla!

 

Sounded like an easy enough fix. I't didn't quite do it for me, though.

 

Instead of this URL

/80]http://looks.seligmanfox.de/80/osCsid/53a5...d4e/notify[]/80

 

I know get this one:

http://looks.seligmanfox.de/notify%5B%5D

 

Equally unsuitable.

There is one little side-effect: Since I tried your fix, I can't work in Search-Engine UN-Safe mode anymore. It seems to strip als osCIDs of the urls. I only made that one change... It's a bit frightening. Any idea?

 

I am still grateful for comments!

Thanks!

German

Link to comment
Share on other sites

Think I figured it out:

 

(Thanks to Hobbzillas jumpstarting):

 

The string needs to be:

tep_redirect(tep_href_link(FILENAME_DEFAULT, $notify_string, 'NONSSL', 'true', ''));

 

Just got it by playing around. Doesn't make a lot of logical sense to me, but works.

That's what counts for me at the moments.

Thanks for your help! :P

German

Link to comment
Share on other sites

Well, I guess I should have tried it before posting my suggestion! :)

 

Glad you found out a solution..

 

I (currently) have a cookie only site.. & my solution did work for me..

for anyone else reading this..

Link to comment
Share on other sites

Archived

This topic is now archived and is closed to further replies.

×
×
  • Create New...