Jump to content
dev osCommerce
Forum
  • Checkout
  • Login
  • Contact Us
  • Get in touch

osCommerce

The e-commerce.

New Demo
Our Partners

New Price Update wrong signs after shipping link

hunig

By hunig
in General Support

Recommended Posts

hunig

hunig

Posted
Posted

Hello all,

 

After installing " New Price Update", witch works fine so far.

 

I have two problems

 

1st. It shows those " "> " signs after the tax and shipping info.

 

2nd. If there is no product variation it shows the tax and shipping info two times.

 

I will post my product_info.php, maybe someone can help me ... i am seaching for the last three days but I am a beginner in java and php. :blush: :angry:

 

Thanks in advance

 

swen

 

<?php
/*
 $Id: product_info.php,v 1.97 2003/07/01 14:34:54 hpdl Exp $

 osCommerce, Open Source E-Commerce Solutions
 [url="http://www.oscommerce.com"]http://www.oscommerce.com[/url]

 Copyright © 2003 osCommerce

 Released under the GNU General Public License
*/

 require('includes/application_top.php');

 require(DIR_WS_LANGUAGES . $language . '/' . FILENAME_PRODUCT_INFO);

 $product_check_query = tep_db_query("select count(*) as total from " . TABLE_PRODUCTS . " p, " . TABLE_PRODUCTS_DESCRIPTION . " pd where p.products_status = '1' and p.products_id = '" . (int)$HTTP_GET_VARS['products_id'] . "' and pd.products_id = p.products_id and pd.language_id = '" . (int)$languages_id . "'");
 $product_check = tep_db_fetch_array($product_check_query);
?>
<!doctype html public "-//W3C//DTD HTML 4.01 Transitional//EN">
<html <?php echo HTML_PARAMS; ?>
<head>
<?php
/*** Begin Header Tags SEO ***/
if ( file_exists(DIR_WS_INCLUDES . 'header_tags.php') ) {
 require(DIR_WS_INCLUDES . 'header_tags.php');
} else {
?>
 <title><?php echo TITLE; ?></title>
<?php
}
/*** End Header Tags SEO ***/
?>
<base href="<?php echo (($request_type == 'SSL') ? HTTPS_SERVER : HTTP_SERVER) . DIR_WS_CATALOG; ?>">
<link rel="stylesheet" type="text/css" href="stylesheet.css">
<!-- Attrib price update  //-->
<script language="javascript">
<!--
  function FormatNumber(num)
  {
    if(isNaN(num)) { num = "0"; }
    sign = (num == (num = Math.abs(num)));
    num = Math.floor(num*100+0.50000000001);
    cents = num%100;
    num = Math.floor(num/100).toString();
    if(cents<10) { cents = "0" + cents; }
    for (var i = 0; i < Math.floor((num.length-(1+i))/3); i++)
    {
      num = num.substring(0,num.length-(4*i+3))+','+ num.substring(num.length-(4*i+3));
    }
    return (((sign)?'':'-') + num + '.' + cents);
  }

    function FormatNumber1(num)
 {
   if(isNaN(num)) { num = "0"; }
   sign = (num == (num = Math.abs(num)));
   num = Math.floor(num*1+0.50000000001);
   cents = num%100;
   num = Math.floor(num/100).toString();
   if(cents<10) { cents = "0" + cents; }
   for (var i = 0; i < Math.floor((num.length-(1+i))/3); i++)
   {
     num = num.substring(0,num.length-(4*i+3))+','+ num.substring(num.length-(4*i+3));
   }
   return (((sign)?'':'-') + num + ',' + cents);
 }

 function showPrice(form)
 {
  var currencysymbol1 = "";
   var currencysymbol2 = "";
   var myTotalPrice = 0;
   var showUP = 0;
   var myMathProblem = "";
   myItemPrice = parseFloat(form.nuPrice.value);

  myDollarSign2 = form.nuPrice.value.indexOf("EUR",0)
  if ( myDollarSign2 != "-1" )
  {
     currencysymbol1 = "";
    currencysymbol2 = " EUR";
  } else {
    currencysymbol1 = "$";
    currencysymbol2 = "";
  }

  for (var i = 0; i < form.elements.length; i++)
   {
     var e = form.elements[i];
     if ( e.type == 'select-one' )
     {
       showUP = 1;
       Item = e.selectedIndex;
       myPrice = e.options[item].text;
       myDollarSign = myPrice.indexOf("$",0)
       if ( myDollarSign != "-1" )
       {
       currencysymbol1 = "$";
       currencysymbol2 = "";
         myParSign = myPrice.indexOf(")", myDollarSign);
         myAttributeString = myPrice.substring(myDollarSign+1, myParSign);
         myAttributeString = myAttributeString.replace(/,/,"");
         myAttributePrice = parseFloat(myAttributeString);
         myMathProblem = myPrice.charAt(myDollarSign - 1);
       } else {
        myDollarSign1 = myPrice.indexOf("(",0)
        if ( myDollarSign1 != "-1" )
        {
        currencysymbol1 = "";
         currencysymbol2 = " EUR";
        myParSign = myPrice.indexOf(")", myDollarSign1);
        myAttributeString = myPrice.substring(myDollarSign1+1, myParSign);
        myAttributeString = myAttributeString.replace(/,/,"");
        myAttributePrice = parseFloat(myAttributeString);
        myMathProblem = myPrice.charAt(myDollarSign1 - 1);
        } else {
        myAttributePrice = 0;
        }

     }
         if (myMathProblem == "-")
         {
           myTotalPrice = myTotalPrice - myAttributePrice;
         } else {
           myTotalPrice = myTotalPrice + myAttributePrice;
         }
     }
   }
   if ( showUP )
   {
     myDollarSign3 = form.nuPrice.value.indexOf(".",0)
     if ( myDollarSign3 != "-1" )
     {
       myTotalPrice = FormatNumber(myTotalPrice + myItemPrice);
     } else {
       myTotalPrice = FormatNumber1(myTotalPrice + myItemPrice);
     }
       document.getElementById("productNEWprice").innerHTML = currencysymbol1 + myTotalPrice + currencysymbol2;
   }
 }

   function showPrice1(form)
 {
  var currencysymbol1 = "";
   var currencysymbol2 = "";
   var myTotalPrice = 0;
   var showUP = 0;
   var myMathProblem = "";
   myItemPrice = parseFloat(form.nuPrice1.value);

  myDollarSign2 = form.nuPrice1.value.indexOf("EUR",0)
  if ( myDollarSign2 != "-1" )
  {
     currencysymbol1 = "";
    currencysymbol2 = " EUR";
  } else {
    currencysymbol1 = "$";
    currencysymbol2 = "";
  }

  for (var i = 0; i < form.elements.length; i++)
   {
     var e = form.elements[i];
     if ( e.type == 'select-one' )
     {
       showUP = 1;
       Item = e.selectedIndex;
       myPrice = e.options[item].text;
       myDollarSign = myPrice.indexOf("$",0)
       if ( myDollarSign != "-1" )
       {
       currencysymbol1 = "$";
       currencysymbol2 = "";
         myParSign = myPrice.indexOf(")", myDollarSign);
         myAttributeString = myPrice.substring(myDollarSign+1, myParSign);
         myAttributeString = myAttributeString.replace(/,/,"");
         myAttributePrice = parseFloat(myAttributeString);
         myMathProblem = myPrice.charAt(myDollarSign - 1);
       } else {
        myDollarSign1 = myPrice.indexOf("(",0)
        if ( myDollarSign1 != "-1" )
        {
        currencysymbol1 = "";
         currencysymbol2 = " EUR";
        myParSign = myPrice.indexOf(")", myDollarSign1);
        myAttributeString = myPrice.substring(myDollarSign1+1, myParSign);
        myAttributeString = myAttributeString.replace(/,/,"");
        myAttributePrice = parseFloat(myAttributeString);
        myMathProblem = myPrice.charAt(myDollarSign1 - 1);
        } else {
        myAttributePrice = 0;
        }

     }
         if (myMathProblem == "-")
         {
           myTotalPrice = myTotalPrice - myAttributePrice;
         } else {
           myTotalPrice = myTotalPrice + myAttributePrice;
         }
     }
   }
   if ( showUP )
   {
     myDollarSign3 = form.nuPrice1.value.indexOf(".",0)
     if ( myDollarSign3 != "-1" )
     {
       myTotalPrice = FormatNumber(myTotalPrice + myItemPrice);
     } else {
       myTotalPrice = FormatNumber1(myTotalPrice + myItemPrice);
     }
  	if(document.getElementById("productNEWprice1")!=null){
       	document.getElementById("productNEWprice1").innerHTML = currencysymbol1 + myTotalPrice + currencysymbol2;
	}
	//productNEWprice1.innerHTMML="Algo"; 
   }
 }
//-->
</script>
<!-- Attrib price update Fin //-->
<script type="text/javascript" src="lightbox/prototype.js"></script>
<script type="text/javascript" src="lightbox/scriptaculous.js?load=effects"></script>
<link rel="stylesheet" href="lightbox/lightbox.css" type="text/css" media="screen">
<script type="text/javascript" src="lightbox/builder.js"></script>
<script type="text/javascript" src="lightbox/lightbox.js"></script>
</head>
<body marginwidth="0" marginheight="0" topmargin="0" bottommargin="0" leftmargin="0" rightmargin="0">
<?php /*** Begin Header Tags SEO ***/ ?>
<a name="<?php echo $header_tags_array['title']; ?>"></a>
<?php /*** End Header Tags SEO ***/ ?>
<!-- header //-->
<?php require(DIR_WS_INCLUDES . 'header.php'); ?>
<!-- header_eof //-->

<!-- body //-->
<table bgcolor="#FFE0C1" border="0" width="100%" cellspacing="3" cellpadding="3">
 <tr>
   <td bgcolor="#E2C7C7" width="<?php echo BOX_WIDTH; ?>" valign="top"><table bgcolor="#FFE0C1" border="0" width="<?php echo BOX_WIDTH; ?>" cellspacing="0" cellpadding="2">
<!-- left_navigation //-->
<?php require(DIR_WS_INCLUDES . 'column_left.php'); ?>
<!-- left_navigation_eof //-->
   </table></td>
<!-- body_text //-->
   <td width="100%" valign="top" ><?php echo tep_draw_form('cart_quantity', tep_href_link(FILENAME_PRODUCT_INFO, tep_get_all_get_params(array('action')) . 'action=add_product')); ?><table border="0" width="100%" cellspacing="0" cellpadding="0">
<?php
 if ($product_check['total'] < 1) {
?>
     <tr>
       <td><?php new infoBox(array(array('text' => TEXT_PRODUCT_NOT_FOUND))); ?></td>
     </tr>
     <tr>
       <td><?php echo tep_draw_separator('pixel_trans.gif', '100%', '10'); ?></td>
     </tr>
     <tr>
       <td><table border="0" width="100%" cellspacing="0" cellpadding="0" class="infoBox">
         <tr class="infoBoxContents">
           <td><table  align="right" border="0" width="100%" cellspacing="0" cellpadding="0" bgcolor="#FFE0C1">
             <tr>
               <td width="10"><?php echo tep_draw_separator('pixel_trans.gif', '10', '1'); ?></td>
               <td align="right"><?php echo '<a href="' . tep_href_link(FILENAME_DEFAULT) . '">' . tep_image_button('button_continue.gif', IMAGE_BUTTON_CONTINUE) . '</a>'; ?></td>
               <td width="10"><?php echo tep_draw_separator('pixel_trans.gif', '10', '1'); ?></td>
             </tr>
           </table></td>
         </tr>
       </table></td>
     </tr>
<?php
 } else {
   $product_info_query = tep_db_query("select p.products_id, pd.products_name, pd.products_description, p.products_model, p.products_quantity, p.products_image, pd.products_url, p.products_price, p.products_tax_class_id, p.products_date_added, p.products_date_available, p.manufacturers_id from " . TABLE_PRODUCTS . " p, " . TABLE_PRODUCTS_DESCRIPTION . " pd where p.products_status = '1' and p.products_id = '" . (int)$HTTP_GET_VARS['products_id'] . "' and pd.products_id = p.products_id and pd.language_id = '" . (int)$languages_id . "'");
   $product_info = tep_db_fetch_array($product_info_query);

   tep_db_query("update " . TABLE_PRODUCTS_DESCRIPTION . " set products_viewed = products_viewed+1 where products_id = '" . (int)$HTTP_GET_VARS['products_id'] . "' and language_id = '" . (int)$languages_id . "'");

   if ($new_price = tep_get_products_special_price($product_info['products_id'])) {
     $products_price = '<s>' . $currencies->display_price($product_info['products_price'], tep_get_tax_rate($product_info['products_tax_class_id'])) . '</s> <span class="productSpecialPrice">' . $currencies->display_price($new_price, tep_get_tax_rate($product_info['products_tax_class_id'])) . '</span>';
//Attrib price update
$nuPrice1 =  $currencies->display_price($product_info['products_price'], tep_get_tax_rate($product_info['products_tax_class_id']));
$nuPrice =  $currencies->display_price($new_price, tep_get_tax_rate($product_info['products_tax_class_id']));
//Attrib price update Fin

   } else {
//Attrib price update
$products_price = $currencies->display_price($product_info['products_price'], tep_get_tax_rate($product_info['products_tax_class_id']));
$nuPrice = $products_price;
   }
$nuPrice = str_replace(",", "", $nuPrice);
$nuPrice1 = str_replace(",", "", $nuPrice1);
//Attrib price update Fin

   if (tep_not_null($product_info['products_model'])) {
     $products_name = $product_info['products_name'] . '<br><span class="smallText">[' . $product_info['products_model'] . ']</span>';
   } else {
     $products_name = $product_info['products_name'];
   }
?>
     <tr>
       <td><table border="0" width="100%" cellspacing="0" cellpadding="0">
         <tr>
           <td class="pageHeading" valign="top"><?php echo $products_name; ?></td>
<td class="pageHeading" align="right" valign="top" bgcolor="#FFE0C1">
<!-- price update attributes begin -->
		<?php 
			if(tep_has_product_attributes($product_info['products_id'])){ 
				if ($new_price = tep_get_products_special_price($product_info['products_id'])) {
					?> 
<script type="text/javascript">document.write('<s><div id="productNEWprice1"></div>\n</s>');</script>
<script type="text/javascript">document.write('<span class="productSpecialPrice"><div id="productNEWprice"></div>\n</span>');</script>
					<noscript><?php echo $products_price; ?></noscript>
					<?php } else {?>
					<script type="text/javascript">document.write('<div id="productNEWprice"></div>\n</span>');</script>
					<noscript><?php echo $products_price; ?></noscript>
					<?php }
			 } else { 
				 echo $products_price; } ?>
           </td>
<!-- price update attributes end -->
         </tr>
       </table></td>
     </tr>
     <tr>
       <td><?php echo tep_draw_separator('pixel_trans.gif', '100%', '10'); ?></td>
     </tr>
     <tr><td class="main" align="right" valign="top">
                             <input type="hidden" name="nuPrice" value="<?php echo str_replace("$","",$nuPrice); ?>">
                            <input type="hidden" name="nuPrice1" value="<?php echo str_replace("$","",$nuPrice1); ?>"></td>
                           </tr><tr>
       <td class="main">
<?php
   if (tep_not_null($product_info['products_image'])) {
?>
         <table border="0" cellspacing="0" cellpadding="0" align="right">
           <tr>
             <td align="center" class="smallText">
<?php echo '<a href="' . tep_href_link(DIR_WS_IMAGES . $product_info['products_image']) . '" target="_blank" rel="lightbox">' . tep_image(DIR_WS_IMAGES . $product_info['products_image'], $product_info['products_name'], SMALL_IMAGE_WIDTH, SMALL_IMAGE_HEIGHT, 'hspace="5" vspace="5"') . '<br>' . TEXT_CLICK_TO_ENLARGE . '</a>'; ?>
             </td>
           </tr>
         </table>
<?php
   }
?>
         <p><?php echo stripslashes($product_info['products_description']); ?></p>
<?php
   $products_attributes_query = tep_db_query("select count(*) as total from " . TABLE_PRODUCTS_OPTIONS . " popt, " . TABLE_PRODUCTS_ATTRIBUTES . " patrib where patrib.products_id='" . (int)$HTTP_GET_VARS['products_id'] . "' and patrib.options_id = popt.products_options_id and popt.language_id = '" . (int)$languages_id . "'");
   $products_attributes = tep_db_fetch_array($products_attributes_query);
   if ($products_attributes['total'] > 0) {
?>
         <table border="0" cellspacing="0" cellpadding="2">
           <tr>
             <td class="main" colspan="0"><?php echo TEXT_PRODUCT_OPTIONS; ?></td>
           </tr>
<?php
     $products_options_name_query = tep_db_query("select distinct popt.products_options_id, popt.products_options_name from " . TABLE_PRODUCTS_OPTIONS . " popt, " . TABLE_PRODUCTS_ATTRIBUTES . " patrib where patrib.products_id='" . (int)$HTTP_GET_VARS['products_id'] . "' and patrib.options_id = popt.products_options_id and popt.language_id = '" . (int)$languages_id . "' order by popt.products_options_name");
     while ($products_options_name = tep_db_fetch_array($products_options_name_query)) {
       $products_options_array = array();
       $products_options_query = tep_db_query("select pov.products_options_values_id, pov.products_options_values_name, pa.options_values_price, pa.price_prefix from " . TABLE_PRODUCTS_ATTRIBUTES . " pa, " . TABLE_PRODUCTS_OPTIONS_VALUES . " pov where pa.products_id = '" . (int)$HTTP_GET_VARS['products_id'] . "' and pa.options_id = '" . (int)$products_options_name['products_options_id'] . "' and pa.options_values_id = pov.products_options_values_id and pov.language_id = '" . (int)$languages_id . "'");
       while ($products_options = tep_db_fetch_array($products_options_query)) {
         $products_options_array[] = array('id' => $products_options['products_options_values_id'], 'text' => $products_options['products_options_values_name']);
         if ($products_options['options_values_price'] != '0') {
$products_options_array[sizeof($products_options_array)-1]['text'] .= ' (' . $products_options['price_prefix'] . $currencies->display_price2($products_options['options_values_price'], tep_get_tax_rate($product_info['products_tax_class_id'])) .') ';
         }
       }

       if (isset($cart->contents[$HTTP_GET_VARS['products_id']]['attributes'][$products_options_name['products_options_id']])) {
         $selected_attribute = $cart->contents[$HTTP_GET_VARS['products_id']]['attributes'][$products_options_name['products_options_id']];
       } else {
         $selected_attribute = false;
       }
?>
           <tr>
             <td class="main"><?php echo $products_options_name['products_options_name'] . ':'; ?></td>
             <!-- Attrib price update  //-->
<td class="main"><?php echo tep_draw_pull_down_menu('id[' . $products_options_name['products_options_id'] . ']', $products_options_array, $selected_attribute, "onChange='showPrice(this.form);showPrice1(this.form);'");?></td>
<!-- Proyecto Icaro (Fin Modificado) //-->
           </tr>
<?php
     }
?>
         </table>
<?php
   }
?>
       </td>
     </tr>
     <tr>
       <td><?php echo tep_draw_separator('pixel_trans.gif', '100%', '10'); ?></td>
     </tr>
<?php
   $reviews_query = tep_db_query("select count(*) as count from " . TABLE_REVIEWS . " where products_id = '" . (int)$HTTP_GET_VARS['products_id'] . "'");
   $reviews = tep_db_fetch_array($reviews_query);
   if ($reviews['count'] > 0) {
?>
     <tr>
       <td class="main"><?php echo TEXT_CURRENT_REVIEWS . ' ' . $reviews['count']; ?></td>
     </tr>
     <tr>
       <td><?php echo tep_draw_separator('pixel_trans.gif', '100%', '10'); ?></td>
     </tr>
<?php	
   }

   if (tep_not_null($product_info['products_url'])) {
?>
     <tr>
       <td class="main"><?php echo sprintf(TEXT_MORE_INFORMATION, tep_href_link(FILENAME_REDIRECT, 'action=url&goto=' . urlencode($product_info['products_url']), 'NONSSL', true, false)); ?></td>
     </tr>
     <tr>
       <td><?php echo tep_draw_separator('pixel_trans.gif', '100%', '10'); ?></td>
     </tr>
<?php
   }

   if ($product_info['products_date_available'] > date('Y-m-d H:i:s')) {
?>
     <tr>
       <td align="center" class="smallText">^<?php echo sprintf(TEXT_DATE_AVAILABLE, tep_date_long($product_info['products_date_available'])); ?></td>
     </tr>
<?php
   } else {
?>
     <tr>
       <td align="center" class="smallText"><?php echo sprintf(TEXT_DATE_ADDED, tep_date_long($product_info['products_date_added'])); ?></td>
     </tr>
<?php
   }
?>
     <tr>
       <td><?php echo tep_draw_separator('pixel_trans.gif', '100%', '10'); ?></td>
     </tr>
     <tr>
       <td><table border="0" width="100%" cellspacing="0" cellpadding="0" class="infoBox">
         <tr class="infoBoxContents">
           <td><table border="0" width="100%" cellspacing="0" cellpadding="2" bgcolor="#FFE0C1">
             <tr>
               <td width="10"><?php echo tep_draw_separator('pixel_trans.gif', '10', '1'); ?></td>
               <td class="main"><?php echo '<a href="' . tep_href_link(FILENAME_PRODUCT_REVIEWS, tep_get_all_get_params()) . '">' . tep_image_button('button_reviews.gif', IMAGE_BUTTON_REVIEWS) . '</a>'; ?></td>
               <td class="main" align="right"><?php echo tep_draw_hidden_field('products_id', $product_info['products_id']) . tep_image_submit('button_in_cart.gif', IMAGE_BUTTON_IN_CART); ?></td>
               <td width="10"><?php echo tep_draw_separator('pixel_trans.gif', '10', '1'); ?></td>
             </tr>
           </table></td>
         </tr>
       </table></td>
     </tr>
     <tr>
       <td><?php echo tep_draw_separator('pixel_trans.gif', '100%', '10'); ?></td>
     </tr>
     <tr>
       <td>
<?php
   if ((USE_CACHE == 'true') && empty($SID)) {
     echo tep_cache_also_purchased(3600);
   } else {
     include(DIR_WS_MODULES . FILENAME_ALSO_PURCHASED_PRODUCTS);
   }
 }
?>
       </td>
     </tr>
   </table></td>
<!-- body_text_eof //-->
   <td bgcolor="#E2C7C7" width="<?php echo BOX_WIDTH; ?>" valign="top"><table bgcolor="#FFE0C1" border="0" width="<?php echo BOX_WIDTH; ?>" cellspacing="0" cellpadding="2">
<!-- right_navigation //-->
<?php require(DIR_WS_INCLUDES . 'column_right.php'); ?>
<!-- right_navigation_eof //-->
   </table></td>
 </tr>
</table>
<!-- body_eof //-->
<!-- Attrib price update  //-->
<script language="javascript">
<!--
 showPrice(cart_quantity);
 showPrice1(cart_quantity);
//-->
</script>
<!-- Attrib price update Fin //-->

<!-- footer //-->
<?php require(DIR_WS_INCLUDES . 'footer.php'); ?>
<!-- footer_eof //-->
<br>
</body>
</html>
<?php require(DIR_WS_INCLUDES . 'application_bottom.php'); ?>

hunig

hunig

Posted
  • Author
Posted

Has nobody else this problem ???

 

I have been searching for hours and have no idea what else i can do...

:'( :( :( :(

Archived

This topic is now archived and is closed to further replies.

Go to topic listing
×
×
  • Create New...