Help! Can you see the problem in this code?

April 15, 2008

At www.birdsinmyyard.com, if you see a product listed on the home page or new products page or, basically any page except the product's own page, the description is cut off. I modified the descrpt. length in mysql and so it displays on the product page correctly, but I want to fix it to show the full description on any page.

I think I see where in the code it does this... but I don't know what the syntax would be to adjust it. Here's the code for products_new.php:

===========================================================

<?php

/*

$Id: products_new.php,v 1.27 2003/06/09 22:35:33 hpdl Exp $

osCommerce, Open Source E-Commerce Solutions

http://www.oscommerce.com

Released under the GNU General Public License

*/

require('includes/application_top.php');

require(DIR_WS_LANGUAGES . $language . '/' . FILENAME_PRODUCTS_NEW);

$breadcrumb->add(NAVBAR_TITLE, tep_href_link(FILENAME_PRODUCTS_NEW));

?>

<!doctype html public "-//W3C//DTD HTML 4.01 Transitional//EN">

<head>

</head>

<?php require(DIR_WS_INCLUDES . 'header.php'); ?>

<tr>

<?php require(DIR_WS_INCLUDES . 'column_left.php'); ?>

</td>

<?php /* require(DIR_WS_BOXES . 'panel_top.php'); */ ?>

<? tep_draw_heading_top();?>

<? new contentBoxHeading_ProdNew($info_box_contents);?>

<? tep_draw_heading_top_3();?>

<?php

$products_new_array = array();

$products_new_query_raw = "select p.products_id, pd.products_name, p.products_image, p.products_price, p.products_tax_class_id, p.products_date_added, m.manufacturers_name from " . TABLE_PRODUCTS . " p left join " . TABLE_MANUFACTURERS . " m on (p.manufacturers_id = m.manufacturers_id), " . TABLE_PRODUCTS_DESCRIPTION . " pd where p.products_status = '1' and p.products_id = pd.products_id and pd.language_id = '" . (int)$languages_id . "' order by p.products_date_added DESC, pd.products_name";

$products_new_split = new splitPageResults($products_new_query_raw, MAX_DISPLAY_PRODUCTS_NEW);

if (($products_new_split->number_of_rows > 0) && ((PREV_NEXT_BAR_LOCATION == '1') || (PREV_NEXT_BAR_LOCATION == '2'))) {

?>

<?php echo tep_draw_result_top_1(); ?>

<tr>

<td><?php echo $products_new_split->display_count(TEXT_DISPLAY_NUMBER_OF_PRODUCTS_NEW); ?></td>

<td class="result_right"><?php echo TEXT_RESULT_PAGE . ' ' . $products_new_split->display_links(MAX_DISPLAY_PAGE_LINKS, tep_get_all_get_params(array('page', 'info', 'x', 'y'))); ?></td>

</tr>

</table>

<?php echo tep_draw_result_top(); ?>

<?php echo tep_draw_result_bottom_1(); ?>

<?php

}

?>

<?php

if ($products_new_split->number_of_rows > 0) {

$products_new_query = tep_db_query($products_new_split->sql_query);

$row = 0;

$col = 0;

$info_box_contents = array();

while ($products_new = tep_db_fetch_array($products_new_query)) {

$product_query = tep_db_query("select products_description, products_id from " . TABLE_PRODUCTS_DESCRIPTION . " where products_id = '" . (int)$products_new['products_id'] . "' and language_id = '" . (int)$languages_id . "'");

$product = tep_db_fetch_array($product_query);

$p_desc = substr($product['products_description'], 0, MAX_DESCR_1);

$p_id = $product['products_id'];

$p_pic = '<a href="' . tep_href_link(FILENAME_PRODUCT_INFO, 'products_id=' . $products_new['products_id']) . '">' . tep_image(DIR_WS_IMAGES . $products_new['products_image'], $products_new['products_name'], SMALL_IMAGE_WIDTH, SMALL_IMAGE_HEIGHT) . '</a>';

$p_name = '<a href="' . tep_href_link(FILENAME_PRODUCT_INFO, 'products_id=' . $products_new['products_id']) . '">' . substr( $products_new['products_name'],0,MAX_DESCR_NAME) . '</a>';

if ($new_price = tep_get_products_special_price($products_new['products_id'])) {

$products_price = '<s>' . $currencies->display_price($products_new['products_price'], tep_get_tax_rate($products_new['products_tax_class_id'])) . '</s> <span class="productSpecialPrice">' . $currencies->display_price($new_price, tep_get_tax_rate($products_new['products_tax_class_id'])) . '</span>';

} else {

$products_price = '<span class="productSpecialPrice">'.$currencies->display_price($products_new['products_price'], tep_get_tax_rate($products_new['products_tax_class_id']).'</span>');

}

$p_price = $products_price;

$products_new['products_name'] = tep_get_products_name($products_new['products_id']);

$info_box_contents[$row][$col] = array('align' => 'center',

'params' => ' style="width:33%;"',

'text' => '

<tr>

<td>'.tep_draw_prod_top().''.$p_pic.''.tep_draw_prod_bottom().'</td>

</tr>

<tr>

</tr>

<tr>

</tr>

<tr>

<td style="height:53px " class="vam">'.$p_price.'</td>

</tr>

<tr>

<td style="height:68px "><a href="' . tep_href_link('product_info.php?products_id='.$p_id) . '">'.tep_image_button("button_details.gif").'</a><br>

<a href="'.tep_href_link("products_new.php","action=buy_now&products_id=".$p_id).'">'.tep_image_button('button_add_to_cart2.gif').'</a></td>

</tr>

</table>

');

$col ++;

if ($col > 2) {

$col = 0;

$row ++;

}

new contentBox($info_box_contents);

} else {

?>

</table>

<?php

}

?>

<?php echo tep_draw_result_bottom(); ?>

<?php

if (($products_new_split->number_of_rows > 0) && ((PREV_NEXT_BAR_LOCATION == '2') || (PREV_NEXT_BAR_LOCATION == '3'))) {

?>

<?php echo tep_draw_result_top_2(); ?>

<tr>

<td><?php echo $products_new_split->display_count(TEXT_DISPLAY_NUMBER_OF_PRODUCTS_NEW); ?></td>

<td class="result_right"><?php echo TEXT_RESULT_PAGE . ' ' . $products_new_split->display_links(MAX_DISPLAY_PAGE_LINKS, tep_get_all_get_params(array('page', 'info', 'x', 'y'))); ?></td>

</tr>

</table>

<?php echo tep_draw_result_bottom_2(); ?>

<?php

}

?>

<? tep_draw_heading_bottom_3();?>

<? tep_draw_heading_bottom();?>

</td>

<?php require(DIR_WS_INCLUDES . 'column_right.php'); ?>

</td>

</tr>

</table>

<?php require(DIR_WS_INCLUDES . 'footer.php'); ?>

</body>

</html>

<?php require(DIR_WS_INCLUDES . 'application_bottom.php'); ?>

========================================================

Can anyone help me figure out how to fix this? I won't use templates again... first time

using OScommerce :( Thanks in advance for any help

germ · April 16, 2008

Change this code:

$p_desc = substr($product['products_description'], 0, MAX_DESCR_1);

to:

//$p_desc = substr($product['products_description'], 0, MAX_DESCR_1);
$p_desc = $product['products_description'];

And see if that's what you want.

Help! Can you see the problem in this code?

Recommended Posts

Guest

germ

Archived

Browse

Activity