No email delevered to the user when subjected by Arabic words!

Liquid Snake · March 18, 2008

Hello everyone,

No emails delevered to the customers when the message subjected with arabic world, when I send news letters subjected with arabic words its not delevered, or even when someone register with first/last name using Arabic!

or when sending message from "Contact us" page using arabic words in "Name" textbox

and everything is works perfect with English

I sill can't figure out the problem >_<

Thanks in advance

Liquid Snake · March 19, 2008

umm anyone can help?

arietis · March 19, 2008

Hello everyone,
No emails delevered to the customers when the message subjected with arabic world, when I send news letters subjected with arabic words its not delevered, or even when someone register with first/last name using Arabic!

or when sending message from "Contact us" page using arabic words in "Name" textbox

and everything is works perfect with English

I sill can't figure out the problem >_<

Thanks in advance

for those of us non-arabic speaking people....can you show how you're entering arabic words into your email. if i can reproduce what you're doing, i can probably figure out what the problem is and show you how to fix it. i suspect that the php mail() function doesn't understand the arabic characters, but if they're encoded it'll probably work. it should be a quick fix once i can reproduce it.

Liquid Snake · March 19, 2008

thank you sir for reply :)

here is copy of email.php

I think the problem in on of this lines:

	  $this->build_params['html_encoding'] = 'quoted-printable';
  $this->build_params['text_encoding'] = '7bit';
  $this->build_params['html_charset'] = constant('CHARSET');
  $this->build_params['text_charset'] = constant('CHARSET');
  $this->build_params['text_wrap'] = 998;

(Full code)

<?php

ini_set('sendmail_from', 'info@ :) .com');

/*
 $Id: email.php,v 1.12 2003/06/17 17:29:44 dgw_ Exp $

 osCommerce, Open Source E-Commerce Solutions
 http://www.oscommerce.com

 Copyright (c) 2003 osCommerce

 Released under the GNU General Public License

 mail.php - a class to assist in building mime-HTML eMails

 The original class was made by Richard Heyes <[email protected]>
 and can be found here: http://www.phpguru.org

 Renamed and Modified by Jan Wildeboer for osCommerce
*/

 class email {
var $html;
var $text;
var $output;
var $html_text;
var $html_images;
var $image_types;
var $build_params;
var $attachments;
var $headers;

function email($headers = '') {
  if ($headers == '') $headers = array();

  $this->html_images = array();
  $this->headers = array();

  if (EMAIL_LINEFEED == 'CRLF') {
	$this->lf = "\r\n";
  } else {
	$this->lf = "\n";
  }

/**
* If you want the auto load functionality
* to find other mime-image/file types, add the
* extension and content type here.
*/

  $this->image_types = array('gif' => 'image/gif',
							 'jpg' => 'image/jpeg',
							 'jpeg' => 'image/jpeg',
							 'jpe' => 'image/jpeg',
							 'bmp' => 'image/bmp',
							 'png' => 'image/png',
							 'tif' => 'image/tiff',
							 'tiff' => 'image/tiff',
							 'swf' => 'application/x-shockwave-flash');

  $this->build_params['html_encoding'] = 'quoted-printable';
  $this->build_params['text_encoding'] = '7bit';
  $this->build_params['html_charset'] = constant('CHARSET');
  $this->build_params['text_charset'] = constant('CHARSET');
  $this->build_params['text_wrap'] = 998;

/**
* Make sure the MIME version header is first.
*/

  $this->headers[] = 'MIME-Version: 1.0';

  reset($headers);
  while (list(,$value) = each($headers)) {
	if (tep_not_null($value)) {
	  $this->headers[] = $value;
	}
  }
}

/**
* This function will read a file in
* from a supplied filename and return
* it. This can then be given as the first
* argument of the the functions
* add_html_image() or add_attachment().
*/

function get_file($filename) {
  $return = '';

  if ($fp = fopen($filename, 'rb')) {
	while (!feof($fp)) {
	  $return .= fread($fp, 1024);
	}
	fclose($fp);

	return $return;
  } else {
	return false;
  }
}

/**
* Function for extracting images from
* html source. This function will look
* through the html code supplied by add_html()
* and find any file that ends in one of the
* extensions defined in $obj->image_types.
* If the file exists it will read it in and
* embed it, (not an attachment).
*
* Function contributed by Dan Allen
*/

function find_html_images($images_dir) {
// Build the list of image extensions
  while (list($key, ) = each($this->image_types)) {
	$extensions[] = $key;
  }

  preg_match_all('/"([^"]+\.(' . implode('|', $extensions).'))"/Ui', $this->html, $images);

  for ($i=0; $i<count($images[1]); $i++) {
	if (file_exists($images_dir . $images[1][$i])) {
	  $html_images[] = $images[1][$i];
	  $this->html = str_replace($images[1][$i], basename($images[1][$i]), $this->html);
	}
  }

  if (tep_not_null($html_images)) {
// If duplicate images are embedded, they may show up as attachments, so remove them.
	$html_images = array_unique($html_images);
	sort($html_images);

	for ($i=0; $i<count($html_images); $i++) {
	  if ($image = $this->get_file($images_dir . $html_images[$i])) {
		$content_type = $this->image_types[substr($html_images[$i], strrpos($html_images[$i], '.') + 1)];
		$this->add_html_image($image, basename($html_images[$i]), $content_type);
	  }
	}
  }
}

/**
* Adds plain text. Use this function
* when NOT sending html email
*/

function add_text($text = '') {
  $this->text = tep_convert_linefeeds(array("\r\n", "\n", "\r"), $this->lf, $text);
}

/**
* Adds a html part to the mail.
* Also replaces image names with
* content-id's.
*/

function add_html($html, $text = NULL, $images_dir = NULL) {
  $this->html = tep_convert_linefeeds(array("\r\n", "\n", "\r"), '<br>', $html);
  $this->html_text = tep_convert_linefeeds(array("\r\n", "\n", "\r"), $this->lf, $text);

  if (isset($images_dir)) $this->find_html_images($images_dir);
}

/**
* Adds an image to the list of embedded
* images.
*/

function add_html_image($file, $name = '', $c_type='application/octet-stream') {
  $this->html_images[] = array('body' => $file,
							   'name' => $name,
							   'c_type' => $c_type,
							   'cid' => md5(uniqid(time())));
}

/**
* Adds a file to the list of attachments.
*/

function add_attachment($file, $name = '', $c_type='application/octet-stream', $encoding = 'base64') {
  $this->attachments[] = array('body' => $file,
							   'name' => $name,
							   'c_type' => $c_type,
							   'encoding' => $encoding);
}

/**
* Adds a text subpart to a mime_part object
*/

/* HPDL PHP3 */
//	function &add_text_part(&$obj, $text) {
function add_text_part(&$obj, $text) {
  $params['content_type'] = 'text/plain';
  $params['encoding'] = $this->build_params['text_encoding'];
  $params['charset'] = $this->build_params['text_charset'];

  if (is_object($obj)) {
	return $obj->addSubpart($text, $params);
  } else {
	return new mime($text, $params);
  }
}

/**
* Adds a html subpart to a mime_part object
*/

/* HPDL PHP3 */
//	function &add_html_part(&$obj) {
function add_html_part(&$obj) {
  $params['content_type'] = 'text/html';
  $params['encoding'] = $this->build_params['html_encoding'];
  $params['charset'] = $this->build_params['html_charset'];

  if (is_object($obj)) {
	return $obj->addSubpart($this->html, $params);
  } else {
	return new mime($this->html, $params);
  }
}

/**
* Starts a message with a mixed part
*/

/* HPDL PHP3 */
//	function &add_mixed_part() {
function add_mixed_part() {
  $params['content_type'] = 'multipart/mixed';

  return new mime('', $params);
}

/**
* Adds an alternative part to a mime_part object
*/

/* HPDL PHP3 */
//	function &add_alternative_part(&$obj) {
function add_alternative_part(&$obj) {
  $params['content_type'] = 'multipart/alternative';

  if (is_object($obj)) {
	return $obj->addSubpart('', $params);
  } else {
	return new mime('', $params);
  }
}

/**
* Adds a html subpart to a mime_part object
*/

/* HPDL PHP3 */
//	function &add_related_part(&$obj) {
function add_related_part(&$obj) {
  $params['content_type'] = 'multipart/related';

  if (is_object($obj)) {
	return $obj->addSubpart('', $params);
  } else {
	return new mime('', $params);
  }
}

/**
* Adds an html image subpart to a mime_part object
*/

/* HPDL PHP3 */
//	function &add_html_image_part(&$obj, $value) {
function add_html_image_part(&$obj, $value) {
  $params['content_type'] = $value['c_type'];
  $params['encoding'] = 'base64';
  $params['disposition'] = 'inline';
  $params['dfilename'] = $value['name'];
  $params['cid'] = $value['cid'];

  $obj->addSubpart($value['body'], $params);
}

/**
* Adds an attachment subpart to a mime_part object
*/

/* HPDL PHP3 */
//	function &add_attachment_part(&$obj, $value) {
function add_attachment_part(&$obj, $value) {
  $params['content_type'] = $value['c_type'];
  $params['encoding'] = $value['encoding'];
  $params['disposition'] = 'attachment';
  $params['dfilename'] = $value['name'];

  $obj->addSubpart($value['body'], $params);
}

/**
* Builds the multipart message from the
* list ($this->_parts). $params is an
* array of parameters that shape the building
* of the message. Currently supported are:
*
* $params['html_encoding'] - The type of encoding to use on html. Valid options are
*							"7bit", "quoted-printable" or "base64" (all without quotes).
*							7bit is EXPRESSLY NOT RECOMMENDED. Default is quoted-printable
* $params['text_encoding'] - The type of encoding to use on plain text Valid options are
*							"7bit", "quoted-printable" or "base64" (all without quotes).
*							Default is 7bit
* $params['text_wrap']	 - The character count at which to wrap 7bit encoded data.
*							Default this is 998.
* $params['html_charset']  - The character set to use for a html section.
*							Default is iso-8859-1
* $params['text_charset']  - The character set to use for a text section.
*						  - Default is iso-8859-1
*/

/* HPDL PHP3 */
//	function build_message($params = array()) {
function build_message($params = '') {
  if ($params == '') $params = array();

  if (count($params) > 0) {
	reset($params);
	while(list($key, $value) = each($params)) {
	  $this->build_params[$key] = $value;
	}
  }

  if (tep_not_null($this->html_images)) {
	reset($this->html_images);
	while (list(,$value) = each($this->html_images)) {
	  $this->html = str_replace($value['name'], 'cid:' . $value['cid'], $this->html);
	}
  }

  $null = NULL;
  $attachments = ((tep_not_null($this->attachments)) ? true : false);
  $html_images = ((tep_not_null($this->html_images)) ? true : false);
  $html = ((tep_not_null($this->html)) ? true : false);
  $text = ((tep_not_null($this->text)) ? true : false);

  switch (true) {
	case (($text == true) && ($attachments == false)):
/* HPDL PHP3 */
//		  $message =& $this->add_text_part($null, $this->text);
	  $message = $this->add_text_part($null, $this->text);
	  break;
	case (($text == false) && ($attachments == true) && ($html == false)):
/* HPDL PHP3 */
//		  $message =& $this->add_mixed_part();
	  $message = $this->add_mixed_part();

	  for ($i=0; $i<count($this->attachments); $i++) {
		$this->add_attachment_part($message, $this->attachments[$i]);
	  }
	  break;
	case (($text == true) && ($attachments == true)):
/* HPDL PHP3 */
//		  $message =& $this->add_mixed_part();
	  $message = $this->add_mixed_part();
	  $this->add_text_part($message, $this->text);

	  for ($i=0; $i<count($this->attachments); $i++) {
		$this->add_attachment_part($message, $this->attachments[$i]);
	  }
	  break;
	case (($html == true) && ($attachments == false) && ($html_images == false)):
	  if (tep_not_null($this->html_text)) {
/* HPDL PHP3 */
//			$message =& $this->add_alternative_part($null);
		$message = $this->add_alternative_part($null);
		$this->add_text_part($message, $this->html_text);
		$this->add_html_part($message);
	  } else {
/* HPDL PHP3 */
//			$message =& $this->add_html_part($null);
		$message = $this->add_html_part($null);
	  }
	  break;
	case (($html == true) && ($attachments == false) && ($html_images == true)):
	  if (tep_not_null($this->html_text)) {
/* HPDL PHP3 */
//			$message =& $this->add_alternative_part($null);
		$message = $this->add_alternative_part($null);
		$this->add_text_part($message, $this->html_text);
/* HPDL PHP3 */
//			$related =& $this->add_related_part($message);
		$related = $this->add_related_part($message);
	  } else {
/* HPDL PHP3 */
//			$message =& $this->add_related_part($null);
//			$related =& $message;
		$message = $this->add_related_part($null);
		$related = $message;
	  }
	  $this->add_html_part($related);

	  for ($i=0; $i<count($this->html_images); $i++) {
		$this->add_html_image_part($related, $this->html_images[$i]);
	  }
	  break;
	case (($html == true) && ($attachments == true) && ($html_images == false)):
/* HPDL PHP3 */
//		  $message =& $this->add_mixed_part();
	  $message = $this->add_mixed_part();
	  if (tep_not_null($this->html_text)) {
/* HPDL PHP3 */
//			$alt =& $this->add_alternative_part($message);
		$alt = $this->add_alternative_part($message);
		$this->add_text_part($alt, $this->html_text);
		$this->add_html_part($alt);
	  } else {
		$this->add_html_part($message);
	  }

	  for ($i=0; $i<count($this->attachments); $i++) {
		$this->add_attachment_part($message, $this->attachments[$i]);
	  }
	  break;
	case (($html == true) && ($attachments == true) && ($html_images == true)):
/* HPDL PHP3 */
//		  $message =& $this->add_mixed_part();
	  $message = $this->add_mixed_part();

	  if (tep_not_null($this->html_text)) {
/* HPDL PHP3 */
//			$alt =& $this->add_alternative_part($message);
		$alt = $this->add_alternative_part($message);
		$this->add_text_part($alt, $this->html_text);
/* HPDL PHP3 */
//			$rel =& $this->add_related_part($alt);
		$rel = $this->add_related_part($alt);
	  } else {
/* HPDL PHP3 */
//			$rel =& $this->add_related_part($message);
		$rel = $this->add_related_part($message);
	  }
	  $this->add_html_part($rel);

	  for ($i=0; $i<count($this->html_images); $i++) {
		$this->add_html_image_part($rel, $this->html_images[$i]);
	  }

	  for ($i=0; $i<count($this->attachments); $i++) {
		$this->add_attachment_part($message, $this->attachments[$i]);
	  }
	  break;
  }

  if ( (isset($message)) && (is_object($message)) ) {
	$output = $message->encode();
	$this->output = $output['body'];

	reset($output['headers']);
	while (list($key, $value) = each($output['headers'])) {
	  $headers[] = $key . ': ' . $value;
	}

	$this->headers = array_merge($this->headers, $headers);

	return true;
  } else {
	return false;
  }
}

/**
* Sends the mail.
*/

function send($to_name, $to_addr, $from_name, $from_addr, $subject = '', $headers = '') {
  if ((strstr($to_name, "\n") != false) || (strstr($to_name, "\r") != false)) {
	return false;
  }

  if ((strstr($to_addr, "\n") != false) || (strstr($to_addr, "\r") != false)) {
	return false;
  }

  if ((strstr($subject, "\n") != false) || (strstr($subject, "\r") != false)) {
	return false;
  }

  if ((strstr($from_name, "\n") != false) || (strstr($from_name, "\r") != false)) {
	return false;
  }

  if ((strstr($from_addr, "\n") != false) || (strstr($from_addr, "\r") != false)) {
	return false;
  }

  $to = (($to_name != '') ? '"' . $to_name . '" <' . $to_addr . '>' : $to_addr);
  $from = (($from_name != '') ? '"' . $from_name . '" <' . $from_addr . '>' : $from_addr);

  if (is_string($headers)) {
	$headers = explode($this->lf, trim($headers));
  }

  for ($i=0; $i<count($headers); $i++) {
	if (is_array($headers[$i])) {
	  for ($j=0; $j<count($headers[$i]); $j++) {
		if ($headers[$i][$j] != '') {
		  $xtra_headers[] = $headers[$i][$j];
		}
	  }
	}

	if ($headers[$i] != '') {
	  $xtra_headers[] = $headers[$i];
	}
  }

  if (!isset($xtra_headers)) {
	$xtra_headers = array();
  }

  if (EMAIL_TRANSPORT == 'smtp') {
	return mail($to_addr, $subject, $this->output, 'From: ' . $from . $this->lf . 'To: ' . $to . $this->lf . implode($this->lf, $this->headers) . $this->lf . implode($this->lf, $xtra_headers));
  } else {
	return mail($to, $subject, $this->output, 'From: '.$from.$this->lf.implode($this->lf, $this->headers).$this->lf.implode($this->lf, $xtra_headers));
  }
}

/**
* Use this method to return the email
* in message/rfc822 format. Useful for
* adding an email to another email as
* an attachment. there's a commented
* out example in example.php.
*
* string get_rfc822(string To name,
*	   string To email,
*	   string From name,
*	   string From email,
*	   [string Subject,
*		string Extra headers])
*/

function get_rfc822($to_name, $to_addr, $from_name, $from_addr, $subject = '', $headers = '') {
// Make up the date header as according to RFC822
  $date = 'Date: ' . date('D, d M y H:i:s');
  $to = (($to_name != '') ? 'To: "' . $to_name . '" <' . $to_addr . '>' : 'To: ' . $to_addr);
  $from = (($from_name != '') ? 'From: "' . $from_name . '" <' . $from_addr . '>' : 'From: ' . $from_addr);

  if (is_string($subject)) {
	$subject = 'Subject: ' . $subject;
  }

  if (is_string($headers)) {
	$headers = explode($this->lf, trim($headers));
  }

  for ($i=0; $i<count($headers); $i++) {
	if (is_array($headers[$i])) {
	  for ($j=0; $j<count($headers[$i]); $j++) {
		if ($headers[$i][$j] != '') {
		  $xtra_headers[] = $headers[$i][$j];
		}
	  }
	}

	if ($headers[$i] != '') {
	  $xtra_headers[] = $headers[$i];
	}
  }

  if (!isset($xtra_headers)) {
	$xtra_headers = array();
  }

  $headers = array_merge($this->headers, $xtra_headers);

  return $date . $this->lf . $from . $this->lf . $to . $this->lf . $subject . $this->lf . implode($this->lf, $headers) . $this->lf . $this->lf . $this->output;
}
 }
?>

arietis · March 19, 2008

thank you sir for reply :)

here is copy of email.php

I think the problem in on of this lines:

	  $this->build_params['html_encoding'] = 'quoted-printable';
  $this->build_params['text_encoding'] = '7bit';
  $this->build_params['html_charset'] = constant('CHARSET');
  $this->build_params['text_charset'] = constant('CHARSET');
  $this->build_params['text_wrap'] = 998;

well, the encoding says '7bit' and i'm sure arabic is not. it's possible to encode the subject, as well as the content of the email. but i need some sample arabic text so that i'm sure i'm reproducing your problem correctly. can you reply with your name or something simple, in arabic, so i can see what the behavior is?

Liquid Snake · March 20, 2008

here is some arabic txt:

مرحبا بكم في موقعنا نتمنى لكم قضاء اسعد الاوقات

Thanks alot for helping me ^^

arietis · March 21, 2008

here is some arabic txt:

مرحبا بكم في موقعنا نتمنى لكم قضاء اسعد الاوقات

Thanks alot for helping me ^^

sorry for not getting back to you sooner - i spent all day yesterday with a client. :)

let's try fixing the subject first, then we'll move on to the body of the email once i know we're on the right track.

in your admin/includes/classes/email.php file, on or about line 520 you will find the following code:

	  if (EMAIL_TRANSPORT == 'smtp') {
	return mail($to_addr, $subject, $this->output, 'From: ' . $from . $this->lf . 'To: ' . $to . $this->lf . implode($this->lf, $this->headers) . $this->lf . implode($this->lf, $xtra_headers));
  } else {
	return mail($to, $subject, $this->output, 'From: '.$from.$this->lf.implode($this->lf, $this->headers).$this->lf.implode($this->lf, $xtra_headers));
  }

just before that, insert the following code:

	$sCharset = 'iso-8859-6';

// check to see if hi-ascii characters present
$fEncode = false;
for ($i = 0; $i < strlen($subject) && !$fEncode; $i++)
{
	if (ord(substr($subject, $i, 1)) >= 128)
		$fEncode = true;
}
// hi-ascii present modify subject line
if ($fEncode)
{
	$subject = '=?' . $sCharset . '?B?' . base64_encode($subject) . '?=';
}

this code first checks to see if you have entered a subject line in arabic, and if so, adjusts the subject according to the smtp encoding standards.

this is assuming the iso-8859-6 character set. my test was able to send the subject line correctly to a gmail account and the characters looked - at least to my western eyes - like the same arabic characters that you included in your last post. if they're not right, then you can try one of the other charset values such as 'ASMO-708' or 'windows-1256'. see http://www.aspnetemail.com/charsets.aspx for a list and which one fits best for you.

once you try this, let me know how it works. if it does, we'll do a similar thing for the body of the message.

Liquid Snake · March 24, 2008

WoW its working!

Thanks champ! i own you one! :thumbsup:

THANK YOU SOOooooo MUCH :D :D :D

arietis · March 24, 2008

WoW its working!

good, i'm glad to hear that.

when i get a chance later tonight or tomorrow i'll come up with the changes for the body of the email. at least we know we have the proper encoding with the 'iso-8859-6'.

by the way, happy new year (a couple days late). :thumbsup:

Liquid Snake · March 25, 2008

happy new year

same 2 you my friend :):)

arietis · March 25, 2008

ok, i've got the body of the email figured out now.

as before, on or about line 520 of admin/includes/classes/email.php you will find the following code

	  if (EMAIL_TRANSPORT == 'smtp') {
	return mail($to_addr, $subject, $this->output, 'From: ' . $from . $this->lf . 'To: ' . $to . $this->lf . implode($this->lf, $this->headers) . $this->lf . implode($this->lf, $xtra_headers));
  } else {
	return mail($to, $subject, $this->output, 'From: '.$from.$this->lf.implode($this->lf, $this->headers).$this->lf.implode($this->lf, $xtra_headers));
  }

this should be replaced with:

	$sCharset = 'iso-8859-6';

// check to see if html encoded wide characters are present
if (strpos($subject, '') !== false)
{
	$sTempSubject = html_entity_decode($subject, ENT_QUOTES);
	$sTempSubject = preg_replace('/([a-f0-9]+);/mei',"chr(0x\\1)", $sTempSubject);
	$subject = '=?' . $sCharset . '?B?' . base64_encode($sTempSubject) . '?=';
}

$fEncode = false;
if (strpos($this->output, '') !== false)
{
	$fEncode = true;		// when this is set, the mail() calls below use the modified body

	// decode the html entities
	$sBodyText = html_entity_decode($this->output);
	$sBodyText = preg_replace('/([a-f0-9]+);/mei',"chr(0x\\1)", $sBodyText);

	// encode as base64
	$sBodyText = chunk_split(base64_encode($sBodyText));

	// change existing Content-transfer-encoding header
	$fFound = false;
	for ($i = 0; $i < count($this->headers) && !$fFound; $i++)
	{
		$nOff = strpos($this->headers[$i], ':');
		if ($nOff !== false)
		{
			if (strcasecmp(substr($this->headers[$i], 0, $nOff), 'Content-Transfer-Encoding') == 0)
			{
				$this->headers[$i] = 'Content-Transfer-Encoding: base64';
				$fFound = true;
			}
		}
	}
	if (!$fFound)
		$this->headers[] = 'Content-Transfer-Encoding: base64';

	// change existing content-type header
	$fFound = false;
	for ($i = 0; $i < count($this->headers) && !$fFound; $i++)
	{
		$nOff = strpos($this->headers[$i], ':');
		if ($nOff !== false)
		{
			if (strcasecmp(substr($this->headers[$i], 0, $nOff), 'Content-type') == 0)
			{
				$this->headers[$i] = 'Content-type: text/plain; encoding="' . $sCharset . '"';
				$fFound = true;
			}
		}
	}
	if (!$fFound)
		$this->headers[] = 'Content-type: application/octet stream; encoding="' . $sCharset . '"';
}

  if (EMAIL_TRANSPORT == 'smtp') {
	return mail($to_addr, $subject, ( $fEncode ? $sBodyText : $this->output), 'From: ' . $from . $this->lf . 'To: ' . $to . $this->lf . implode($this->lf, $this->headers) . $this->lf . implode($this->lf, $xtra_headers));
  } else {
	return mail($to, $subject, ( $fEncode ? $sBodyText : $this->output), 'From: '.$from.$this->lf.implode($this->lf, $this->headers).$this->lf.implode($this->lf, $xtra_headers));
  }

note that this should replace the code i gave you before. i found a bug in there so just ignore my previous post. :) this also changes the five lines of code starting on line 520. this is important, otherwise you won't get the body of the email sent correctly.

try this out and let me know how it works for you.

Liquid Snake · April 8, 2008

Hello arietis,

I'm sorry did not received an email that there is new post

I'll test the code now and tell you.

Thanks again I realy appreciate you help

Liquid Snake · April 8, 2008

I keep see this error when i inter the admin cp:

Parse error: syntax error, unexpected ';', expecting T_FUNCTION in D:\hshome\**\**\Admin\includes\classes\email.php on line 632

I think what is missing is only a ; but cant find where..

here is a copy of my corrent code after your edit:

<?php
/*
 $Id: email.php 1739 2007-12-20 00:52:16Z hpdl $

 osCommerce, Open Source E-Commerce Solutions
 http://www.oscommerce.com

 Copyright (c) 2003 osCommerce

 Released under the GNU General Public License

 mail.php - a class to assist in building mime-HTML eMails

 The original class was made by Richard Heyes <[email protected]>
 and can be found here: http://www.phpguru.org

 Renamed and Modified by Jan Wildeboer for osCommerce
*/

 class email {
var $html;
var $text;
var $output;
var $html_text;
var $html_images;
var $image_types;
var $build_params;
var $attachments;
var $headers;

function email($headers = '') {
  if ($headers == '') $headers = array();

  $this->html_images = array();
  $this->headers = array();

  if (EMAIL_LINEFEED == 'CRLF') {
	$this->lf = "\r\n";
  } else {
	$this->lf = "\n";
  }

/**
* If you want the auto load functionality
* to find other mime-image/file types, add the
* extension and content type here.
*/

  $this->image_types = array('gif' => 'image/gif',
							 'jpg' => 'image/jpeg',
							 'jpeg' => 'image/jpeg',
							 'jpe' => 'image/jpeg',
							 'bmp' => 'image/bmp',
							 'png' => 'image/png',
							 'tif' => 'image/tiff',
							 'tiff' => 'image/tiff',
							 'swf' => 'application/x-shockwave-flash');

  $this->build_params['html_encoding'] = 'quoted-printable';
  $this->build_params['text_encoding'] = '7bit';
  $this->build_params['html_charset'] = constant('CHARSET');
  $this->build_params['text_charset'] = constant('CHARSET');
  $this->build_params['text_wrap'] = 998;

/**
* Make sure the MIME version header is first.
*/

  $this->headers[] = 'MIME-Version: 1.0';

  reset($headers);
  while (list(,$value) = each($headers)) {
	if (tep_not_null($value)) {
	  $this->headers[] = $value;
	}
  }
}

/**
* This function will read a file in
* from a supplied filename and return
* it. This can then be given as the first
* argument of the the functions
* add_html_image() or add_attachment().
*/

function get_file($filename) {
  $return = '';

  if ($fp = fopen($filename, 'rb')) {
	while (!feof($fp)) {
	  $return .= fread($fp, 1024);
	}
	fclose($fp);

	return $return;
  } else {
	return false;
  }
}

/**
* Function for extracting images from
* html source. This function will look
* through the html code supplied by add_html()
* and find any file that ends in one of the
* extensions defined in $obj->image_types.
* If the file exists it will read it in and
* embed it, (not an attachment).
*
* Function contributed by Dan Allen
*/

function find_html_images($images_dir) {
// Build the list of image extensions
  while (list($key, ) = each($this->image_types)) {
	$extensions[] = $key;
  }

  preg_match_all('/"([^"]+\.(' . implode('|', $extensions).'))"/Ui', $this->html, $images);

  for ($i=0; $i<count($images[1]); $i++) {
	if (file_exists($images_dir . $images[1][$i])) {
	  $html_images[] = $images[1][$i];
	  $this->html = str_replace($images[1][$i], basename($images[1][$i]), $this->html);
	}
  }

  if (tep_not_null($html_images)) {
// If duplicate images are embedded, they may show up as attachments, so remove them.
	$html_images = array_unique($html_images);
	sort($html_images);

	for ($i=0; $i<count($html_images); $i++) {
	  if ($image = $this->get_file($images_dir . $html_images[$i])) {
		$content_type = $this->image_types[substr($html_images[$i], strrpos($html_images[$i], '.') + 1)];
		$this->add_html_image($image, basename($html_images[$i]), $content_type);
	  }
	}
  }
}

/**
* Adds plain text. Use this function
* when NOT sending html email
*/

function add_text($text = '') {
  $this->text = tep_convert_linefeeds(array("\r\n", "\n", "\r"), $this->lf, $text);
}

/**
* Adds a html part to the mail.
* Also replaces image names with
* content-id's.
*/

function add_html($html, $text = NULL, $images_dir = NULL) {
  $this->html = tep_convert_linefeeds(array("\r\n", "\n", "\r"), '<br>', $html);
  $this->html_text = tep_convert_linefeeds(array("\r\n", "\n", "\r"), $this->lf, $text);

  if (isset($images_dir)) $this->find_html_images($images_dir);
}

/**
* Adds an image to the list of embedded
* images.
*/

function add_html_image($file, $name = '', $c_type='application/octet-stream') {
  $this->html_images[] = array('body' => $file,
							   'name' => $name,
							   'c_type' => $c_type,
							   'cid' => md5(uniqid(time())));
}

/**
* Adds a file to the list of attachments.
*/

function add_attachment($file, $name = '', $c_type='application/octet-stream', $encoding = 'base64') {
  $this->attachments[] = array('body' => $file,
							   'name' => $name,
							   'c_type' => $c_type,
							   'encoding' => $encoding);
}

/**
* Adds a text subpart to a mime_part object
*/

/* HPDL PHP3 */
//	function &add_text_part(&$obj, $text) {
function add_text_part(&$obj, $text) {
  $params['content_type'] = 'text/plain';
  $params['encoding'] = $this->build_params['text_encoding'];
  $params['charset'] = $this->build_params['text_charset'];

  if (is_object($obj)) {
	return $obj->addSubpart($text, $params);
  } else {
	return new mime($text, $params);
  }
}

/**
* Adds a html subpart to a mime_part object
*/

/* HPDL PHP3 */
//	function &add_html_part(&$obj) {
function add_html_part(&$obj) {
  $params['content_type'] = 'text/html';
  $params['encoding'] = $this->build_params['html_encoding'];
  $params['charset'] = $this->build_params['html_charset'];

  if (is_object($obj)) {
	return $obj->addSubpart($this->html, $params);
  } else {
	return new mime($this->html, $params);
  }
}

/**
* Starts a message with a mixed part
*/

/* HPDL PHP3 */
//	function &add_mixed_part() {
function add_mixed_part() {
  $params['content_type'] = 'multipart/mixed';

  return new mime('', $params);
}

/**
* Adds an alternative part to a mime_part object
*/

/* HPDL PHP3 */
//	function &add_alternative_part(&$obj) {
function add_alternative_part(&$obj) {
  $params['content_type'] = 'multipart/alternative';

  if (is_object($obj)) {
	return $obj->addSubpart('', $params);
  } else {
	return new mime('', $params);
  }
}

/**
* Adds a html subpart to a mime_part object
*/

/* HPDL PHP3 */
//	function &add_related_part(&$obj) {
function add_related_part(&$obj) {
  $params['content_type'] = 'multipart/related';

  if (is_object($obj)) {
	return $obj->addSubpart('', $params);
  } else {
	return new mime('', $params);
  }
}

/**
* Adds an html image subpart to a mime_part object
*/

/* HPDL PHP3 */
//	function &add_html_image_part(&$obj, $value) {
function add_html_image_part(&$obj, $value) {
  $params['content_type'] = $value['c_type'];
  $params['encoding'] = 'base64';
  $params['disposition'] = 'inline';
  $params['dfilename'] = $value['name'];
  $params['cid'] = $value['cid'];

  $obj->addSubpart($value['body'], $params);
}

/**
* Adds an attachment subpart to a mime_part object
*/

/* HPDL PHP3 */
//	function &add_attachment_part(&$obj, $value) {
function add_attachment_part(&$obj, $value) {
  $params['content_type'] = $value['c_type'];
  $params['encoding'] = $value['encoding'];
  $params['disposition'] = 'attachment';
  $params['dfilename'] = $value['name'];

  $obj->addSubpart($value['body'], $params);
}

/**
* Builds the multipart message from the
* list ($this->_parts). $params is an
* array of parameters that shape the building
* of the message. Currently supported are:
*
* $params['html_encoding'] - The type of encoding to use on html. Valid options are
*							"7bit", "quoted-printable" or "base64" (all without quotes).
*							7bit is EXPRESSLY NOT RECOMMENDED. Default is quoted-printable
* $params['text_encoding'] - The type of encoding to use on plain text Valid options are
*							"7bit", "quoted-printable" or "base64" (all without quotes).
*							Default is 7bit
* $params['text_wrap']	 - The character count at which to wrap 7bit encoded data.
*							Default this is 998.
* $params['html_charset']  - The character set to use for a html section.
*							Default is iso-8859-1
* $params['text_charset']  - The character set to use for a text section.
*						  - Default is iso-8859-1
*/

/* HPDL PHP3 */
//	function build_message($params = array()) {
function build_message($params = '') {
  if ($params == '') $params = array();

  if (count($params) > 0) {
	reset($params);
	while(list($key, $value) = each($params)) {
	  $this->build_params[$key] = $value;
	}
  }

  if (tep_not_null($this->html_images)) {
	reset($this->html_images);
	while (list(,$value) = each($this->html_images)) {
	  $this->html = str_replace($value['name'], 'cid:' . $value['cid'], $this->html);
	}
  }

  $null = NULL;
  $attachments = ((tep_not_null($this->attachments)) ? true : false);
  $html_images = ((tep_not_null($this->html_images)) ? true : false);
  $html = ((tep_not_null($this->html)) ? true : false);
  $text = ((tep_not_null($this->text)) ? true : false);

  switch (true) {
	case (($text == true) && ($attachments == false)):
/* HPDL PHP3 */
//		  $message =& $this->add_text_part($null, $this->text);
	  $message = $this->add_text_part($null, $this->text);
	  break;
	case (($text == false) && ($attachments == true) && ($html == false)):
/* HPDL PHP3 */
//		  $message =& $this->add_mixed_part();
	  $message = $this->add_mixed_part();

	  for ($i=0; $i<count($this->attachments); $i++) {
		$this->add_attachment_part($message, $this->attachments[$i]);
	  }
	  break;
	case (($text == true) && ($attachments == true)):
/* HPDL PHP3 */
//		  $message =& $this->add_mixed_part();
	  $message = $this->add_mixed_part();
	  $this->add_text_part($message, $this->text);

	  for ($i=0; $i<count($this->attachments); $i++) {
		$this->add_attachment_part($message, $this->attachments[$i]);
	  }
	  break;
	case (($html == true) && ($attachments == false) && ($html_images == false)):
	  if (tep_not_null($this->html_text)) {
/* HPDL PHP3 */
//			$message =& $this->add_alternative_part($null);
		$message = $this->add_alternative_part($null);
		$this->add_text_part($message, $this->html_text);
		$this->add_html_part($message);
	  } else {
/* HPDL PHP3 */
//			$message =& $this->add_html_part($null);
		$message = $this->add_html_part($null);
	  }
	  break;
	case (($html == true) && ($attachments == false) && ($html_images == true)):
	  if (tep_not_null($this->html_text)) {
/* HPDL PHP3 */
//			$message =& $this->add_alternative_part($null);
		$message = $this->add_alternative_part($null);
		$this->add_text_part($message, $this->html_text);
/* HPDL PHP3 */
//			$related =& $this->add_related_part($message);
		$related = $this->add_related_part($message);
	  } else {
/* HPDL PHP3 */
//			$message =& $this->add_related_part($null);
//			$related =& $message;
		$message = $this->add_related_part($null);
		$related = $message;
	  }
	  $this->add_html_part($related);

	  for ($i=0; $i<count($this->html_images); $i++) {
		$this->add_html_image_part($related, $this->html_images[$i]);
	  }
	  break;
	case (($html == true) && ($attachments == true) && ($html_images == false)):
/* HPDL PHP3 */
//		  $message =& $this->add_mixed_part();
	  $message = $this->add_mixed_part();
	  if (tep_not_null($this->html_text)) {
/* HPDL PHP3 */
//			$alt =& $this->add_alternative_part($message);
		$alt = $this->add_alternative_part($message);
		$this->add_text_part($alt, $this->html_text);
		$this->add_html_part($alt);
	  } else {
		$this->add_html_part($message);
	  }

	  for ($i=0; $i<count($this->attachments); $i++) {
		$this->add_attachment_part($message, $this->attachments[$i]);
	  }
	  break;
	case (($html == true) && ($attachments == true) && ($html_images == true)):
/* HPDL PHP3 */
//		  $message =& $this->add_mixed_part();
	  $message = $this->add_mixed_part();

	  if (tep_not_null($this->html_text)) {
/* HPDL PHP3 */
//			$alt =& $this->add_alternative_part($message);
		$alt = $this->add_alternative_part($message);
		$this->add_text_part($alt, $this->html_text);
/* HPDL PHP3 */
//			$rel =& $this->add_related_part($alt);
		$rel = $this->add_related_part($alt);
	  } else {
/* HPDL PHP3 */
//			$rel =& $this->add_related_part($message);
		$rel = $this->add_related_part($message);
	  }
	  $this->add_html_part($rel);

	  for ($i=0; $i<count($this->html_images); $i++) {
		$this->add_html_image_part($rel, $this->html_images[$i]);
	  }

	  for ($i=0; $i<count($this->attachments); $i++) {
		$this->add_attachment_part($message, $this->attachments[$i]);
	  }
	  break;
  }

  if ( (isset($message)) && (is_object($message)) ) {
	$output = $message->encode();
	$this->output = $output['body'];

	reset($output['headers']);
	while (list($key, $value) = each($output['headers'])) {
	  $headers[] = $key . ': ' . $value;
	}

	$this->headers = array_merge($this->headers, $headers);

	return true;
  } else {
	return false;
  }
}

/**
* Sends the mail.
*/

function send($to_name, $to_addr, $from_name, $from_addr, $subject = '', $headers = '') {
  if ((strstr($to_name, "\n") != false) || (strstr($to_name, "\r") != false)) {
	return false;
  }

  if ((strstr($to_addr, "\n") != false) || (strstr($to_addr, "\r") != false)) {
	return false;
  }

  if ((strstr($subject, "\n") != false) || (strstr($subject, "\r") != false)) {
	return false;
  }

  if ((strstr($from_name, "\n") != false) || (strstr($from_name, "\r") != false)) {
	return false;
  }

  if ((strstr($from_addr, "\n") != false) || (strstr($from_addr, "\r") != false)) {
	return false;
  }

  $to = (($to_name != '') ? '"' . $to_name . '" <' . $to_addr . '>' : $to_addr);
  $from = (($from_name != '') ? '"' . $from_name . '" <' . $from_addr . '>' : $from_addr);

  if (is_string($headers)) {
	$headers = explode($this->lf, trim($headers));
  }

  for ($i=0; $i<count($headers); $i++) {
	if (is_array($headers[$i])) {
	  for ($j=0; $j<count($headers[$i]); $j++) {
		if ($headers[$i][$j] != '') {
		  $xtra_headers[] = $headers[$i][$j];
		}
	  }
	}

	if ($headers[$i] != '') {
	  $xtra_headers[] = $headers[$i];
	}
  }

  if (!isset($xtra_headers)) {
	$xtra_headers = array();
  }
/*******************/
$sCharset = 'iso-8859-6';

// check to see if html encoded wide characters are present
if (strpos($subject, '') !== false)
{
	$sTempSubject = html_entity_decode($subject, ENT_QUOTES);
	$sTempSubject = preg_replace('/([a-f0-9]+);/mei',"chr(0x\\1)", $sTempSubject);
	$subject = '=?' . $sCharset . '?B?' . base64_encode($sTempSubject) . '?=';
}

$fEncode = false;
if (strpos($this->output, '') !== false)
{
	$fEncode = true;		// when this is set, the mail() calls below use the modified body

	// decode the html entities
	$sBodyText = html_entity_decode($this->output);
	$sBodyText = preg_replace('/([a-f0-9]+);/mei',"chr(0x\\1)", $sBodyText);

	// encode as base64
	$sBodyText = chunk_split(base64_encode($sBodyText));

	// change existing Content-transfer-encoding header
	$fFound = false;
	for ($i = 0; $i < count($this->headers) && !$fFound; $i++)
	{
		$nOff = strpos($this->headers[$i], ':');
		if ($nOff !== false)
		{
			if (strcasecmp(substr($this->headers[$i], 0, $nOff), 'Content-Transfer-Encoding') == 0)
			{
				$this->headers[$i] = 'Content-Transfer-Encoding: base64';
				$fFound = true;
			}
		}
	}
	if (!$fFound)
		$this->headers[] = 'Content-Transfer-Encoding: base64';

	// change existing content-type header
	$fFound = false;
	for ($i = 0; $i < count($this->headers) && !$fFound; $i++)
	{
		$nOff = strpos($this->headers[$i], ':');
		if ($nOff !== false)
		{
			if (strcasecmp(substr($this->headers[$i], 0, $nOff), 'Content-type') == 0)
			{
				$this->headers[$i] = 'Content-type: text/plain; encoding="' . $sCharset . '"';
				$fFound = true;
			}
		}
	}
	if (!$fFound)
		$this->headers[] = 'Content-type: application/octet stream; encoding="' . $sCharset . '"';
}

  if (EMAIL_TRANSPORT == 'smtp') {
	return mail($to_addr, $subject, ( $fEncode ? $sBodyText : $this->output), 'From: ' . $from . $this->lf . 'To: ' . $to . $this->lf . implode($this->lf, $this->headers) . $this->lf . implode($this->lf, $xtra_headers));
  } else {
	return mail($to, $subject, ( $fEncode ? $sBodyText : $this->output), 'From: '.$from.$this->lf.implode($this->lf, $this->headers).$this->lf.implode($this->lf, $xtra_headers));
  }
/**
* Use this method to return the email
* in message/rfc822 format. Useful for
* adding an email to another email as
* an attachment. there's a commented
* out example in example.php.
*
* string get_rfc822(string To name,
*	   string To email,
*	   string From name,
*	   string From email,
*	   [string Subject,
*		string Extra headers])
*/

function get_rfc822($to_name, $to_addr, $from_name, $from_addr, $subject = '', $headers = '') {
// Make up the date header as according to RFC822
  $date = 'Date: ' . date('D, d M y H:i:s');
  $to = (($to_name != '') ? 'To: "' . $to_name . '" <' . $to_addr . '>' : 'To: ' . $to_addr);
  $from = (($from_name != '') ? 'From: "' . $from_name . '" <' . $from_addr . '>' : 'From: ' . $from_addr);

  if (is_string($subject)) {
	$subject = 'Subject: ' . $subject;
  }

  if (is_string($headers)) {
	$headers = explode($this->lf, trim($headers));
  }

  for ($i=0; $i<count($headers); $i++) {
	if (is_array($headers[$i])) {
	  for ($j=0; $j<count($headers[$i]); $j++) {
		if ($headers[$i][$j] != '') {
		  $xtra_headers[] = $headers[$i][$j];
		}
	  }
	}

	if ($headers[$i] != '') {
	  $xtra_headers[] = $headers[$i];
	}
  }

  if (!isset($xtra_headers)) {
	$xtra_headers = array();
  }

  $headers = array_merge($this->headers, $xtra_headers);

  return $date . $this->lf . $from . $this->lf . $to . $this->lf . $subject . $this->lf . implode($this->lf, $headers) . $this->lf . $this->lf . $this->output;
}}
?>

arietis · April 8, 2008

I keep see this error when i inter the admin cp:
Parse error: syntax error, unexpected ';', expecting T_FUNCTION in D:\hshome\**\**\Admin\includes\classes\email.php on line 632

on about line 576 you have:

	  if (EMAIL_TRANSPORT == 'smtp') {
	return mail($to_addr, $subject, ( $fEncode ? $sBodyText : $this->output), 'From: ' . $from . $this->lf . 'To: ' . $to . $this->lf . implode($this->lf, $this->headers) . $this->lf . implode($this->lf, $xtra_headers));
  } else {
	return mail($to, $subject, ( $fEncode ? $sBodyText : $this->output), 'From: '.$from.$this->lf.implode($this->lf, $this->headers).$this->lf.implode($this->lf, $xtra_headers));
  }

and you need:

	  if (EMAIL_TRANSPORT == 'smtp') {
	return mail($to_addr, $subject, ( $fEncode ? $sBodyText : $this->output), 'From: ' . $from . $this->lf . 'To: ' . $to . $this->lf . implode($this->lf, $this->headers) . $this->lf . implode($this->lf, $xtra_headers));
  } else {
	return mail($to, $subject, ( $fEncode ? $sBodyText : $this->output), 'From: '.$from.$this->lf.implode($this->lf, $this->headers).$this->lf.implode($this->lf, $xtra_headers));
  }
}

just add the second close brace (}) at the end and it should fix it for you.

Liquid Snake · April 14, 2008

Hello

I just tested the code, everything is working great except one thing which is so weird I just found it out!

When I send E-mail using Arabic sentience in the subject it shows some other letters, for example when I write "Hello, Welcome to our store" it shows as "Geldf, wseddkf, eldofpe"

I hope you understand what i mean

other then that everything is working great

Thanks alot

arietis · April 14, 2008

i just sent you a pm...we'll see if we can get rid of that for you.

No email delevered to the user when subjected by Arabic words!

Recommended Posts

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Archived