Freedom Fighter Posted December 5, 2002 Posted December 5, 2002 Okay, I have a computer hardware reveiw site and just as we start to get 2000+ hits a day, I get this nice little warning message above my logo that says: Warning: mysql_num_rows(): supplied argument is not a valid MySQL result resource in /home/virtual/site3/fst/var/www/html/includes/sql_layer.php on line 238 You can actually see the warning message by going to: http://www.computersphere.net This stupid message is making the site look like crap and annoying. If anyone could help me with this I would deeply appericate it. I have already been the the PHP Nuke forums but they don't know what the heck they are doing and no one is helping me, so I thought I would come to my favortie place! I appericate everyones help with this! Thanks, Alex Extreme Alterations
dahammer2 Posted December 5, 2002 Posted December 5, 2002 At a guess just before line 238 is a SQL statement which fails i.e. bad syntax/missing something.. I'd start by finding out whats wrong with that..
Freedom Fighter Posted December 5, 2002 Author Posted December 5, 2002 Here it is.. I can't find anything wrong?? <?php /************************************************************************/ /* PHP-NUKE: Web Portal System */ /* =========================== */ /* */ /* Copyright © 2002 by Francisco Burzi */ /* http://phpnuke.org */ /* */ /* PostgreSQL fix by Rub?n Campos - Oscar Silla */ /* */ /* This program is free software. You can redistribute it and/or modify */ /* it under the terms of the GNU General Public License as published by */ /* the Free Software Foundation; either version 2 of the License. */ /************************************************************************/ if (eregi("sql_layer.php",$PHP_SELF)) { Header("Location: ../index.php"); die(); } /* $dbtype = "MySQL"; */ /* $dbtype = "mSQL"; */ /* $dbtype = "PostgreSQL"; */ /* $dbtype = "PostgreSQL_local";// When postmaster start without "-i" option. */ /* $dbtype = "ODBC"; */ /* $dbtype = "ODBC_Adabas"; */ /* $dbtype = "Interbase"; */ /* $dbtype = "Sybase"; */ /* * sql_connect($host, $user, $password, $db) * returns the connection ID */ class ResultSet { var $result; var $total_rows; var $fetched_rows; function set_result( $res ) { $this->result = $res; } function get_result() { return $this->result; } function set_total_rows( $rows ) { $this->total_rows = $rows; } function get_total_rows() { return $this->total_rows; } function set_fetched_rows( $rows ) { $this->fetched_rows = $rows; } function get_fetched_rows() { return $this->fetched_rows; } function increment_fetched_rows() { $this->fetched_rows = $this->fetched_rows + 1; } } function sql_connect($host, $user, $password, $db) { global $dbtype; switch ($dbtype) { case "MySQL": $dbi=@mysql_connect($host, $user, $password); mysql_select_db($db); return $dbi; break;; case "mSQL": $dbi=msql_connect($host); msql_select_db($db); return $dbi; break;; case "PostgreSQL": $dbi=@pg_connect("host=$host user=$user password=$password port=5432 dbname=$db"); return $dbi; break;; case "PostgreSQL_local": $dbi=@pg_connect("user=$user password=$password dbname=$db"); return $dbi; break;; case "ODBC": $dbi=@odbc_connect($db,$user,$password); return $dbi; break;; case "ODBC_Adabas": $dbi=@odbc_connect($host.":".$db,$user,$password); return $dbi; break;; case "Interbase": $dbi=@ibase_connect($host.":".$db,$user,$password); return $dbi; break;; case "Sybase": $dbi=@sybase_connect($host, $user, $password); sybase_select_db($db,$dbi); return $dbi; break;; default: break;; } } function sql_logout($id) { global $dbtype; switch ($dbtype) { case "MySQL": $dbi=@mysql_close($id); return $dbi; break;; case "mSQL": $dbi=@msql_close($id); return $dbi; break;; case "PostgreSQL": case "PostgreSQL_local": $dbi=@pg_close($id); return $dbi; break;; case "ODBC": case "ODBC_Adabas": $dbi=@odbc_close($id); return $dbi; break;; case "Interbase": $dbi=@ibase_close($id); return $dbi; break;; case "Sybase": $dbi=@sybase_close($id); return $dbi; break;; default: break;; } } /* * sql_query($query, $id) * executes an SQL statement, returns a result identifier */ function sql_query($query, $id) { global $dbtype; global $sql_debug; $sql_debug = 0; if($sql_debug) echo "SQL query: ".str_replace(",",", ",$query)."<BR>"; switch ($dbtype) { case "MySQL": $res=@mysql_query($query, $id); return $res; break;; case "mSQL": $res=@msql_query($query, $id); return $res; break;; case "PostgreSQL": case "PostgreSQL_local": $res=pg_exec($id,$query); $result_set = new ResultSet; $result_set->set_result( $res ); $result_set->set_total_rows( sql_num_rows( $result_set ) ); $result_set->set_fetched_rows( 0 ); return $result_set; break;; case "ODBC": case "ODBC_Adabas": $res=@odbc_exec($id,$query); return $res; break;; case "Interbase": $res=@ibase_query($id,$query); return $res; break;; case "Sybase": $res=@sybase_query($query, $id); return $res; break;; default: break;; } } /* * sql_num_rows($res) * given a result identifier, returns the number of affected rows */ function sql_num_rows($res) { global $dbtype; switch ($dbtype) { case "MySQL": $rows=mysql_num_rows($res); return $rows; break;; case "mSQL": $rows=msql_num_rows($res); return $rows; break;; case "PostgreSQL": case "PostgreSQL_local": $rows=pg_numrows( $res->get_result() ); return $rows; break;; case "ODBC": case "ODBC_Adabas": $rows=odbc_num_rows($res); return $rows; break;; case "Interbase": echo "<BR>Error! PHP dosen't support ibase_numrows!<BR>"; return $rows; break;; case "Sybase": $rows=sybase_num_rows($res); return $rows; break;; default: break;; } } /* * sql_fetch_row(&$res,$row) * given a result identifier, returns an array with the resulting row * Needs also a row number for compatibility with PostgreSQL */ function sql_fetch_row(&$res, $nr) { global $dbtype; switch ($dbtype) { case "MySQL": $row = mysql_fetch_row($res); return $row; break;; case "mSQL": $row = msql_fetch_row($res); return $row; break;; case "PostgreSQL": case "PostgreSQL_local": if ( $res->get_total_rows() > $res->get_fetched_rows() ) { $row = pg_fetch_row($res->get_result(), $res->get_fetched_rows() ); $res->increment_fetched_rows(); return $row; } else { return false; } break;; case "ODBC": case "ODBC_Adabas": $row = array(); $cols = odbc_fetch_into($res, $nr, $row); return $row; break;; case "Interbase": $row = ibase_fetch_row($res); return $row; break;; case "Sybase": $row = sybase_fetch_row($res); return $row; break;; default: break;; } } /* * sql_fetch_array($res,$row) * given a result identifier, returns an associative array * with the resulting row using field names as keys. * Needs also a row number for compatibility with PostgreSQL. */ function sql_fetch_array(&$res, $nr) { global $dbtype; switch ($dbtype) { case "MySQL": $row = array(); $row = mysql_fetch_array($res); return $row; break;; case "mSQL": $row = array(); $row = msql_fetch_array($res); return $row; break;; case "PostgreSQL": case "PostgreSQL_local": if( $res->get_total_rows() > $res->get_fetched_rows() ) { $row = array(); $row = pg_fetch_array($res->get_result(), $res->get_fetched_rows() ); $res->increment_fetched_rows(); return $row; } else { return false; } break;; /* * ODBC doesn't have a native _fetch_array(), so we have to * use a trick. Beware: this might cause HUGE loads! */ case "ODBC": $row = array(); $result = array(); $result = odbc_fetch_row($res, $nr); $nf = odbc_num_fields($res); /* Field numbering starts at 1 */ for($count=1; $count < $nf+1; $count++) { $field_name = odbc_field_name($res, $count); $field_value = odbc_result($res, $field_name); $row[$field_name] = $field_value; } return $row; break;; case "ODBC_Adabas": $row = array(); $result = array(); $result = odbc_fetch_row($res, $nr); $nf = count($result)+2; /* Field numbering starts at 1 */ for($count=1; $count < $nf; $count++) { $field_name = odbc_field_name($res, $count); $field_value = odbc_result($res, $field_name); $row[$field_name] = $field_value; } return $row; break;; case "Interbase": $orow=ibase_fetch_object($res); $row=get_object_vars($orow); return $row; break;; case "Sybase": $row = sybase_fetch_array($res); return $row; break;; } } function sql_fetch_object(&$res, $nr) { global $dbtype; switch ($dbtype) { case "MySQL": $row = mysql_fetch_object($res); if($row) return $row; else return false; break;; case "mSQL": $row = msql_fetch_object($res); if($row) return $row; else return false; break;; case "PostgreSQL": case "PostgreSQL_local": if( $res->get_total_rows() > $res->get_fetched_rows() ) { $row = pg_fetch_object( $res->get_result(), $res->get_fetched_rows() ); $res->increment_fetched_rows(); if($row) return $row; else return false; } else { return false; } break;; case "ODBC": $result = odbc_fetch_row($res, $nr); if(!$result) return false; $nf = odbc_num_fields($res); /* Field numbering starts at 1 */ for($count=1; $count < $nf+1; $count++) { $field_name = odbc_field_name($res, $count); $field_value = odbc_result($res, $field_name); $row->$field_name = $field_value; } return $row; break;; case "ODBC_Adabas": $result = odbc_fetch_row($res, $nr); if(!$result) return false; $nf = count($result)+2; /* Field numbering starts at 1 */ for($count=1; $count < $nf; $count++) { $field_name = odbc_field_name($res, $count); $field_value = odbc_result($res, $field_name); $row->$field_name = $field_value; } return $row; break;; case "Interbase": $orow = ibase_fetch_object($res); if($orow) { $arow=get_object_vars($orow); while(list($name,$key)=each($arow)) { $name=strtolower($name); $row->$name=$key; } return $row; }else return false; break;; case "Sybase": $row = sybase_fetch_object($res); return $row; break;; } } /*** Function Free Result for function free the memory ***/ function sql_free_result($res) { global $dbtype; switch ($dbtype) { case "MySQL": $row = mysql_free_result($res); return $row; break;; case "mSQL": $row = msql_free_result($res); return $row; break;; case "PostgreSQL": case "PostgreSQL_local": $rows=pg_FreeResult( $res->get_result() ); return $rows; break;; case "ODBC": case "ODBC_Adabas": $rows=odbc_free_result($res); return $rows; break;; case "Interbase": echo "<BR>Error! PHP dosen't support ibase_numrows!<BR>"; return $rows; break;; case "Sybase": $rows=sybase_free_result($res); return $rows; break;; } } ?> Please help!! Extreme Alterations
dahammer2 Posted December 5, 2002 Posted December 5, 2002 well, theres nothing wrong with it thats why :) You have to debug and work backwards and discover where the procedure "sql_num_rows($reS)" is being called And before that line at a guess there will be a sql_query() function being called its the query being passed into that, which is the probably the problem. try changing this (line 184ish in that file you pasted here) case "MySQL": $res=@mysql_query($query, $id); return $res; break;; to case "MySQL": $res=mysql_query($query, $id) or die("This query string killed it!<br>:" . $query); return $res; break;; Least this will output the bad querystring and you can do a search to find it.. Once you find the bad query I would suggest you go back to the phpnuke forum and say: "This query X in file X on line X broke my shop, can anyone suggest a solution?" This [/code]
Freedom Fighter Posted December 5, 2002 Author Posted December 5, 2002 I did what you said and it gave me the error that says. This que killed it and what not.. So I loaded my old file and of course it still doesn't work correctly. It has the gay warning at the top. Someone please help me!! I'm losing my mind!!!!!!!! Alex Extreme Alterations
dahammer2 Posted December 5, 2002 Posted December 5, 2002 It was meant to say "this query killed it". and then show you the query so you can see whats wrong with the query. Now if you can't actually see whats wrong with the query then post a question including the query that the error message outputted. Bassically with the little information your telling me all I can tell you is "Theres a broken query, fix it".
rseigel Posted December 5, 2002 Posted December 5, 2002 This que killed it and what not.. Just stop and look at what you're writing for a second! How on earth is anyone here (or anywhere else for that matter) supposed to help you if you refuse to be specific. It has the gay warning at the top. Huh? What "gay warning"? :roll:
Freedom Fighter Posted December 5, 2002 Author Posted December 5, 2002 I fixed it.. I optimized the database :) Alex - Admin Extreme Alterations
Mark Evans Posted December 5, 2002 Posted December 5, 2002 This has nothing to do with osCommerce you should be using the PHP nukes forum for problems with PHP nuke. This thread is now locked. Mark Evans osCommerce Monkey & Lead Guitarist for "Sparky + the Monkeys" (Album on sale in all good record shops) --------------------------------------- Software is like sex: It's better when it's free. (Linus Torvalds)
New 
Recommended Posts
Archived
This topic is now archived and is closed to further replies.