Bug in specials.php - Wrong strike

October 30, 2007

Hello there....

I searched to find a similar issue on the specials.php file but most if not all with syntax errors and some other bugs.. I couldn't find something similar to mine!

I purchased a template and its been installed and configured fine.. Now testing... And this is what i get on the specials.php page: LINK

If you look at the strike, it is the other way around, it appear on the lowest figure/price and not the highest tho! On the check out process page it shows the right discounted price!

So any help about this considering that I am not really a coder but a photographer and designer! It will be really appreciated if you guys can help. :blush:

Regards,

JOE

Nerf-Herder · November 12, 2007

Hey Joe! What do ya know? (Sorry.)

Let me preface this by saying I suck with PHP. I purchased a template from template-help.com, which is one of many domain names this group of template people uses, and had exactly the same problem. Support got back to me and provided an updated product_info.php file, and stated that it was a problem with the template.

Here's the part where I start sucking:

I have no idea what they changed, but I'm pasting the contents of file in the hopes that you might be able to give it the once over and get it figured out. I know for a fact that this is a big issue with the templates. There are hundres of people reporting this issue with them. If you figure out the difference, please... PLEASE post it back here. I'm sure there are a bunch of people that wold benefit from the knowledge.

Thanx, and good luck.

Jon-

Contents of product_info.php from fixed template:

<?php

/*

$Id: product_info.php,v 1.97 2003/07/01 14:34:54 hpdl Exp $

osCommerce, Open Source E-Commerce Solutions

http://www.oscommerce.com

Released under the GNU General Public License

*/

require('includes/application_top.php');

require(DIR_WS_LANGUAGES . $language . '/' . FILENAME_PRODUCT_INFO);

$product_check_query = tep_db_query("select count(*) as total from " . TABLE_PRODUCTS . " p, " . TABLE_PRODUCTS_DESCRIPTION . " pd where p.products_status = '1' and p.products_id = '" . (int)$HTTP_GET_VARS['products_id'] . "' and pd.products_id = p.products_id and pd.language_id = '" . (int)$languages_id . "'");

$product_check = tep_db_fetch_array($product_check_query);

?>

<!doctype html public "-//W3C//DTD HTML 4.01 Transitional//EN">

<head>

function popupWindow(url) {

window.open(url,'popupWindow','toolbar=no,location=no,directories=no,status=no,menubar=no,scrollbars=no,res

izable=yes,copyhistory=no,width=100,height=100,screenX=150,screenY=150,top=150,le

ft=150')

}

//--></script>

</head>

<body>

<?php require(DIR_WS_INCLUDES . 'header.php'); ?>

<tr>

<?php require(DIR_WS_INCLUDES . 'column_left.php'); ?>

</td>

<?php

if ($product_check['total'] < 1) {

?>

<?

/*

<?php echo TEXT_PRODUCT_NOT_FOUND;?>

*/

?>

<? tep_draw_heading_top(); ?>

<?php tep_draw_titletop();?>

<? echo(tep_image(DIR_WS_IMAGES.'1_z3.gif'))?> <?php echo TEXT_PRODUCT_NOT_FOUND;?>

<?php tep_draw_titlebottom();?>

<? tep_draw_heading_top_1(); ?>

<? echo $tep_draw_heading_top_prod_type1?>

</table>

<tr>

<td align="right"><?php echo '<a href="' . tep_href_link(FILENAME_DEFAULT) . '">' . tep_image_button('button_continue.gif', IMAGE_BUTTON_CONTINUE) . '</a>'; ?></td>

</tr>

</table>

<?php echo tep_draw_separator('spacer.gif', '1', '15'); ?><br>

<? echo $tep_draw_heading_bottom_prod_type1?>

<? tep_draw_heading_bottom_1(); ?>

<? tep_draw_heading_bottom(); ?>

<?php

} else {

$product_info_query = tep_db_query("select p.products_id, pd.products_name, pd.products_description, p.products_model, p.products_quantity, p.products_image, pd.products_url, p.products_price, p.products_tax_class_id, p.products_date_added, p.products_date_available, p.manufacturers_id from " . TABLE_PRODUCTS . " p, " . TABLE_PRODUCTS_DESCRIPTION . " pd where p.products_status = '1' and p.products_id = '" . (int)$HTTP_GET_VARS['products_id'] . "' and pd.products_id = p.products_id and pd.language_id = '" . (int)$languages_id . "'");

$product_info = tep_db_fetch_array($product_info_query);

tep_db_query("update " . TABLE_PRODUCTS_DESCRIPTION . " set products_viewed = products_viewed+1 where products_id = '" . (int)$HTTP_GET_VARS['products_id'] . "' and language_id = '" . (int)$languages_id . "'");

if ($new_price = tep_get_products_special_price($product_info['products_id'])) {

$products_price = '<span class="price_txt_strice">' . $currencies->display_price($product_info['products_price'], tep_get_tax_rate($product_info['products_tax_class_id'])) . '</span> <span class="price_txt">' . $currencies->display_price($new_price, tep_get_tax_rate($product_info['products_tax_class_id'])) . '</span>';

} else {

$products_price = '<span class="price_txt">'.$currencies->display_price($product_info['products_price'], tep_get_tax_rate($product_info['products_tax_class_id']).'</span>');

}

if (tep_not_null($product_info['products_model']))

{

$products_name = $product_info['products_name'] . '<br><span class="smallText">[' . $product_info['products_model'] . ']</span>';

} else {

$products_name = $product_info['products_name'];

}

?>

<tr>

<td>

<? tep_draw_heading_top(); ?>

<? /* going title */ ?>

<?php tep_draw_titletop();?>

<?php echo $breadcrumb->trail(' » ')?>

<?php tep_draw_titlebottom();?>

<? tep_draw_heading_top_3(); ?>

<? tep_draw_heading_top_2(); ?>

<? /*

<?php echo $products_name; ?>

<?php echo $breadcrumb->trail(' » ')?>

*/ ?>

<?php

if (tep_not_null($product_info['products_image'])) {

?>

<tr>

</td>

</tr>

</table>

</td>

</tr>

</table>

<tr>

<!--

document.write('<?php echo '<a href="java script:popupWindow(\\\'' . tep_href_link(FILENAME_POPUP_IMAGE, 'pID=' . $product_info['products_id']) . '\\\')">' . tep_image(DIR_WS_IMAGES . $product_info['products_image'],

addslashes($product_info['products_name']), SMALL_IMAGE_WIDTH, SMALL_IMAGE_HEIGHT, 'hspace="0" vspace="0"') . '</a>'; ?>');

//--></script>

<?php echo '<a href="' . tep_href_link(DIR_WS_IMAGES . $product_info['products_image']) . '" target="_blank">' . tep_image(DIR_WS_IMAGES . $product_info['products_image'], $product_info['products_name'], SMALL_IMAGE_WIDTH, SMALL_IMAGE_HEIGHT, 'hspace="0" vspace="0"') . '</a>'; ?><br>

</noscript>

<br>

document.write('<?php echo '<br style="line-height:10px;">

<div><a href="java script:popupWindow(\\\'' . tep_href_link(FILENAME_POPUP_IMAGE, 'pID=' . $product_info['products_id']) . '\\\')">' . TEXT_CLICK_TO_ENLARGE . '</a></div>'; ?>');

//--></script>

<?php echo '<br style="line-height:10px;"><div><a href="' . tep_href_link(DIR_WS_IMAGES . $product_info['products_image']) . '" target="_blank">

' . TEXT_CLICK_TO_ENLARGE . '</a>

</div>'; ?>

</noscript><br>

<?php echo '<br style="line-height:10px;"><div class="link7"><a href="' . tep_href_link(DIR_WS_IMAGES . $product_info['products_image']) . '" target="_blank">

' . TEXT_CLICK_TO_ENLARGE . '</a>

</div>'; ?>

</td>

<td>

<tr>

<?php echo tep_draw_separator('spacer.gif', '1', '1'); ?><br>

</td>

</tr>

</table>

<tr>

<tr>

<tr>

<tr>

<tr>

</td>

<?php echo tep_draw_separator('spacer.gif', '1', '14'); ?><br>

<?php echo tep_draw_hidden_field('products_id', $product_info['products_id']) . tep_image_submit('button_add_to_cart1.gif', IMAGE_BUTTON_IN_CART); ?><br>

<?php echo tep_draw_separator('spacer.gif', '1', '4'); ?><br>

<?php echo '<a href="' . tep_href_link(FILENAME_PRODUCT_REVIEWS, tep_get_all_get_params()) . '">' . tep_image_button('button_reviews.gif', IMAGE_BUTTON_REVIEWS) . '</a>'; ?><br>

</td>

</tr>

</table>

</td>

</tr>

</table>

</td>

</tr>

</table>

</td>

</tr>

</table>

</td>

</tr>

</table>

</td>

</tr>

</table>

<tr>

<?php

}

?>

<?php

$products_attributes_query = tep_db_query("select count(*) as total from " . TABLE_PRODUCTS_OPTIONS . " popt, " . TABLE_PRODUCTS_ATTRIBUTES . " patrib where patrib.products_id='" . (int)$HTTP_GET_VARS['products_id'] . "' and patrib.options_id = popt.products_options_id and popt.language_id = '" . (int)$languages_id . "'");

$products_attributes = tep_db_fetch_array($products_attributes_query);

if ($products_attributes['total'] > 0) {

?>

<?php echo TEXT_PRODUCT_OPTIONS; ?></strong></td></tr>

<?php

$products_options_name_query = tep_db_query("select distinct popt.products_options_id, popt.products_options_name from " . TABLE_PRODUCTS_OPTIONS . " popt, " . TABLE_PRODUCTS_ATTRIBUTES . " patrib where patrib.products_id='" . (int)$HTTP_GET_VARS['products_id'] . "' and patrib.options_id = popt.products_options_id and popt.language_id = '" . (int)$languages_id . "' order by popt.products_options_name");

while ($products_options_name = tep_db_fetch_array($products_options_name_query)) {

$products_options_array = array();

$products_options_query = tep_db_query("select pov.products_options_values_id, pov.products_options_values_name, pa.options_values_price, pa.price_prefix from " . TABLE_PRODUCTS_ATTRIBUTES . " pa, " . TABLE_PRODUCTS_OPTIONS_VALUES . " pov where pa.products_id = '" . (int)$HTTP_GET_VARS['products_id'] . "' and pa.options_id = '" . (int)$products_options_name['products_options_id'] . "' and pa.options_values_id = pov.products_options_values_id and pov.language_id = '" . (int)$languages_id . "'");

while ($products_options = tep_db_fetch_array($products_options_query)) {

$products_options_array[] = array('id' => $products_options['products_options_values_id'], 'text' => $products_options['products_options_values_name']);

if ($products_options['options_values_price'] != '0') {

$products_options_array[sizeof($products_options_array)-1]['text'] .= ' (' . $products_options['price_prefix'] . $currencies->display_price($products_options['options_values_price'], tep_get_tax_rate($product_info['products_tax_class_id'])) .') ';

}

if (isset($cart->contents[$HTTP_GET_VARS['products_id']]['attributes'][$products_options_name['products_options_id']])) {

$selected_attribute = $cart->contents[$HTTP_GET_VARS['products_id']]['attributes'][$products_options_name['products_options_id']];

} else {

$selected_attribute = false;

}

?>

<tr>

</tr>

<?php

}

?>

</table>

<?php

}

?>

<?php

$reviews_query = tep_db_query("select count(*) as count from " . TABLE_REVIEWS . " where products_id = '" . (int)$HTTP_GET_VARS['products_id'] . "'");

$reviews = tep_db_fetch_array($reviews_query);

if ($reviews['count'] > 0) {

?>

<?php echo TEXT_CURRENT_REVIEWS . ' ' . $reviews['count']; ?>

</td></tr>

</table>

<?php

}

if (tep_not_null($product_info['products_url'])) {

?>

<?php echo sprintf(TEXT_MORE_INFORMATION, tep_href_link(FILENAME_REDIRECT, 'action=url&goto=' . urlencode($product_info['products_url']), 'NONSSL', true, false)); ?>

</td></tr>

</table>

<?php

}

if ($product_info['products_date_available'] > date('Y-m-d H:i:s')) {

?>

</table>

<?php

} else {

?>

</table>

<?php

}

?>

<?php echo stripslashes($product_info['products_description']); ?><br>

</div>

<? tep_draw_heading_bottom_2(); ?>

<? tep_draw_heading_bottom_3(); ?>

<?php tep_draw_heading_bottom();?>

<?php

if ((USE_CACHE == 'true') && empty($SID)) {

echo tep_cache_also_purchased(3600);

} else {

?>

<?php

//include(DIR_WS_MODULES . FILENAME_ALSO_PURCHASED_PRODUCTS);

?>

<?php

}

?>

<?

}

?>

</td></tr>

</table></form>

</td>

<?php require(DIR_WS_INCLUDES . 'column_right.php'); ?>

</td>

</tr>

</table>

<?php require(DIR_WS_INCLUDES . 'footer.php'); ?>

</body>

</html>

<?php require(DIR_WS_INCLUDES . 'application_bottom.php'); ?>

----------------------------------------------------

That's it! (without the line above) Ha ha ha...

November 13, 2007

Hello Jon..

And thank you for your reply my friend... I know there are a lot of issues with the pre-made/ready osCommerce templates tho.. But I didn't know before! And that is why they are cheap... In fact we are buying the layout you know what I mean!

Anyways... I tried your fix... And It didn't work tho...

I also think it is not that file: product_info.php... I think the whole problem will be in the specials.php since it shows only on that page!!

Thank you so much for the help, it meant a lot to me.. And hope that some geek will appear and show his/her help here

Regards,

JOE

November 13, 2007

Here is my specials.php content..

Any help?!!

<?php

/*

$Id: specials.php,v 1.49 2003/06/09 22:35:33 hpdl Exp $

osCommerce, Open Source E-Commerce Solutions

http://www.oscommerce.com

Released under the GNU General Public License

*/

require('includes/application_top.php');

require(DIR_WS_LANGUAGES . $language . '/' . FILENAME_SPECIALS);

$breadcrumb->add(NAVBAR_TITLE, tep_href_link(FILENAME_SPECIALS));

?>

<!doctype html public "-//W3C//DTD HTML 4.01 Transitional//EN">

<head>

</head>

<?php require(DIR_WS_INCLUDES . 'header.php'); ?>

<tr>

<?php require(DIR_WS_INCLUDES . 'column_left.php'); ?>

</td>

<?php /* require(DIR_WS_BOXES . 'panel_top.php'); */ ?>

<? tep_draw_heading_top();?>

<? new contentBoxHeading_ProdNew($info_box_contents);?>

<? tep_draw_heading_top_1();?>

<?php

$specials_query_raw = "select p.products_id, pd.products_name, p.products_price, p.products_tax_class_id, p.products_image, s.specials_new_products_price from " . TABLE_PRODUCTS . " p, " . TABLE_PRODUCTS_DESCRIPTION . " pd, " . TABLE_SPECIALS . " s where p.products_status = '1' and s.products_id = p.products_id and p.products_id = pd.products_id and pd.language_id = '" . (int)$languages_id . "' and s.status = '1' order by s.specials_date_added DESC";

$specials_split = new splitPageResults($specials_query_raw, MAX_DISPLAY_SPECIAL_PRODUCTS);

if (($specials_split->number_of_rows > 0) && ((PREV_NEXT_BAR_LOCATION == '1') || (PREV_NEXT_BAR_LOCATION == '2'))) {

?>

<tr>

<td><?php echo $specials_split->display_count(TEXT_DISPLAY_NUMBER_OF_SPECIALS); ?></td>

<td class="result_right"><?php echo TEXT_RESULT_PAGE . ' ' . $specials_split->display_links(MAX_DISPLAY_PAGE_LINKS, tep_get_all_get_params(array('page', 'info', 'x', 'y'))); ?></td>

</tr>

</table>

<?php echo tep_draw_result_top(); ?>

<?php

}

?>

<?php

$row = 0;

$specials_query = tep_db_query($specials_split->sql_query);

$row = 0;

$col = 0;

$info_box_contents = array();

while ($specials = tep_db_fetch_array($specials_query)) {

$specials['products_name'] = tep_get_products_name($specials['products_id']);

// ----------

$product_query = tep_db_query("select products_description, products_id from " . TABLE_PRODUCTS_DESCRIPTION . " where products_id = '" . (int)$specials['products_id'] . "' and language_id = '" . (int)$languages_id . "'");

$product = tep_db_fetch_array($product_query);

$p_desc = substr($product['products_description'], 0, MAX_DESCR_1);

$p_id = $product['products_id'];

$p_pic = '<a href="' . tep_href_link(FILENAME_PRODUCT_INFO, 'products_id=' . $specials['products_id']) . '">' . tep_image(DIR_WS_IMAGES . $specials['products_image'], $specials['products_name'], SMALL_IMAGE_WIDTH, SMALL_IMAGE_HEIGHT) . '</a>';

$p_name = '<a href="' . tep_href_link(FILENAME_PRODUCT_INFO, 'products_id=' . $specials['products_id']) . '">' . $specials['products_name'] . '</a>';

$p_price = $currencies->display_price($specials['products_price'], tep_get_tax_rate($specials['products_tax_class_id'])).'</strong> <s>'.$currencies->display_price($specials['specials_new_products_price'],'').'</s>';

// ----------

$info_box_contents[$row][$col] = array('align' => 'center',

'params' => ' valign="top"',

'text' => ''.tep_draw_prod_top().'

<tr>

'.$p_name.'</td>

</tr>

<tr>

</tr>

<tr>

</tr>

<tr>

<tr>

<td width="87" height="29"><span>'.$p_price.'</span></td>

</tr>

<tr><td><a href="' . tep_href_link('product_info.php?products_id='.$p_id) . '">'.tep_image_button("button_details.gif").'</a></td>

<td><a href="'.tep_href_link("products_new.php","action=buy_now&products_id=".$p_id).'">'.tep_image_button('button_add_to_cart1.gif').'</a><br></td></tr>

</table>

</td></tr>

</table>

</td>

</tr>

</table>

'.tep_draw_prod_bottom());

$col ++;

if ($col > 2) {

$col = 0;

$row ++;

}

new contentBox($info_box_contents);

?>

<?php

if (($specials_split->number_of_rows > 0) && ((PREV_NEXT_BAR_LOCATION == '2') || (PREV_NEXT_BAR_LOCATION == '3'))) {

?>

<?php echo tep_draw_result_bottom(); ?>

<tr>

<td><?php echo $specials_split->display_count(TEXT_DISPLAY_NUMBER_OF_SPECIALS); ?></td>

<td class="result_right"><?php echo TEXT_RESULT_PAGE . ' ' . $specials_split->display_links(MAX_DISPLAY_PAGE_LINKS, tep_get_all_get_params(array('page', 'info', 'x', 'y'))); ?></td>

</tr>

</table>

<?php

}

?>

<? tep_draw_heading_bottom_1();?>

<? tep_draw_heading_bottom();?>

</td>

<?php require(DIR_WS_INCLUDES . 'column_right.php'); ?>

</td>

</tr>

</table>

<?php require(DIR_WS_INCLUDES . 'footer.php'); ?>

</body>

</html>

<?php require(DIR_WS_INCLUDES . 'application_bottom.php'); ?>

Regards,

JOE

spax · November 13, 2007

The specials price is called from a number of files, including product_info.php. Yours seems to have the strike through on the wrong price. Comment out this piece of code in your specials.php, as I have done it with // it should be on one line

// $p_price = $currencies->display_price($specials['products_price'], tep_get_tax_rate($specials['products_tax_class_id'])).'</strong> <s>'.$currencies->display_price($specials['specials_new_products_price'],'').'</s>';

and put this in its place

$p_price = '<s>' . $currencies->display_price($specials['products_price'], tep_get_tax_rate($specials['products_tax_class_id'])).'</s>'.$currencies->display_price($specials['specials_new_products_price'],'');

See if that works for you.

November 14, 2007

The specials price is called from a number of files, including product_info.php. Yours seems to have the strike through on the wrong price. Comment out this piece of code in your specials.php, as I have done it with // it should be on one line
// $p_price = $currencies->display_price($specials['products_price'], tep_get_tax_rate($specials['products_tax_class_id'])).'</strong> <s>'.$currencies->display_price($specials['specials_new_products_price'],'').'</s>';
and put this in its place
$p_price = '<s>' . $currencies->display_price($specials['products_price'], tep_get_tax_rate($specials['products_tax_class_id'])).'</s>'.$currencies->display_price($specials['specials_new_products_price'],'');
See if that works for you.

OMG!! Thank you so much Spax!!! It did fix the DANG annoying issue my friend!! :thumbsup: And it really meant a lot to me! Thank you so much for the help and/or quick pro support!

Hopefully that will be helpful to all the others with similar issue on the same specials.php file! ;)

Regards,

JOE

spax · November 14, 2007

No problem! Glad it worked.

Escu · January 1, 2008

YOU SAVED ME TOO. THANKS

Bug in specials.php - Wrong strike

Recommended Posts

Guest

Nerf-Herder

Guest

Guest

spax

Guest

spax

Escu

Archived

Browse

Activity