Jump to content
  • Checkout
  • Login
  • Get in touch

osCommerce

The e-commerce.

Download Security Needed


MrTheme

Recommended Posts

OOPS! Wrong Forum. Sorry Mods.

 

Alright so I am having a hell of a time trying to get a digital shop set up with limited contribs installed.

 

All I want is a template shop. So secure downloads, fast checkout, Paypal IPN, and STS

 

thats really all I need...

 

I cant seem to get the downloads to go secure. I have attempted every DL contrib out there, no dice.

 

Most of my issues (I thought) were centered around the mktime{} bug

 

So I made an oh so sloppy fix for it...

____

 

This is a really sloppy fix for the mktime{} issue.

 

It will work properly on a 7 day time scale.

 

open includes/modules/downloads.php and admin/include/modules/downloads.php

 

Find:

	  $download_timestamp = mktime(23, 59, 59, $dt_month, $dt_day + $downloads['download_maxdays'], $dt_year);

Replace with:

	  $download_timestamp = mktime(23, 59, 59, $dt_month - 2, $dt_day + 16 + $downloads['download_maxdays'], $dt_year + 8);

If you need to change your days you will have to adjust the line manually

 

Heres the base (which will give you todays date)

	  $download_timestamp = mktime(23, 59, 59, $dt_month - 2, $dt_day + 9 + $downloads['download_maxdays'], $dt_year + 8);

Now lets say you want to give users 2 days to download the file.

 

$dt_day + 11 + $downloads['download_maxdays'],

Now if someone can just prevent users from going to checkout_success and downloading files we will be doing something.

 

For now, this will at least give you the ability to allow downloads.

 

____

 

I am not sure of the security risks of doing this this way, but as it stands any buyer can just initiate an order, and go /checkout_success.php and, anctually be able to download this.

 

Anyone actually have a pre-compiled osc bundle with these contribs already installed?

 

... and actually working?

 

TIA, and hope the little workaround helps.

Edited by MrTheme
Link to comment
Share on other sites

thanks for your advice!

 

i tried also many dowmnaload contribution and cant make a conclusion on wich one to use

my shop would be software to download

could you give us on your testing conlusions ? :rolleyes:

MS2

Link to comment
Share on other sites

I would be happy to do so.

 

I am now going to do a test with the following

 

oscommerce-2.2ms2-060817 (core)

osCommerce PayPal IPN Module v1.0 For 2.2MS2 (AlexStudio)

Super Download Shop v1.1 (AlexStudio)

 

I will skip STS atm, just so I can focus on the contribs by AlexStudio. This way we can be sure there will be no conflicts.

 

I should also mention that my previous attempts were on 2.2RC1, this was my mistake.

 

The install will occur in this exact order and instructions will be followed to the T.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Paste as plain text instead

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

×
×
  • Create New...