Credit Class GV v4.0

[Ian]

I've just uploaded the new version that is compatible with the new checkout code.

 

http://www.oscommerce.com/downloads.php/co...ions,708/type,6

 

If you don't know what the Gift Voucher code does by now, then refer to the install documents.

 

I would say that the code needs to be marked alpha, as we are now testing against a completely new codebase, but the feedback i've had from other testers, (Zac and Gregory, I could not have done this without you guys.) ta very much, seems to suggest no problems.

 

To hobziilla, I haven't had a chance to update the install instuctions, but thanks very much for the Gift Voucher images.

 

I should have an updated version of the Discount Coupons shortly.

 

Maybe I can get some sleep now.

[Ian]

For those people using a previous versio, don't worry, you have not been forgotten.

 

It is my intention to run two versions.

 

V3.x will be for people using iscommerce prior to the new checkout system

v4.x is for people ussing the new checkout system

 

Ian

[Snowman]

Ian i dont suppose you have a loaded snapshot of the new code on the way at all have you??? :wink:

[xaraya]

That might be a bit problematic at the moment. I upgraded Ian's release to current cvs and had to drop some of the contribs in admin/categories.php due to conflicts with the new cvs commits. At the rate things are moving in cvs I'm going to lay low for a couple of weeks until the smoke clears :wink:

[Ian]

Steve,

 

Nice to see you back mate. I went down with some kinda 24hour flu bug on Friday night, and have just managed to drag myself out of bed again.

 

I had meant to post some update details for the current loaded snapshot. There are only about 5 files involved.

 

So if you get the current loaded, and then the Credit Class v4.0 I'll post the files to be upgraded shortly (keep checking www.phesis.co.uk)

[DeVOteD]

I am all new to the ocCommerce Software and have just upload the problem with this update.

 

However if you pay with the giftvoucher with COD it automatically goes into the account.

 

I have read in the install

"When a customer purchases the Gift Voucher one of two things happen depending on what the shop owner wants. Either the amount of

the Gift Voucher is credited to his Gift Voucher account or the amount is stored in a queue for release by admin. Once released by

admin, again the money is stored in the customers Gift Voucher account."

 

How do you get it to Que up.

 

Glenn

[DeVOteD]

Dont worry about it found out where it was moved to.:oops:

 

May want to add that to the install section the directory and file name! :oops:

 

Glenn

[xaraya]

Hi Ian,

 

Has there been any progress made to allow people to purchase Gift Vouchers without being charged for shipping in the new release? If this can be accomplished already without modifying the Gift Voucher contrib I would love to know how. I've set weight to 0 but this doesn't work. Maybe it's a bug with OSC?

 

I see a few people have been able to do this. I got some code from Kim Elliott that you wrote to accomplish this for an older snapshot in shopping_cart.php and table.php. If I could extract the code could it be applied to disable UPS, other shipping methods and work for newer snapshots?

 

http://www.bird-e-toys.com/osc/catalog/def...lt.php?cPath=74

[Ian]

Gregory,

 

I'll send some code for ups for you to test, if it works I'll build it into my cvs.

[xaraya]

Thanks Ian :D

[tnemes]

i have loaded the newest GV 4.0. i have it running, but when testing, i the voucher didnt queue, or at least is not showing up in my Gift Voucher Queue. alos how do i toggle wether or not the voucher is posted immediately, or not until i validate it?

 

 

thanks everybody

 

 

Troy

[Guest]

I'm also interested in not charging shipping for gift vouchers. I was hoping to have this working for the holiday season now upon us, but I can't use this contrib if it charges shipping for something that will be e-mailed...

[gwinger]

I can't find the function define in your package.

 

Fatal error: Call to undefined function: use_credit_amount() in /home/www/web5/html/it-sells/includes/classes/order_total.php on line 114

 

Then I recognized, that the calculation isn't corect sometimes, when you redeem a voucher while checking out.

But maybe it depends on another module I use. Have to check it.

I think it is the calculation of gift voucher. Please Check it, too.

[dhanish]

Hi Guys,

 

Been lurking in the forums and osC community in general...for a while now.

 

We have a client for whom we had made an osC setup with Ian's great contributions for a very old snapshot...which has been working fine...no complaints what so ever.

 

My question is to Ian....When do you think the new coupon code would be done so that it would work with the new checkout code?

 

We are going to be updating the layout for that site and we are debating whether we should upgrade to the new osC code which includes the new checkout code....the only thing that is holding us back is the coupons.

 

The client uses the coupons often so we dont want to get rid of it....but we also want to use the new checkout code....so as to any ideas when the new coupon code would be out so that we can play with it?

 

Thanks for the reply in advance....

 

Keep the great work guys....osC is great but with its dedicated community it even kicks more ass!

[gwinger]

Hi,

 

The coupons are working. I tested it with the 3.2 ot_gv.php and it was normally behaving. Now I play around with the new ot_gv.php and get an error in the checkout_payment.php:

 

Fatal error: Call to undefined function: use_credit_amount() in /home/www/web5/html/it-sells/includes/classes/order_total.php on line 114

 

I found out, that the function use_credit_amount() is in ot_gv.php.

Now I compared all the files of the new checkout gift vouchers addon with those files I actually use. They are identical. I don't found out why the checkout_payment.php isn't able to find that function.

With the old ot_gv.php the checkout works.

Also the coupons work exactly.

Ian, have you tested the addon with a new checkout? Maybe you have forgotten to do all changed files into the package? :?:

[xaraya]

i wonder if the old 3.2 ot_gv.php is compatible with the new GV 4.0...

[Ian]

Gregory,

 

No it's not. I did some code last night (well 3:00am to be precise) for ups/usps. I'll email it to you shortly to test, or did I already, can't remember. :shock:

[Ian]

Dhanish,

 

Coupons will be released any time now, I sent a pre-release version to someone for testing, and there does appear to be a couple of minor issues with the code. Hopfully I'll get this sorted tonight.

[xaraya]

Not yet. I would love to have the UPS code.

 

I just started a new project and would like the client to pay a retainer fee... the gift voucher in this case will be the equivelent of purchasing 8 hours of my time :D

[Ian]

As part of some discussions with Harald, and through reviewing the code, in terms of getting it into cvs I'll be making the following changes to the way Gift Voucher/Coupons work.

 

Currently at checkout if both modules are installed, you would have 2 redeem boxes, and 2 redeem buttons. This will be reduced to one redeem box and no redeem buttons. Redemption being an automatic process on pressing the continue button.

 

There will no longer be a GV account that holds funds. If a customer part uses a Gift Voucher, then to use the balance at a later date they will have to enter the redeem code again. This will mean that the Gift Voucher code can be used on stores that do not require login.

 

For customers who do register there will be a reminder that they have unused Gift Vouchers.

 

Emailing of Gift vouchers will now be done on purchase (during checkout). I haven't decided at what point yet. Queueing of emailed Vouchers will be possible for security reasons.

 

I should have some code for this by next week.

[M@rcel]

Is, as was the intention I thought, this funtionality being included into the standard Osc? To put it another way: Will this code be released through CVS?

 

M@rcel

[eoneolla]

Any idea why checkout would misalign HTML, and not show a checkbox or anything to use Gift Vouchers when running as a user?

 

Also, when a user buys a item with GIFT model, it doesnt get added. This isnt as bad of a problem, because I can always manually send them a voucher email.

 

This is with V4, and tep_snapshot_catalog-20021107 (with the new checkout)

 

 

Thanks,

 

 

Jarett

[Ian]

I don't why they should mis align, but if you email me I'll send he bang up to date version of order_total class and ot_gv.php.

 

Have you made sure the voucher system is enabled in admin.

Also checki the setting for GV_IMMEDIATE in includes/add_application_top.php if it is false then you will need to release the GV in admin. Set to true for bought gigt vouchers to go into account immediately

[helmut]

Hi Ian!

 

At http://www.oscommerce.com/forums/viewtopic.php...te+tax&start=10 you told Steve how to fix the tax problem.

 

Do you also have an idea for his last question:

Ian,

 

in the case you have a voucher worth 10. Take away the VAT (16%). This gives you a net purchase price : 8.6206896. Adding 16 % VAT brings you to: 9.9999999

 

The system show 9.99. How can I round it up to 10?

 

I installed Credit_Class_GV_v3.2.tar.gz ... everything workes fine, but I have the same tax-problem like Steve.

I did set "Include Tax -> true" and "Re-calculate Tax -> false"

 

Thanks,

Helmut

[gwinger]

There is a wrong calculation in the vochers module.

When I use as an example a product which is 100 Euro, and after all costs are listed, the gifz voucher amount of 100 Euro shall be used, the price to pay is invalid. I recalculated the price with different parameters for tax etc in the admin of the ot_module. But it is always wrong and I can't see anything that shows how it makes the wrong billing.

There is no spezial sum like a Tax amount or anything like that , but an unclear amount of 2.37 Euro less or 4.06 Euro less......

Buy any of the Test Produkts in my Test shop and see.

 

Can you understand this? I don't.

 

PS: My Shop is working with your gv 4.0 now. The problem with the checkout_payment.php I had, was generated by a local Proxy. It served me the old ot_gv.php always. :)