Max Character Length of Product Name

[simplyscrim]

Hi all

 

I wouldnt normally ask for advice on a forum, but i have looked everywhere for an answer to this and it is becoming somewhat frustrating.

 

On my page: http://www.simplyscrim.com/shop

 

i have the problem that it is only displaying 13 characters of the product name, where can i set this to something a little longer?

 

I have tried editing the table products_description in phpmyadmin, and changed the type of products_name to varchar(255).

 

This has had no effect on the main site itself.

 

 

Can Anyone HELP PLEASE!!!???

[simplyscrim]

anyone?

[Guest]

its not database related but something else you have probably in your product_listing.php

[simplyscrim]

i cant see anything in my product_listing.php that would set the max characters... have a look:

 

<table cellspacing="0" cellpadding="0" border="0" style="background:url(images/bg_title.gif) right top no-repeat;">

<tr><td height="47" class="title_txt"><?php echo $breadcrumb->trail(' » ')?></td></tr>

</table>

 

 

<? tep_draw_heading_top_11();?>

 

<?

$listing_split = new splitPageResults($listing_sql, MAX_DISPLAY_SEARCH_RESULTS, 'p.products_id');

 

if ( ($listing_split->number_of_rows > 0) && ( (PREV_NEXT_BAR_LOCATION == '1') || (PREV_NEXT_BAR_LOCATION == '2') ) ) {

?>

<table border="0" cellspacing="0" cellpadding="0" class="result box_width_cont">

<tr>

<td><?php echo $listing_split->display_count(TEXT_DISPLAY_NUMBER_OF_PRODUCTS); ?></td>

<td class="result_right"><?php echo TEXT_RESULT_PAGE . ' ' . $listing_split->display_links(MAX_DISPLAY_PAGE_LINKS, tep_get_all_get_params(array('page', 'info', 'x', 'y'))); ?></td>

</tr>

</table>

 

<?php echo tep_draw_result_top(); ?>

 

<?php

}

?>

<table border="0" cellspacing="0" cellpadding="0" class="box_width_cont">

<tr><td valign="top">

<?

$info_box_contents = array();

$list_box_contents = array();

$my_row = 0;

$my_col = 0;

 

$td_counter = 0;

for ($col=0, $n=sizeof($column_list); $col<$n; $col++) {

switch ($column_list[$col]) {

case 'PRODUCT_LIST_MODEL':

$lc_text = TABLE_HEADING_MODEL;

$lc_align = '';

break;

case 'PRODUCT_LIST_NAME':

$lc_text = TABLE_HEADING_PRODUCTS;

$lc_align = '';

break;

case 'PRODUCT_LIST_MANUFACTURER':

$lc_text = TABLE_HEADING_MANUFACTURER;

$lc_align = '';

break;

case 'PRODUCT_LIST_PRICE':

$lc_text = TABLE_HEADING_PRICE;

$lc_align = 'right';

break;

case 'PRODUCT_LIST_QUANTITY':

$lc_text = TABLE_HEADING_QUANTITY;

$lc_align = 'right';

break;

case 'PRODUCT_LIST_WEIGHT':

$lc_text = TABLE_HEADING_WEIGHT;

$lc_align = 'right';

break;

case 'PRODUCT_LIST_IMAGE':

$lc_text = TABLE_HEADING_IMAGE;

$lc_align = 'center';

break;

case 'PRODUCT_LIST_BUY_NOW':

$lc_text = TABLE_HEADING_BUY_NOW;

$lc_align = 'center';

break;

}

 

if ( ($column_list[$col] != 'PRODUCT_LIST_BUY_NOW') && ($column_list[$col] != 'PRODUCT_LIST_IMAGE') ) {

$lc_text = tep_create_sort_heading($HTTP_GET_VARS['sort'], $col+1, $lc_text);

}

 

$list_box_contents[0][] = array('align' => $lc_align,

'params' => 'class="productListing-heading"',

'text' => ' ' . $lc_text . ' ');

}

 

if ($listing_split->number_of_rows > 0) {

$rows = 0;

$listing_query = tep_db_query($listing_split->sql_query);

while ($listing = tep_db_fetch_array($listing_query)) {

$rows++;

 

if (($rows/2) == floor($rows/2)) {

$list_box_contents[] = array('params' => 'class="productListing-even"');

} else {

$list_box_contents[] = array('params' => 'class="productListing-odd"');

}

 

$cur_row = sizeof($list_box_contents) - 1;

 

for ($col=0, $n=sizeof($column_list); $col<$n; $col++) {

$lc_align = '';

 

switch ($column_list[$col]) {

case 'PRODUCT_LIST_MODEL':

$lc_align = '';

$p_model = $lc_text = '' . $listing['products_model'] . '';

break;

case 'PRODUCT_LIST_NAME':

$lc_align = '';

if (isset($HTTP_GET_VARS['manufacturers_id'])) {

$p_name = $lc_text = '<a href="' . tep_href_link(FILENAME_PRODUCT_INFO, 'manufacturers_id=' . $HTTP_GET_VARS['manufacturers_id'] . '&products_id=' . $listing['products_id']) . '">' . substr( $listing['products_name'],0,MAX_DESCR_NAME) . '</a>';

} else {

$p_name = $lc_text = '<a href="' . tep_href_link(FILENAME_PRODUCT_INFO, ($cPath ? 'cPath=' . $cPath . '&' : '') . 'products_id=' . $listing['products_id']) . '">' . substr($listing['products_name'],0,MAX_DESCR_NAME). '</a>';

}

break;

case 'PRODUCT_LIST_MANUFACTURER':

$lc_align = '';

$p_manuf = $lc_text = '<a href="' . tep_href_link(FILENAME_DEFAULT, 'manufacturers_id=' . $listing['manufacturers_id']) . '">' . $listing['manufacturers_name'] . '</a>';

break;

case 'PRODUCT_LIST_PRICE':

$lc_align = 'right';

if (tep_not_null($listing['specials_new_products_price'])) {

$p_price = $lc_text = '<strong>' . $currencies->display_price($listing['specials_new_products_price'], tep_get_tax_rate($listing['products_tax_class_id'])) . '</strong>   <s>' . $currencies->display_price($listing['products_price'], tep_get_tax_rate($listing['products_tax_class_id'])) . '</s>';

} else {

$p_price = $lc_text = '<strong>' . $currencies->display_price($listing['products_price'], tep_get_tax_rate($listing['products_tax_class_id'])) . '</strong>';

}

break;

case 'PRODUCT_LIST_QUANTITY':

$lc_align = 'right';

$p_quntity = $lc_text = '' . $listing['products_quantity'] . '';

break;

case 'PRODUCT_LIST_WEIGHT':

$lc_align = 'right';

$p_weight = $lc_text = '' . $listing['products_weight'] . '';

break;

case 'PRODUCT_LIST_IMAGE':

$lc_align = 'center';

if (isset($HTTP_GET_VARS['manufacturers_id'])) {

$p_pic = $lc_text = '<a href="' . tep_href_link(FILENAME_PRODUCT_INFO, 'manufacturers_id=' . $HTTP_GET_VARS['manufacturers_id'] . '&products_id=' . $listing['products_id']) . '">' . tep_image(DIR_WS_IMAGES . $listing['products_image'], $listing['products_name'], SMALL_IMAGE_WIDTH, SMALL_IMAGE_HEIGHT) . '</a>';

} else {

$p_pic = $lc_text = '<a href="' . tep_href_link(FILENAME_PRODUCT_INFO, ($cPath ? 'cPath=' . $cPath . '&' : '') . 'products_id=' . $listing['products_id']) . '">' . tep_image(DIR_WS_IMAGES . $listing['products_image'], $listing['products_name'], SMALL_IMAGE_WIDTH, SMALL_IMAGE_HEIGHT) . '</a>';

}

break;

case 'PRODUCT_LIST_BUY_NOW':

$lc_align = 'center';

$lc_text = '<a href="' . tep_href_link(basename($PHP_SELF), tep_get_all_get_params(array('action')) . 'action=buy_now&products_id=' . $listing['products_id']) . '">' . tep_image_button('button_buy_now.gif', IMAGE_BUTTON_BUY_NOW) . '</a>';

break;

}

 

 

$product_query = tep_db_query("select products_description, products_id from " . TABLE_PRODUCTS_DESCRIPTION . " where products_id = '" . (int)$listing['products_id'] . "' and language_id = '" . (int)$languages_id . "'");

$product = tep_db_fetch_array($product_query);

 

$p_desc = substr($product['products_description'], 0, MAX_DESCR_1);

$p_id = $product['products_id'];

/* $list_box_contents[$cur_row][] = array('align' => $lc_align,

'params' => '',

'text' => $lc_text); */

 

}

 

 

$info_box_contents[$my_row][$my_col] = array('align' => 'center',

'params' => ' valign="top"',

'text' => ''.tep_draw_prod_top().'

<table cellspacing="0" cellpadding="0" border="0" >

<tr>

<td>'.tep_draw_separator('spacer.gif', '9', '1').'</td>

<td width="96" height="152" align="center">

<table cellpadding="0" cellspacing="0" border="0" style=" width:20px;">

<tr><td>'.$p_pic.'</td></tr>

<tr><td height="35" align="center" style=" vertical-align:middle;">'.$p_price.'</td></tr>

</table>

</td>

<td width="123">

<br style="line-height:17px">

'.$p_name.'<br>

<br style="line-height:5px">

'.$p_desc.'...<br>

<br style="line-height:15px">

<a href="' . tep_href_link('product_info.php?products_id='.$p_id) . '">'.tep_image_button("button_details.gif").'</a><br>

<br style="line-height:4px">

<a href="'.tep_href_link("products_new.php","action=buy_now&products_id=".$p_id).'">'.tep_image_button('button_add_to_cart1.gif').'</a><br>

</td>

<td>'.tep_draw_separator('spacer.gif', '17', '1').'</td>

</tr>

</table>

'.tep_draw_prod_bottom());

 

 

 

 

$my_col ++;

if ($my_col > 1) {

$my_col = 0;

$my_row ++;

}

}

 

 

 

 

 

echo '</td></tr></table>';

 

 

new contentBox($info_box_contents);

// new productListingBox($list_box_contents);

} else { ?>

 

 

 

</td></tr></table>

 

 

 

 

 

 

<? tep_draw_heading_top_111();?>

 

<?

echo '<br style="line-height:1px;"><br style="line-height:15px;">

<table border="0" cellspacing="1" cellpadding="2" class="infoBox box_width_cont">

<tr class="infoBoxContents">

<td>

<table cellpadding="0" cellspacing="0" class="sea_2 product">

<tr><td>'.TEXT_NO_PRODUCTS.'</td></tr>

</table>

</td>

</tr>

</table>

';

tep_draw_heading_bottom_111();

 

}

 

if ( ($listing_split->number_of_rows > 0) && ((PREV_NEXT_BAR_LOCATION == '2') || (PREV_NEXT_BAR_LOCATION == '3')) ) {

?>

 

<?php echo tep_draw_result_bottom(); ?>

 

<table border="0" cellspacing="0" cellpadding="0" class="result box_width_cont">

<tr>

<td><?php echo $listing_split->display_count(TEXT_DISPLAY_NUMBER_OF_PRODUCTS); ?></td>

<td class="result_right"><?php echo TEXT_RESULT_PAGE . ' ' . $listing_split->display_links(MAX_DISPLAY_PAGE_LINKS, tep_get_all_get_params(array('page', 'info', 'x', 'y'))); ?></td>

</tr>

</table>

<?php

}

?>

[Guest]

substr( $listing['products_name'],0,MAX_DESCR_NAME)

 

 

next time you get a template, get it from someone who knows oscommerce or you will get all sorts of problems with such coding.

http://www.oscommerce.com/community/contributions/category,8

[simplyscrim]

max characters 0? we really liked this template cos it suited everything we needed, is that code really that bad? what should i ideally set the value at?

 

many thanks

[simplyscrim]

editing that part of the code does absolutely nothing :S

 

any other advice?

[Guest]

it's not max chars to 0 that means where the string copying will begin but the substr function shouldn't be there in the first place. If you're wondering about the substr function check the php manual

http://www.php.net/manual/en/function.substr.php

 

we really liked this template cos it suited everything we needed, is that code really that bad?

then you gona live with such errors too. It's not my word vs yours but what really happens. Why don't you check it here, just to see how valid the html output is.

http://validator.w3.org

 

I wouldn't use it even if you pay me, because I would have to start rewriting the whole thing pretty much.

[simplyscrim]

well im more than a little confused. im a desinger not a coder, and from what i can tell i've paid for a template that results in alot of code errors. all i want is a functioning site and i dont seem to be getting even close. i only want to extend it by about 15 characters, why is it so damn hard to do so?

[simplyscrim]

anyone else fancy helping me out?

[simplyscrim]

please someone help me out

[simplyscrim]

here we have it, as found in the header.php of all places...

 

define(MAX_DESCR_NAME,'13');

 

:-"

[bill110]

Looked at your site. Only 2 products with 16 chars in product name. Have you corrected it?

The problem you may have at the forum is with templates we would have to see the code pasted here, possibly from several files, due to the way some people make templates. They abandon the osCommerce php structure which is designed for flexibility and conformity.