Need help with a Mod that I'm makeing For Oscommerce

[Optimalkiller]

Hello everyone, got a problem with a mod for Oscommerce the problem that I'm haveing is that for each row it's repeating the same manufactorer, whichis not correct see the code snippet.

 

<?PHP
		for ($i=0, $n=sizeof($sales_products ['products_id']); $i<$n; $i++) {
		// BEGIN associate Manufacturer To Product
    $v_query = tep_db_query("select manufacturers_id from " . TABLE_PRODUCTS . " where products_id = '" .  $sales_products ['products_id'] . "'");
	$v = tep_db_fetch_array($v_query);
  // Select appropriate Manufacturers Name
	$mfg_query = tep_db_query("select manufacturers_id, manufacturers_name from " . TABLE_MANUFACTURERS . " where manufacturers_id = '" . $v['manufacturers_id'] . "'");
	$mfg = tep_db_fetch_array($mfg_query); 
	}
	?>

 

can anyone spot where I have gone wrong on this code snippet. I would be gratefull for any help thanks

 

Optimal

[♥bruyndoncx]

The first line, the logic around $sales_products.

I'm guessing this should be an array, and then further down in teh query it should refer to the $i th element of the array

 

So to be sure, if this doesn't make sense to you, you'll need to post more code specifically where the $sales_products is created

[Optimalkiller]

this is the output that I get.

 

1245 MICROSOFT STREETS AND TRIPS 2007 DVD PC Applications 1

1248 Top Ten Music Collection PC Applications 1

 

 

As you can see it keep repeating as application the Bottom one should be Music.

[♥bruyndoncx]

please post the lines preceding this section whrere you created the $sales_products variable. Without seeing that, can't tell what is should be exactly

[Optimalkiller]

[♥bruyndoncx]

[♥bruyndoncx]

[satish]

$mfg_query = tep_db_query("select manufacturers_id, manufacturers_name from " . TABLE_MANUFACTURERS . " where manufacturers_id = '" . $v['manufacturers_id'] . "'");

$mfg = tep_db_fetch_array($mfg_query);

 

this line has where manufacturers_id = '" . $v['manufacturers_id'] . "'") which appears to be coming from else where and within the loop it is same.

 

Satish

[Optimalkiller]

[♥bruyndoncx]

you are right, look a little bit further on how arrays work, that will give you the background and better understanding.

there are plenty examples in oscommerce.

very llittle code in oscommerce is truely unique, a lot of times you will see a variation on a certain code design.