Problem with product listings

NilfixNI · February 28, 2007

If you take a look at the site things seem fine www.nilfix.co.uk

However, having tinkered with some files (and of course accidentally copied over the backup (I KNOW!!!)) find myself with a dodgy product_info file with my products all squiffy when you look at an individual product -

Take this one for instance - http://www.nilfix.co.uk/product_info.php?products_id=201

The listing has pushed the colums out to the far reaches of the page and the top column is now also saying LINK_1

I dont want to tinker any more cause it's broke enough as it is. I was trying to install one of the VAT contributions but things didn't work out and find myself in a muddle trying to work backwards. Please help if you can! PHP file linked below;

<?php
/*

$Id: product_info.php,v 1.97 2003/07/01 14:34:54 hpdl Exp $

osCommerce, Open Source E-Commerce Solutions

http://www.oscommerce.com

Copyright © 2003 osCommerce

Released under the GNU General Public License

*/

require('includes/application_top.php');

require(DIR_WS_LANGUAGES . $language . '/' . FILENAME_PRODUCT_INFO);

// ADDED BY CLEMENT for design

define('HEADING_IMAGE_FILE', 'table_background_default.gif');

require(DIR_WS_INCLUDES . FILENAME_DESIGN);

//**

$product_check_query = tep_db_query("select count(*) as total from " . TABLE_PRODUCTS . " p, " . TABLE_PRODUCTS_DESCRIPTION . " pd where p.products_status = '1' and p.products_id = '" . (int)$HTTP_GET_VARS['products_id'] . "' and pd.products_id = p.products_id and pd.language_id = '" . (int)$languages_id . "'");

$product_check = tep_db_fetch_array($product_check_query);

?>

<!doctype html public "-//W3C//DTD HTML 4.01 Transitional//EN">

<HTML <?php echo HTML_PARAMS; ?>>

<HEAD>

<META HTTP-EQUIV="Content-Type" CONTENT="text/html; charset=<?php echo CHARSET; ?>">

<?php

// BOF: WebMakers.com Changed: Header Tag Controller v2.5.2

// Replaced by header_tags.php

if ( file_exists(DIR_WS_INCLUDES . 'header_tags.php') ) {

require(DIR_WS_INCLUDES . 'header_tags.php');

} else {

?>

<title><?php echo TITLE; ?></title>

<?php

}

// EOF: WebMakers.com Changed: Header Tag Controller v2.5.2

?>

<BASE HREF="<?php echo (($request_type == 'SSL') ? HTTPS_SERVER : HTTP_SERVER) . DIR_WS_CATALOG; ?>">

<LINK REL="stylesheet" TYPE="text/css" HREF="stylesheet.css">

<script language="javascript"></SCRIPT>

<?php echo HEAD_TAGS; ?>

<?php echo BODY_TAG; ?>



<?php

require(DIR_WS_INCLUDES . 'header.php');

if (COLUMN_LEFT_DISPLAY == 'true') {

echo '';

require(DIR_WS_INCLUDES . 'column_left.php');

echo '';

}

?>



<TD <?php echo CONTENT_PARAM_FIRST_TD; ?>>

<?php echo tep_draw_form('cart_quantity', tep_href_link(FILENAME_PRODUCT_INFO, tep_get_all_get_params(array('action')) . 'action=add_product')); ?>

<?php echo CONTENT_TOP_FIRST_TD; ?>

<TABLE <?php echo CONTENT_PARAM_FIRST_TABLE; ?>>

<?php

if ($product_check['total'] < 1) {

?>

<?php echo CONTENT_TOP_FIRST_TABLE; ?>

<TR>

<TD><?php new infoBox(array(array('text' => TEXT_PRODUCT_NOT_FOUND))); ?></TD>

</TR>

<TR>

<TD><?php echo tep_draw_separator('pixel_trans.gif', '100%', '10'); ?></TD>

</TR>

<TR>

<TD><TABLE BORDER="0" WIDTH="100%" CELLSPACING="1" CELLPADDING="2" CLASS="infoBox_button">

<TR CLASS="infoBoxContents_button">

<TD><TABLE BORDER="0" WIDTH="100%" CELLSPACING="0" CELLPADDING="2">

<TR>

<TD WIDTH="10"><?php echo tep_draw_separator('pixel_trans.gif', '10', '1'); ?></TD>

<TD ALIGN="right"><?php echo '<a href="' . tep_href_link(FILENAME_DEFAULT) . '">' . tep_image_button('button_continue.gif', IMAGE_BUTTON_CONTINUE) . '</a>'; ?></TD>

<TD WIDTH="10"><?php echo tep_draw_separator('pixel_trans.gif', '10', '1'); ?></TD>

</TR>

</TABLE></TD>

</TR>

</TABLE></TD>

</TR>

<?php

} else {

$product_info_query = tep_db_query("select p.products_id, pd.products_name, pd.products_description, p.products_model, p.products_quantity, p.products_image, pd.products_url, p.products_price, p.products_tax_class_id, p.products_date_added, p.products_date_available, p.manufacturers_id from " . TABLE_PRODUCTS . " p, " . TABLE_PRODUCTS_DESCRIPTION . " pd where p.products_status = '1' and p.products_id = '" . (int)$HTTP_GET_VARS['products_id'] . "' and pd.products_id = p.products_id and pd.language_id = '" . (int)$languages_id . "'");

$product_info = tep_db_fetch_array($product_info_query);

tep_db_query("update " . TABLE_PRODUCTS_DESCRIPTION . " set products_viewed = products_viewed+1 where products_id = '" . (int)$HTTP_GET_VARS['products_id'] . "' and language_id = '" . (int)$languages_id . "'");

if ($new_price = tep_get_products_special_price($product_info['products_id'])) {

$products_price = '<s>' . $currencies->display_price($product_info['products_price'], tep_get_tax_rate($product_info['products_tax_class_id'])) . '</s> <span class="productSpecialPrice">' . $currencies->display_price($new_price, tep_get_tax_rate($product_info['products_tax_class_id'])) . '</span>';

} else {

$products_price = $currencies->display_price($product_info['products_price'], tep_get_tax_rate($product_info['products_tax_class_id']));

}

if (tep_not_null($product_info['products_model'])) {

$products_name = $product_info['products_name'] . ' <span class="smallText">[' . $product_info['products_model'] . ']</span>';

} else {

$products_name = $product_info['products_name'];

}

?>

<TR>

<TD><TABLE BORDER="0" WIDTH="100%" CELLSPACING="0" CELLPADDING="0">

<TR>

<TD CLASS="pageHeading" VALIGN="top" style="padding-left: 7px;"><?php echo $products_name; ?></TD>

</TR>

<TR>

<TD CLASS="pageHeading" ALIGN="right" VALIGN="top" style="padding-right: 10px;"><?php echo $products_price; ?></TD>

</TR>

</TABLE></TD>

</TR>

<TR>

<TD><?php echo tep_draw_separator('pixel_trans.gif', '100%', '10'); ?></TD>

</TR>

<TR>

<TD CLASS="main">

<?php

if (tep_not_null($product_info['products_image'])) {

?>

<TABLE BORDER="0" CELLSPACING="0" CELLPADDING="2" ALIGN="right">

<TR>

<TD ALIGN="center" CLASS="smallText">

<script language="javascript"></SCRIPT>

<NOSCRIPT>

<?php echo '<a href="' . tep_href_link(DIR_WS_IMAGES . $product_info['products_image']) . '" target="_blank">' . tep_image(DIR_WS_IMAGES . $product_info['products_image'], $product_info['products_name'], SMALL_IMAGE_WIDTH, SMALL_IMAGE_HEIGHT, 'hspace="5" vspace="5"') . '<br>' . TEXT_CLICK_TO_ENLARGE . '</a>'; ?>

</NOSCRIPT>

</TD>

</TR>

</TABLE>

<?php

}

?>

<P><?php echo stripslashes($product_info['products_description']); ?></P>

<?php

$products_attributes_query = tep_db_query("select count(*) as total from " . TABLE_PRODUCTS_OPTIONS . " popt, " . TABLE_PRODUCTS_ATTRIBUTES . " patrib where patrib.products_id='" . (int)$HTTP_GET_VARS['products_id'] . "' and patrib.options_id = popt.products_options_id and popt.language_id = '" . (int)$languages_id . "'");

$products_attributes = tep_db_fetch_array($products_attributes_query);

if ($products_attributes['total'] > 0) {

?>

<TABLE BORDER="0" CELLSPACING="0" CELLPADDING="2">

<TR>

<TD CLASS="main" COLSPAN="2"><?php echo TEXT_PRODUCT_OPTIONS; ?></TD>

</TR>

<?php

$products_options_name_query = tep_db_query("select distinct popt.products_options_id, popt.products_options_name from " . TABLE_PRODUCTS_OPTIONS . " popt, " . TABLE_PRODUCTS_ATTRIBUTES . " patrib where patrib.products_id='" . (int)$HTTP_GET_VARS['products_id'] . "' and patrib.options_id = popt.products_options_id and popt.language_id = '" . (int)$languages_id . "' order by popt.products_options_name");

while ($products_options_name = tep_db_fetch_array($products_options_name_query)) {

$products_options_array = array();

$products_options_query = tep_db_query("select pov.products_options_values_id, pov.products_options_values_name, pa.options_values_price, pa.price_prefix from " . TABLE_PRODUCTS_ATTRIBUTES . " pa, " . TABLE_PRODUCTS_OPTIONS_VALUES . " pov where pa.products_id = '" . (int)$HTTP_GET_VARS['products_id'] . "' and pa.options_id = '" . (int)$products_options_name['products_options_id'] . "' and pa.options_values_id = pov.products_options_values_id and pov.language_id = '" . (int)$languages_id . "'");

while ($products_options = tep_db_fetch_array($products_options_query)) {

$products_options_array[] = array('id' => $products_options['products_options_values_id'], 'text' => $products_options['products_options_values_name']);

if ($products_options['options_values_price'] != '0') {

$products_options_array[sizeof($products_options_array)-1]['text'] .= ' (' . $products_options['price_prefix'] . $currencies->display_price($products_options['options_values_price'], tep_get_tax_rate($product_info['products_tax_class_id'])) .') ';

}

if (isset($cart->contents[$HTTP_GET_VARS['products_id']]['attributes'][$products_options_name['products_options_id']])) {

$selected_attribute = $cart->contents[$HTTP_GET_VARS['products_id']]['attributes'][$products_options_name['products_options_id']];

} else {

$selected_attribute = false;

}

?>

<TR>

<TD CLASS="main"><?php echo $products_options_name['products_options_name'] . ':'; ?></TD>

<TD CLASS="main"><?php echo tep_draw_pull_down_menu('id[' . $products_options_name['products_options_id'] . ']', $products_options_array, $selected_attribute); ?></TD>

</TR>

<?php

}

?>

</TABLE>

<?php

}

?>

</TD>

</TR>

<TR>

<TD><?php echo tep_draw_separator('pixel_trans.gif', '100%', '10'); ?></TD>

</TR>

<?php

$reviews_query = tep_db_query("select count(*) as count from " . TABLE_REVIEWS . " where products_id = '" . (int)$HTTP_GET_VARS['products_id'] . "'");

$reviews = tep_db_fetch_array($reviews_query);

if ($reviews['count'] > 0) {

?>

<TR>

<TD CLASS="main"><?php echo TEXT_CURRENT_REVIEWS . ' ' . $reviews['count']; ?></TD>

</TR>

<TR>

<TD><?php echo tep_draw_separator('pixel_trans.gif', '100%', '10'); ?></TD>

</TR>

<?php

}

if (tep_not_null($product_info['products_url'])) {

?>

<TR>

<TD CLASS="main"><?php echo sprintf(TEXT_MORE_INFORMATION, tep_href_link(FILENAME_REDIRECT, 'action=url&goto=' . urlencode($product_info['products_url']), 'NONSSL', true, false)); ?></TD>

</TR>

<TR>

<TD><?php echo tep_draw_separator('pixel_trans.gif', '100%', '10'); ?></TD>

</TR>

<?php

}

if ($product_info['products_date_available'] > date('Y-m-d H:i:s')) {

?>

<TR>

<TD ALIGN="center" CLASS="smallText"><?php echo sprintf(TEXT_DATE_AVAILABLE, tep_date_long($product_info['products_date_available'])); ?></TD>

</TR>

<?php

} else {

?>

<TR>

<TD ALIGN="center" CLASS="smallText"><?php echo sprintf(TEXT_DATE_ADDED, tep_date_long($product_info['products_date_added'])); ?></TD>

</TR>

<?php

}

?>

<TR>

<TD><?php echo tep_draw_separator('pixel_trans.gif', '100%', '10'); ?></TD>

</TR>

<TR>

<TD><TABLE BORDER="0" WIDTH="100%" CELLSPACING="1" CELLPADDING="2" CLASS="infoBox_button">

<TR CLASS="infoBoxContents_button">

<TD><TABLE BORDER="0" WIDTH="100%" CELLSPACING="0" CELLPADDING="2">

<TR>

<TD WIDTH="10"><?php echo tep_draw_separator('pixel_trans.gif', '10', '1'); ?></TD>

<TD CLASS="main"><?php echo '<a href="' . tep_href_link(FILENAME_PRODUCT_REVIEWS, tep_get_all_get_params()) . '">' . tep_image_button('button_reviews.gif', IMAGE_BUTTON_REVIEWS) . '</a>'; ?></TD>

<TD CLASS="main" ALIGN="right"><?php echo tep_draw_hidden_field('products_id', $product_info['products_id']) . tep_image_submit('button_in_cart.gif', IMAGE_BUTTON_IN_CART); ?></TD>

<TD WIDTH="10"><?php echo tep_draw_separator('pixel_trans.gif', '10', '1'); ?></TD>

</TR>

</TABLE></TD>

</TR>

</TABLE></TD>

</TR>

<TR>

<TD><?php echo tep_draw_separator('pixel_trans.gif', '100%', '10'); ?></TD>

</TR>

<TR>

<TD>

<?php

if ((USE_CACHE == 'true') && empty($SID)) {

echo tep_cache_also_purchased(3600);

} else {

include(DIR_WS_MODULES . FILENAME_ALSO_PURCHASED_PRODUCTS);

}

}

?>

</TD>

</TR>

<?php echo CONTENT_BOTTOM_FIRST_TABLE; ?>

</TABLE></form>

<?php echo CONTENT_BOTTOM_FIRST_TD; ?>

</TD>



<?php

if (COLUMN_RIGHT_DISPLAY == 'true') {

echo '';

require(DIR_WS_INCLUDES . 'column_right.php');

echo '';

}

require(DIR_WS_INCLUDES . 'footer.php');

?>

<?php echo ENDING_TAGS; ?>

<?php require(DIR_WS_INCLUDES . 'application_bottom.php'); ?>

omar2886 · February 28, 2007

show us the login.php file.

May be there is the problem of the Link_1

NilfixNI · February 28, 2007

show us the login.php file.
May be there is the problem of the Link_1

I never touched any of the files in this php file, the only ones I edited were the ones asked by the contribution installation guide

As requested

<?php

/*

$Id: login.php,v 1.80 2003/06/05 23:28:24 hpdl Exp $

osCommerce, Open Source E-Commerce Solutions

http://www.oscommerce.com

Released under the GNU General Public License

*/

require('includes/application_top.php');

// redirect the customer to a friendly cookie-must-be-enabled page if cookies are disabled (or the session has not started)

if ($session_started == false) {

tep_redirect(tep_href_link(FILENAME_COOKIE_USAGE));

}

require(DIR_WS_LANGUAGES . $language . '/' . FILENAME_LOGIN);

// ADDED BY CLEMENT for design

define('HEADING_IMAGE_FILE', 'table_background_login.gif');

require(DIR_WS_INCLUDES . FILENAME_DESIGN);

//**

$error = false;

if (isset($HTTP_GET_VARS['action']) && ($HTTP_GET_VARS['action'] == 'process')) {

$email_address = tep_db_prepare_input($HTTP_POST_VARS['email_address']);

$password = tep_db_prepare_input($HTTP_POST_VARS['password']);

// Check if email exists

$check_customer_query = tep_db_query("select customers_id, customers_firstname, customers_password, customers_email_address, customers_default_address_id from " . TABLE_CUSTOMERS . " where customers_email_address = '" . tep_db_input($email_address) . "'");

if (!tep_db_num_rows($check_customer_query)) {

$error = true;

} else {

$check_customer = tep_db_fetch_array($check_customer_query);

// Check that password is good

if (!tep_validate_password($password, $check_customer['customers_password'])) {

$error = true;

} else {

if (SESSION_RECREATE == 'True') {

tep_session_recreate();

}

$check_country_query = tep_db_query("select entry_country_id, entry_zone_id from " . TABLE_ADDRESS_BOOK . " where customers_id = '" . (int)$check_customer['customers_id'] . "' and address_book_id = '" . (int)$check_customer['customers_default_address_id'] . "'");

$check_country = tep_db_fetch_array($check_country_query);

$customer_id = $check_customer['customers_id'];

$customer_default_address_id = $check_customer['customers_default_address_id'];

$customer_first_name = $check_customer['customers_firstname'];

$customer_country_id = $check_country['entry_country_id'];

$customer_zone_id = $check_country['entry_zone_id'];

tep_session_register('customer_id');

tep_session_register('customer_default_address_id');

tep_session_register('customer_first_name');

tep_session_register('customer_country_id');

tep_session_register('customer_zone_id');

tep_db_query("update " . TABLE_CUSTOMERS_INFO . " set customers_info_date_of_last_logon = now(), customers_info_number_of_logons = customers_info_number_of_logons+1 where customers_info_id = '" . (int)$customer_id . "'");

// restore cart contents

$cart->restore_contents();

if (sizeof($navigation->snapshot) > 0) {

$origin_href = tep_href_link($navigation->snapshot['page'], tep_array_to_string($navigation->snapshot['get'], array(tep_session_name())), $navigation->snapshot['mode']);

$navigation->clear_snapshot();

tep_redirect($origin_href);

} else {

tep_redirect(tep_href_link(FILENAME_DEFAULT));

}

if ($error == true) {

$messageStack->add('login', TEXT_LOGIN_ERROR);

}

$breadcrumb->add(NAVBAR_TITLE, tep_href_link(FILENAME_LOGIN, '', 'SSL'));

?>

<!doctype html public "-//W3C//DTD HTML 4.01 Transitional//EN">

<HEAD>

function session_win() {

window.open("<?php echo tep_href_link(FILENAME_INFO_SHOPPING_CART); ?>","info_shopping_cart","height=460,width=430,toolbar=no,statusbar=no,scrollbars=yes").focus();

}

//--></SCRIPT>

<?php echo HEAD_TAGS; ?>

<?php echo BODY_TAG; ?>

<?php

require(DIR_WS_INCLUDES . 'header.php');

if (COLUMN_LEFT_DISPLAY == 'true') {

echo '';

require(DIR_WS_INCLUDES . 'column_left.php');

echo '';

}

?>

<?php echo tep_draw_form('login', tep_href_link(FILENAME_LOGIN, 'action=process', 'SSL')); ?>

<?php echo CONTENT_TOP_FIRST_TD; ?>

<?php echo CONTENT_TOP_FIRST_TABLE; ?>

<?php

if ($messageStack->size('login') > 0) {

?>

<TR>

<TD><?php echo $messageStack->output('login'); ?></TD>

</TR>

<?php

}

if ($cart->count_contents() > 0) {

?>

<TR>

</TR>

<TR>

</TR>

<?php

}

?>

<TR>

<TR>

</TR>

<TR>

<TR>

</TR>

<TR>

<TD CLASS="main" VALIGN="top"><?php echo TEXT_NEW_CUSTOMER . '<br><br>' . TEXT_NEW_CUSTOMER_INTRODUCTION; ?></TD>

</TR>

<TR>

</TR>

<TR>

<TR>

<TD ALIGN="right"><?php echo '<a href="' . tep_href_link(FILENAME_CREATE_ACCOUNT, '', 'SSL') . '">' . tep_image_button('button_continue.gif', IMAGE_BUTTON_CONTINUE) . '</a>'; ?></TD>

</TR>

</TABLE></TD>

</TR>

</TABLE></TD>

</TR>

</TABLE></TD>

<TR>

</TR>

<TR>

</TR>

<TR>

</TR>

<TR>

</TR>

<TR>

</TR>

<TR>

</TR>

<TR>

<TD CLASS="smallText" COLSPAN="2"><?php echo '<a href="' . tep_href_link(FILENAME_PASSWORD_FORGOTTEN, '', 'SSL') . '">' . TEXT_PASSWORD_FORGOTTEN . '</a>'; ?></TD>

</TR>

<TR>

</TR>

<TR>

<TR>

</TR>

</TABLE></TD>

</TR>

</TABLE></TD>

</TR>

</TABLE></TD>

</TR>

</TABLE></TD>

</TR>

<?php echo CONTENT_BOTTOM_FIRST_TABLE; ?>

</TABLE></form>

<?php echo CONTENT_BOTTOM_FIRST_TD; ?>

</TD>

<?php

if (COLUMN_RIGHT_DISPLAY == 'true') {

echo '';

require(DIR_WS_INCLUDES . 'column_right.php');

echo '';

}

require(DIR_WS_INCLUDES . 'footer.php');

?>

<?php echo ENDING_TAGS; ?>

<?php require(DIR_WS_INCLUDES . 'application_bottom.php'); ?>

NilfixNI · March 1, 2007

Desperate at the minute for a solution. Noticing a deffinate decline in sales/queries.

Problem with product listings

Recommended Posts

NilfixNI

omar2886

NilfixNI

NilfixNI

Archived

Browse

Activity