Please Help!!

Casadeva · February 19, 2007

Hi I had an email from my first ever customer who tried to create and account. She got the message that her address must contain at least 3 letters and it does! Also the county must contain 2 letter which it does!

Where do I start to look to sort this out? I've tried to create and account myself and get the same error messages. I created and account last week which worked fine :'( any ideas what I have done? I obviously don't want to lose my first customer.

web address is www.petbling.co.uk/oscom

Thanks guys

Eva (stupid blonde 30 something who was pleased with herself at making the site but now feels a bit dumb)

Velveeta · February 19, 2007

Hi I had an email from my first ever customer who tried to create and account. She got the message that her address must contain at least 3 letters and it does! Also the county must contain 2 letter which it does!
Where do I start to look to sort this out? I've tried to create and account myself and get the same error messages. I created and account last week which worked fine :'( any ideas what I have done? I obviously don't want to lose my first customer.

web address is www.petbling.co.uk/oscom

Thanks guys

Eva (stupid blonde 30 something who was pleased with herself at making the site but now feels a bit dumb)

Can you post your create_account.php file here so we can take a look at it? It could be that one of the checks is off somehow... Also, I hate to do this, but it's "create an account" :D hee hee... I wouldn't have said anything but you said "and" 3 times up there :D

Richard.

Casadeva · February 20, 2007

Can you post your create_account.php file here so we can take a look at it? It could be that one of the checks is off somehow... Also, I hate to do this, but it's "create an account" :D hee hee... I wouldn't have said anything but you said "and" 3 times up there :D

Richard.

Sorry about the ands it was way past this girls bedtime and I don't think my fingers were actually connected to my brain!

hee is the create account file

<?php

/*

$Id: create_account.php 6137 2005-05-10 12:59:09Z jim $

osCommerce, Open Source E-Commerce Solutions

http://www.oscommerce.com

Released under the GNU General Public License

*/

require('includes/application_top.php');

// needs to be included earlier to set the success message in the messageStack

require(DIR_WS_LANGUAGES . $language . '/' . FILENAME_CREATE_ACCOUNT);

$process = false;

if (isset($HTTP_POST_VARS['action']) && ($HTTP_POST_VARS['action'] == 'process')) {

$process = true;

if (ACCOUNT_GENDER == 'true') {

if (isset($HTTP_POST_VARS['gender'])) {

$gender = tep_db_prepare_input($HTTP_POST_VARS['gender']);

} else {

$gender = false;

}

$firstname = tep_db_prepare_input($HTTP_POST_VARS['firstname']);

$lastname = tep_db_prepare_input($HTTP_POST_VARS['lastname']);

if (ACCOUNT_DOB == 'true') $dob = tep_db_prepare_input($HTTP_POST_VARS['dob']);

$email_address = tep_db_prepare_input($HTTP_POST_VARS['email_address']);

if (ACCOUNT_COMPANY == 'true') $company = tep_db_prepare_input($HTTP_POST_VARS['company']);

$street_address = tep_db_prepare_input($HTTP_POST_VARS['1st Line Address']);

if (ACCOUNT_SUBURB == 'true') $suburb = tep_db_prepare_input($HTTP_POST_VARS['2nd Line Address']);

$postcode = tep_db_prepare_input($HTTP_POST_VARS['postcode']);

$city = tep_db_prepare_input($HTTP_POST_VARS['Town']);

if (ACCOUNT_STATE == 'true') {

$state = tep_db_prepare_input($HTTP_POST_VARS['County']);

if (isset($HTTP_POST_VARS['zone_id'])) {

$zone_id = tep_db_prepare_input($HTTP_POST_VARS['zone_id']);

} else {

$zone_id = false;

}

$country = tep_db_prepare_input($HTTP_POST_VARS['country']);

$telephone = tep_db_prepare_input($HTTP_POST_VARS['telephone']);

$fax = tep_db_prepare_input($HTTP_POST_VARS['fax']);

if (isset($HTTP_POST_VARS['newsletter'])) {

$newsletter = tep_db_prepare_input($HTTP_POST_VARS['newsletter']);

} else {

$newsletter = false;

}

$password = tep_db_prepare_input($HTTP_POST_VARS['password']);

$confirmation = tep_db_prepare_input($HTTP_POST_VARS['confirmation']);

$error = false;

if (ACCOUNT_GENDER == 'true') {

if ( ($gender != 'm') && ($gender != 'f') ) {

$error = true;

$messageStack->add('create_account', ENTRY_GENDER_ERROR);

}

if (strlen($firstname) < ENTRY_FIRST_NAME_MIN_LENGTH) {

$error = true;

$messageStack->add('create_account', ENTRY_FIRST_NAME_ERROR);

}

if (strlen($lastname) < ENTRY_LAST_NAME_MIN_LENGTH) {

$error = true;

$messageStack->add('create_account', ENTRY_LAST_NAME_ERROR);

}

if (ACCOUNT_DOB == 'true') {

if (checkdate(substr(tep_date_raw($dob), 4, 2), substr(tep_date_raw($dob), 6, 2), substr(tep_date_raw($dob), 0, 4)) == false) {

$error = true;

$messageStack->add('create_account', ENTRY_DATE_OF_BIRTH_ERROR);

}

if (strlen($email_address) < ENTRY_EMAIL_ADDRESS_MIN_LENGTH) {

$error = true;

$messageStack->add('create_account', ENTRY_EMAIL_ADDRESS_ERROR);

} elseif (tep_validate_email($email_address) == false) {

$error = true;

$messageStack->add('create_account', ENTRY_EMAIL_ADDRESS_CHECK_ERROR);

} else {

$check_email_query = tep_db_query("select count(*) as total from " . TABLE_CUSTOMERS . " where customers_email_address = '" . tep_db_input($email_address) . "'");

$check_email = tep_db_fetch_array($check_email_query);

if ($check_email['total'] > 0) {

$error = true;

$messageStack->add('create_account', ENTRY_EMAIL_ADDRESS_ERROR_EXISTS);

}

if (strlen($street_address) < ENTRY_STREET_ADDRESS_MIN_LENGTH) {

$error = true;

$messageStack->add('create_account', ENTRY_STREET_ADDRESS_ERROR);

}

if (strlen($postcode) < ENTRY_POSTCODE_MIN_LENGTH) {

$error = true;

$messageStack->add('create_account', ENTRY_POST_CODE_ERROR);

}

if (strlen($city) < ENTRY_CITY_MIN_LENGTH) {

$error = true;

$messageStack->add('create_account', ENTRY_CITY_ERROR);

}

if (is_numeric($country) == false) {

$error = true;

$messageStack->add('create_account', ENTRY_COUNTRY_ERROR);

}

if (ACCOUNT_STATE == 'true') {

$zone_id = 0;

$check_query = tep_db_query("select count(*) as total from " . TABLE_ZONES . " where zone_country_id = '" . (int)$country . "'");

$check = tep_db_fetch_array($check_query);

$entry_state_has_zones = ($check['total'] > 0);

if ($entry_state_has_zones == true) {

$zone_query = tep_db_query("select distinct zone_id from " . TABLE_ZONES . " where zone_country_id = '" . (int)$country . "' and (zone_name like '" . tep_db_input($state) . "%' or zone_code like '%" . tep_db_input($state) . "%')");

if (tep_db_num_rows($zone_query) == 1) {

$zone = tep_db_fetch_array($zone_query);

$zone_id = $zone['zone_id'];

} else {

$error = true;

$messageStack->add('create_account', ENTRY_STATE_ERROR_SELECT);

}

} else {

if (strlen($state) < ENTRY_STATE_MIN_LENGTH) {

$error = true;

$messageStack->add('create_account', ENTRY_STATE_ERROR);

}

if (strlen($telephone) < ENTRY_TELEPHONE_MIN_LENGTH) {

$error = true;

$messageStack->add('create_account', ENTRY_TELEPHONE_NUMBER_ERROR);

}

if (strlen($password) < ENTRY_PASSWORD_MIN_LENGTH) {

$error = true;

$messageStack->add('create_account', ENTRY_PASSWORD_ERROR);

} elseif ($password != $confirmation) {

$error = true;

$messageStack->add('create_account', ENTRY_PASSWORD_ERROR_NOT_MATCHING);

}

if ($error == false) {

$sql_data_array = array('customers_firstname' => $firstname,

'customers_lastname' => $lastname,

'customers_email_address' => $email_address,

'customers_telephone' => $telephone,

'customers_fax' => $fax,

'customers_newsletter' => $newsletter,

'customers_password' => tep_encrypt_password($password));

if (ACCOUNT_GENDER == 'true') $sql_data_array['customers_gender'] = $gender;

if (ACCOUNT_DOB == 'true') $sql_data_array['customers_dob'] = tep_date_raw($dob);

tep_db_perform(TABLE_CUSTOMERS, $sql_data_array);

$customer_id = tep_db_insert_id();

$sql_data_array = array('customers_id' => $customer_id,

'entry_firstname' => $firstname,

'entry_lastname' => $lastname,

'entry_street_address' => $street_address,

'entry_postcode' => $postcode,

'entry_city' => $city,

'entry_country_id' => $country);

if (ACCOUNT_GENDER == 'true') $sql_data_array['entry_gender'] = $gender;

if (ACCOUNT_COMPANY == 'true') $sql_data_array['entry_company'] = $company;

if (ACCOUNT_SUBURB == 'true') $sql_data_array['entry_suburb'] = $suburb;

if (ACCOUNT_STATE == 'true') {

if ($zone_id > 0) {

$sql_data_array['entry_zone_id'] = $zone_id;

$sql_data_array['entry_state'] = '';

} else {

$sql_data_array['entry_zone_id'] = '0';

$sql_data_array['entry_state'] = $state;

}

tep_db_perform(TABLE_ADDRESS_BOOK, $sql_data_array);

$address_id = tep_db_insert_id();

tep_db_query("update " . TABLE_CUSTOMERS . " set customers_default_address_id = '" . (int)$address_id . "' where customers_id = '" . (int)$customer_id . "'");

tep_db_query("insert into " . TABLE_CUSTOMERS_INFO . " (customers_info_id, customers_info_number_of_logons, customers_info_date_account_created) values ('" . (int)$customer_id . "', '0', now())");

if (SESSION_RECREATE == 'True') {

tep_session_recreate();

}

$customer_first_name = $firstname;

$customer_default_address_id = $address_id;

$customer_country_id = $country;

$customer_zone_id = $zone_id;

tep_session_register('customer_id');

tep_session_register('customer_first_name');

tep_session_register('customer_default_address_id');

tep_session_register('customer_country_id');

tep_session_register('customer_zone_id');

// restore cart contents

$cart->restore_contents();

// build the message content

$name = $firstname . ' ' . $lastname;

if (ACCOUNT_GENDER == 'true') {

if ($gender == 'm') {

$email_text = sprintf(EMAIL_GREET_MR, $lastname);

} else {

$email_text = sprintf(EMAIL_GREET_MS, $lastname);

}

} else {

$email_text = sprintf(EMAIL_GREET_NONE, $firstname);

}

$email_text .= EMAIL_WELCOME . EMAIL_TEXT . EMAIL_CONTACT . EMAIL_WARNING;

tep_mail($name, $email_address, EMAIL_SUBJECT, $email_text, STORE_OWNER, STORE_OWNER_EMAIL_ADDRESS);

tep_redirect(tep_href_link(FILENAME_CREATE_ACCOUNT_SUCCESS, '', 'SSL'));

}

$breadcrumb->add(NAVBAR_TITLE, tep_href_link(FILENAME_CREATE_ACCOUNT, '', 'SSL'));

?>

<!doctype html public "-//W3C//DTD HTML 4.01 Transitional//EN">

<head>

<?php require('includes/form_check.js.php'); ?>

</head>

<?php require(DIR_WS_INCLUDES . 'header.php'); ?>

<tr>

<td width="<?php echo BOX_WIDTH; ?>" valign="top"><table border="0" width="<?php echo BOX_WIDTH; ?>" cellspacing="0" cellpadding="2">

<?php require(DIR_WS_INCLUDES . 'column_left.php'); ?>

</table></td>

<tr>

<tr>

</tr>

</table></td>

</tr>

<tr>

</tr>

<tr>

</tr>

<tr>

</tr>

<?php

if ($messageStack->size('create_account') > 0) {

?>

<tr>

<td><?php echo $messageStack->output('create_account'); ?></td>

</tr>

<tr>

</tr>

<?php

}

?>

<tr>

<tr>

</tr>

</table></td>

</tr>

<tr>

<?php

if (ACCOUNT_GENDER == 'true') {

?>

<tr>

<td class="main"><?php echo tep_draw_radio_field('gender', 'm') . ' ' . MALE . ' ' . tep_draw_radio_field('gender', 'f') . ' ' . FEMALE . ' ' . (tep_not_null(ENTRY_GENDER_TEXT) ? '<span class="inputRequirement">' . ENTRY_GENDER_TEXT . '</span>': ''); ?></td>

</tr>

<?php

}

?>

<tr>

<td class="main"><?php echo tep_draw_input_field('firstname') . ' ' . (tep_not_null(ENTRY_FIRST_NAME_TEXT) ? '<span class="inputRequirement">' . ENTRY_FIRST_NAME_TEXT . '</span>': ''); ?></td>

</tr>

<tr>

<td class="main"><?php echo tep_draw_input_field('lastname') . ' ' . (tep_not_null(ENTRY_LAST_NAME_TEXT) ? '<span class="inputRequirement">' . ENTRY_LAST_NAME_TEXT . '</span>': ''); ?></td>

</tr>

<?php

if (ACCOUNT_DOB == 'true') {

?>

<tr>

<td class="main"><?php echo tep_draw_input_field('dob') . ' ' . (tep_not_null(ENTRY_DATE_OF_BIRTH_TEXT) ? '<span class="inputRequirement">' . ENTRY_DATE_OF_BIRTH_TEXT . '</span>': ''); ?></td>

</tr>

<?php

}

?>

<tr>

<td class="main"><?php echo tep_draw_input_field('email_address') . ' ' . (tep_not_null(ENTRY_EMAIL_ADDRESS_TEXT) ? '<span class="inputRequirement">' . ENTRY_EMAIL_ADDRESS_TEXT . '</span>': ''); ?></td>

</tr>

</table></td>

</tr>

</table></td>

</tr>

<?php

if (ACCOUNT_COMPANY == 'true') {

?>

<tr>

</tr>

<tr>

</tr>

<tr>

<tr>

<td class="main"><?php echo tep_draw_input_field('company') . ' ' . (tep_not_null(ENTRY_COMPANY_TEXT) ? '<span class="inputRequirement">' . ENTRY_COMPANY_TEXT . '</span>': ''); ?></td>

</tr>

</table></td>

</tr>

</table></td>

</tr>

<?php

}

?>

<tr>

</tr>

<tr>

</tr>

<tr>

<tr>

<td class="main"><?php echo tep_draw_input_field('street_address') . ' ' . (tep_not_null(ENTRY_STREET_ADDRESS_TEXT) ? '<span class="inputRequirement">' . ENTRY_STREET_ADDRESS_TEXT . '</span>': ''); ?></td>

</tr>

<?php

if (ACCOUNT_SUBURB == 'true') {

?>

<tr>

<td class="main"><?php echo tep_draw_input_field('suburb') . ' ' . (tep_not_null(ENTRY_SUBURB_TEXT) ? '<span class="inputRequirement">' . ENTRY_SUBURB_TEXT . '</span>': ''); ?></td>

</tr>

<?php

}

?>

<tr>

<td class="main"><?php echo tep_draw_input_field('postcode') . ' ' . (tep_not_null(ENTRY_POST_CODE_TEXT) ? '<span class="inputRequirement">' . ENTRY_POST_CODE_TEXT . '</span>': ''); ?></td>

</tr>

<tr>

<td class="main"><?php echo tep_draw_input_field('city') . ' ' . (tep_not_null(ENTRY_CITY_TEXT) ? '<span class="inputRequirement">' . ENTRY_CITY_TEXT . '</span>': ''); ?></td>

</tr>

<?php

if (ACCOUNT_STATE == 'true') {

?>

<tr>

<?php

if ($process == true) {

if ($entry_state_has_zones == true) {

$zones_array = array();

$zones_query = tep_db_query("select zone_name from " . TABLE_ZONES . " where zone_country_id = '" . (int)$country . "' order by zone_name");

while ($zones_values = tep_db_fetch_array($zones_query)) {

$zones_array[] = array('id' => $zones_values['zone_name'], 'text' => $zones_values['zone_name']);

}

echo tep_draw_pull_down_menu('state', $zones_array);

} else {

echo tep_draw_input_field('state');

}

} else {

echo tep_draw_input_field('state');

}

if (tep_not_null(ENTRY_STATE_TEXT)) echo ' <span class="inputRequirement">' . ENTRY_STATE_TEXT;

?>

</td>

</tr>

<?php

}

?>

<tr>

<td class="main"><?php echo tep_get_country_list('country') . ' ' . (tep_not_null(ENTRY_COUNTRY_TEXT) ? '<span class="inputRequirement">' . ENTRY_COUNTRY_TEXT . '</span>': ''); ?></td>

</tr>

</table></td>

</tr>

</table></td>

</tr>

<tr>

</tr>

<tr>

</tr>

<tr>

<tr>

<td class="main"><?php echo tep_draw_input_field('telephone') . ' ' . (tep_not_null(ENTRY_TELEPHONE_NUMBER_TEXT) ? '<span class="inputRequirement">' . ENTRY_TELEPHONE_NUMBER_TEXT . '</span>': ''); ?></td>

</tr>

<tr>

<td class="main"><?php echo tep_draw_input_field('fax') . ' ' . (tep_not_null(ENTRY_FAX_NUMBER_TEXT) ? '<span class="inputRequirement">' . ENTRY_FAX_NUMBER_TEXT . '</span>': ''); ?></td>

</tr>

</table></td>

</tr>

</table></td>

</tr>

<tr>

</tr>

<tr>

</tr>

<tr>

<tr>

<td class="main"><?php echo tep_draw_checkbox_field('newsletter', '1') . ' ' . (tep_not_null(ENTRY_NEWSLETTER_TEXT) ? '<span class="inputRequirement">' . ENTRY_NEWSLETTER_TEXT . '</span>': ''); ?></td>

</tr>

</table></td>

</tr>

</table></td>

</tr>

<tr>

</tr>

<tr>

</tr>

<tr>

<tr>

<td class="main"><?php echo tep_draw_password_field('password') . ' ' . (tep_not_null(ENTRY_PASSWORD_TEXT) ? '<span class="inputRequirement">' . ENTRY_PASSWORD_TEXT . '</span>': ''); ?></td>

</tr>

<tr>

<td class="main"><?php echo tep_draw_password_field('confirmation') . ' ' . (tep_not_null(ENTRY_PASSWORD_CONFIRMATION_TEXT) ? '<span class="inputRequirement">' . ENTRY_PASSWORD_CONFIRMATION_TEXT . '</span>': ''); ?></td>

</tr>

</table></td>

</tr>

</table></td>

</tr>

<tr>

</tr>

<tr>

<tr>

</tr>

</table></td>

</tr>

</table></td>

</tr>

</table></form></td>

</table></td>

</tr>

</table>

<?php include(DIR_WS_INCLUDES . 'footer.php'); ?>

<br>

</body>

</html>

<?php require(DIR_WS_INCLUDES . 'application_bottom.php'); ?>

Velveeta · February 20, 2007

Well, I notice you've got some outside-the-norm field names for that create account form... things like "1st Line Address" and "County" and whatnot... Could you post a link to your site so I can go take a look at it and check something real quick?

Richard.

Casadeva · February 20, 2007

The url is www.petbling.co.uk/oscom

Although I think I sorted it by making all the minimums 0 in the configuration section probably not and ideal soloution but it seems to have worked for now. Any other suggestions would be appreciated.

eva x

Velveeta · February 20, 2007

Ok, here's your problem, and the setting of the minimums to 0 won't really help, because the problem is legitimate :D Right now you're not storing any customer street address or town info because it's not there... This is the html markup from your create_account page:

<td><table border="0" cellspacing="2" cellpadding="2">
		  <tr>
			<td class="main">1st Line Address:</td>
			<td class="main"><input type="text" name="street_address"> <span class="inputRequirement">*</span></td>
		  </tr>
		  <tr>
			<td class="main">2nd Line Address:</td>
			<td class="main"><input type="text" name="suburb"> </td>
		  </tr>
		  <tr>
			<td class="main">Post Code:</td>
			<td class="main"><input type="text" name="postcode"> <span class="inputRequirement">*</span></td>
		  </tr>
		  <tr>
			<td class="main">Town:</td>
			<td class="main"><input type="text" name="city"> <span class="inputRequirement">*</span></td>
		  </tr>

If you'll notice, your 1st Line Address, 2nd Line Address, and Town lines all still have the default oscommerce field names, street_address, suburb, and city... So in your code that processes the form, you've got this:

$street_address = tep_db_prepare_input($HTTP_POST_VARS['1st Line Address']);
if (ACCOUNT_SUBURB == 'true') $suburb = tep_db_prepare_input($HTTP_POST_VARS['2nd Line Address']);
$postcode = tep_db_prepare_input($HTTP_POST_VARS['postcode']);
$city = tep_db_prepare_input($HTTP_POST_VARS['Town']);

You're referencing the wrong $HTTP_POST_VARS field names... You've got $HTTP_POST_VARS['1st Line Address'], but that actual value is $HTTP_POST_VARS['street_address']... The ['1st Line Address'] field doesn't exist in that post data, so it's assigning an empty string to the $street_address variable, and when it gets lower in the script and checks a blank against the minimum requirement, it's throwing the error... Same for $HTTP_POST_VARS['Town'] which should be ['city']... And ['2nd Line Address'] should be ['suburb']... You can either change this stuff there in the processing section, back to the default names, or you can change the actual field names down below where the form is actually drawn, to match what you have there in the processing section, although I would advise using underscores instead of spaces in those field names...

Richard.

Casadeva · February 20, 2007

Ok, here's your problem, and the setting of the minimums to 0 won't really help, because the problem is legitimate :D Right now you're not storing any customer street address or town info because it's not there... This is the html markup from your create_account page:
<td><table border="0" cellspacing="2" cellpadding="2">
		  <tr>
			<td class="main">1st Line Address:</td>
			<td class="main"><input type="text" name="street_address"> <span class="inputRequirement">*</span></td>
		  </tr>
		  <tr>
			<td class="main">2nd Line Address:</td>
			<td class="main"><input type="text" name="suburb"> </td>
		  </tr>
		  <tr>
			<td class="main">Post Code:</td>
			<td class="main"><input type="text" name="postcode"> <span class="inputRequirement">*</span></td>
		  </tr>
		  <tr>
			<td class="main">Town:</td>
			<td class="main"><input type="text" name="city"> <span class="inputRequirement">*</span></td>
		  </tr>
If you'll notice, your 1st Line Address, 2nd Line Address, and Town lines all still have the default oscommerce field names, street_address, suburb, and city... So in your code that processes the form, you've got this:
$street_address = tep_db_prepare_input($HTTP_POST_VARS['1st Line Address']);
if (ACCOUNT_SUBURB == 'true') $suburb = tep_db_prepare_input($HTTP_POST_VARS['2nd Line Address']);
$postcode = tep_db_prepare_input($HTTP_POST_VARS['postcode']);
$city = tep_db_prepare_input($HTTP_POST_VARS['Town']);
You're referencing the wrong $HTTP_POST_VARS field names... You've got $HTTP_POST_VARS['1st Line Address'], but that actual value is $HTTP_POST_VARS['street_address']... The ['1st Line Address'] field doesn't exist in that post data, so it's assigning an empty string to the $street_address variable, and when it gets lower in the script and checks a blank against the minimum requirement, it's throwing the error... Same for $HTTP_POST_VARS['Town'] which should be ['city']... And ['2nd Line Address'] should be ['suburb']... You can either change this stuff there in the processing section, back to the default names, or you can change the actual field names down below where the form is actually drawn, to match what you have there in the processing section, although I would advise using underscores instead of spaces in those field names...

Richard.

Thank you Richard

I thought that I'd just changed what appears on the page in the define bit in the english php file but what do I know? (not enough obviously lol)

Eva x

Please Help!!

Recommended Posts

Casadeva

Link to comment

Share on other sites

Velveeta

Link to comment

Share on other sites

Casadeva

Link to comment

Share on other sites

Velveeta

Link to comment

Share on other sites

Casadeva

Link to comment

Share on other sites

Velveeta

Link to comment

Share on other sites

Casadeva

Link to comment

Share on other sites

Archived

Browse

Activity