PHP newbie needs help with orders.php

itsgraham · February 16, 2007

Hi all.

I have installed the admin only comments contrib which works well on the individual order page ( orders.php )but I need to see the comments on the orders overview ( which is still orders.php )

I have it working but it shows the same comments for all the orders ( the comments relevant to whichever order is highlighted ) any idea how I make it pull the right comments for each order ?

regards.

Graham

Velveeta · February 16, 2007

Hi all.
I have installed the admin only comments contrib which works well on the individual order page ( orders.php )but I need to see the comments on the orders overview ( which is still orders.php )

I have it working but it shows the same comments for all the orders ( the comments relevant to whichever order is highlighted ) any idea how I make it pull the right comments for each order ?

regards.

Graham

Sounds like it's not using the right orders_id in the query, can you post the query it's using here so we can try to figure out what's wrong with it?

Richard.

itsgraham · February 16, 2007

Sounds like it's not using the right orders_id in the query, can you post the query it's using here so we can try to figure out what's wrong with it?

Richard.

Okay :) This is the code I am using, I have copied it from further up the file where it is working on the individual order page ( obviously not as simple as that L) )

<tr>

</tr>

<?php

$admin_comments_query = tep_db_query("select orders_id, date_added, comments from admin_comments where orders_id = '" . tep_db_input($oID) . "' order by date_added");

if (tep_db_num_rows($admin_comments_query)) {

while ($admin_history = tep_db_fetch_array($admin_comments_query)) {

echo ' <tr>' . "\n" .

' <td class="smallText" align="center">' . tep_datetime_short($admin_history['date_added']) . '</td>' . "\n" .

' <td class="smallText">' . nl2br(tep_db_output($admin_history['comments'])) . ' </td>' . "\n" .

' </tr>' . "\n";

}

} else {

echo ' <tr>' . "\n" .

' <td class="smallText" colspan="2">No Admin Comments.</td>' . "\n" .

' </tr>' . "\n";

}

?>

</table>

<?php echo tep_draw_form('status', FILENAME_ORDERS, tep_get_all_get_params(array('action')) . 'action=update_admin_comments'); ?>

<tr>

<!-- <td class="main"><b>Admin Comments</b></td>

</tr> -->

<tr>

</tr>

<tr>

</td>

</tr>

</table></form></td>

Velveeta · February 16, 2007

Okay :) This is the code I am using, I have copied it from further up the file where it is working on the individual order page ( obviously not as simple as that L) )



<td class="dataTableContent">

<B><?php echo $orders['orders_id']; ?>

<table width="100%" border="1" cellpadding="2" cellspacing="0">

<tr>

<td class="smallText" align="center"><b><?php echo TABLE_HEADING_DATE_ADDED; ?></b></td>

<td class="smallText" align="center"><b><?php echo TABLE_HEADING_COMMENTS; ?></b></td>

</tr>

<?php

$admin_comments_query = tep_db_query("select orders_id, date_added, comments from admin_comments where orders_id = '" . tep_db_input($oID) . "' order by date_added");

if (tep_db_num_rows($admin_comments_query)) {

while ($admin_history = tep_db_fetch_array($admin_comments_query)) {

echo ' <tr>' . "\n" .

' <td class="smallText" align="center">' . tep_datetime_short($admin_history['date_added']) . '</td>' . "\n" .

' <td class="smallText">' . nl2br(tep_db_output($admin_history['comments'])) . ' </td>' . "\n" .

' </tr>' . "\n";

}

} else {

echo ' <tr>' . "\n" .

' <td class="smallText" colspan="2">No Admin Comments.</td>' . "\n" .

' </tr>' . "\n";

}

?>

</table>

<?php echo tep_draw_form('status', FILENAME_ORDERS, tep_get_all_get_params(array('action')) . 'action=update_admin_comments'); ?>

<table width="100%" border="0" cellpadding="0" cellspacing="0" class="main">

<tr>



<tr>

<td><?php echo tep_draw_textarea_field('admin_comments', 'soft', '20', '1'); ?></td>

</tr>

<tr>

<td><?php echo tep_image_submit('button_update.gif', IMAGE_UPDATE); ?>

</td>

</tr>

</table></form></td>

Ok, most likely what's happening here is that it's working right in the edit order screen, which is where you'd add them I'm guessing, and where any existing ones are showing up also... There's this bit of code in place right before the start of the html output:

if (($action == 'edit') && isset($HTTP_GET_VARS['oID'])) {
$oID = tep_db_prepare_input($HTTP_GET_VARS['oID']);

$orders_query = tep_db_query("select orders_id from " . TABLE_ORDERS . " where orders_id = '" . (int)$oID . "'");
$order_exists = true;
if (!tep_db_num_rows($orders_query)) {
  $order_exists = false;
  $messageStack->add(sprintf(ERROR_ORDER_DOES_NOT_EXIST, $oID), 'error');
}
 }

This sets the $oID variable... but only for the 'edit' command... If you want to use this on the main order listing as well, you'll need to set it for that as well, just using this same line before you send that query from the right column section at the bottom of the file:

$oID = tep_db_prepare_input($HTTP_GET_VARS['oID']);

Richard.

itsgraham · February 16, 2007

Uhhh ok :) I will try and digest that and let you know if it solves the problem. Thanks for your input Richard.

regards

Graham

Ok, most likely what's happening here is that it's working right in the edit order screen, which is where you'd add them I'm guessing, and where any existing ones are showing up also... There's this bit of code in place right before the start of the html output:
if (($action == 'edit') && isset($HTTP_GET_VARS['oID'])) {
$oID = tep_db_prepare_input($HTTP_GET_VARS['oID']);

$orders_query = tep_db_query("select orders_id from " . TABLE_ORDERS . " where orders_id = '" . (int)$oID . "'");
$order_exists = true;
if (!tep_db_num_rows($orders_query)) {
  $order_exists = false;
  $messageStack->add(sprintf(ERROR_ORDER_DOES_NOT_EXIST, $oID), 'error');
}
 }
This sets the $oID variable... but only for the 'edit' command... If you want to use this on the main order listing as well, you'll need to set it for that as well, just using this same line before you send that query from the right column section at the bottom of the file:

$oID = tep_db_prepare_input($HTTP_GET_VARS['oID']);

Richard.

itsgraham · February 17, 2007

Uhhh ok :) I will try and digest that and let you know if it solves the problem. Thanks for your input Richard.
regards

Graham

I'm stumped. I have tried adding the line where i think it should probably go but it just sows as code ( and if I put it above the table it shows six times ( the same number as there are orders on the page )

Can you be more specific about where it goes ?

regards

Graham

Velveeta · February 17, 2007

I'm stumped. I have tried adding the line where i think it should probably go but it just sows as code ( and if I put it above the table it shows six times ( the same number as there are orders on the page )

Can you be more specific about where it goes ?

regards

Graham

Ummm, the line that I told you to insert shouldn't "show" anything... It only sets a variable, it doesn't output anything... And actually, now that I just downloaded a copy of osc real quick to take a look at orders.php, I realize you don't even need that... All you need to do is change the variable that's being stuck into the sql query from this:

$admin_comments_query = tep_db_query("select orders_id, date_added, comments from admin_comments where orders_id = '" . tep_db_input($oID) . "' order by date_added");

To this:

$admin_comments_query = tep_db_query("select orders_id, date_added, comments from admin_comments where orders_id = '" . tep_db_input($oInfo->orders_id) . "' order by date_added");

Richard.

itsgraham · February 17, 2007

Now I'm even more confused :)

I have six ( dummy ) orders showing on the order overview. Before I made this change if I clicked on order 6 then all six orders showed the comments for order 6. If I clicked on order 5 then all six showed the comments relating to order 5..... and so on.

I made the change you showed and now if I click on order 6 all orders still show comments related to order 6 .... If I click on order 5 then orders 5,4,3,2 & 1 show the comments relating to order 5 but order 6 shows the comments for a previously deleted order. .... If I click on order 4 then 4,3,2,1 all show comments related to order 4 and orders 6 & 5 show the comments for the deleted order. and so on until I click on order 1 which shows comments for order 1 and all the rest show the comments for the deleted order.

I had a fullhead of hair before I started this.

Richard - I really appreciate your time with this.

regards

Graham

Ummm, the line that I told you to insert shouldn't "show" anything... It only sets a variable, it doesn't output anything... And actually, now that I just downloaded a copy of osc real quick to take a look at orders.php, I realize you don't even need that... All you need to do is change the variable that's being stuck into the sql query from this:

$admin_comments_query = tep_db_query("select orders_id, date_added, comments from admin_comments where orders_id = '" . tep_db_input($oID) . "' order by date_added");

To this:

$admin_comments_query = tep_db_query("select orders_id, date_added, comments from admin_comments where orders_id = '" . tep_db_input($oInfo->orders_id) . "' order by date_added");

Richard.

Velveeta · February 17, 2007

Now I'm even more confused :)

I have six ( dummy ) orders showing on the order overview. Before I made this change if I clicked on order 6 then all six orders showed the comments for order 6. If I clicked on order 5 then all six showed the comments relating to order 5..... and so on.

I made the change you showed and now if I click on order 6 all orders still show comments related to order 6 .... If I click on order 5 then orders 5,4,3,2 & 1 show the comments relating to order 5 but order 6 shows the comments for a previously deleted order. .... If I click on order 4 then 4,3,2,1 all show comments related to order 4 and orders 6 & 5 show the comments for the deleted order. and so on until I click on order 1 which shows comments for order 1 and all the rest show the comments for the deleted order.

I had a fullhead of hair before I started this.

Richard - I really appreciate your time with this.

regards

Graham

How about you post that entire orders.php file so we can see just how you're actually trying to use this query...

Richard.

itsgraham · February 17, 2007

How about you post that entire orders.php file so we can see just how you're actually trying to use this query...

Richard.

OK, but its a long file.

I should point out that my intent was to get the individual comments from the admin only comments box to show up on the order overview so I could use them for my own order numbers and find them quickly. At the moment I also have the ability to make notes on the overview page as well but I am not so concerned about keeping that bit.

<?php

/*

$Id: orders.php,v 1.112 2003/06/29 22:50:52 hpdl Exp $

osCommerce, Open Source E-Commerce Solutions

http://www.oscommerce.com

Released under the GNU General Public License

*/

require('includes/application_top.php');

require(DIR_WS_CLASSES . 'currencies.php');

$currencies = new currencies();

$orders_statuses = array();

$orders_status_array = array();

$orders_status_query = tep_db_query("select orders_status_id, orders_status_name from " . TABLE_ORDERS_STATUS . " where language_id = '" . (int)$languages_id . "'");

while ($orders_status = tep_db_fetch_array($orders_status_query)) {

$orders_statuses[] = array('id' => $orders_status['orders_status_id'],

'text' => $orders_status['orders_status_name']);

$orders_status_array[$orders_status['orders_status_id']] = $orders_status['orders_status_name'];

}

$action = (isset($HTTP_GET_VARS['action']) ? $HTTP_GET_VARS['action'] : '');

if (tep_not_null($action)) {

switch ($action) {

// BOF Admin Only Comments Box v1.2

case 'update_admin_comments':

$oID = tep_db_prepare_input($HTTP_GET_VARS['oID']);

$comments = tep_db_prepare_input($HTTP_POST_VARS['admin_comments']);

$order_updated = false;

tep_db_query("insert into admin_comments (orders_id, date_added, comments) values ('" . (int)$oID . "', now(), '" . tep_db_input($comments) . "')");

$order_updated = true;

if ($order_updated == true) {

$messageStack->add_session('Admin Comments Updated', 'success');

} else {

$messageStack->add_session('Admin Comments Not Updated', 'warning');

}

tep_redirect(tep_href_link(FILENAME_ORDERS, tep_get_all_get_params(array('action')) . 'action=edit'));

break;

// EOF Admin Only Comments Box v1.2

case 'update_order':

$oID = tep_db_prepare_input($HTTP_GET_VARS['oID']);

$status = tep_db_prepare_input($HTTP_POST_VARS['status']);

$comments = tep_db_prepare_input($HTTP_POST_VARS['comments']);

$order_updated = false;

//fast easy checkout start

$check_status_query = tep_db_query("select customers_name, customers_email_address,customers_id, orders_status, date_purchased from " . TABLE_ORDERS . " where orders_id = '" . (int)$oID . "'");

$check_status = tep_db_fetch_array($check_status_query);

$cust_id = $check_status['customers_id'];

//fast easy checkout end

if ( ($check_status['orders_status'] != $status) || tep_not_null($comments)) {

tep_db_query("update " . TABLE_ORDERS . " set orders_status = '" . tep_db_input($status) . "', last_modified = now() where orders_id = '" . (int)$oID . "'");

$customer_notified = '0';

if (isset($HTTP_POST_VARS['notify']) && ($HTTP_POST_VARS['notify'] == 'on')) {

$notify_comments = '';

//fast easy checkout start

if (isset($HTTP_POST_VARS['notify_comments']) && ($HTTP_POST_VARS['notify_comments'] == 'on')) {

$notify_comments = sprintf(EMAIL_TEXT_COMMENTS_UPDATE, $comments) . "\n\n";

}

// start no account changes

$noaccount_check_query= tep_db_query("select createaccount from " . TABLE_CUSTOMERS . " where customers_id = '" . $cust_id . "'");

$noaccount_check= tep_db_fetch_array($noaccount_check_query);

if ($noaccount_check['createaccount'] == 'Y'){$email = STORE_NAME . "\n" . EMAIL_SEPARATOR . "\n" . EMAIL_TEXT_ORDER_NUMBER . ' ' . $oID . "\n" . EMAIL_TEXT_INVOICE_URL . ' ' . tep_catalog_href_link(FILENAME_CATALOG_ACCOUNT_HISTORY_INFO, 'order_id=' . $oID, 'SSL') . "\n" . EMAIL_TEXT_DATE_ORDERED . ' ' . tep_date_long($check_status['date_purchased']) . "\n\n" . $notify_comments . sprintf(EMAIL_TEXT_STATUS_UPDATE, $orders_status_array[$status]); }

else {$email = STORE_NAME . "\n" . EMAIL_SEPARATOR . "\n" . EMAIL_TEXT_ORDER_NUMBER . ' ' . $oID . "\n" . EMAIL_TEXT_DATE_ORDERED . ' ' . tep_date_long($check_status['date_purchased']) . "\n\n" . $notify_comments . sprintf(EMAIL_TEXT_STATUS_UPDATE, $orders_status_array[$status]); } tep_mail($check_status['customers_name'], $check_status['customers_email_address'], EMAIL_TEXT_SUBJECT, $email, STORE_OWNER, STORE_OWNER_EMAIL_ADDRESS);

$customer_notified = '1';

}

//fast easy checkout end

tep_db_query("insert into " . TABLE_ORDERS_STATUS_HISTORY . " (orders_id, orders_status_id, date_added, customer_notified, comments) values ('" . (int)$oID . "', '" . tep_db_input($status) . "', now(), '" . tep_db_input($customer_notified) . "', '" . tep_db_input($comments) . "')");

$order_updated = true;

}

if ($order_updated == true) {

$messageStack->add_session(SUCCESS_ORDER_UPDATED, 'success');

} else {

$messageStack->add_session(WARNING_ORDER_NOT_UPDATED, 'warning');

}

tep_redirect(tep_href_link(FILENAME_ORDERS, tep_get_all_get_params(array('action')) . 'action=edit'));

break;

case 'deleteconfirm':

$oID = tep_db_prepare_input($HTTP_GET_VARS['oID']);

tep_remove_order($oID, $HTTP_POST_VARS['restock']);

tep_redirect(tep_href_link(FILENAME_ORDERS, tep_get_all_get_params(array('oID', 'action'))));

break;

}

if (($action == 'edit') && isset($HTTP_GET_VARS['oID'])) {

$oID = tep_db_prepare_input($HTTP_GET_VARS['oID']);

$orders_query = tep_db_query("select orders_id from " . TABLE_ORDERS . " where orders_id = '" . (int)$oID . "'");

$order_exists = true;

if (!tep_db_num_rows($orders_query)) {

$order_exists = false;

$messageStack->add(sprintf(ERROR_ORDER_DOES_NOT_EXIST, $oID), 'error');

}

include(DIR_WS_CLASSES . 'order.php');

?>

<!doctype html public "-//W3C//DTD HTML 4.01 Transitional//EN">

<head>

</head>

<?php

require(DIR_WS_INCLUDES . 'header.php');

?>

<tr>

<td width="<?php echo BOX_WIDTH; ?>" valign="top"><table border="0" width="<?php echo BOX_WIDTH; ?>" cellspacing="1" cellpadding="1" class="columnLeft">

<?php require(DIR_WS_INCLUDES . 'column_left.php'); ?>

</table></td>

<?php

if (($action == 'edit') && ($order_exists == true)) {

$order = new order($oID);

?>

<tr>

<tr>

<td class="pageHeading" align="right"><?php echo '<a href="' . tep_href_link(FILENAME_ORDERS, tep_get_all_get_params(array('action'))) . '">' . tep_image_button('button_back.gif', IMAGE_BACK) . '</a>'; ?></td>

</tr>

</table></td>

</tr>

<tr>

<tr>

</tr>

<tr>

<tr>

<td class="main"><?php echo tep_address_format($order->customer['format_id'], $order->customer, 1, '', '<br>'); ?></td>

</tr>

<tr>

</tr>

<tr>

<td class="main"><?php echo $order->customer['telephone']; ?></td>

</tr>

<tr>

<td class="main"><?php echo '<a href="mailto:' . $order->customer['email_address'] . '"><u>' . $order->customer['email_address'] . '</u></a>'; ?></td>

</tr>

</table></td>

<tr>

<td class="main"><?php echo tep_address_format($order->delivery['format_id'], $order->delivery, 1, '', '<br>'); ?></td>

</tr>

</table></td>

<tr>

<td class="main"><?php echo tep_address_format($order->billing['format_id'], $order->billing, 1, '', '<br>'); ?></td>

</tr>

</table></td>

</tr>

</table></td>

</tr>

<tr>

</tr>

<tr>

<tr>

<td class="main"><?php echo $order->info['payment_method']; ?></td>

</tr>

<?php

if (tep_not_null($order->info['cc_type']) || tep_not_null($order->info['cc_owner']) || tep_not_null($order->info['cc_number'])) {

?>

<tr>

</tr>

<tr>

</tr>

<tr>

<td class="main"><?php echo $order->info['cc_owner']; ?></td>

</tr>

<tr>

<td class="main"><?php echo $order->info['cc_number']; ?></td>

</tr>

<tr>

<td class="main"><?php echo $order->info['cc_expires']; ?></td>

</tr>

<?php

}

?>

</table></td>

</tr>

<tr>

</tr>

<tr>

</tr>

<?php

for ($i=0, $n=sizeof($order->products); $i<$n; $i++) {

echo ' <tr class="dataTableRow">' . "\n" .

' <td class="dataTableContent" valign="top" align="right">' . $order->products[$i]['qty'] . ' x</td>' . "\n" .

' <td class="dataTableContent" valign="top">' . $order->products[$i]['name'];

if (isset($order->products[$i]['attributes']) && (sizeof($order->products[$i]['attributes']) > 0)) {

for ($j = 0, $k = sizeof($order->products[$i]['attributes']); $j < $k; $j++) {

echo '<br><nobr><small> <i> - ' . $order->products[$i]['attributes'][$j]['option'] . ': ' . $order->products[$i]['attributes'][$j]['value'];

if ($order->products[$i]['attributes'][$j]['price'] != '0') echo ' (' . $order->products[$i]['attributes'][$j]['prefix'] . $currencies->format($order->products[$i]['attributes'][$j]['price'] * $order->products[$i]['qty'], true, $order->info['currency'], $order->info['currency_value']) . ')';

echo '</i></small></nobr>';

}

echo ' </td>' . "\n" .

' <td class="dataTableContent" valign="top">' . $order->products[$i]['model'] . '</td>' . "\n" .

' <td class="dataTableContent" align="right" valign="top">' . tep_display_tax_value($order->products[$i]['tax']) . '%</td>' . "\n" .

' <td class="dataTableContent" align="right" valign="top"><b>' . $currencies->format($order->products[$i]['final_price'], true, $order->info['currency'], $order->info['currency_value']) . '</b></td>' . "\n" .

' <td class="dataTableContent" align="right" valign="top"><b>' . $currencies->format(tep_add_tax($order->products[$i]['final_price'], $order->products[$i]['tax']), true, $order->info['currency'], $order->info['currency_value']) . '</b></td>' . "\n" .

' <td class="dataTableContent" align="right" valign="top"><b>' . $currencies->format($order->products[$i]['final_price'] * $order->products[$i]['qty'], true, $order->info['currency'], $order->info['currency_value']) . '</b></td>' . "\n" .

' <td class="dataTableContent" align="right" valign="top"><b>' . $currencies->format(tep_add_tax($order->products[$i]['final_price'], $order->products[$i]['tax']) * $order->products[$i]['qty'], true, $order->info['currency'], $order->info['currency_value']) . '</b></td>' . "\n";

echo ' </tr>' . "\n";

}

?>

<tr>

<?php

for ($i = 0, $n = sizeof($order->totals); $i < $n; $i++) {

echo ' <tr>' . "\n" .

' <td align="right" class="smallText">' . $order->totals[$i]['title'] . '</td>' . "\n" .

' <td align="right" class="smallText">' . $order->totals[$i]['text'] . '</td>' . "\n" .

' </tr>' . "\n";

}

?>

</table></td>

</tr>

</table></td>

</tr>

<tr>

</tr>

<tr>

<tr>

<tr>

<tr>

</tr>

<?php

$orders_history_query = tep_db_query("select orders_status_id, date_added, customer_notified, comments from " . TABLE_ORDERS_STATUS_HISTORY . " where orders_id = '" . tep_db_input($oID) . "' order by date_added");

if (tep_db_num_rows($orders_history_query)) {

while ($orders_history = tep_db_fetch_array($orders_history_query)) {

echo ' <tr>' . "\n" .

' <td class="smallText" align="center">' . tep_datetime_short($orders_history['date_added']) . '</td>' . "\n" .

' <td class="smallText" align="center">';

if ($orders_history['customer_notified'] == '1') {

echo tep_image(DIR_WS_ICONS . 'tick.gif', ICON_TICK) . "</td>\n";

} else {

echo tep_image(DIR_WS_ICONS . 'cross.gif', ICON_CROSS) . "</td>\n";

}

echo ' <td class="smallText">' . $orders_status_array[$orders_history['orders_status_id']] . '</td>' . "\n" .

' <td class="smallText">' . nl2br(tep_db_output($orders_history['comments'])) . ' </td>' . "\n" .

' </tr>' . "\n";

}

} else {

echo ' <tr>' . "\n" .

' <td class="smallText" colspan="5">' . TEXT_NO_ORDER_HISTORY . '</td>' . "\n" .

' </tr>' . "\n";

}

?>

</table></td>

</tr>

<tr>

</tr>

<?php echo tep_draw_form('status', FILENAME_ORDERS, tep_get_all_get_params(array('action')) . 'action=update_order'); ?>

<tr>

</tr>

<tr>

</tr>

<tr>

<tr>

<tr>

<?php echo tep_draw_pull_down_menu('status', $orders_statuses, $order->info['orders_status']); ?></td>

</tr>

<tr>

<?php echo tep_draw_checkbox_field('notify', '', true); ?></td>

<?php echo tep_draw_checkbox_field('notify_comments', '', true); ?></td>

</tr>

</table></td>

</tr>

</table></td></form>

</tr>

</table></td>

<tr>

<tr>

</tr>

<?php

$admin_comments_query = tep_db_query("select orders_id, date_added, comments from admin_comments where orders_id = '" . tep_db_input($oID) . "' order by date_added");

if (tep_db_num_rows($admin_comments_query)) {

while ($admin_history = tep_db_fetch_array($admin_comments_query)) {

echo ' <tr>' . "\n" .

' <td class="smallText" align="center">' . tep_datetime_short($admin_history['date_added']) . '</td>' . "\n" .

' <td class="smallText">' . nl2br(tep_db_output($admin_history['comments'])) . ' </td>' . "\n" .

' </tr>' . "\n";

}

} else {

echo ' <tr>' . "\n" .

' <td class="smallText" colspan="2">No Admin Comments.</td>' . "\n" .

' </tr>' . "\n";

}

?>

</table></td>

</tr>

<tr>

<tr>

<td class="main"><b>Admin Comments</b></td>

</tr>

<tr>

</tr>

<tr>

</tr>

</table></form></td>

</tr>

</table></td>

</tr>

</table>

<tr>

<td colspan="2" align="right"><?php echo '<a href="' . tep_href_link(FILENAME_ORDERS_INVOICE, 'oID=' . $HTTP_GET_VARS['oID']) . '" TARGET="_blank">' . tep_image_button('button_invoice.gif', IMAGE_ORDERS_INVOICE) . '</a> <a href="' . tep_href_link(FILENAME_ORDERS_PACKINGSLIP, 'oID=' . $HTTP_GET_VARS['oID']) . '" TARGET="_blank">' . tep_image_button('button_packingslip.gif', IMAGE_ORDERS_PACKINGSLIP) . '</a> <a href="' . tep_href_link(FILENAME_ORDERS, tep_get_all_get_params(array('action'))) . '">' . tep_image_button('button_back.gif', IMAGE_BACK) . '</a>'; ?></td>

</tr>

<?php

} else {

?>

<tr>

<tr>

</form></tr>

<td class="smallText" align="right"><?php echo HEADING_TITLE_STATUS . ' ' . tep_draw_pull_down_menu('status', array_merge(array(array('id' => '', 'text' => TEXT_ALL_ORDERS)), $orders_statuses), '', 'onChange="this.form.submit();"'); ?></td>

</form></tr>

</table></td>

</tr>

</table></td>

</tr>

<tr>

<tr>

</tr>

<?php

if (isset($HTTP_GET_VARS['cID'])) {

$cID = tep_db_prepare_input($HTTP_GET_VARS['cID']);

$orders_query_raw = "select o.orders_id, o.customers_name, o.customers_id, o.payment_method, o.date_purchased, o.last_modified, o.currency, o.currency_value, s.orders_status_name, ot.text as order_total from " . TABLE_ORDERS . " o left join " . TABLE_ORDERS_TOTAL . " ot on (o.orders_id = ot.orders_id), " . TABLE_ORDERS_STATUS . " s where o.customers_id = '" . (int)$cID . "' and o.orders_status = s.orders_status_id and s.language_id = '" . (int)$languages_id . "' and ot.class = 'ot_total' order by orders_id DESC";

} elseif (isset($HTTP_GET_VARS['status']) && is_numeric($HTTP_GET_VARS['status']) && ($HTTP_GET_VARS['status'] > 0)) {

$status = tep_db_prepare_input($HTTP_GET_VARS['status']);

$orders_query_raw = "select o.orders_id, o.customers_name, o.payment_method,

o.date_purchased, o.last_modified, o.currency, o.currency_value, s.orders_status_name, ot.text as order_total from " . TABLE_ORDERS . " o left join " . TABLE_ORDERS_TOTAL . " ot on (o.orders_id = ot.orders_id), " . TABLE_ORDERS_STATUS . " s where o.orders_status = s.orders_status_id and s.language_id = '" . (int)$languages_id . "' and s.orders_status_id = '" . (int)$status . "' and ot.class = 'ot_total' order by o.orders_id DESC";

} else {

$orders_query_raw = "select o.orders_id, o.customers_name, o.payment_method, o.date_purchased, o.last_modified, o.currency, o.currency_value, s.orders_status_name, ot.text as order_total from " . TABLE_ORDERS . " o left join " . TABLE_ORDERS_TOTAL . " ot on (o.orders_id = ot.orders_id), " . TABLE_ORDERS_STATUS . " s where o.orders_status = s.orders_status_id and s.language_id = '" . (int)$languages_id . "' and ot.class = 'ot_total' order by o.orders_id DESC";

}

$orders_split = new splitPageResults($HTTP_GET_VARS['page'], MAX_DISPLAY_SEARCH_RESULTS, $orders_query_raw, $orders_query_numrows);

$orders_query = tep_db_query($orders_query_raw);

while ($orders = tep_db_fetch_array($orders_query)) {

if ((!isset($HTTP_GET_VARS['oID']) || (isset($HTTP_GET_VARS['oID']) && ($HTTP_GET_VARS['oID'] == $orders['orders_id']))) && !isset($oInfo)) {

$oInfo = new objectInfo($orders);

}

if (isset($oInfo) && is_object($oInfo) && ($orders['orders_id'] == $oInfo->orders_id)) {

echo '

<!-- THIS WAS IN FOLLOWING TABLE ROW BRACKETS

onmouseover="rowOverEffect(this)" onmouseout="rowOutEffect(this)" onclick="document.location.href=\'' . tep_href_link(FILENAME_ORDERS, tep_get_all_get_params(array('oID', 'action')) . 'oID=' . $oInfo->orders_id . '&action=edit') . '\'" ENDS -->

<tr id="defaultSelected" class="dataTableRowSelected">' . "\n";

} else {

echo '

<!-- THIS WAS IN FOLLOWING TABLE ROW BRACKETS

onmouseover="rowOverEffect(this)" onmouseout="rowOutEffect(this)" onclick="document.location.href=\'' . tep_href_link(FILENAME_ORDERS, tep_get_all_get_params(array('oID')) . 'oID=' . $orders['orders_id']) . '\'" ENDS -->

<tr class="dataTableRow">' . "\n";

}

?>

<td class="dataTableContent"><?php echo '<a href="' . tep_href_link(FILENAME_ORDERS, tep_get_all_get_params(array('oID', 'action')) . 'oID=' . $orders['orders_id'] . '&action=edit') . '">' . tep_image(DIR_WS_ICONS . 'preview.gif', ICON_PREVIEW) . '</a> ' . $orders['customers_name']; ?></td>

<tr>

</tr>

<?php

$admin_comments_query = tep_db_query("select orders_id, date_added, comments from admin_comments where orders_id = '" . tep_db_input($oInfo->orders_id) . "' order by date_added");

if (tep_db_num_rows($admin_comments_query)) {

while ($admin_history = tep_db_fetch_array($admin_comments_query)) {

echo ' <tr>' . "\n" .

' <td class="smallText" align="center">' . tep_datetime_short($admin_history['date_added']) . '</td>' . "\n" .

' <td class="smallText">' . nl2br(tep_db_output($admin_history['comments'])) . ' </td>' . "\n" .

' </tr>' . "\n";

}

} else {

echo ' <tr>' . "\n" .

' <td class="smallText" colspan="2">No Admin Comments.</td>' . "\n" .

' </tr>' . "\n";

}

?>

</table>

<?php echo tep_draw_form('status', FILENAME_ORDERS, tep_get_all_get_params(array('action')) . 'action=update_admin_comments'); ?>

<tr>

<!-- <td class="main"><b>Admin Comments</b></td>

</tr> -->

<tr>

</tr>

<tr>

</td>

</tr>

</table></form></td>

<td class="dataTableContent" align="right"><?php if (isset($oInfo) && is_object($oInfo) && ($orders['orders_id'] == $oInfo->orders_id)) { echo tep_image(DIR_WS_IMAGES . 'icon_arrow_right.gif', ''); } else { echo '<a href="' . tep_href_link(FILENAME_ORDERS, tep_get_all_get_params(array('oID')) . 'oID=' . $orders['orders_id']) . '">' . tep_image(DIR_WS_IMAGES . 'icon_info.gif', IMAGE_ICON_INFO) . '</a>'; } ?> </td>

</tr>

<?php

}

?>

<tr>

<tr>

<td class="smallText" valign="top"><?php echo $orders_split->display_count($orders_query_numrows, MAX_DISPLAY_SEARCH_RESULTS, $HTTP_GET_VARS['page'], TEXT_DISPLAY_NUMBER_OF_ORDERS); ?></td>

<td class="smallText" align="right"><?php echo $orders_split->display_links($orders_query_numrows, MAX_DISPLAY_SEARCH_RESULTS, MAX_DISPLAY_PAGE_LINKS, $HTTP_GET_VARS['page'], tep_get_all_get_params(array('page', 'oID', 'action'))); ?></td>

</tr>

</table></td>

</tr>

</table></td>

<?php

$heading = array();

$contents = array();

switch ($action) {

case 'delete':

$heading[] = array('text' => '<b>' . TEXT_INFO_HEADING_DELETE_ORDER . '</b>');

$contents = array('form' => tep_draw_form('orders', FILENAME_ORDERS, tep_get_all_get_params(array('oID', 'action')) . 'oID=' . $oInfo->orders_id . '&action=deleteconfirm'));

$contents[] = array('text' => TEXT_INFO_DELETE_INTRO . '<br><br><b>' . $cInfo->customers_firstname . ' ' . $cInfo->customers_lastname . '</b>');

$contents[] = array('text' => '<br>' . tep_draw_checkbox_field('restock') . ' ' . TEXT_INFO_RESTOCK_PRODUCT_QUANTITY);

$contents[] = array('align' => 'center', 'text' => '<br>' . tep_image_submit('button_delete.gif', IMAGE_DELETE) . ' <a href="' . tep_href_link(FILENAME_ORDERS, tep_get_all_get_params(array('oID', 'action')) . 'oID=' . $oInfo->orders_id) . '">' . tep_image_button('button_cancel.gif', IMAGE_CANCEL) . '</a>');

break;

default:

if (isset($oInfo) && is_object($oInfo)) {

$heading[] = array('text' => '<b>[' . $oInfo->orders_id . '] ' . tep_datetime_short($oInfo->date_purchased) . '</b>');

$contents[] = array('align' => 'center', 'text' => '<a href="' . tep_href_link(FILENAME_ORDERS, tep_get_all_get_params(array('oID', 'action')) . 'oID=' . $oInfo->orders_id . '&action=edit') . '">' . tep_image_button('button_edit.gif', IMAGE_EDIT) . '</a> <a href="' . tep_href_link(FILENAME_ORDERS, tep_get_all_get_params(array('oID', 'action')) . 'oID=' . $oInfo->orders_id . '&action=delete') . '">' . tep_image_button('button_delete.gif', IMAGE_DELETE) . '</a>');

$contents[] = array('align' => 'center', 'text' => '<a href="' . tep_href_link(FILENAME_ORDERS_INVOICE, 'oID=' . $oInfo->orders_id) . '" TARGET="_blank">' . tep_image_button('button_invoice.gif', IMAGE_ORDERS_INVOICE) . '</a> <a href="' . tep_href_link(FILENAME_ORDERS_PACKINGSLIP, 'oID=' . $oInfo->orders_id) . '" TARGET="_blank">' . tep_image_button('button_packingslip.gif', IMAGE_ORDERS_PACKINGSLIP) . '</a>');

$contents[] = array('text' => '<br>' . TEXT_DATE_ORDER_CREATED . ' ' . tep_date_short($oInfo->date_purchased));

if (tep_not_null($oInfo->last_modified)) $contents[] = array('text' => TEXT_DATE_ORDER_LAST_MODIFIED . ' ' . tep_date_short($oInfo->last_modified));

$contents[] = array('text' => '<br>' . TEXT_INFO_PAYMENT_METHOD . ' ' . $oInfo->payment_method);

}

break;

}

if ( (tep_not_null($heading)) && (tep_not_null($contents)) ) {

echo ' <td width="25%" valign="top">' . "\n";

$box = new box;

echo $box->infoBox($heading, $contents);

echo ' </td>' . "\n";

}

?>

</tr>

</table></td>

</tr>

<?php

}

?>

</table></td>

</tr>

</table>

<?php require(DIR_WS_INCLUDES . 'footer.php'); ?>

<br>

</body>

</html>

<?php require(DIR_WS_INCLUDES . 'application_bottom.php'); ?>

Velveeta · February 17, 2007

Could you do me a favor and edit your last post real quick to add in code block markers at the top and bottom of that file, so all of the indentions are there? Makes it much easier to read through :D Just highlight the whole file's worth of text, and right above the editor box, on the 2nd row where the b/i/u buttons and everything are, the right-most one says "Wrap in code tags" if you hover over it... Just click it with that file's text highlighted and it'll do the trick... Also, when you said the order overview page, I'm assuming you mean the order listing that shows all of your orders, 1 row at a time, right?

Richard.

tfittsy · February 17, 2007

try changing this line:

$admin_comments_query = tep_db_query("select orders_id, date_added, comments from admin_comments where orders_id = '" . tep_db_input($oInfo->orders_id) . "' order by date_added");

to this:

$admin_comments_query = tep_db_query("select orders_id, date_added, comments from admin_comments where orders_id = '" . tep_db_prepare_input($orders['orders_id') . "' order by date_added");

Velveeta · February 17, 2007

try changing this line:

$admin_comments_query = tep_db_query("select orders_id, date_added, comments from admin_comments where orders_id = '" . tep_db_input($oInfo->orders_id) . "' order by date_added");

to this:

$admin_comments_query = tep_db_query("select orders_id, date_added, comments from admin_comments where orders_id = '" . tep_db_prepare_input($orders['orders_id') . "' order by date_added");

tfittsy is most likely right, I just wanted to point out a quick typo to save you a post back here :)

tep_db_prepare_input($orders['orders_id') = tep_db_prepare_input($orders['orders_id'])

Richard.

tfittsy · February 18, 2007

tfittsy is most likely right, I just wanted to point out a quick typo to save you a post back here :)

tep_db_prepare_input($orders['orders_id') = tep_db_prepare_input($orders['orders_id'])

Richard.

Good catch. I've already been up for 16 hours today... It's been a long one.

itsgraham · February 18, 2007

Oh wow guys.... IT WORKS...IT WORKS...IT WORKS...

Thank you so much.

I have been pussling over that for days :)

One little problem ( though I can live with it ) when I make a comment on the overview ( yes, the one that lists orders one line at a time ) and click update it works but it then takes me to the individual order edit page instead of staying on the overview.

I can live with that, it is more important to read the comments on the overview, not sure we will need to make comments there as well. ( i may even decide to delete the bit of code that puts the input text box there, havent decided yet )

Many thanks guys, you are php stars

regards

Graham

Velveeta · February 18, 2007

Oh wow guys.... IT WORKS...IT WORKS...IT WORKS...

Thank you so much.

I have been pussling over that for days :)

One little problem ( though I can live with it ) when I make a comment on the overview ( yes, the one that lists orders one line at a time ) and click update it works but it then takes me to the individual order edit page instead of staying on the overview.

I can live with that, it is more important to read the comments on the overview, not sure we will need to make comments there as well. ( i may even decide to delete the bit of code that puts the input text box there, havent decided yet )

Many thanks guys, you are php stars

regards

Graham

For this, it's most likely because the form is being submitted with the same action value that is being used when you submit a new comment on the order edit page... And in that section, it redirects back to the order edit page... So when you submit a comment from the order overview page, it's going back to that action to process, which then redirects to the order edit page as well... If you want to redirect back to the order overview page, I would suggest cloning the section of orders.php that processes that new comment, and listing it as a new action value, say 'update_admin_comments_from_overview', where it does the exact same thing as far as sticking the entry into the admin_comments table, but it redirects back to the main page rather than back to the order edit page...

Richard.

tfittsy · February 18, 2007

Oh wow guys.... IT WORKS...IT WORKS...IT WORKS...

Thank you so much.

I have been pussling over that for days :)

One little problem ( though I can live with it ) when I make a comment on the overview ( yes, the one that lists orders one line at a time ) and click update it works but it then takes me to the individual order edit page instead of staying on the overview.

I can live with that, it is more important to read the comments on the overview, not sure we will need to make comments there as well. ( i may even decide to delete the bit of code that puts the input text box there, havent decided yet )

Many thanks guys, you are php stars

regards

Graham

If you want it to stay on the order overview screen after an update you'll need to find the tep_draw_form() function and change the parameters. it probably has action=edit in there somewhere and you'll need to remove that but make sure it still has whatever action has it perform the update on your comments.

PHP newbie needs help with orders.php

Recommended Posts

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Archived