Howto... Show a No-Image-Available image

[xirrom]

How can I show a 'dummy' Image (No Image Available) for products that do not have an existing image available?

 

I did a search in this osc forum and found another sollution but unfortunally the code did not exactly match with my code.

 

Below is my code. I found it in the file Product_listing.php. (I assume this is the part that should be edited.) Is there anyone who wants to help me and tell/show me what to change or add in this code so that a 'dummy' picture will be shown when there is not a real image for that product available? This is a part of the code in my product_listing.php

		  case 'PRODUCT_LIST_IMAGE':
		$lc_align = 'center';
		if (isset($HTTP_GET_VARS['manufacturers_id'])) {
		  $lc_text = '<a href="' . tep_href_link(FILENAME_PRODUCT_INFO, 'manufacturers_id=' . $HTTP_GET_VARS['manufacturers_id'] . '&products_id=' . $listing['products_id']) . '">' . tep_image(DIR_WS_IMAGES . $listing['products_image'], $listing['products_name'], SMALL_IMAGE_WIDTH, SMALL_IMAGE_HEIGHT) . '</a>';
		} else {
		  $lc_text = ' <a href="' . tep_href_link(FILENAME_PRODUCT_INFO, ($cPath ? 'cPath=' . $cPath . '&' : '') . 'products_id=' . $listing['products_id']) . '">' . tep_image(DIR_WS_IMAGES . $listing['products_image'], $listing['products_name'], SMALL_IMAGE_WIDTH, SMALL_IMAGE_HEIGHT) . '</a> ';
		}
		break;

[bill110]

You don't really have to edit code. Just have your own "no image available" image and when you add a product without an image use that one as the product image.

[xirrom]

I don't add products manually: its done automatically by an external script.

Currently there are over 8000 products in the database. Approx. 25% does not have an image.

For all those products that don't have an image, I need a sollution: the script should be modified to show a dummy image.

 

A product listening looks like this:

[jonquil]

I understand your intent but I think you're going about it the long way with many pages of code to edit. You gave the code chunk for catalog/product_listing.php. This is the only area where your edit would function. Consider the product_info, products_new, etc.

 

Give this a try:

		  case 'PRODUCT_LIST_IMAGE':
		$lc_align = 'center';
		if (isset($HTTP_GET_VARS['manufacturers_id'])) {
		  $lc_text = '<a href="' . tep_href_link(FILENAME_PRODUCT_INFO, 'manufacturers_id=' . $HTTP_GET_VARS['manufacturers_id'] . '&products_id=' . $listing['products_id']) . '">' . tep_image(DIR_WS_IMAGES . $listing['products_image'], $listing['products_name'], SMALL_IMAGE_WIDTH, SMALL_IMAGE_HEIGHT) . '</a>';
		} else {
		  $lc_text = ' <a href="' . tep_href_link(FILENAME_PRODUCT_INFO, ($cPath ? 'cPath=' . $cPath . '&' : '') . 'products_id=' . $listing['products_id']) . '">' . tep_image(DIR_WS_IMAGES . $listing['products_image'], $listing['products_name'], SMALL_IMAGE_WIDTH, SMALL_IMAGE_HEIGHT) . '</a> ';
		} else {
			$lc_text = '<a href="' . tep_href_link(FILENAME_PRODUCT_INFO, ($cPath ? 'cPath=' . $cPath . '&' : '') . 'products_id=' . $listing['products_id']) . '">' . tep_image(DIR_WS_IMAGES . "notavail.gif", $listing['products_name'], SMALL_IMAGE_WIDTH, SMALL_IMAGE_HEIGHT) . '</a>?';
		}
		break;

 

Just upload a custom notavail.gif or whatever your dummy image is. Be sure to match your dummy filename in the last code chunk above.

 

Again, this will only work for the Product Listing page unless you manually find and edit the code in a bunch of other pages.

 

May I suggest that in your external script's image name field that you enter "notavail.gif" (or whatever) when no product image file name is available.

 

This would accomplish the same thing as a manual edit of any product with a missing product image, and IMHO, this is a better way to accomplish what you want to achieve.

 

jon

[♥bruyndoncx]

Everyone above makes valid points, but I can sympathise with you :)

Even though I'm doing the coding and customizing for my loading scripts too, I've found it easier to adapt the listing pages to make sure that everything shows up nicely on the surface, without having to go and edit the products.

 

So here goes ...

As a first entry within your case statement, you'd want to add this line which basically adhoc sets a default image.

if (!$listing['products_image']) $listing['products_image'] = 'nopicture.gif';

 

Basically, you can modify/adapt this one liner for each page where you want this quick fix.

 

HTH

[wheeloftime]

Everyone above makes valid points, but I can sympathise with you :)

Even though I'm doing the coding and customizing for my loading scripts too, I've found it easier to adapt the listing pages to make sure that everything shows up nicely on the surface, without having to go and edit the products.

 

So here goes ...

As a first entry within your case statement, you'd want to add this line which basically adhoc sets a default image.

if (!$listing['products_image']) $listing['products_image'] = 'nopicture.gif';

 

Basically, you can modify/adapt this one liner for each page where you want this quick fix.

 

HTH

Adding my 2cts. I would just make a slight alteration to my database. Go to the products tabel and edit the field products_image. With 'standard value' fill in 'no_image.gif' or something and from now on every new product will have that image for default. Run a one time query to find all existing products with no image attached and replace the empty field with again the value 'no_image.gif'.

UPDATE `products` SET `products_image` =  'no_image.gif' WHERE `products_image` = ''

 

You could also run this one query after each batch upload into osCommerce and keep it with that.

[xirrom]

Hello 2-All, Thanks for your help!

 

The simplest solution was to rename the NULL in the database to no_image.gif and refill all NULLS by updating. That works perfectly (offcourse...) but you just need to come up with such easy sollution... Well, this is a sullution what used to refer as 'KISS'.

[♥bruyndoncx]

just make sure that when you use easypopulate to load your database that you don't supply an empty string and effectively remove the database default value ... if it happens, you've been warned :)