ianric Posted January 18, 2007 Share Posted January 18, 2007 Hi I am using the firstpluszones shipping mod and I have managed to replace the text with Postage but it is in brackets. How do I get replace (Postage) with Postage no brackets. the same can be seen with the default install of OSC. many thanks Ian Link to comment Share on other sites More sharing options...
wheeloftime Posted January 18, 2007 Share Posted January 18, 2007 Hi I am using the firstpluszones shipping mod and I have managed to replace the text with Postage but it is in brackets. How do I get replace (Postage) with Postage no brackets. the same can be seen with the default install of OSC. many thanks Ian It is probably hard coded inside the source file. I don't know which files this contrib has but you know as you have installed it. The source file should be the (catalog)/includes/modules/shipping/<thatsthename.php> file Link to comment Share on other sites More sharing options...
ianric Posted January 19, 2007 Author Share Posted January 19, 2007 It is probably hard coded inside the source file. I don't know which files this contrib has but you know as you have installed it. The source file should be the (catalog)/includes/modules/shipping/<thatsthename.php> file Hi thanks for the reply. I still can't do it. This is the code that makes the field $this->quotes = array('id' => $this->code, 'module' => MODULE_SHIPPING_FIRSTPLUSZONES_TEXT_TITLE, 'methods' => array(array('id' => $this->code, 'title' => sprintf(MODULE_SHIPPING_FIRSTPLUSZONES_TEXT_WAY, $table_cost_first, $table_cost_additional), 'cost' => $shipping + constant(MODULE_SHIPPING_FIRSTPLUSZONES_ZONES_HANDLING_ . $dest_zone)))); I have tried changing the 'title' => sprintf... to 'title' =>'Postage' but it still gets wrapped in brackets. Thanks for helping Ian Link to comment Share on other sites More sharing options...
wheeloftime Posted January 19, 2007 Share Posted January 19, 2007 Hi thanks for the reply. I still can't do it. This is the code that makes the field $this->quotes = array('id' => $this->code, 'module' => MODULE_SHIPPING_FIRSTPLUSZONES_TEXT_TITLE, 'methods' => array(array('id' => $this->code, 'title' => sprintf(MODULE_SHIPPING_FIRSTPLUSZONES_TEXT_WAY, $table_cost_first, $table_cost_additional), 'cost' => $shipping + constant(MODULE_SHIPPING_FIRSTPLUSZONES_ZONES_HANDLING_ . $dest_zone)))); I have tried changing the 'title' => sprintf... to 'title' =>'Postage' but it still gets wrapped in brackets. Thanks for helping Ian I downloaded the contrib and I think you are refering to this part of the accompanying language file: define('MODULE_SHIPPING_FIRSTPLUSZONES_TEXT_WAY', '(£%s first item, £%s each additional item)'); Changes to textual parts, if not hard coded, usually come from the language file and that's where you can make the changes (I am curious now where you changed what to Postage ?). Link to comment Share on other sites More sharing options...
ianric Posted January 19, 2007 Author Share Posted January 19, 2007 I downloaded the contrib and I think you are refering to this part of the accompanying language file: define('MODULE_SHIPPING_FIRSTPLUSZONES_TEXT_WAY', '(£%s first item, £%s each additional item)'); Changes to textual parts, if not hard coded, usually come from the language file and that's where you can make the changes (I am curious now where you changed what to Postage ?). Hi Tried that, and that's the line I changed to 'Postage' and it still displays in brackets. A screenshot is here. I'm still a noob with PHP so I thought it could be an array of an array and tried the implode but no luck. Ian Link to comment Share on other sites More sharing options...
wheeloftime Posted January 19, 2007 Share Posted January 19, 2007 Hi Tried that, and that's the line I changed to 'Postage' and it still displays in brackets. A screenshot is here. I'm still a noob with PHP so I thought it could be an array of an array and tried the implode but no luck. Ian You mean if you change the define to: define('MODULE_SHIPPING_FIRSTPLUSZONES_TEXT_WAY', '£%s first item, £%s each additional item'); it still shows with (.....) ??! Link to comment Share on other sites More sharing options...
ianric Posted January 19, 2007 Author Share Posted January 19, 2007 You mean if you change the define to: define('MODULE_SHIPPING_FIRSTPLUSZONES_TEXT_WAY', '£%s first item, £%s each additional item'); it still shows with (.....) ??! Yes!! and its driving me mad. I'll have another look at it tomorrow when I'm fresh. Thanks for the help Ian Link to comment Share on other sites More sharing options...
wheeloftime Posted January 19, 2007 Share Posted January 19, 2007 Yes!! and its driving me mad. I'll have another look at it tomorrow when I'm fresh. Thanks for the help Ian I'll install it in a test shop and see what gives...hang on a bit longer :-) Link to comment Share on other sites More sharing options...
wheeloftime Posted January 19, 2007 Share Posted January 19, 2007 I'll install it in a test shop and see what gives...hang on a bit longer :-) For me it shows like: Zone Rates, First Item, Plus Additional Items Zone Rates, First Item, Plus Additional Items £3.50 first item, £2.00 each additional item without the brackets alright. You are not looking at some cached page or something are you ? Link to comment Share on other sites More sharing options...
ianric Posted January 19, 2007 Author Share Posted January 19, 2007 For me it shows like: Zone Rates, First Item, Plus Additional Items Zone Rates, First Item, Plus Additional Items £3.50 first item, £2.00 each additional item without the brackets alright. You are not looking at some cached page or something are you ? Hi Thanks for that I am now at home and tried it in IE and Firefox and I still get the brackets. Uninstalled, re downloaded installed and still no change. I've PM'd you with login & pass Thanks again Ian Link to comment Share on other sites More sharing options...
wheeloftime Posted January 19, 2007 Share Posted January 19, 2007 Hi Thanks for that I am now at home and tried it in IE and Firefox and I still get the brackets. Uninstalled, re downloaded installed and still no change. I've PM'd you with login & pass Thanks again Ian Okay. I'll see at it now.. Link to comment Share on other sites More sharing options...
wheeloftime Posted January 19, 2007 Share Posted January 19, 2007 Okay. I'll see at it now.. And....no brackets I see. Zone Rates, First Item, Plus Additional Items £3.50 first item, £2.00 each additional item and a shipping price of 7,50 GBP (which isn't in the pasted part above) On a side note: I am not sure if this contrib is working as it should. In my test shop I defined two zones, the default one for GB and an extra zone for NL, BE. My test customer though is assigned to Italy (IT) and this shipping option showed with the GB rates.... Link to comment Share on other sites More sharing options...
ianric Posted January 20, 2007 Author Share Posted January 20, 2007 And....no brackets I see. Zone Rates, First Item, Plus Additional Items £3.50 first item, £2.00 each additional item and a shipping price of 7,50 GBP (which isn't in the pasted part above) On a side note: I am not sure if this contrib is working as it should. In my test shop I defined two zones, the default one for GB and an extra zone for NL, BE. My test customer though is assigned to Italy (IT) and this shipping option showed with the GB rates.... Hi thanks for having a look. At least I now the prob is at my end. I think the prob with the zones is my fault because it was working yesterday. I uninstalled the module and didn't add countries into any zones when I reinstalled. Thanks Ian Link to comment Share on other sites More sharing options...
ianric Posted February 13, 2007 Author Share Posted February 13, 2007 Hi thanks for having a look. At least I now the prob is at my end. I think the prob with the zones is my fault because it was working yesterday. I uninstalled the module and didn't add countries into any zones when I reinstalled. Thanks Ian Hi Just thought I'd let everyone know that I have solved the postage brackets prob. I am looking for another shipping module and came across this http://www.oscommerce.com/community/contributions,4473. this section tell you what to do INSTALLATION ============ Only one file needs a change, for cosmetic reasons. Step (1) Open catalog/checkout_shipping.php ------------------------------------------- In checkout_confirmation, double brackets are shown and not required, so the below edit removes this. [Find around Line 121 in catalog/checkout_shipping.php] 'title' => (($free_shipping == true) ? $quote[0]['methods'][0]['title'] : $quote[0]['module'] . ' (' . $quote[0]['methods'][0]['title'] . ')'), [CHANGE TO] 'title' => (($free_shipping == true) ? $quote[0]['methods'][0]['title'] : $quote[0]['module'] . $quote[0]['methods'][0]['title']), No more brackets after Postage!! :lol: Ian Link to comment Share on other sites More sharing options...
Recommended Posts
Archived
This topic is now archived and is closed to further replies.