register globals contribution

[artcoder]

I'm doing a line by line comparison of the register globals contribution with the latest 2.2 ms 2 release. And in particular, I'm looking at the function tep_get_uprid() in catalog/includes/functions/general.php.

 

There is a lot more code and functionality in the 2.2ms2 release version than in the contribution version. And it looks like these extra code has nothing to do with the register globals fix. Do anybody know why the discreprency? The only thing I could think of is that this new code in the 2.2 release was added after the contribution was made. Is that a reasonable assumption? Or am I totally missing something.

 

So if I install the contribution version, then I would not get these functionality in my osCommerce, unless I manually merge the code discrepencies. Correct?

 

Now the big questions is "Is it the extra effort of patching and code merging worth the benefit of having register globals turned off?"

 

How bad of a security risk (if at all) is having the register globals turned on?

 

"Do you patch or not patch?", that is the question.

[Guest]

I'm doing a line by line comparison of the register globals contribution with the latest 2.2 ms 2 release. And in particular, I'm looking at the function tep_get_uprid() in catalog/includes/functions/general.php.

 

There is a lot more code and functionality in the 2.2ms2...

That's because the version of the register globals contribution that you are looking at is rather old now and should not be used with the latest version of OSC. It was created from the original contribution that I wrote which you can find here...

 

http://www.oscommerce.com/community/contributions,2097

 

This (original) register globals contribution has been kept up to date and can be used with the latest OSC versions.

 

It also includes line-by-line instructions in case you need that so the diff that you've been doing has actually already been done for you :-)

 

Rich.

[artcoder]

Thanks for the info.

[UncleSteve]

Hi,

 

Just wondering how you've been getting on with this issue, as I've encountered problems and have no idea how to overcome them!

 

Due to my webspace provider suddenly making changes without telling me, I had to rush an install of the Register Globals (http://www.oscommerce.com/community/contributions,2097) contrib. to bring my site back on line.

 

My site is back on line, well sort of... I've now discovered a problem with the ordering process, as follows...

 

If items are ordered from the full product description, everything is fine. However if a second but different item is ordered by using the 'buy now' button/option from the list of products in a category (rather than the full product description), your then taken to the cart (or at least you do in my case) only to find the second but different product NOT added to the cart, but the first item quantity has been doubled!

 

As a temporary fix, I've disabled the 'buy now' buttons, but would like to sort the problem out properly.

 

Any hints or ways to make good please?

 

Thanks in advance :)

 

I expect you know, for the Globals contrib. I've had to make additions to these files

catalog/includes/application_top.php

catalog/includes/classes/order.php

catalog/includes/functions/general.php

catalog/includes/functions/gzip_compression.php

catalog/includes/functions/sessions.php

catalog/includes/languages/english/password_forgotten.php

 

catalog/admin/products_attributes.php

catalog/admin/includes/application_top.php

catalog/admin/includes/functions/general.php

catalog/admin/includes/functions/sessions.php

[UncleSteve]

Hi,

 

Just wondering how you've been getting on with this issue, as I've encountered problems and have no idea how to overcome them!

 

Due to my webspace provider suddenly making changes without telling me, I had to rush an install of the Register Globals (http://www.oscommerce.com/community/contributions,2097) contrib. to bring my site back on line.

 

My site is back on line, well sort of... I've now discovered a problem with the ordering process, as follows...

 

If items are ordered from the full product description, everything is fine. However if a second but different item is ordered by using the 'buy now' button/option from the list of products in a category (rather than the full product description), your then taken to the cart (or at least you do in my case) only to find the second but different product NOT added to the cart, but the first item quantity has been doubled!

 

As a temporary fix, I've disabled the 'buy now' buttons, but would like to sort the problem out properly.

 

Any hints or ways to make good please?

 

Thanks in advance :)

 

I expect you know, for the Globals contrib. I've had to make additions to these files

catalog/includes/application_top.php

catalog/includes/classes/order.php

catalog/includes/functions/general.php

catalog/includes/functions/gzip_compression.php

catalog/includes/functions/sessions.php

catalog/includes/languages/english/password_forgotten.php

 

catalog/admin/products_attributes.php

catalog/admin/includes/application_top.php

catalog/admin/includes/functions/general.php

catalog/admin/includes/functions/sessions.php

I'm still having various problems with my site :( The problem above is still present, however I've found no conformation email are sent out if the customer pays by credit card. I have a number of problems in admin, but not to concerned about them at present.

 

I'm wondering if I should be adding a bit of code to all the effected pages/process's?

 

Any feedback etc. would be greatly appreciated