I`ve modified Pro_Columm Contribute..but a bit problem.

[Tai]

I want to show product description in Product listing Contribution but I don`t know what this problem from? Have a look here:

http://taiosc.coolfreepages.com/catalog/de....php?cPath=2_19

the correct one should be like this:

http://taiosc.coolfreepages.com/catalog/de....php?cPath=3_10

 

Here is the code:

<?php

/*

$Id: product_listing_col.php,v 1.00 2002/05/06 20:28:07 icw_ Exp $

 

osCommerce, Open Source E-Commerce Solutions

http://www.oscommerce.com

Copyright © 2002 osCommerce

 

Released under the GNU General Public License

*/

?>

<!-- product_listing_col //-->

<?php

DEFINE('PRODUCT_LIST_COL_NUM',3);

$listing_split = new splitPageResults($HTTP_GET_VARS['page'], MAX_DISPLAY_SEARCH_RESULTS, $listing_sql, $listing_numrows);

?>

<table width="100%">

<tr>

<td class="smallText"> <?php echo $listing_split->display_count($listing_numrows, MAX_DISPLAY_SEARCH_RESULTS, $HTTP_GET_VARS['page'], TEXT_DISPLAY_NUMBER_OF_PRODUCTS); ?> </td>

<td align="right" class="smallText"> <?php echo TEXT_RESULT_PAGE; ?> <?php echo $listing_split->display_links($listing_numrows, MAX_DISPLAY_SEARCH_RESULTS, MAX_DISPLAY_PAGE_LINKS, $HTTP_GET_VARS['page'], tep_get_all_get_params(array('page', 'info', 'x', 'y'))); ?> </td>

</tr>

</table>

<?php

$info_box_contents = array();

$row = 0;

$col = 0;

$listing = tep_db_query($listing_sql);

while ($listing_values = tep_db_fetch_array($listing)) {

$listing_values['products_name'] = tep_get_products_name($listing_values['products_id']);

$lc_text= '<a href="' . tep_href_link(FILENAME_PRODUCT_INFO, 'products_id=' . $listing_values['products_id']) . '">' . tep_image(DIR_WS_IMAGES . $listing_values['products_image'], $listing_values['products_name'], SMALL_IMAGE_WIDTH, SMALL_IMAGE_HEIGHT) . '</a><br><a href="' . tep_href_link(FILENAME_PRODUCT_INFO, 'products_id=' . $listing_values['products_id']) . '">' . $listing_values['products_name'] .

'</a><br>' .

//hack show description

$listing_values['products_description'] = tep_get_products_name($listing_values['products_description']) . 

$lc_text = substr($listing_values['products_description'], 0, PRODUCT_LIST_DESCRIPTION_LENGTH) . ' ...'

 .'<br>'; //end of hack

 

if ($listing_values['specials_new_products_price']) {

$lc_text .= ' <s>' . $currencies->display_price($listing_values['products_price'], tep_get_tax_rate($listing_values['products_tax_class_id'])) . '</s>  <span class="productSpecialPrice">' . $currencies->display_price($listing_values['specials_new_products_price'], tep_get_tax_rate($listing_values['products_tax_class_id'])) . '</span> ';

} else {

$lc_text .= ' ' . $currencies->display_price($listing_values['products_price'], tep_get_tax_rate($listing_values['products_tax_class_id'])) . ' ';

}

if (PRODUCT_LIST_BUY_NOW) {

$lc_text .= '<br><a href="' . tep_href_link(basename($PHP_SELF), tep_get_all_get_params(array('action')) . 'action=buy_now&products_id=' . $listing_values['products_id'], 'NONSSL') . '">' . tep_image_button('button_buy_now.gif') . '</a> ';

}

$info_box_contents[$row][$col] = array('align' => 'left',

'params' => 'class="smallText" width="33%" valign="top"',

'text' => $lc_text);

$col ++;

if ($col > PRODUCT_LIST_COL_NUM-1) {

$col = 0;

$row ++;

}

}

new contentBox($info_box_contents);

?>

<table width="100%">

<tr>

<td class="smallText"> <?php echo $listing_split->display_count($listing_numrows, MAX_DISPLAY_SEARCH_RESULTS, $HTTP_GET_VARS['page'], TEXT_DISPLAY_NUMBER_OF_PRODUCTS); ?> </td>

<td align="right" class="smallText"> <?php echo TEXT_RESULT_PAGE; ?> <?php echo $listing_split->display_links($listing_numrows, MAX_DISPLAY_SEARCH_RESULTS, MAX_DISPLAY_PAGE_LINKS, $HTTP_GET_VARS['page'], tep_get_all_get_params(array('page', 'info', 'x', 'y'))); ?> </td>

</tr>

</table>

<!-- product_listing_col //-->

 

anyone know the mistake came from?

Thanks so much.[/url]

[Ajeh]

You have quotes in your text that are not being stripped out.

 

These are sticking in apostrophes and confusing the select statements and out put etc.

[Ian]

The problem is your trying to get hold of the product description in the wrong way as it already seems to be in $listing_values['products_description'] there's no need for

$listing_values['products_description'] = tep_get_products_name($listing_values['products_description'])

 

all you should need is

 

$lc_text .= substr($listing_values['products_description'], 0, PRODUCT_LIST_DESCRIPTION_LENGTH) . ' ...' 

   .'<br>';

 

I haven't tested this at all, but it should do the trick.

[Tai]

Thanks Ian for your help.

Now it works.