When does 300k+ contribs get approved/disapproved?

[Phliplip]

Hi,

 

About a week ago i added a new contributution that was 300k+, on the uploade page there stood that they would get manually approved/disapproved.

 

Haven't heard anything and it doesn't seems like it is online yet.

 

My contrib was a rework of osCommerce 2.2 Milestone 2 Update 060817 to support register_global=off and register_long_arrays=off.. basicly to work with php.ini-recomended

 

Also added som other small changes, which was bescribed both in the contrib text and in a readme in the package.

 

I also wrote Harald, but he's probably to busy :blush:

 

/Philip

[Jack_mcs]

It used to take about a day but with the reduction in staff, I imagine it might be longer. But you probably don't need it OK'ed. The original update includes all files in the shop. Your contribution shouldn't have those. In fact, if it does, it is considered a fork and is against forum rules to update. You should trim it down to just the files that were changed, along with instructions, license and so on. It shouldn't be more than 100K in that case.

 

Jack

[Phliplip]

A fork? I just fixed it to work with recomended php settings, mainly for security reasons. CRE Loaded or osC Manager i would consider to be forks! But i am not publishing it under another name, or license etc etc.

 

If i was to submit a version only with changes to the original pack. It would take me HOURS of HOURS to write down, and it would take the people that wanted to use it HOURS to implement. And would most likely not work anyways. And it would not give any sence, as they would have to change their installed contributions. And i would say that its alot easier to do changes while installing contribs, than trying to do it years and months after they have been installed, you will always forget something.

 

So if it is not accepted as it is. I will just use it for my own personal pleasure. And people are welcome to PM me for a copy.

[boxtel]

A fork? I just fixed it to work with recomended php settings, mainly for security reasons. CRE Loaded or osC Manager i would consider to be forks! But i am not publishing it under another name, or license etc etc.

 

If i was to submit a version only with changes to the original pack. It would take me HOURS of HOURS to write down, and it would take the people that wanted to use it HOURS to implement. And would most likely not work anyways. And it would not give any sence, as they would have to change their installed contributions. And i would say that its alot easier to do changes while installing contribs, than trying to do it years and months after they have been installed, you will always forget something.

 

So if it is not accepted as it is. I will just use it for my own personal pleasure. And people are welcome to PM me for a copy.

 

very few people will run a default install so very few will be able and willing to simply copy a newly altered copy as is.

So yes, you need to provide the alterations and detailed install instructions along with it.

and that is never larger than 300K