Coding Question

[Becki]

Hi all,

 

I'm trying to install a contribution (HTC) but have already modified the lines I should be modifying. Can anyone tell me how I might combine these lines?

 

EXISTING MODIFIED LINE

$product_query = tep_db_query("select pd.products_name,

pd.products_description, pd.products_short, pd.products_url, p.products_id,

p.products_quantity, p.products_model, p.products_image,

p.products_image_med, p.products_image_lrg, p.products_image_sm_1,

p.products_image_xl_1, p.products_image_sm_2, p.products_image_xl_2,

p.products_image_sm_3, p.products_image_xl_3, p.products_image_sm_4,

p.products_image_xl_4, p.products_image_sm_5, p.products_image_xl_5,

p.products_image_sm_6, p.products_image_xl_6, p.products_price,

p.products_weight, p.products_date_added, p.products_last_modified,

date_format(p.products_date_available, '%Y-%m-%d') as

products_date_available, p.products_status, p.products_featured,

p.products_featured_until, p.products_tax_class_id, p.manufacturers_id from

" . TABLE_PRODUCTS . " p, " . TABLE_PRODUCTS_DESCRIPTION . " pd where

p.products_id = '" . (int)$HTTP_GET_VARS['pID'] . "' and p.products_id =

pd.products_id and pd.language_id = '" . (int)$languages_id . "'");

 

ORIGINAL LINE WITH MODIFICATION IN FOR HTC

$product_query = tep_db_query("select pd.products_name,

pd.products_description, pd.products_head_title_tag,

pd.products_head_desc_tag, pd.products_head_keywords_tag, pd.products_url,

p.products_id, p.products_quantity, p.products_model, p.products_image,

p.products_price, p.products_weight, p.products_date_added,

p.products_last_modified, date_format(p.products_date_available, '%Y-%m-%d')

as products_date_available, p.products_status, p.products_tax_class_id,

p.manufacturers_id from " . TABLE_PRODUCTS . " p, " .

TABLE_PRODUCTS_DESCRIPTION . " pd where p.products_id = '" .

(int)$HTTP_GET_VARS['pID'] . "' and p.products_id = pd.products_id and

pd.language_id = '" . (int)$languages_id . "'");

 

I'm quite a newbie so don't really know whats happening but do the variables have to be in the correct order? If they do then i'm not sure, because pd.products_short is a new piece of code so would that go before the HTC mod or after?

 

Can i do this or will it not work?

 

$product_query = tep_db_query("select pd.products_name,

pd.products_description, pd.products_short, pd.products_head_title_tag,

pd.products_head_desc_tag, pd.products_head_keywords_tag, pd.products_url, p.products_id,

p.products_quantity, p.products_model, p.products_image,

p.products_image_med, p.products_image_lrg, p.products_image_sm_1,

p.products_image_xl_1, p.products_image_sm_2, p.products_image_xl_2,

p.products_image_sm_3, p.products_image_xl_3, p.products_image_sm_4,

p.products_image_xl_4, p.products_image_sm_5, p.products_image_xl_5,

p.products_image_sm_6, p.products_image_xl_6, p.products_price,

p.products_weight, p.products_date_added, p.products_last_modified,

date_format(p.products_date_available, '%Y-%m-%d') as

products_date_available, p.products_status, p.products_featured,

p.products_featured_until, p.products_tax_class_id, p.manufacturers_id from

" . TABLE_PRODUCTS . " p, " . TABLE_PRODUCTS_DESCRIPTION . " pd where

p.products_id = '" . (int)$HTTP_GET_VARS['pID'] . "' and p.products_id =

pd.products_id and pd.language_id = '" . (int)$languages_id . "'");

 

Thank you for any advice - could I just copy both lines into the code so that they co-exist without trying to combine them?

 

Becki

[boxtel]

Hi all,

 

I'm trying to install a contribution (HTC) but have already modified the lines I should be modifying. Can anyone tell me how I might combine these lines?

 

EXISTING MODIFIED LINE

$product_query = tep_db_query("select pd.products_name,

pd.products_description, pd.products_short, pd.products_url, p.products_id,

p.products_quantity, p.products_model, p.products_image,

p.products_image_med, p.products_image_lrg, p.products_image_sm_1,

p.products_image_xl_1, p.products_image_sm_2, p.products_image_xl_2,

p.products_image_sm_3, p.products_image_xl_3, p.products_image_sm_4,

p.products_image_xl_4, p.products_image_sm_5, p.products_image_xl_5,

p.products_image_sm_6, p.products_image_xl_6, p.products_price,

p.products_weight, p.products_date_added, p.products_last_modified,

date_format(p.products_date_available, '%Y-%m-%d') as

products_date_available, p.products_status, p.products_featured,

p.products_featured_until, p.products_tax_class_id, p.manufacturers_id from

" . TABLE_PRODUCTS . " p, " . TABLE_PRODUCTS_DESCRIPTION . " pd where

p.products_id = '" . (int)$HTTP_GET_VARS['pID'] . "' and p.products_id =

pd.products_id and pd.language_id = '" . (int)$languages_id . "'");

 

ORIGINAL LINE WITH MODIFICATION IN FOR HTC

$product_query = tep_db_query("select pd.products_name,

pd.products_description, pd.products_head_title_tag,

pd.products_head_desc_tag, pd.products_head_keywords_tag, pd.products_url,

p.products_id, p.products_quantity, p.products_model, p.products_image,

p.products_price, p.products_weight, p.products_date_added,

p.products_last_modified, date_format(p.products_date_available, '%Y-%m-%d')

as products_date_available, p.products_status, p.products_tax_class_id,

p.manufacturers_id from " . TABLE_PRODUCTS . " p, " .

TABLE_PRODUCTS_DESCRIPTION . " pd where p.products_id = '" .

(int)$HTTP_GET_VARS['pID'] . "' and p.products_id = pd.products_id and

pd.language_id = '" . (int)$languages_id . "'");

 

I'm quite a newbie so don't really know whats happening but do the variables have to be in the correct order? If they do then i'm not sure, because pd.products_short is a new piece of code so would that go before the HTC mod or after?

 

Can i do this or will it not work?

 

$product_query = tep_db_query("select pd.products_name,

pd.products_description, pd.products_short, pd.products_head_title_tag,

pd.products_head_desc_tag, pd.products_head_keywords_tag, pd.products_url, p.products_id,

p.products_quantity, p.products_model, p.products_image,

p.products_image_med, p.products_image_lrg, p.products_image_sm_1,

p.products_image_xl_1, p.products_image_sm_2, p.products_image_xl_2,

p.products_image_sm_3, p.products_image_xl_3, p.products_image_sm_4,

p.products_image_xl_4, p.products_image_sm_5, p.products_image_xl_5,

p.products_image_sm_6, p.products_image_xl_6, p.products_price,

p.products_weight, p.products_date_added, p.products_last_modified,

date_format(p.products_date_available, '%Y-%m-%d') as

products_date_available, p.products_status, p.products_featured,

p.products_featured_until, p.products_tax_class_id, p.manufacturers_id from

" . TABLE_PRODUCTS . " p, " . TABLE_PRODUCTS_DESCRIPTION . " pd where

p.products_id = '" . (int)$HTTP_GET_VARS['pID'] . "' and p.products_id =

pd.products_id and pd.language_id = '" . (int)$languages_id . "'");

 

Thank you for any advice - could I just copy both lines into the code so that they co-exist without trying to combine them?

 

Becki

 

yes, you can, the order in which you select the fields does not matter. The added fields are all from pd (products_description) and that table is already referenced.

[Becki]

yes, you can, the order in which you select the fields does not matter. The added fields are all from pd (products_description) and that table is already referenced.

 

 

Ok, Thanks. I'll give it a try.

 

Becki