Jump to content
  • Checkout
  • Login
  • Get in touch

osCommerce

The e-commerce.

Help looking at some code!!!


Guest

Recommended Posts

Im editing my new_products.php ok, I decided to install the Random_Products Module, but i had to input the into my orginal new_products.php since it is heavly modified. Well IT WORKS, but im supposed to have 3 products per column and 3 products per row. Thats a total of 9 Products! I used too with the unmodified code, but then i modified it and can't figure it out, but i didn't change ne of my tables(I DON"T THINK) Ne ways if you stand it pelase help me out.

 

 

This is the Origianl code with a picture of what it looked like.

 

?>
<!-- new_products //-->
<?php

 if ( (!isset($new_products_category_id)) || ($new_products_category_id == '0') ) {
$new_products_query = tep_db_query("select p.products_id, p.products_image, p.products_tax_class_id, if(s.status, s.specials_new_products_price, p.products_price) as products_price from " . TABLE_PRODUCTS . " p left join " . TABLE_SPECIALS . " s on p.products_id = s.products_id where products_status = '1' order by p.products_date_added desc limit " . MAX_DISPLAY_NEW_PRODUCTS);
 } else {
$new_products_query = tep_db_query("select distinct p.products_id, p.products_image, p.products_tax_class_id, if(s.status, s.specials_new_products_price, p.products_price) as products_price from " . TABLE_PRODUCTS . " p left join " . TABLE_SPECIALS . " s on p.products_id = s.products_id, " . TABLE_PRODUCTS_TO_CATEGORIES . " p2c, " . TABLE_CATEGORIES . " c where p.products_id = p2c.products_id and p2c.categories_id = c.categories_id and c.parent_id = '" . (int)$new_products_category_id . "' and p.products_status = '1' order by p.products_date_added desc limit " . MAX_DISPLAY_NEW_PRODUCTS);
 }

 $row = 0;
 $col = 0;


 echo '


					  <table cellspacing=0 cellpadding=0 width=474 align=center>
					  <tr><td height=4 colspan=5></td></tr>
					   <tr><td colspan=5><img src=images/m36.gif width=148 height=15></td></tr>
					   <tr><td height=4 colspan=5></td></tr>
					   <tr><td height=1 width=474 bgcolor=#A90000 colspan=5></td></tr>
					   <tr><td height=16 colspan=5></td></tr>
					   <tr>
   ';


 while ($new_products = tep_db_fetch_array($new_products_query)) {
  $new_products['products_name'] = tep_get_products_name($new_products['products_id']);
  $product_query = tep_db_query("select products_description  from " . TABLE_PRODUCTS_DESCRIPTION . " where products_id = '" . (int)$new_products['products_id'] . "' and language_id = '" . (int)1 . "'");
  $product = tep_db_fetch_array($product_query);
  $new_products['products_description'] = $product['products_description'];
  echo '

					   <td width=157 valign=top>
							<table cellspacing=0 cellpadding=0 width=142 align=center>
							 <tr><td height=42 align=center colspan=2><a class=ml2 href="' . tep_href_link(FILENAME_PRODUCT_INFO, 'products_id=' . $new_products['products_id']) . '">' . $new_products['products_name'] . '</a></td></tr>
							 <tr><td height=8 colspan=2></td></tr>
							 <tr><td colspan=2><img src=images/m40.gif width=142 height=1></td></tr>
							 <tr><td height=4 colspan=2></td></tr>
							 <tr><td width=100 align=center><a href="' . tep_href_link(FILENAME_PRODUCT_INFO, 'products_id=' . $new_products['products_id']) . '">' . tep_image(DIR_WS_IMAGES . $new_products['products_image'], $new_products['products_name'], SMALL_IMAGE_WIDTH, SMALL_IMAGE_HEIGHT, 'vspace=5') . '</a></td><td width=42 height=15  valign=bottom class=ch1>'.$currencies->display_price($new_products['products_price'], tep_get_tax_rate($new_products['products_tax_class_id'])).'</td></tr>
							 <tr><td height=6 colspan=2></td></tr>
							 <tr><td colspan=2><img src=images/m40.gif width=142 height=1></td></tr>
							 <tr><td height=7 colspan=2></td></tr>
							 <tr><td colspan=2><a href="' . tep_href_link(FILENAME_PRODUCT_INFO, 'products_id=' . $new_products['products_id']) . '">' . tep_image_button('small_view.gif') . '</a>  <a href="' . tep_href_link(basename($PHP_SELF), tep_get_all_get_params(array('action')) . 'action=buy_now&products_id=' . $new_products['products_id']) . '">' . tep_image_button('button_in_cart.gif') . '</a></td></tr>
							 <tr><td height=3 colspan=2></td></tr>
							</table>
						   </td>



	';

$col ++;
if ($col > 2) {
  $col = 0;
  $row ++;
  echo '
					 </tr>
					 <tr>
	   ';
} else echo '<td width=1 bgcolor=#4C4C4C></td>';
 }


 echo '

					 </tr>
					 <tr><td colspan=2 height=15></td></tr>				
					</table>
   ';


?>

 

products1.JPG

 

Now this is the Modified code with a picture of what it looks like now!

 

?>
<!-- new_products //-->
<?php
 $info_box_contents = array();
 $info_box_contents[] = array('text' => sprintf(TABLE_HEADING_NEW_PRODUCTS, strftime('%B')));

 new contentBoxHeading($info_box_contents);

 if ( (!isset($random_product_category_id)) || ($random_product_category_id == '0') ) {
// start random new products
$random_product_query = tep_db_query("select p.products_id, p.products_image, p.products_tax_class_id, if(s.status, s.specials_new_products_price, p.products_price) as products_price from " . TABLE_PRODUCTS . " p left join " . TABLE_SPECIALS . " s on p.products_id = s.products_id where products_status = '1' order by p.products_date_added desc limit " . MAX_RANDOM_SELECT_NEW);
 } else {
$random_product_query = tep_db_query("select distinct p.products_id, p.products_image, p.products_tax_class_id, if(s.status, s.specials_new_products_price, p.products_price) as products_price from " . TABLE_PRODUCTS . " p left join " . TABLE_SPECIALS . " s on p.products_id = s.products_id, " . TABLE_PRODUCTS_TO_CATEGORIES . " p2c, " . TABLE_CATEGORIES . " c where p.products_id = p2c.products_id and p2c.categories_id = c.categories_id and c.parent_id = '" . (int)$random_product_category_id . "' and p.products_status = '1' order by p.products_date_added desc limit " . MAX_RANDOM_SELECT_NEW);
// end random new products	
 }

 // start random new products
 // To configure:
 //
 // Under Admin - Configuration - Maximum Values
 // Set the following:
 //  'Selection of Random New Products' 
 //   (MAX_RANDOM_SELECT_NEW) - Sets how many of the most recent new product entries are queried
 //  'New Products Module'
 //   (MAX_DISPLAY_NEW_PRODUCTS) - Sets how many random new products are displayed on screen
 //
$row = 0;
 $col = 0;
 $pCount = 0;
 $info_box_contents = array();
 $found_products = array();
 $num_rows = tep_db_num_rows($random_product_query);
 if (MAX_DISPLAY_NEW_PRODUCTS > MAX_RANDOM_SELECT_NEW) {
// don't allow more new products than will be queried
$max_new_products = MAX_RANDOM_SELECT_NEW;
 } else {
$max_new_products = MAX_DISPLAY_NEW_PRODUCTS;
 }
 if ($num_rows < $max_new_products) {
  $max_new_products = $num_rows;
 }
//  echo "num_rows: " . $num_rows . " max_new_products " . $max_new_products . "<br>";
 if ($num_rows > 0) {		
while ($pCount < $max_new_products) {	
  // choose a random row 
  $random_product = '';
  $random_row = tep_rand(0, ($num_rows - 1));
  tep_db_data_seek($random_product_query, $random_row);
  $random_product = tep_db_fetch_array($random_product_query);
  // see if found already, if not use else skip
  $found = 0;
  for ($ii=0; $ii < $pCount; $ii++) {
	if ($found_products[$ii] == $random_product['products_id']) {
	  $found = 1;

	}
  }
  if ($found == 0) {
	// keep track of found id's
	$found_products[$pCount] += $random_product['products_id'];
	$pCount ++; 

 echo '


					  <table cellspacing=0 cellpadding=0 width=474 align=center>
					  <tr><td height=4 colspan=5></td></tr>
					   <tr><td colspan=5><img src=images/m36.gif width=148 height=15></td></tr>
					   <tr><td height=4 colspan=5></td></tr>
					   <tr><td height=1 width=474 bgcolor=#A90000 colspan=5></td></tr>
					   <tr><td height=16 colspan=5></td></tr>
					   <tr>
   ';


{
  $random_product['products_name'] = tep_get_products_name($random_product['products_id']);
  $product_query = tep_db_query("select products_description  from " . TABLE_PRODUCTS_DESCRIPTION . " where products_id = '" . (int)$random_product['products_id'] . "' and language_id = '" . (int)1 . "'");
  $product = tep_db_fetch_array($product_query);
  $random_product['products_description'] = $product['products_description'];
  echo '

					   <td width=157 valign=top>
							<table cellspacing=0 cellpadding=0 width=142 align=center>
							 <tr><td height=42 align=center colspan=2><a class=ml2 href="' . tep_href_link(FILENAME_PRODUCT_INFO, 'products_id=' . $random_product['products_id']) . '">' . $random_product['products_name'] . '</a></td></tr>
							 <tr><td height=8 colspan=2></td></tr>
							 <tr><td colspan=2><img src=images/m40.gif width=142 height=1></td></tr>
							 <tr><td height=4 colspan=2></td></tr>
							 <tr><td width=100 align=center><a href="' . tep_href_link(FILENAME_PRODUCT_INFO, 'products_id=' . $random_product['products_id']) . '">' . tep_image(DIR_WS_IMAGES . $random_product['products_image'], $random_product['products_name'], SMALL_IMAGE_WIDTH, SMALL_IMAGE_HEIGHT, 'vspace=5') . '</a></td><td width=42 height=15  valign=bottom class=ch1>'.$currencies->display_price($random_product['products_price'], tep_get_tax_rate($random_product['products_tax_class_id'])).'</td></tr>
							 <tr><td height=6 colspan=2></td></tr>
							 <tr><td colspan=2><img src=images/m40.gif width=142 height=1></td></tr>
							 <tr><td height=7 colspan=2></td></tr>
							 <tr><td colspan=2><a href="' . tep_href_link(FILENAME_PRODUCT_INFO, 'products_id=' . $random_product['products_id']) . '">' . tep_image_button('small_view.gif') . '</a>  <a href="' . tep_href_link(basename($PHP_SELF), tep_get_all_get_params(array('action')) . 'action=buy_now&products_id=' . $random_product['products_id']) . '">' . tep_image_button('button_in_cart.gif') . '</a></td></tr>
							 <tr><td height=3 colspan=2></td></tr>
							</table>
						   </td>
	';

$col ++;
if ($col > 2) {
  $col = 0;
  $row ++;
  echo '
					 </tr>
					 <tr>
	   ';
} else echo '<td width=1 bgcolor=#4C4C4C></td>';
 }
} // found
} // while pCount
 } // num_rows  
// end random new products

 echo '
					   </tr>
					 <tr><td colspan=2 height=15></td></tr>				
					</table>
   ';
?>

 

products2.JPG

 

Now can u tell me what im doing wrong... Thanks guys.... Great Great Help!!!!!!!

Link to comment
Share on other sites

I just noticed that for some reason it is looping somewere so it is reposting the table every time it pulls a new product... Might want to be thinking of that as well

Link to comment
Share on other sites

LOL after i noticed the loop i was looking at the code and figured it out had to put the echo table before the new modifications to the code lol thanks ne ways guys...

 

// start random new products
 // To configure:
 //
 // Under Admin - Configuration - Maximum Values
 // Set the following:
 //  'Selection of Random New Products' 
 //   (MAX_RANDOM_SELECT_NEW) - Sets how many of the most recent new product entries are queried
 //  'New Products Module'
 //   (MAX_DISPLAY_NEW_PRODUCTS) - Sets how many random new products are displayed on screen
 //
$row = 0;
 $col = 0;
 $pCount = 0;
 $info_box_contents = array();
 $found_products = array();
 $num_rows = tep_db_num_rows($random_product_query);

 echo '


					  <table cellspacing=0 cellpadding=0 width=474 align=center>
					  <tr><td height=4 colspan=5></td></tr>
					   <tr><td colspan=5><img src=images/m36.gif width=148 height=15></td></tr>
					   <tr><td height=4 colspan=5></td></tr>
					   <tr><td height=1 width=474 bgcolor=#A90000 colspan=5></td></tr>
					   <tr><td height=16 colspan=5></td></tr>
					   <tr>
   ';

 if (MAX_DISPLAY_NEW_PRODUCTS > MAX_RANDOM_SELECT_NEW) {
// don't allow more new products than will be queried
$max_new_products = MAX_RANDOM_SELECT_NEW;
 } else {
$max_new_products = MAX_DISPLAY_NEW_PRODUCTS;
 }
 if ($num_rows < $max_new_products) {
  $max_new_products = $num_rows;
 }
//  echo "num_rows: " . $num_rows . " max_new_products " . $max_new_products . "<br>";

Link to comment
Share on other sites

Archived

This topic is now archived and is closed to further replies.

×
×
  • Create New...