Jump to content
  • Checkout
  • Login
  • Get in touch

osCommerce

The e-commerce.

Header


jkjr87

Recommended Posts

Posted
My store http://wheelsandspinners.com/Store/catalog/

 

The header has a white line along the bottom of it and the right side of it. Any ideas how to get rid of it? Thanks.

in header.php try changing the background color of the first table to black.

My Contributions

 

Stylesheet With Descriptions Glassy Grey Boxtops Our Products Meta Tags On The Fly

Password Protect Admin

"No matter where you go....There you are" - Buccaroo Bonsai

Posted
in header.php try changing the background color of the first table to black.

 

 

it changes the whole center of my store black. heres my header code:

 

<?php

/*

$Id: header.php,v 1.42 2003/06/10 18:20:38 hpdl Exp $

 

osCommerce, Open Source E-Commerce Solutions

http://www.oscommerce.com

 

Copyright © 2003 osCommerce

 

Released under the GNU General Public License

*/

 

print ('<center><table width="753" border="0" cellpadding="0" cellspacing="0">

<tr>

<td bgcolor="white">');

 

// check if the 'install' directory exists, and warn of its existence

if (WARN_INSTALL_EXISTENCE == 'true') {

if (file_exists(dirname($HTTP_SERVER_VARS['SCRIPT_FILENAME']) . '/install')) {

$messageStack->add('header', WARNING_INSTALL_DIRECTORY_EXISTS, 'warning');

}

}

 

// check if the configure.php file is writeable

if (WARN_CONFIG_WRITEABLE == 'true') {

if ( (file_exists(dirname($HTTP_SERVER_VARS['SCRIPT_FILENAME']) . '/includes/configure.php')) && (is_writeable(dirname($HTTP_SERVER_VARS['SCRIPT_FILENAME']) . '/includes/configure.php')) ) {

$messageStack->add('header', WARNING_CONFIG_FILE_WRITEABLE, 'warning');

}

}

 

// check if the session folder is writeable

if (WARN_SESSION_DIRECTORY_NOT_WRITEABLE == 'true') {

if (STORE_SESSIONS == '') {

if (!is_dir(tep_session_save_path())) {

$messageStack->add('header', WARNING_SESSION_DIRECTORY_NON_EXISTENT, 'warning');

} elseif (!is_writeable(tep_session_save_path())) {

$messageStack->add('header', WARNING_SESSION_DIRECTORY_NOT_WRITEABLE, 'warning');

}

}

}

 

// check session.auto_start is disabled

if ( (function_exists('ini_get')) && (WARN_SESSION_AUTO_START == 'true') ) {

if (ini_get('session.auto_start') == '1') {

$messageStack->add('header', WARNING_SESSION_AUTO_START, 'warning');

}

}

 

if ( (WARN_DOWNLOAD_DIRECTORY_NOT_READABLE == 'true') && (DOWNLOAD_ENABLED == 'true') ) {

if (!is_dir(DIR_FS_DOWNLOAD)) {

$messageStack->add('header', WARNING_DOWNLOAD_DIRECTORY_NON_EXISTENT, 'warning');

}

}

 

if ($messageStack->size('header') > 0) {

echo $messageStack->output('header');

}

?>

<table id="Table_01" width="754" height="139" border="0" cellpadding="0" cellspacing="0">

<tr>

<td rowspan="7">

<img src="http://jkjrproductions.com/images/header_01.gif" width="1" height="138" alt=""></td>

<td rowspan="6">

<img src="http://jkjrproductions.com/images/header_02.gif" width="419" height="135" alt=""></td>

<td colspan="8">

<img src="http://jkjrproductions.com/images/header_03.gif" width="333" height="17" alt=""></td>

<td>

<img src="http://jkjrproductions.com/images/spacer.gif" width="1" height="17" alt=""></td>

</tr>

<tr>

<td rowspan="6">

<img src="http://jkjrproductions.com/images/header_04.gif" width="13" height="121" alt=""></td>

<td rowspan="2">

<a href="http://wheelsandspinners.com/Store/catalog/index.php"><img src="http://jkjrproductions.com/images/header_05.gif" width="76" height="35" alt="Home" border="0"></a></td>

<td rowspan="3">

<img src="http://jkjrproductions.com/images/header_06.gif" width="11" height="61" alt=""></td>

<td>

<a href="http://wheelsandspinners.com/Store/catalog/shopping_cart.php"><img src="http://jkjrproductions.com/images/header_07.gif" width="88" height="32" alt="View Cart" border="0"></a></td>

<td rowspan="3">

<img src="http://jkjrproductions.com/images/header_08.gif" width="14" height="61" alt=""></td>

<td colspan="2">

<a href="https://jonk.powweb.com/Store/catalog/login.php"><img src="http://jkjrproductions.com/images/header_09.gif" width="114" height="32" alt="My Account" border="0"></a></td>

<td rowspan="6">

<img src="http://jkjrproductions.com/images/header_10.gif" width="17" height="121" alt=""></td>

<td>

<img src="http://jkjrproductions.com/images/spacer.gif" width="1" height="32" alt=""></td>

</tr>

<tr>

<td rowspan="2">

<img src="http://jkjrproductions.com/images/header_11.gif" width="88" height="29" alt=""></td>

<td colspan="2" rowspan="2">

<img src="http://jkjrproductions.com/images/header_12.gif" width="114" height="29" alt=""></td>

<td>

<img src="http://jkjrproductions.com/images/spacer.gif" width="1" height="3" alt=""></td>

</tr>

<tr>

<td>

<img src="http://jkjrproductions.com/images/header_13.gif" width="76" height="26" alt=""></td>

<td>

<img src="http://jkjrproductions.com/images/spacer.gif" width="1" height="26" alt=""></td>

</tr>

<tr>

<td colspan="5">

<a href="http://wheelsandspinners.com/live_support//client.php" target="blank"><img src="http://jkjrproductions.com/images/header_14.gif" width="302" height="51" alt="Live Support" border="0"></a></td>

<td rowspan="3">

<img src="http://jkjrproductions.com/images/header_15.gif" width="1" height="60" alt=""></td>

<td>

<img src="http://jkjrproductions.com/images/spacer.gif" width="1" height="51" alt=""></td>

</tr>

<tr>

<td colspan="5" rowspan="2">

<img src="http://jkjrproductions.com/images/header_16.gif" width="302" height="9" alt=""></td>

<td>

<img src="http://jkjrproductions.com/images/spacer.gif" width="1" height="6" alt=""></td>

</tr>

<tr>

<td>

<img src="http://jkjrproductions.com/images/header_17.gif" width="419" height="3" alt=""></td>

<td>

<img src="http://jkjrproductions.com/images/spacer.gif" width="1" height="3" alt=""></td>

</tr>

<tr>

<td>

<img src="images/spacer.gif" width="1" height="1" alt=""></td>

<td>

<img src="images/spacer.gif" width="419" height="1" alt=""></td>

<td>

<img src="images/spacer.gif" width="13" height="1" alt=""></td>

<td>

<img src="images/spacer.gif" width="76" height="1" alt=""></td>

<td>

<img src="images/spacer.gif" width="11" height="1" alt=""></td>

<td>

<img src="images/spacer.gif" width="88" height="1" alt=""></td>

<td>

<img src="images/spacer.gif" width="14" height="1" alt=""></td>

<td>

<img src="images/spacer.gif" width="113" height="1" alt=""></td>

<td>

<img src="images/spacer.gif" width="1" height="1" alt=""></td>

<td>

<img src="images/spacer.gif" width="17" height="1" alt=""></td>

<td></td>

</tr>

</table><table border="0" align="center" width="<?php echo PAGE_WIDTH; ?>" cellspacing="0" cellpadding="0">

<tr class="headerNavigation">

<td class="headerNavigation"><?php echo $breadcrumb->trail(' ? '); ?></td>

<script type="text/javascript" language="JavaScript1.2">

<!--

function clearThis(it){

it.value = "";

}

//-->

</script>

<td class="headerNavigation" align="right" valign="top"><td align="right" valign="middle" bgcolor="000000"><?php echo tep_draw_form('search', tep_href_link(FILENAME_ADVANCED_SEARCH_RESULT, '', 'NONSSL', false), 'get') . tep_draw_hidden_field('search_in_description','1') . tep_draw_input_field('keywords', '', 'size="10" maxlength="30" bgcolor="8d4040" style="width: ' . (BOX_WIDTH+10) . 'px"') . ' ' . tep_hide_session_id() .'<input type="submit" name="Submit" value="Search">' . '</form>'; ?></td>

<td align="right" class="headerNavigation"><?php if (tep_session_is_registered('customer_id')) { ?><a href="<?php echo tep_href_link(FILENAME_LOGOFF, '', 'SSL'); ?>" class="headerNavigation"><?php echo HEADER_TITLE_LOGOFF; ?></a> ?|? <?php } ?><a href="<?php echo tep_href_link(FILENAME_ACCOUNT, '', 'SSL'); ?>" class="headerNavigation"><?php echo HEADER_TITLE_MY_ACCOUNT; ?></a> ?|? <a href="<?php echo tep_href_link(FILENAME_SHOPPING_CART); ?>" class="headerNavigation"><?php echo HEADER_TITLE_CART_CONTENTS; ?></a> ?|? <a href="<?php echo tep_href_link(FILENAME_CHECKOUT_SHIPPING, '', 'SSL'); ?>" class="headerNavigation"><?php echo HEADER_TITLE_CHECKOUT; ?></a> ??</td>

</tr>

</table>

<?php

if (isset($HTTP_GET_VARS['error_message']) && tep_not_null($HTTP_GET_VARS['error_message'])) {

?>

<table border="0" width="100%" cellspacing="0" cellpadding="2">

<tr class="headerError">

<td class="headerError"><?php echo htmlspecialchars(urldecode($HTTP_GET_VARS['error_message'])); ?></td>

</tr>

</table>

<?php

}

 

if (isset($HTTP_GET_VARS['info_message']) && tep_not_null($HTTP_GET_VARS['info_message'])) {

?>

<table border="0" width="100%" cellspacing="0" cellpadding="0">

<tr class="headerInfo">

<td class="headerInfo"><?php echo htmlspecialchars($HTTP_GET_VARS['info_message']); ?></td>

</tr>

</table>

<?php

}

?>

 

<table border="0" align="center" width="<?php echo PAGE_WIDTH; ?>" cellspacing="0" cellpadding="0">

<td width="100%">

Posted

EEEKK!!!!!!!!!

YIKS!!!!

 

you're just plain 'table' happy - huh?

 

what's this about?

	<tr>
	<td>
		<img src="images/spacer.gif" width="1" height="1" alt=""></td>
	<td>
		<img src="images/spacer.gif" width="419" height="1" alt=""></td>
	<td>
		<img src="images/spacer.gif" width="13" height="1" alt=""></td>
	<td>
		<img src="images/spacer.gif" width="76" height="1" alt=""></td>
	<td>
		<img src="images/spacer.gif" width="11" height="1" alt=""></td>
	<td>
		<img src="images/spacer.gif" width="88" height="1" alt=""></td>
	<td>
		<img src="images/spacer.gif" width="14" height="1" alt=""></td>
	<td>
		<img src="images/spacer.gif" width="113" height="1" alt=""></td>
	<td>
		<img src="images/spacer.gif" width="1" height="1" alt=""></td>
	<td>
		<img src="images/spacer.gif" width="17" height="1" alt=""></td>
	<td></td>
</tr>

etc. etc.

 

at first look i thought your header table might be bordered - but unless #Table_01 in your stylesheet is defined to have a border - i guess it's sumtin else - perhaps your images have borders --- but upon closer look - i'm sorry - i don't want to look closer - the generated html is much too much all over the place --- i'd sit down and reduce it as much as you can, at least to a more logical point - then perhaps it'd be easier to nail down what is causing your issue.

 

sorry....

 

think about this - your pics are bigg enough - why load your bandwidth - and page load time more with uneeded text (html source) - yes even text adds up..

Posted

actually without going too much deeper....

 

you might merely be running into added space - when there is space between an image and its container ("TD" - table cells in this case) SOMETIMES that space appears on the page...

 

so instead of this....

	<tr>
	<td>
		<img src="images/spacer.gif" width="1" height="1" alt=""></td>
	<td>
		<img src="images/spacer.gif" width="419" height="1" alt=""></td>
	<td>
		<img src="images/spacer.gif" width="13" height="1" alt=""></td>
	<td>
		<img src="images/spacer.gif" width="76" height="1" alt=""></td>
	<td>
		<img src="images/spacer.gif" width="11" height="1" alt=""></td>
	<td>
		<img src="images/spacer.gif" width="88" height="1" alt=""></td>
	<td>
		<img src="images/spacer.gif" width="14" height="1" alt=""></td>
	<td>
		<img src="images/spacer.gif" width="113" height="1" alt=""></td>
	<td>
		<img src="images/spacer.gif" width="1" height="1" alt=""></td>
	<td>
		<img src="images/spacer.gif" width="17" height="1" alt=""></td>
	<td></td>
</tr>

you might want this...

	<tr>
	<td><img src="images/spacer.gif" width="1" height="1" alt=""></td>
	<td><img src="images/spacer.gif" width="419" height="1" alt=""></td>
	<td><img src="images/spacer.gif" width="13" height="1" alt=""></td>
	<td><img src="images/spacer.gif" width="76" height="1" alt=""></td>
	<td><img src="images/spacer.gif" width="11" height="1" alt=""></td>
	<td><img src="images/spacer.gif" width="88" height="1" alt=""></td>
	<td><img src="images/spacer.gif" width="14" height="1" alt=""></td>
	<td><img src="images/spacer.gif" width="113" height="1" alt=""></td>
	<td><img src="images/spacer.gif" width="1" height="1" alt=""></td>
	<td><img src="images/spacer.gif" width="17" height="1" alt=""></td>
	<td></td>
</tr>

 

[ why you'd want so many cells > ???? < you could use colspan in TD if needed - that'd clean things up]

 

but the point is if you get rid of the space between your images and their containers ("TD"), then you MIGHT get rid of your display 'space' problem . . .

Posted
ok, i tried all of that and its still there. any more ideas?

 

The empty td (last one in the row) is most likely the problem. Instead of adding the spacer, you should just simplify with the colspan as squeekit suggested.

 

 

Change-

<tr>
<td><img src="images/spacer.gif" width="1" height="1" alt=""></td>
<td><img src="images/spacer.gif" width="419" height="1" alt=""></td>
<td><img src="images/spacer.gif" width="13" height="1" alt=""></td>
<td><img src="images/spacer.gif" width="76" height="1" alt=""></td>
<td><img src="images/spacer.gif" width="11" height="1" alt=""></td>
<td><img src="images/spacer.gif" width="88" height="1" alt=""></td>
<td><img src="images/spacer.gif" width="14" height="1" alt=""></td>
<td><img src="images/spacer.gif" width="113" height="1" alt=""></td>
<td><img src="images/spacer.gif" width="1" height="1" alt=""></td>
<td><img src="images/spacer.gif" width="17" height="1" alt=""></td>
<td></td>
</tr>

 

To -

<tr>
<td colspan="11"><img src="images/spacer.gif" width="753" height="1" alt=""></td>
</tr>

 

If that doesn't work....

 

There may be an issue with the 'tracking' box on the lower right side. It is bigger than all the rest and may be kicking your table out from below causing the white space on the right side of the header.

 

I took a quick look at the source code off your website and noticed a few other issues that may be causing the problem as well;

 

there is an issue between the body and footer rems, tag(s) are either missing or need to be added

</table>
<!-- body_eof //-->

<!-- footer //-->
 </td>

</table>

 

there is a code problem in your "print" table at the top of the header

Header.php code -

print ('<center><table width="753" border="0" cellpadding="0" cellspacing="0">
<tr>
<td bgcolor="white">');

 

webpage source -

<center><table width="753" border="0" cellpadding="0" cellspacing="0">

this leaves an open table. Since your table is only 753 px wide it will print the same without this.

 

there is a problem with your table_01

Header.php code -

<table id="Table_01" width="754" height="139" border="0" cellpadding="0" cellspacing="0">

webpage source for "Table_01" shows it as 753 px instead of 754 px.

 

Your source code has tables that can be removed and tags that need to be closed or changed. I recommend that you start from the top and work through each table, tr, td to make sure each one is needed and then closed. :thumbsup:

Archived

This topic is now archived and is closed to further replies.

×
×
  • Create New...